From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 77B1CC433E0 for ; Wed, 6 Jan 2021 00:43:46 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 0235C22DD3 for ; Wed, 6 Jan 2021 00:43:45 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0235C22DD3 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 29B508D00CA; Tue, 5 Jan 2021 19:43:45 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 249F18D006E; Tue, 5 Jan 2021 19:43:45 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1609C8D00CA; Tue, 5 Jan 2021 19:43:45 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0050.hostedemail.com [216.40.44.50]) by kanga.kvack.org (Postfix) with ESMTP id 0056A8D006E for ; Tue, 5 Jan 2021 19:43:44 -0500 (EST) Received: from smtpin06.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id B931F181AEF1A for ; Wed, 6 Jan 2021 00:43:44 +0000 (UTC) X-FDA: 77673502368.06.fruit86_0904203274dd Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin06.hostedemail.com (Postfix) with ESMTP id 9B5BD10033C30 for ; Wed, 6 Jan 2021 00:43:44 +0000 (UTC) X-HE-Tag: fruit86_0904203274dd X-Filterd-Recvd-Size: 4204 Received: from so254-31.mailgun.net (so254-31.mailgun.net [198.61.254.31]) by imf44.hostedemail.com (Postfix) with ESMTP for ; Wed, 6 Jan 2021 00:43:43 +0000 (UTC) DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1609893824; h=Content-Transfer-Encoding: MIME-Version: Message-Id: Date: Subject: Cc: To: From: Sender; bh=pzrh7dwncd17lj6KkzA6WwnlG1QsGgiLO7PzX4xZ938=; b=YfdsPxf4vOclHNqz6c3bk1L19mH9/easJWjX+PJm3wfoQ4hU07vd7lHaR6IVnXIEnJ3NOuMq J7EkC1fnAJWQuppem11fZaVIbv6ohKS/rP+XKr+Nr7xYPPt+cEKvdMvFtCWd9vNth65KiRPl kSNlNPagAtAb3IXq5DGwY20BKLM= X-Mailgun-Sending-Ip: 198.61.254.31 X-Mailgun-Sid: WyIwY2Q3OCIsICJsaW51eC1tbUBrdmFjay5vcmciLCAiYmU5ZTRhIl0= Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n05.prod.us-west-2.postgun.com with SMTP id 5ff507bdd3eb3c36b4c12da5 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Wed, 06 Jan 2021 00:43:41 GMT Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 32E73C433C6; Wed, 6 Jan 2021 00:43:41 +0000 (UTC) Received: from th-lint-014.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: sudaraja) by smtp.codeaurora.org (Postfix) with ESMTPSA id 77EF6C433CA; Wed, 6 Jan 2021 00:43:40 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 77EF6C433CA Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=fail smtp.mailfrom=sudaraja@codeaurora.org From: Sudarshan Rajagopalan To: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Cc: Sudarshan Rajagopalan Subject: [PATCH] mm: vmscan: support complete shrinker reclaim Date: Tue, 5 Jan 2021 16:43:38 -0800 Message-Id: <2d1f1dbb7e018ad02a9e7af36a8c86397a1598a7.1609892546.git.sudaraja@codeaurora.org> X-Mailer: git-send-email 2.25.0 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Ensure that shrinkers are given the option to completely drop their caches even when their caches are smaller than the batch size. This change helps improve memory headroom by ensuring that under significant memory pressure shrinkers can drop all of their caches. This change only attempts to more aggressively call the shrinkers during background memory reclaim, inorder to avoid hurting the performance of direct memory reclaim. Signed-off-by: Sudarshan Rajagopalan Cc: Andrew Morton --- mm/vmscan.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/mm/vmscan.c b/mm/vmscan.c index 9727dd8e2581..35973665ae64 100644 --- a/mm/vmscan.c +++ b/mm/vmscan.c @@ -424,6 +424,10 @@ static unsigned long do_shrink_slab(struct shrink_co= ntrol *shrinkctl, long batch_size =3D shrinker->batch ? shrinker->batch : SHRINK_BATCH; long scanned =3D 0, next_deferred; + long min_cache_size =3D batch_size; + + if (current_is_kswapd()) + min_cache_size =3D 0; =20 if (!(shrinker->flags & SHRINKER_NUMA_AWARE)) nid =3D 0; @@ -503,7 +507,7 @@ static unsigned long do_shrink_slab(struct shrink_con= trol *shrinkctl, * scanning at high prio and therefore should try to reclaim as much as * possible. */ - while (total_scan >=3D batch_size || + while (total_scan > min_cache_size || total_scan >=3D freeable) { unsigned long ret; unsigned long nr_to_scan =3D min(batch_size, total_scan); --=20 Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project