From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4499BE77188 for ; Mon, 6 Jan 2025 11:02:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C80C16B008A; Mon, 6 Jan 2025 06:02:37 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C30B96B0092; Mon, 6 Jan 2025 06:02:37 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AF8766B0093; Mon, 6 Jan 2025 06:02:37 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 8FF816B008A for ; Mon, 6 Jan 2025 06:02:37 -0500 (EST) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 37F804593F for ; Mon, 6 Jan 2025 11:02:37 +0000 (UTC) X-FDA: 82976738754.29.C119DB7 Received: from mail-pl1-f181.google.com (mail-pl1-f181.google.com [209.85.214.181]) by imf01.hostedemail.com (Postfix) with ESMTP id 3440A40006 for ; Mon, 6 Jan 2025 11:02:34 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=IP09RjDq; dmarc=pass (policy=quarantine) header.from=bytedance.com; spf=pass (imf01.hostedemail.com: domain of zhengqi.arch@bytedance.com designates 209.85.214.181 as permitted sender) smtp.mailfrom=zhengqi.arch@bytedance.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1736161355; a=rsa-sha256; cv=none; b=BAck1AVbKXx+SdvE6oKC/mkLRzdVw4pte9w3klouIBAGVpAEU4yHe7TGG6hAJ7Gj0xNTl1 l5p7BjOLuiur5AnaKUd51SfKAPIrSy0c/BwQMjOkBI2j6+lbRcHzcgckt2K93O/QAPoNso WzwBxPxjtvx1YRKosBDUy2WANAzM1Qk= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=IP09RjDq; dmarc=pass (policy=quarantine) header.from=bytedance.com; spf=pass (imf01.hostedemail.com: domain of zhengqi.arch@bytedance.com designates 209.85.214.181 as permitted sender) smtp.mailfrom=zhengqi.arch@bytedance.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1736161355; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=PtS7kKDFbbWBE6dlgb91yolih02/BD7li/VWMu2pf+Q=; b=E05lhUqwrtaovn2LTqPELaBInCBxatEtjCxVEZul0FwG4DCGXsPBpOuoCVciY+5jhMLq4W RsT/fJLb9SvcygHbggrAEGJcD2XhySWxQoxBL11yuj5FPGuV1Kv46OyMeOKLIrmEYOjh4D aXzcdwlDdXoqWGgH4zZy2NNaTiU5XGA= Received: by mail-pl1-f181.google.com with SMTP id d9443c01a7336-2161eb95317so209058815ad.1 for ; Mon, 06 Jan 2025 03:02:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1736161353; x=1736766153; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=PtS7kKDFbbWBE6dlgb91yolih02/BD7li/VWMu2pf+Q=; b=IP09RjDq57QvKuwHxliIkK5prniSUiLmitIYSxgjmtae5oT91pFv/+TJWLejXP0syV 7TlNiVhAgDbgNF0KAjSWWXa2Z80tPntaP8iYBUItZkBd06X7Iy3JVP+dvEQdmwZk6PA/ cA9CAwtQB9w5v8bMe3ooZrYrny0loEZs8AkWstQHVTNVT1i7ywSkr3i66MfMGSXBH2N6 NYi2z40jYAFSza+zE8ZoR6phDF9anu0M3PTR8TEGqxZKSWQERsfto6tzFpXFGwi3bPes LBnDwLMZoiupVMTNmSA3hE9iP7S3sew51shCpvqi5neHDINUVIvPTW2QFrk4lIOtUkLL JS2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736161353; x=1736766153; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=PtS7kKDFbbWBE6dlgb91yolih02/BD7li/VWMu2pf+Q=; b=kVOj74nN4lXMkj4scfhAFoBFEoGAODjcFNsZNrarMz8iQhponwgS4P+fzwMEPx6Z8A kcb5VtrkOzASEFvVtiufE4YvpXSg1sDvKXhrUN38ngfLfkl1e5z3gTjNb3XU2+JB0+Ns 8hoI2w+byb7hGh6+DWkVOZ3GvhqR+N2mGwTJVBgwfvxKBf23QLYk/L/fEI/ZMqIJHe9d l6LlxhlexA0Q3lFUWrZVHzKamNazlDwMqnBffz9hLquRoseh7gu2MRcXno12T4b2hyoP +S/o7AK8tz8MWbQZFheqNoacYcEV4OgMOSZA+hr/eYj+io4Gqxc91H3Ar0LLjVbNIWAa YoeQ== X-Forwarded-Encrypted: i=1; AJvYcCWY0xYjI8BdAhGHnBs8PEzsm2uDojSOGHK7o0iRB49XbV5vQ0VqBDca9TsR5zpVotYkwDdTx9o6oQ==@kvack.org X-Gm-Message-State: AOJu0YxJ2tGpUNyRFquhgHsfLTERsrGeSEZEI57k4OAC8/ty9o/M9Olw upIQpmp1yswQCHJZSu2vvgce4VSetmwjZeL0b/bzc4OIRYD0rsKD7UwmbQhTqqo= X-Gm-Gg: ASbGncte0WH7H1Zv5ctzTTZz4NFEjU7DU64/SlsERZtFyYkZrVQjt3n1UIbrdQScH8L Hw7FgKNB2R5VWBX08hmcnSCtF0vTF3+HNd088orrdIK/iFnmgjl1FphC42QMbDUKaK9Zu45cmkF 8jOWDJApwYokJiWG04vBJar5lo2u7lmhaokG2Jg1Drg85S5NwWbXn3Sm/zzv6RE9aO46hhy2iCw B3I8LUUY0ArEGAnWmFsPT0jSlW8CSOXnrPL9zRR/Vaq0DPlDMZH1aHcRvlNqkehMqAupXqHNl+o qdc5nA== X-Google-Smtp-Source: AGHT+IFCeOw2arXEHpOUWAGun1CKXf9/XTpPQ1dFbIMLlKInW35U2LjXZ6DtTEzjdru/7w1/tbEHpw== X-Received: by 2002:a05:6a00:4644:b0:725:b347:c3cc with SMTP id d2e1a72fcca58-72abdeb9c33mr83929136b3a.23.1736161353534; Mon, 06 Jan 2025 03:02:33 -0800 (PST) Received: from [10.84.148.23] ([203.208.167.150]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-72aad816464sm31123318b3a.40.2025.01.06.03.02.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 06 Jan 2025 03:02:33 -0800 (PST) Message-ID: <2d16f0fe-9c7f-4229-b7b5-ffa3ab1b1143@bytedance.com> Date: Mon, 6 Jan 2025 19:02:17 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 12/15] s390: pgtable: also move pagetable_dtor() of PxD to __tlb_remove_table() Content-Language: en-US To: Alexander Gordeev Cc: peterz@infradead.org, kevin.brodsky@arm.com, palmer@dabbelt.com, tglx@linutronix.de, david@redhat.com, jannh@google.com, hughd@google.com, yuzhao@google.com, willy@infradead.org, muchun.song@linux.dev, vbabka@kernel.org, lorenzo.stoakes@oracle.com, akpm@linux-foundation.org, rientjes@google.com, vishal.moola@gmail.com, arnd@arndb.de, will@kernel.org, aneesh.kumar@kernel.org, npiggin@gmail.com, dave.hansen@linux.intel.com, rppt@kernel.org, ryan.roberts@arm.com, linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, sparclinux@vger.kernel.org, linux-kernel@vger.kernel.org, x86@kernel.org, linux-arch@vger.kernel.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, loongarch@lists.linux.dev, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-openrisc@vger.kernel.org, linux-sh@vger.kernel.org, linux-um@lists.infradead.org References: From: Qi Zheng In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 3440A40006 X-Stat-Signature: 4tghbk35a1hrokrkpaajc9ms1c6g7esh X-Rspam-User: X-HE-Tag: 1736161354-340049 X-HE-Meta: U2FsdGVkX1/S5bKpxpPNc6Q0LoKmTVtu+xkdwABV+a0pQGjuX/gjx686xZ5nhV2QU3Q2QxplSAlq9RluC7CJ6eETl8ZY1sonS+JB4pk4+RQxyS51NBMZ0xVQgAJcBfgL0yvXL9/aiOgYvkXzg+9Fsct0NP0e1W0pT6q0NI7clAtwOp1AlObC3DkXcTph/NODY2y/nxAopSHwb4+WkVWoxuT96B6MlMgXBAQEvVpyA9kHyJZ8Hh4qGmuGQuQ1ww2hlahiaPQaWpxTrlmeuX+eIE669jxxMYot3rzfdPBfpyzxsnzKy+HLIS5284nm4JoFK8B7ipa5nJVhQhXW+5UYqYgSwKIDYNLFFlHquBTxhJjwpc48YAdZUfiE9zaUzCPskc/t/+po8sSvgb6j7zc0Ss2SLKMGro/18pnL0NYxEhNVlBLKzI0yo58DULvZy2hj78xqO97Ez4uxpkX72eQNzM2Jg2tPvGV32bEbbRUqwLeSv+KVeTelre8BuXHpwcLbEQMIWwhdXFQupymr7LUCBhmulkfRT00+paU39snyVBu8+NOc0ly8R0cSCvGdYIgtFKM+8+9Rgu3YDNuxX8EXiHjosxDRCsc4d4MxzwJwB/27XpEz6LxBtYXaPh7Xko+Fj1gmI1MpqpAa5UjCXyfLgHazaOw8EXf3E9S5SxHDTCDabF1Pyvx20nCrIMhDfzjvKTiy7oI8lIT+OI1D5377P9F9XwVDVIi4qzsM9pfhsZYtoUlVASHs0vmLlPAkOYSw4e8Q4fcAGfH4I79hpzzmqLK+r1l65yA5rpyvskZnvANe/H5ZyZoCQaeSxYfnGnXRp/zTW/Oi2XTLQqfaa7XHVuZCbvmTW3Jrgk+1u6Bw7E8Xtkh0OUpJNnJGrm6CSlIxNMown+2vz+I0MWSrdzl1w0f50GPLApNZ1Ofy2vdCXJTJHAVJdQysmcin/ES2ByL7m9di72E9H8s7UxlXeP/ onZAjm28 As3bFiPQ0/1FXWJXA87FIwkk6hfMQhIAu1nhugN/iPIkC6FJV4+If0+8OX5SMuNwWB4hujwKx4CEXkQsptCVw6JPdr3RRwQoIjRDewo4T/RV7ky9UPbjTD0Nsj+bBCKFh5sbpd0x0mNvnKPwCakybxswjRe/5a5ctRILTwV4EZ9xP39t0iTS+cFEdHz0XvA5sZC3SS1wZGmNI1uslT8N3yDMPZpNJ3P2l1MRQCYcl8styVkyCbVW+/avgGrcqvK3Nl7vGJOJi6/s30y5OKIYIyDmakFQ84c2hAT4tYSUhm/mDZUbiK73jhIV9Ya4hHu4npSNijxMJ3hzeN/G0/sVjptTHOvDU51Od/KkVTiRDWgNJ+RV2tZ1di7crcqpLUrZJL2+AXOy35oND/EuSiAbRBBj9phw9rr2tE2ztYOWrAWunAKvbQK6o4g+VzKS5WLFIFDGyjdEUYvzTU+k= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2025/1/6 18:36, Alexander Gordeev wrote: > On Mon, Dec 30, 2024 at 05:07:47PM +0800, Qi Zheng wrote: >> To unify the PxD and PTE TLB free path, also move the pagetable_dtor() of >> PMD|PUD|P4D to __tlb_remove_table(). > > The above and Subject are still incorrect: pagetable_dtor() is > called from pagetable_dtor_free(), not from __tlb_remove_table(). Hmm, __tlb_remove_table() calls pagetable_dtor_free(), so moving to pagetable_dtor_free() means moving to __tlb_remove_table(). Right? And the main purpose of this patch is also to move pagetable_dtor() to __tlb_remove_table(). So I think this description makes sense? > > ... >> diff --git a/arch/s390/mm/pgalloc.c b/arch/s390/mm/pgalloc.c >> index 569de24d33761..c73b89811a264 100644 >> --- a/arch/s390/mm/pgalloc.c >> +++ b/arch/s390/mm/pgalloc.c >> @@ -180,7 +180,7 @@ unsigned long *page_table_alloc(struct mm_struct *mm) >> return table; >> } >> >> -static void pagetable_pte_dtor_free(struct ptdesc *ptdesc) >> +static void pagetable_dtor_free(struct ptdesc *ptdesc) >> { >> pagetable_dtor(ptdesc); >> pagetable_free(ptdesc); >> @@ -190,20 +190,14 @@ void page_table_free(struct mm_struct *mm, unsigned long *table) >> { >> struct ptdesc *ptdesc = virt_to_ptdesc(table); >> >> - pagetable_pte_dtor_free(ptdesc); >> + pagetable_dtor_free(ptdesc); >> } >> >> void __tlb_remove_table(void *table) >> { >> struct ptdesc *ptdesc = virt_to_ptdesc(table); >> - struct page *page = ptdesc_page(ptdesc); >> >> - if (compound_order(page) == CRST_ALLOC_ORDER) { >> - /* pmd, pud, or p4d */ >> - pagetable_free(ptdesc); >> - return; >> - } >> - pagetable_pte_dtor_free(ptdesc); >> + pagetable_dtor_free(ptdesc); >> }