From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 60C46D2444F for ; Thu, 10 Oct 2024 21:51:22 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D9B076B0085; Thu, 10 Oct 2024 17:51:21 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D4B0A6B0088; Thu, 10 Oct 2024 17:51:21 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C12B96B0089; Thu, 10 Oct 2024 17:51:21 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id A2E616B0085 for ; Thu, 10 Oct 2024 17:51:21 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 6B847160C6A for ; Thu, 10 Oct 2024 21:51:17 +0000 (UTC) X-FDA: 82659039120.21.F51B58C Received: from mail-il1-f178.google.com (mail-il1-f178.google.com [209.85.166.178]) by imf12.hostedemail.com (Postfix) with ESMTP id 2382840010 for ; Thu, 10 Oct 2024 21:51:17 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=google header.b=LyKLNaUT; dmarc=pass (policy=none) header.from=linuxfoundation.org; spf=pass (imf12.hostedemail.com: domain of skhan@linuxfoundation.org designates 209.85.166.178 as permitted sender) smtp.mailfrom=skhan@linuxfoundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1728597051; a=rsa-sha256; cv=none; b=GnpJpjv97gwoelQAuvNCikKdyiMY3cTUtqYhsfhrOWkQLOZn+Vz+QEzJsEkr+erQYjhdk3 8xxxGzKf4zYLgEnu2onuPF8/a/9SHBy/PBNcikMtPGnnmQfF3Kh48Jjbuh4VpmbelvGKsG HVu+dwFfUix366FnGwXb5u+XbIoj/xY= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=google header.b=LyKLNaUT; dmarc=pass (policy=none) header.from=linuxfoundation.org; spf=pass (imf12.hostedemail.com: domain of skhan@linuxfoundation.org designates 209.85.166.178 as permitted sender) smtp.mailfrom=skhan@linuxfoundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1728597051; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=uh29BSYlRHYdLt2ocxo/fMoIUs4a5eCJ/P6zRKs85Io=; b=gBvapXcZH6Ij0uqBBpLGPkMmmG868an+HfFuSGnjhnpWn+FXbS86Nnzt6i/AGyxQOOZyow PPca2MhBmAxpd5DBqSlC0o2IJhdcTBA9GU/cJkpd1viWc25PwPLUYoCCCDubwCabWV3I1M BvCHmhI7P0lqjvu5aYAUfS68RGYSjSA= Received: by mail-il1-f178.google.com with SMTP id e9e14a558f8ab-3a344f92143so6627925ab.2 for ; Thu, 10 Oct 2024 14:51:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; t=1728597078; x=1729201878; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=uh29BSYlRHYdLt2ocxo/fMoIUs4a5eCJ/P6zRKs85Io=; b=LyKLNaUTRNMJ6SKweMoM6xRW2qOg1sMZKz8LOI7AB4JO1uSt+M46mrfpJLVy7kBV0s kNv2kHeh6gqCZPhenDQjQNnfqNzUbT8Lx8ehiF4byJO59nBAvFPuk9+g4pV+GEEToVO0 eCOXYYqFTPQtK3h05zhVpXQT0lLLOwqWjYXtw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728597078; x=1729201878; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=uh29BSYlRHYdLt2ocxo/fMoIUs4a5eCJ/P6zRKs85Io=; b=Gx3+1kjDNgRo84WZQjd3lvhzwJWdGS5Ob9qUGb5nEWTXSHS7DkDd/euqFsMyI/+v5A LNwoSe0My9ndS9lLjiHe5A4q6zd6ZoX9f4GH8avA7MhKJX6hc6pcto8i/JwDsew7+tAJ jeWz7A/RwwNOJckzRQUf9TVte8Bry63ROLfA9rTrYS/0TY/Uqjns7G2fvxFKGxvoq6uL FMNcXKV7ZvV3+upTK4VpzV22k5jjpeEl6djDdUMuwDGl8wb7nzXy4Dos4bGd/66a4HH6 knZLWAjBSZIVs1wsd4teZlQv8HZianCx49+QdCTMtZ1Cpe0JMJRCMS8Is6+glASEPqoP I3YA== X-Gm-Message-State: AOJu0YxqNvYxRFiaVh6mShIVaY5aF9tFcKnlRcehjnEpRpB+nt955ROE ToUsNoSmLvmEVwvQxk3Lzjnz7iPw3jvYrNAb2ZF8KNS14UQXO15G/WwE3O/N1ak= X-Google-Smtp-Source: AGHT+IGiDgwEJY1ZMq6egYLmaOYSKlkRouWLFZDSNPsrPR3YOwgzGFrvb5pu1BOry26y2sZLkG8dPA== X-Received: by 2002:a92:c544:0:b0:3a0:4e2b:9ab9 with SMTP id e9e14a558f8ab-3a3b5f7a9b9mr3132295ab.5.1728597078374; Thu, 10 Oct 2024 14:51:18 -0700 (PDT) Received: from [192.168.1.128] ([38.175.170.29]) by smtp.gmail.com with ESMTPSA id e9e14a558f8ab-3a3afdae1a7sm4331785ab.1.2024.10.10.14.51.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 10 Oct 2024 14:51:17 -0700 (PDT) Message-ID: <2d048360-64b8-4af8-a5a5-3b69c5d3247d@linuxfoundation.org> Date: Thu, 10 Oct 2024 15:51:16 -0600 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH][next] mm/execmem: Remove logically deadcode in execmem.c To: "Everest K.C." , akpm@linux-foundation.org Cc: linux-mm@kvack.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, Shuah Khan References: <20241010181102.5522-1-everestkc@everestkc.com.np> Content-Language: en-US From: Shuah Khan In-Reply-To: <20241010181102.5522-1-everestkc@everestkc.com.np> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Stat-Signature: dx7pdb54jcizj4dwe1frz6sqtyrxh4b1 X-Rspamd-Queue-Id: 2382840010 X-Rspamd-Server: rspam02 X-HE-Tag: 1728597077-883255 X-HE-Meta: U2FsdGVkX183uDj+aaQdv83I5FWPAP8clps5vnIsiWscCYqZ1I2eJT+6V8LMZoRbNgNUD8KUGRq3BE423X7LLtZXJMRFv+TXCmx4q1Gxxfc4dLfMmPRN1iZAwiMOYXUBpC1AuAvuG0lfv7sKtG6FkdFdI0vOWKWW1IIEYQXN8hRWsJBL0nBXAjxGlcXbZy09OY6o2lzMLANCOyevBcD/Rd1SG/Hi6tcoX6roezH3fWnI8J5HcCyCAO1VYkYjaGhrpp6QumrIejj0TsR8XjwCkEcca8OrOve5fUDzxoLtE6gR0+2kwRXVPwCVUlCnpkR2+qI31IKHRESm7ydxRF/Vr07C+f8PouY/HqNYQdJ6j/6msy1euq1z+nN5yzQ2D5q6Au9XFR9MchcAEC8EskJMtfRQ2/9ZiFu9g+gYdsO/lHbNTJCI2WnG5pyaFZWRProRAuR7pYaAeSksfx832yCFdpKU+uqBwRVgRPufhft8IXbx/Oyuy4Y+D4cASnp4atT2JHp4AmNFG/25yGbYZzHeCBYeV1RteIendP3wrq1uUfglr4ypvaJ7P/QUiI5opspLZMIQcZxGL7dxIKYkoAjMLZPQK8fWrxSXkfyR/3J44o3j614UvXvV5ZGwPhgu5Jq6/XSkvlYJQm36R5nMfrMHUUmvuNk+1bp+y0CPqqgjwM/dNxWQwX0JHOybK2tk8u2DC5dK5S3JoYvhfNBO0BtJXg3m2fTCezA4Eb8kvyXffxuF25cjdssNvCMgsJGuU5K/gakPp+7A8THo8doXok7kDO2nE9M1C/DGhCGbFtj0WY05iwAX9X50VjOcIGh9bpaj3bo5NnKvVB3szNsBGgm5Kj0ufqwbVAfi9Top8XAZFG3mQenwjOeaHMox/Ol5KF7OzW8mCATiKV8hdP8f9BpIGrvJXKcl+BTpSg4oENEOpsOhfe7eM8cTuGS1kW8QOOFq0juk/aCMGej7H4rwHR/ IpSNmsEr c7F/k0xXbuNLg5pa06feeqn2AXTjQgMcnOwYzDjdIPWSmwKrndqZPeb7nf0itaXaAVB8hqUvNgbvYPIx2E7stNHjf4CX5S3PU0oWy4qYZoApZQub1jMaQfDfRVkA16L8PR0lzpS3FswJQy7pcWQ1wQ/nCJpZ0b8/j9x8uOlYQLpg5sEmfYnXb4k0y+VAcBqWtCTX0h7xYOHQAXcsaPS+Eb3Pn8bgp9GdYJBO08GRgqyykkmkhH7H7qe0plttia5Mb3uVB2dJmp4yAIKlkM111VNoGu9M75LSR4rE+57jC+5sC0uUdkwEqhRcn5kBXVvVB2/FnUtUSZVfBeaHFKEIYzonXVQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.020436, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 10/10/24 12:10, Everest K.C. wrote: > NULL check of variable `area` within the `mas_for_each` loop is > unnecessary, as the varialbe `area` can never be NULL. So, the > `continue` statement inside the if block is never reached. > > Remove the if block that performs the NULL check. > > This was reported by Coverity Scan: > https://scan7.scan.coverity.com/#/project-view/51525/11354?selectedIssue=1600362 > > Fixes: d44c3485820e ("execmem: add support for cache of large ROX pages") > Signed-off-by: Everest K.C. > --- > mm/execmem.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/mm/execmem.c b/mm/execmem.c > index 9c6ff9687860..97706d8ed720 100644 > --- a/mm/execmem.c > +++ b/mm/execmem.c > @@ -75,9 +75,6 @@ static void execmem_cache_clean(struct work_struct *work) > mas_for_each(&mas, area, ULONG_MAX) { > size_t size; > > - if (!area) > - continue; > - This more of a question than comment: mas_for_each() says: Note: may return the zero entry. Does that mean mas_range_len() can be zero? Does that need to be handled? > size = mas_range_len(&mas); > > if (IS_ALIGNED(size, PMD_SIZE) && thanks, -- Shuah