From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2D7A6C76195 for ; Fri, 24 Mar 2023 18:03:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7381F6B0072; Fri, 24 Mar 2023 14:03:08 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6E8386B0074; Fri, 24 Mar 2023 14:03:08 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5B25B6B0075; Fri, 24 Mar 2023 14:03:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 4BA9B6B0072 for ; Fri, 24 Mar 2023 14:03:08 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 100FD1207CF for ; Fri, 24 Mar 2023 18:03:08 +0000 (UTC) X-FDA: 80604563256.02.60ABEED Received: from mout.web.de (mout.web.de [212.227.17.11]) by imf28.hostedemail.com (Postfix) with ESMTP id C8696C001C for ; Fri, 24 Mar 2023 18:03:05 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=web.de header.s=s29768273 header.b=GvwiJ9ut; spf=pass (imf28.hostedemail.com: domain of Markus.Elfring@web.de designates 212.227.17.11 as permitted sender) smtp.mailfrom=Markus.Elfring@web.de; dmarc=pass (policy=none) header.from=web.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1679680986; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=RHsurbdzd2jF+P9BCTKbE6gSb10VPLgsD92TZmb2Yvw=; b=Vd4BnZ7btcd9C23jGEBaMFAQmI5O3NxU0/NsLX+B3GDTnLmeKW+LzzIF6JbcK27CQDaGWB XufneGoPL2I9CNCLB3XzFVPoHy7gL6b3vAh9nVj+x5xs2p+7z35x0suVZqONjh7T5cv3Yn jwDtJZCJtR89FUJKfiVKfeXYNdT4GqE= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=web.de header.s=s29768273 header.b=GvwiJ9ut; spf=pass (imf28.hostedemail.com: domain of Markus.Elfring@web.de designates 212.227.17.11 as permitted sender) smtp.mailfrom=Markus.Elfring@web.de; dmarc=pass (policy=none) header.from=web.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1679680986; a=rsa-sha256; cv=none; b=X64L81n+nZxjOeeA91T+kwNyrjCtTdT5lgqrpQntgAqvuQjGfAUaVrVMKkwtOvnefuBsuB oBLe9tVCEGsVC3991UE3hdZGL6k+3ZHdXfgPUdTurILuBBWBpFm1nkiJAl1tQ6j1q0llt3 qZCUWEKdqb4emCjZuXf+yngDFcOGplo= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=s29768273; t=1679680983; i=markus.elfring@web.de; bh=RHsurbdzd2jF+P9BCTKbE6gSb10VPLgsD92TZmb2Yvw=; h=X-UI-Sender-Class:Date:Subject:To:Cc:References:From:In-Reply-To; b=GvwiJ9ut0E+qaOXet8zYlnM7/lywNxKts4NDPdiM2ONO6rLoWMibLEml5nGVvVxst 3oRcPUTCKQ+dC4Rd+NVN99arxyQ4GMtkU1VjOo4ITruLxzHMiiAdAI++atS98FhmCa MIpUpYnXXINfaJyotjh09BwL8lO4MRr5zJCgAitd3O2poJNQE6CiD4Jx6xRXLde1JE dJf9XPR5PUUT00yHcXw/JnB5aKNT7+0qFfFGaKbFtXQgw0LGi/8D1JcpDbTOmh11wA XBraTOirvJzkb0/aNIIUBs0VnCOhmuYqfnUnlp9PLEkepdz/YZ9TSg92ZGc3KoxfmU w3pogz4KyoriA== X-UI-Sender-Class: 814a7b36-bfc1-4dae-8640-3722d8ec6cd6 Received: from [192.168.178.21] ([94.31.81.83]) by smtp.web.de (mrweb105 [213.165.67.124]) with ESMTPSA (Nemesis) id 1MIya8-1pveyj0Mzi-00KNjP; Fri, 24 Mar 2023 19:03:03 +0100 Message-ID: <2d012b08-ea84-79ce-c858-113b26655b5c@web.de> Date: Fri, 24 Mar 2023 19:03:01 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH] mm/mempolicy: Fix exception handling in shared_policy_replace() Content-Language: en-GB To: Vlastimil Babka , kernel-janitors@vger.kernel.org, linux-mm@kvack.org, Andrew Morton , Kosaki Motohiro , Mel Gorman Cc: cocci@inria.fr, LKML References: <6e9ca062-939b-af96-c8ff-56ad485d6e79@web.de> <22a1ec75-155a-2392-ce39-4bca3fc081eb@suse.cz> From: Markus Elfring In-Reply-To: <22a1ec75-155a-2392-ce39-4bca3fc081eb@suse.cz> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:hcldPPeDEvEkETjaa2RUSGTxpzZWR3vaRrmaQelJvteg9wMlR/P 4UmGi4aEIxS2lUWrqMs9ia+2lLo7v9xdMKMoWOCp23BrcoCw5iU/3OYTyMkZp2+tH1FAO4E UkGFcyb3PCrb36plF0mFSDP9I6phcRYS8IeYXk5qoJ8fWfivK+7o3nEfPNzKNKOZhKraCP9 bCAUH6P7lmQBH5crSzUyg== UI-OutboundReport: notjunk:1;M01:P0:eYt2YIl+NVw=;ny35/dbsr9awgEHE81/kFxux+uB EIDeWgwHynQK41KYORTaR8A3oz1mCHtDyOX2AdPDWceFysScFw+EPrWpYBRIsHHbUAL+ZlGcO AKUUUSgbj6hE06vrDIj846tTZyk+kw6PWMuT5XgdshCFRiMlmTJuPlF2NVvEXEYCWaeKqNeqz ReQnG+1GjPklBbZfMRQE76H335ZQcGpFh8uRIlkh6FlWzLWceH2Cb5iZBX3TJkWTqj7rZstOF ts2y+7sxYaq09MxM1WX2gnSZtT4CxDPpODazmc46LwegucBAXJ2igwb3uJmP+130AvsiAJq1L UrHmwR/h6gqCCFo92arYwkNu7Ieu46Ml0ZUT7vQRpCuO9Tk/yDwkfb3l/XKwpaAeVxHDaiHGA QHhaHYji7nS6JVgZ94cslQqLD4RuFCo00oAxy0vEB/+8Dy5hruYZJoyio5V0hM5bsD4tHc1DR QagQ6gGbHyZ7MjXsDzjY5ckXu824GZpSBR+VvDxyO6uifaOHEiOaU63fGJkrWdnqArRu0ABtt eS/qpDRTAnqtdqUCLSGy1T5k7s9DFuQzp/Ci/0OrVYMReK56Ql/gAU6Ib3SXgYy0m9n1tFQzz NbJ7su4GPNDZRA4SKIxI86rbwoKPjOzA76dF1qhwoW6k0eF0jQRInexojxcwJtivgEPwuAT7p MylEvQ/XUlr1YSP9Cz1TmBy9xiMgSxaHNk9mOzP6BCwogH2F3xezTjlJsmc2RkPOSP06pHAQT j8i1OoGSrhtTdpXHTzUPca7aNvuZrEmgToZJO803gC+yP0PsOZly0RPshJqpY5fZuaDgpnioS cRVOsaKEWsWG6eVp1KljPyPyox4HJoludyahQc8oCbkQdeEUwr6LtvGGt78POP1OPzd9ZKbAO Zdhj8yW1XQRFdgJKFo+rcqiD1zjm9dwYV8015AZplSijZ33Uke2uopKR9 X-Rspamd-Queue-Id: C8696C001C X-Stat-Signature: ez5i7idw43actgc937gptzzeemogxusb X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1679680985-537975 X-HE-Meta: U2FsdGVkX18GYHoep8VZKIO5mOrJjyFoIyLZskZvXINzS3YiqcmyFo0OoeNZqxdwBzrcduryRXzR+z0UBjYTLek/R+YD8iKuJpv6esWDsxWx9MtB6H5it7spz/ssSeEz6hjRR7jwhxFkn4pz8E1sdL2qJiDPz4YiwBUBJavYBqbKiRzbY8EyeNJHUpG6DIg8LM+q1YH5DcAAEqCudGxwE86NqY8zY4kXZ4gdSaEdC80HQFK8MymN5uhFUxuHl9zO3lXAWUtVH2GJiFYoVbGTm7jEYO91f1AwVwtCPjbHaYwFXzW2dqoge3OdP4sto5HAIbtXf4Kp25x10uScFcm8A/1RmK/cAuRAWao4u1I7ep2sCyywFqysQ513LjstqxZmoWyp62XBp/F9qZVqiE6HDXfrqEqaRlPuqtHNxNRI6UGUMoenVXgk3bKB9fDr/IiLLnMNR47tdogGcU77XobdKkewKj2238kw6PUBj/+ZDNleNY7WwIS+iPwLRXBTZJFJVVFSJmgudBpXjh+tRVqJkATFBrV3LuhQgjrCcoa/1UWx4Mn33yZq0r+5nGMW3OH2eMzdinGbYEzBbpFpe2eiL1QByK1eVDUXaCrVJ9tnQYGElWAzqabVRHkimUgHE34EtpEzSjcOGyydh834FyCkhk67pkxs5NZvFptGy5THY6N8VYWpuwDff/+tuPOebDyTEbhMN0BFq4YzIonY/Jp3NdRYNs5/kbCl0QXY2qDtvh3EHaxIh2/lAxf6r62UPYEdxzFSttkoA5Ma8X3SiIRMLCTi7uzpTlOQ5fIuPh/6xLv7H7HVDUBI+I7yJyUnOd9YplSXePsiol54V2kuNR5+EDpGdFgOE7aQo2fp42W+VmwqSn0kBxCusXcdF2xSvQq8l5AuqT8MDWX1aVfI1RhE0exsv016yJWdtl0PfjjHDgxXc0/dhfNnQDC6qMa3qBKB/9o/8+1KCUN4vQQasdK XdcSVC6v j9GSr206OoqUdbWjK5gouAtB+DKoxWQZHH8/Lhl7Ui0ExwsFKdJ08VynAazlnpNvk+aY2vg9N9/4OlaFMr2PCmXoDknRR0AythYYlvSCEjYV+hArlqxuMralrPlmwlasL+Qw9c6OstxngX2twUFL1n9Ag0AEfoa70+DJzyhWEBd1Q/39nsOs6PuVJtIILFfT4YsG/3oEqYVi7IMsRmVbVtSteZXSAMxOsgUss7PKZEUj+LovmrUHmo0/BGxeGBQuEbTxWNzagdcEkNLOMRhrCeFMcu1lKo/nO3OdpMXIQHILF8sQ= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > Your patch doesn't apply, seems like it uses spaces instead of tabs. I am sorry for this glitch. Andrew Morton picked my change suggestion up yesterday. https://git.kernel.org/pub/scm/linux/kernel/git/akpm/25-new.git/tree/patch= es/mm-mempolicy-fix-exception-handling-in-shared_policy_replace.patch > https://lore.kernel.org/all/6e9ca062-939b-af96-c8ff-56ad485d6e79@web.de/ > > Re: subject, I don't see a bug that this would fix. You could say it's > "cleanup" and this function could use one, but for a cleanup it's not > improving the situation much. I find a few details improvable also for the mentioned function implementa= tion. >> The label =E2=80=9Cerr_out=E2=80=9D was used to jump to another pointer= check despite of >> the detail in the implementation of the function =E2=80=9Cshared_policy= _replace=E2=80=9D >> that it was determined already that a corresponding variable contained = a >> null pointer because of a failed call of the function =E2=80=9Ckmem_cac= he_alloc=E2=80=9D. >> >> 1. Use more appropriate labels instead. >> >> 2. The implementation of the function =E2=80=9Cmpol_put=E2=80=9D contai= ns a pointer check >> =C2=A0=C2=A0 for its single input parameter. >> =C2=A0=C2=A0 Thus delete a redundant check in the caller. >> >> >> This issue was detected by using the Coccinelle software. >> >> Fixes: 42288fe366c4f1ce7522bc9f27d0bc2a81c55264 ("mm: mempolicy: Conver= t shared_policy mutex to spinlock") > > Again this is not a fix. Do you find the change description helpful? Regards, Markus