From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B6234C02198 for ; Sat, 8 Feb 2025 16:41:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 320056B0083; Sat, 8 Feb 2025 11:41:39 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 2D0396B0088; Sat, 8 Feb 2025 11:41:39 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 197FE6B0089; Sat, 8 Feb 2025 11:41:39 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id F03BE6B0083 for ; Sat, 8 Feb 2025 11:41:38 -0500 (EST) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id A13CF162801 for ; Sat, 8 Feb 2025 16:41:38 +0000 (UTC) X-FDA: 83097343476.15.BF2F53F Received: from mail-pl1-f178.google.com (mail-pl1-f178.google.com [209.85.214.178]) by imf18.hostedemail.com (Postfix) with ESMTP id A83561C0002 for ; Sat, 8 Feb 2025 16:41:36 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=iOJwB7gD; spf=pass (imf18.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.214.178 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1739032896; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=vXCjsjIchj4ClmE8mkIDMpox5dmrDwmTJqUAgxNU5dQ=; b=Cn6xNuAN3htxj4eyRsO0ox4lrDUPHdnOnXClPYsEPrkuqINOUyUiDLC95Wq7tngsGscy+p 73wJtEK07Fr6F7Hk6ObEHGmKoIGMQfqEjX0URjxZl+3267d0wtRSeDDRgXdOuSTu3/+6L8 KVCmxNopduDPJm/66p779fzZwCyPicI= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=iOJwB7gD; spf=pass (imf18.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.214.178 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1739032896; a=rsa-sha256; cv=none; b=JnJos4D4ZqgxqkLM/zv9QccgRNoaxgCYWHlC8FAB1JPNPPaVrhlHKG01F/w+o5jSAFsvIX 6vZoET3vTV8mrnb1ZBwQ/cJ8yZIfbaURGt++YnmJKveaJSO9iJXyIYSipV9lwusz0Xa0+c 3atRmLcjmbPhZwu6OEjz9nJuhLrfrUY= Received: by mail-pl1-f178.google.com with SMTP id d9443c01a7336-21f50895565so24727675ad.2 for ; Sat, 08 Feb 2025 08:41:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1739032895; x=1739637695; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=vXCjsjIchj4ClmE8mkIDMpox5dmrDwmTJqUAgxNU5dQ=; b=iOJwB7gDn/9DlzMWkzhyc9dPjzRpP7GuRXZcTzVaxoVyU52OkDHRywC0u9uIowmKo1 6HG0LclvBQ5dsPyOKqDIBR0/jq0eY7nCmclJgiy0lt42PGgCLDtvS5XaBrdu65/lnFi8 D32wwYeFYDoJxXA8b3UNr+0QJhhiyyyaFXisE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739032895; x=1739637695; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=vXCjsjIchj4ClmE8mkIDMpox5dmrDwmTJqUAgxNU5dQ=; b=nE7bSV3XmgnDBzmCyaBwPtWkH3IvoomEmVByDXCyU8xlzzgZjOBJRJLsRzTYy5Eava HX6nPTtbtDBO3REZjkPxpg8mBXnWC6D1hu3g0noj2l/OaW/sz375/00bIIKJpp+j9MN/ zy2QPS1trrieDJolKdJNHgPVtpxcIFq/3j9EABtMg0w5SWWgV/rdZaR7gHN0TuHcNgCr Cm1C3t626phq454OHiUJbVXNiseI8yV8t+67wZMbH9IZuib2YdHeP0VIzChNo9DiMizN MOJrl/SHJStLddnX20neL/GNO1D8DedwbLEO3Y+OHJO5PSYImusCVOPScuxW4ZqSu6DZ 9V6Q== X-Forwarded-Encrypted: i=1; AJvYcCWuh9cH4Y0x3NKXKibgnytD5LT/fslpZu3hxSzECD3D70w4DLEX1UjjzHxfYfhFt2TQez3W/iNQZw==@kvack.org X-Gm-Message-State: AOJu0Yyki9QhTxYBibK1uVlwDkGHXpcpNUjd+MYDo9TqWSaHqL6OHW/w 1erBQghz5WOD79q72gVPE4nclbHMv3gC4arAgiw0oJua4+Hai0BHD9HiqUXymQ== X-Gm-Gg: ASbGncsLHBdzjJs+WM5CG0F1VBOHMThPMiUCAAhiYo1ime3x0CvlNOsoefOf8TLgG6K vBmP/xOm1Pvz0YJPNJuyaQhWujxHPKMBl5X7OkstmK0Vm4STJaa33JhZdZxoKv4iq4aGYZryFud 6zzJYK8vBAbdWJZ2cvjSl6ELEAD6zCo7ftOHmXpu3RK60iox9AoLVk0mZJCtj3MCHiMdgSzpi+J G9z/7HJbEBxYKFxijuCko0Zw4ONf2555n1n9JVen3J/4toxDNHAblsbWD43UpCkr4zpYKDymXbJ 6lrsjuZBjo30Eogvqw== X-Google-Smtp-Source: AGHT+IFgi77tH3wA01tZZCz7a+5y8kuCdm5LYnkR+qY46E3GAn35GhJb9PnwYL0bHM9MBXsMPLcUjQ== X-Received: by 2002:a17:902:e547:b0:212:996:3536 with SMTP id d9443c01a7336-21f4e1cb73fmr137616885ad.10.1739032895636; Sat, 08 Feb 2025 08:41:35 -0800 (PST) Received: from google.com ([2401:fa00:8f:203:139a:254:3216:daad]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-21f3687bde1sm49019555ad.195.2025.02.08.08.41.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 08 Feb 2025 08:41:35 -0800 (PST) Date: Sun, 9 Feb 2025 01:41:28 +0900 From: Sergey Senozhatsky To: Sergey Senozhatsky Cc: Yosry Ahmed , Kairui Song , Andrew Morton , Minchan Kim , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCHv4 02/17] zram: do not use per-CPU compression streams Message-ID: <2ckvrkhhioezkjscvwvzclspikstx2sreglsyie5bi725fypdm@bxxuqtulk3gl> References: <20250131090658.3386285-3-senozhatsky@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Rspamd-Queue-Id: A83561C0002 X-Stat-Signature: xc4q5ppqgcp5ncqs53ctc1ccubgo8xx3 X-Rspamd-Server: rspam03 X-HE-Tag: 1739032896-421812 X-HE-Meta: U2FsdGVkX1/Hr71UcbajKylIClwrrIIO2dVJDz+eRifRrhV0dIkgzMPCRdObYeQsmanJ06ulc9I0sjpVDN3K3huxP3EyeijYwTQxvJHef1u3hpVuIRk42jlGTEqvN+ppGH8JySPLaE6+aG7Ngce9G6dNnlY4lyTi7jAnDF9toiYbqXUGEBJfHvKmIODVxD28QVC9DIAvvba6fqiEzcYwK6FkzUzdO66E8ipvELWN4EpRlM/R1BUfj80kJMn2ralGOIDxe1tX1Cg6wbaQx8HpcoLwo/UtLj5CXYynTHk/uPuy3N/6ZglteLP3Xc7B6KOXZBb1QWAluUjXSY+r4iccUJPDHccrHQgHGXnO+QtP28Sd6SnEuKCQ4818XStsuhbjkGLBY8PEpA1cLKbZX3o+OdxgyLLEIgNFOFfPsAYWRl+huLKpuZd/AwbFO55jYxA4R0dQ8+If0cNh4s5FuxMfr8ZUFnlkwQ4R/LidHRA+8anwkMswBmKNg1Xjb3neAZHepLIfBq3lMaJYZD26o6kn7Txbl81IiVGLST/6iMY73JpUwp8wEfkRYeV/WGjNiysXLLP/4mGLOevAvhu9NkjDy9gmWePTXax3KfB7tStR8/WHF8GJoxCMfZMkypz7jmeawxxIn9YaQeLCc1Pt/GVmRv81aqgJVicDWaTzmpR1jsps98ibAzASjryRzfq8qoRNbisVGyc+O2y3M9ToqepIXUF/7xkeV/4ggA/tqCsZmrPcr3OqxSeoobX5BhLac2S5XVsM3xbM/5izcsLjVLC4YFa4wYZVAqC+j8efgWjOjGh1YSkuNdouD8Y4Ivq+04KyQd8D+gVUKMBGUrDmzaPLdWzvpTPP4HYwrOsyS6wlqWW21bPqawHtVnaZYrkEGUeGbZz03vsid94AShaZ0d1qSIX9r/xyUS9MyWI7uyeNjFk0Rml8s0sTUnw+SloTkyVCoSCtEA686wK94aEI4Vd etwpjIKk vmAaylfPrhLQYdYJ/e3mbDrPohRO7sqwkXBJGR9yb0UFlEkWBvS9RRg6R6fkWai0b+JO4Mh+7ZMdPhCaXK0fJn55wUHtUNJ+xh83StP1hgV2ST5TL3jwp/f4lhGX9vZzeF6KQPA9h7RQXjSchBGYTA+v/P8C9uBTTx/ORj/ZapExkb4DrsVTxaKIRTvrN9ZDjGLjEQSLjtFNcIZtg7F3WshNDReGVlZ77pTjAGJvPNHVIi1m5Sj3kNKLvg9ovhgYiOZXtm6gaMcNkGSgwFwT4twFtve1nTvlorFxqHSRLQgfsnhuoFStlM4Er5Fp39Z3yOYfCiU978DB25gN9U8YcZGPouSAk8EOFfvE89AlKZO3p8nY= X-Bogosity: Ham, tests=bogofilter, spamicity=0.005377, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On (25/02/09 01:20), Sergey Senozhatsky wrote: > So I moved lockdep class keys to per-zram device and per-zsmalloc pool > to separate the lockdep chains. Looks like that did the trick. > > [..] > > [ 1714.900906] [ T172] Chain exists of: > ptlock_ptr(ptdesc)#2 --> zram-entry->lock --> &zstrm->lock > > [ 1714.903183] [ T172] Possible unsafe locking scenario: > > [ 1714.904463] [ T172] CPU0 CPU1 > [ 1714.905380] [ T172] ---- ---- > [ 1714.906293] [ T172] lock(&zstrm->lock); > [ 1714.907006] [ T172] lock(zram-entry->lock); > [ 1714.908204] [ T172] lock(&zstrm->lock); > [ 1714.909347] [ T172] lock(ptlock_ptr(ptdesc)#2); > [ 1714.910179] [ T172] > *** DEADLOCK *** Actually, let me look at this more. Maybe I haven't figured it out yet.