From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 31597E77188 for ; Fri, 10 Jan 2025 19:35:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B6E006B00AC; Fri, 10 Jan 2025 14:35:07 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B1CC56B00BB; Fri, 10 Jan 2025 14:35:07 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 974296B00C1; Fri, 10 Jan 2025 14:35:07 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 77D206B00AC for ; Fri, 10 Jan 2025 14:35:07 -0500 (EST) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 0BBBCB0609 for ; Fri, 10 Jan 2025 19:35:07 +0000 (UTC) X-FDA: 82992545454.03.4F99585 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2041.outbound.protection.outlook.com [40.107.93.41]) by imf26.hostedemail.com (Postfix) with ESMTP id 306B814000B for ; Fri, 10 Jan 2025 19:35:04 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=amd.com header.s=selector1 header.b=iIO2HkM0; spf=pass (imf26.hostedemail.com: domain of Thomas.Lendacky@amd.com designates 40.107.93.41 as permitted sender) smtp.mailfrom=Thomas.Lendacky@amd.com; dmarc=pass (policy=quarantine) header.from=amd.com; arc=pass ("microsoft.com:s=arcselector10001:i=1") ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1736537704; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=lwnNTEWv/Nl/9uVx40C6GWbeOQf2jWqKCYhuVUmUqvs=; b=x4Lizye+5a3REP9TE4qFFqQsuJxBeYyfrg1yq7GY+dphnifPpkHFGjfRJnhnPh1Zugiy3R sTuHPoTgDiOhwdXJu1q71pwdF2d+r19bVsYIRBjzYLyiYyThypqsdWbYUe62018vj+Lyda DOwOr0Y6CnULpA8pVUxNLLmLKXNRTCg= ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1736537704; a=rsa-sha256; cv=pass; b=Sc3e7doFlPAGIpDVxuLwtRw2M9cEudaoOql1UBHswU2/SWOqRGz1L9LOTR+uT4w5WnwpLn fP2tfKD8taL+NAc1pID81osfO5ElgrFUCYEyisZIOgyKtzS0+WvyBNHn691ojjp/0P9s5/ 3zoLe3aFUxRDtC1BTl5MByQ1DAPQ8Pw= ARC-Authentication-Results: i=2; imf26.hostedemail.com; dkim=pass header.d=amd.com header.s=selector1 header.b=iIO2HkM0; spf=pass (imf26.hostedemail.com: domain of Thomas.Lendacky@amd.com designates 40.107.93.41 as permitted sender) smtp.mailfrom=Thomas.Lendacky@amd.com; dmarc=pass (policy=quarantine) header.from=amd.com; arc=pass ("microsoft.com:s=arcselector10001:i=1") ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=AtZ1J7z5mygihW0qTKWTHWTjHbXo/gxx1C+axtwvRHBYrTdEFi+YMHnTobW/ESA9Kpw6++S+iWmSyjU4R1uq4OpHMKI6d22uLad1YmgLuPGbuO+guFopQJWkT347pyrKgftevG4NRzpop1HbmNLR7CWMIsd7LNI4qpW+l3qihF14wmwp3J5LmiZV9g1TJJJiugFgAL+DyxAEyu8Dv6LP92BJcZJXHfFjHqyNMNR3zomqlqomfE2kIWPUlqXdeVB7XefHsHPHZBCkY1rg2zNd7litSxjl/Pus+QNme4Np7xy17kMKn9AyAOEldUiymNJcAdgMVGzXfrUs7jJnNUbaPA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=lwnNTEWv/Nl/9uVx40C6GWbeOQf2jWqKCYhuVUmUqvs=; b=xtZgPB2ScHGkZqToiKOYnPWwMUUP4gdhpx0CkG9ChQJ/OYPb4EjNoCbNbfPVpYOWRC8tpR1EYJ8dAR4bybEw4JrOORcd1bPssjtwiaQll3LNfuRwLfn0Ad/KfNXdU6ZmZyCciss6YJC3nW7EzccACLxnJkQ3Lb/UcejVMuHupXLoYd+NLffHg5f87jKdNp698AuU5rB2m648wZ2uVyltJ7ajiKTdNBKiFm6YWQnueCPJHOpHB2pNRlJL4CnDvvRAT2+o3yq/0PQVaMh23YgQnzmk3oGBypIIC60bbwyrb+GLCo6p7HpnitI+LvBAB1nLmc0z3L0urX93T0ARh3cLbw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=lwnNTEWv/Nl/9uVx40C6GWbeOQf2jWqKCYhuVUmUqvs=; b=iIO2HkM0k8I+6+qG9JL5VFAdjtXQ3dyutqMGcNzJppkI8BL1w/88zCqyi/WwYwhY/L4ubNHkP4JHJFYXdgsiYIQrxg03MfLNaCxGX5NjsHncthETBvJGL2r/KGZ5kcTXoDKNDSoEtqDw/F4FNrGmUqPIK6RBPBHM2/7gDBfigCw= Received: from DM4PR12MB5070.namprd12.prod.outlook.com (2603:10b6:5:389::22) by DM4PR12MB7648.namprd12.prod.outlook.com (2603:10b6:8:104::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8335.13; Fri, 10 Jan 2025 19:35:01 +0000 Received: from DM4PR12MB5070.namprd12.prod.outlook.com ([fe80::20a9:919e:fd6b:5a6e]) by DM4PR12MB5070.namprd12.prod.outlook.com ([fe80::20a9:919e:fd6b:5a6e%7]) with mapi id 15.20.8335.011; Fri, 10 Jan 2025 19:35:01 +0000 Message-ID: <2cf92ecf-cd14-734a-6dd9-bd489321651e@amd.com> Date: Fri, 10 Jan 2025 13:34:58 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [PATCH 11/12] x86/mm: enable AMD translation cache extensions Content-Language: en-US To: Rik van Riel , x86@kernel.org Cc: linux-kernel@vger.kernel.org, kernel-team@meta.com, dave.hansen@linux.intel.com, luto@kernel.org, peterz@infradead.org, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, hpa@zytor.com, akpm@linux-foundation.org, nadav.amit@gmail.com, zhengqi.arch@bytedance.com, linux-mm@kvack.org References: <20241230175550.4046587-1-riel@surriel.com> <20241230175550.4046587-12-riel@surriel.com> From: Tom Lendacky In-Reply-To: <20241230175550.4046587-12-riel@surriel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: SN7P220CA0003.NAMP220.PROD.OUTLOOK.COM (2603:10b6:806:123::8) To DM4PR12MB5070.namprd12.prod.outlook.com (2603:10b6:5:389::22) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM4PR12MB5070:EE_|DM4PR12MB7648:EE_ X-MS-Office365-Filtering-Correlation-Id: 45770130-8cc4-4c14-53a0-08dd31addfb6 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|7416014|1800799024|376014|366016|7053199007; X-Microsoft-Antispam-Message-Info: =?utf-8?B?bGp5ak9Pbm9vR09IWGUydkJYZHBqaXZKNFE5eUdiaFhtN3E3L3VQUW42SjJP?= =?utf-8?B?M1QvbEY4eVNpZ2dpUHN0SWY5M3lWMjNycU9MZDNQZDBGTWV1eTA1QWUwaEc2?= =?utf-8?B?dndUMW5ib3plYTEyQ0pvTVNzeDFJTVNlcHJnaDN5b2FKN0lhY0J2MHlnNWpu?= =?utf-8?B?UUVsY2p5bkV1anZlMnpIUmsrUzVZTFovY0VraXRZc00rbXF2L3dKQjRMc3JE?= =?utf-8?B?dVlNS2h4WjI2NEUwL2pISFVzemNNSDdYd1NDenhjOUFhZHp5NjFXeTlKakdz?= =?utf-8?B?QWxsWnJHS3k4bEJMdTNrM1hUbW5pQi9pSmx5blpWWmJaN0hYR2hUUm96Qzl6?= =?utf-8?B?VThxcVduMmVSV1NjOStpNnJJaG1wZVV6YzZ2OFVwcVVaM0VVUFFtZkJDdm5Q?= =?utf-8?B?bUdkUUpHK2ZGMkVjc0MrY2xmSlN3d290RDdvbUtXemdBWW5xN2VUc0Nzclll?= =?utf-8?B?aTVxN2xzd29zTUN1OFc3MVBRd05QSFE1SU1VT0FLSnJwL3pHRFNyamJ6ME1j?= =?utf-8?B?MjBxd0gvcmIwbUR5L054YXQ3NXdsUThSZGJGTXBoUU1KbFNjR2thY0M1cWE3?= =?utf-8?B?aVRLaTJoYTRNVDR3bm1aWms1UEh0Q3ZCM1lNWFhJU0xiKzJqRWJqWTZ0WGFl?= =?utf-8?B?Vkpjd2M3RVFJMHFpelJ4dlNickljbGF6TVRMMytnT1FZNStsRlZtR293QkIz?= =?utf-8?B?MEc1aktFdGxPeVpQV1ZIM0FSUnRlSlVaTlhZa1kwY0RDYTVrRThDUmNPYVlk?= =?utf-8?B?c29XTXhwbTAxU1VNYzJseThhYUQzSmVrdWs0dnR1aTZZQzNjRGgxNFE3WU82?= =?utf-8?B?YWlJTjFNTjFLeTU2ckxORmI4Q0VzYzhxYS85ZHZITGg1NytjaUdkbUl5Zi8y?= =?utf-8?B?UXBiU01IUHhsUGZhZzVrbCsxM0M1SWEzcXM0Nm1IVndMSUtHL3JpS0lsUkth?= =?utf-8?B?WDZWK2ZtVDh3MHBDQUJiUEhxN3hCUHQ0RFNwL2dZam5CSlc1T1phWkZTWXkz?= =?utf-8?B?bGc2K1BGNzNuc2lqUGJETm5jSmVSelNrYldHTmlkM3YzbVZ5OG92ZUZDRHZG?= =?utf-8?B?c2RHbWZ1WGxLVTRMR3Y2Rkx1RnJBWnNmYzJqbVBjeno3aU5RSC9pdzlKYy80?= =?utf-8?B?OWNOL3dXL1hiS0JNb0Q3bjFxK045eGlpVmhGVHN4WVBmS0ZUVmlDU1ZyVjA0?= =?utf-8?B?YkZsTWF0Q2htdGhGTUI4VEE2eHU2aXJxYTNSeW80cEhFRy90alFyaS9rSGl6?= =?utf-8?B?Ty9lbEJJbUNPOTRZb1BEVDgyV0tjZ283bHpvN0F5Y2kwaEt5ZjFnU3NJU0Rx?= =?utf-8?B?bVp5R3VjMHZKNlNUSGxibytwOUV4dUZPVlg5NDBPT01TUmVxOTJvSlUvdTho?= =?utf-8?B?TWlZdE5oSGtvRzFVSTR4a09zdXgvMnJ0OWVad3JFNkdlV21mRVdIbXhxVkRM?= =?utf-8?B?V0pPb2ljcjBaRW9VVGtOaVc5Ni9CUlhnWE50RnphU3pnR2tyVUtUcHNtdUZr?= =?utf-8?B?SHg0dHZJS0E3bnhnSUVtWFNjWUx2anhXZVRBNnRMd1VkQTAzcm1QOU54VmNP?= =?utf-8?B?Tk9vSWJrcVpCOGJnYjMyNk1ZTHE0OEE5a25yWmZNU2lTUHBEcExEcitYanZT?= =?utf-8?B?UmEyTkpFMHo1ZjM0VTJkcnA2NVdlYXVnRUpVaGpMdFJPdndTS09PbVJINndP?= =?utf-8?B?bFRtY0gzZFJ3bXVRVVByeENQRkRuN2RhVU5ZVUN0MmRLbUszWmVWNnkzdmcw?= =?utf-8?B?bDhWaEhZNGJQYTJEcGhvaTBBcGMwYk5XY2pxYWxCRWNBSG5xU2V6YzFCOE03?= =?utf-8?B?VTNGRG1iTS9wNXVkaVJrc01ZSmF4Kzl2YVFybHpPU2tWSXI5eVBSTWsrMUl5?= =?utf-8?Q?69MTAcCXF4UBy?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM4PR12MB5070.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(7416014)(1800799024)(376014)(366016)(7053199007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QVl5eStXenhuUGYzd3diaUd2OHMrREJRdWwzM1ltOEdZK3pieHZrQ0ZVeVVj?= =?utf-8?B?UkdOaHEvaFF6RXBLcDZWZlpNY1E5U0hFU3B3VE5wMUR5ckJ1bVVEc25pTEYz?= =?utf-8?B?TW9FWWIyc25kaitKZUR3eVpnNlZhL1YyNXBydjVZdjhhR0Z0UlFsVCtNcGJS?= =?utf-8?B?cTVLZXlmQU5MNEdGVGRvRmtpWnhMM0JueURlM2FTdlY3QW1TcTNVclQ2TytT?= =?utf-8?B?N1ZDWnJ6WlZlYUZLWXI5dWhNdXJ6N3NSbG5RQlEzaE1pdWFFcHdoenlhd0dX?= =?utf-8?B?ZER3a29za1V5YlE2UnF0OVBMYXZQVjlOQ1hKanhvYmNPUkg4aUZuYWE3clFo?= =?utf-8?B?QUxOVTlIaUlxNVhjTjdXT0tucXYxVnU0MjRNWW9TNS9XRUF2Tnprb1ZLc3Nj?= =?utf-8?B?RG5kRTlzV1M5THlIWW40NVNudmZZWm00ZUxlVlhkNVRtTk12b01VbUlRcFFL?= =?utf-8?B?T0pCMU01aVJJQkNYU3hLQUM3YytmeVZib1NUSnpDOEdmeVZhQzZGTmVhTlBu?= =?utf-8?B?QjhBeko1a1lmOTNSRW1qWDNLckZSM0daa29qRmVuVDNWb0JFMlczVU9VcHU3?= =?utf-8?B?RFhNMjZPeThRdWZSbytlQUYrdFNBeExPQzF1amhwOC8ySXpmZHM2RjYvcjdR?= =?utf-8?B?TFRMN0RRdnNxVXd2c3MrMlh5cm5KcExyS3g1Y1dzYjV2YnV0YUhsYkhLZ0VH?= =?utf-8?B?WGVLazhZTitNM3FUMHhtMG45bmc5ekFqcEl2eFJ3aWFjeEVsaWNneXRsbHRx?= =?utf-8?B?elAwYUd4NEtIWjdjS3AxeTNSbWYxZlVoVmFnR3QzUDJydmRtYWs5a1RSWFFl?= =?utf-8?B?SXdvYTgySVJMaDN3eEhVekZ3Z1p6WjhaTHVVNWNqcVdKS3hSZ2ZSeEI0cTVX?= =?utf-8?B?ZFZFeXN4NDRaWlZyYkkreit4ckI3d05MSk5QMHZQenptU0xGcDlYSnQwMzB6?= =?utf-8?B?TUtBY2l4d1RCRTUrU1E3V3dGUTBBOWg5RXhXTmVkbUlDMTlqcExxSGFtT3lt?= =?utf-8?B?dGlCd21JL0RLaFNQMFNKQlFQUTJmaVQ1eGRmb2xXVjVRVk5KUzJIekxFSVFV?= =?utf-8?B?d0NVa1NpcXcrN1VwbkRJUXBxbFMzSUFnbkRvSUhMR1B4ajJmYmRhU1BrMFpD?= =?utf-8?B?OFdTOEdEUlFsLzNUdEt0QTVLcytIVjNyZkFMcDFzcmlpT2ZocVBJLzRhdGRG?= =?utf-8?B?cXRlMWc3MVZ5eERkY0w5YlNzS1p5bEFGUGZweHgwOEpOZVVieWREUDNSU2tM?= =?utf-8?B?YjFkOG1PakdsNzQxblJCNWZmUjhIZC9CcGpYbnhCU3JxL3M0NXY1ZVYraDVC?= =?utf-8?B?RFVaUStOM2dPM0d3RkFack1lZmdRNzZXaEhYSFpna081QkliR29pelJZbE9P?= =?utf-8?B?Y1pIaTh3T3JtbFRLOGlCcUozdTFwS2t4a2tlYTB2NnZDbnEwakNmaWtoQi90?= =?utf-8?B?aTNkVTVhY1pTd2RycE9CaHN2anhjNFB2RUkzTGt3Y3hmZDhQekR1V0xORERp?= =?utf-8?B?N1hXMU9sTjgyRHY0S3VMUjRMQ2xIb2NzVXhycGVEM3ZKVkRKVUNKRk5KMFhP?= =?utf-8?B?NitPNjMwV3lkY1E5T20zWVo4Q2dJeldVTHVnTWUyUmRXZS9DZ0ppU00wdmx3?= =?utf-8?B?TUNGOHNseWQrbElXYXlwQmxWb1NJcDAzQ2huYWs1dkJKL1N5WEh1YjgzZVh5?= =?utf-8?B?UWNyMy91K1c1d1BpM2dHaWxJMlZBZW9DTUg5UThYUHp2VjB4OGM1REJaYWo4?= =?utf-8?B?Sk9MZ05zckV6RU1tN0tFeXZJcVdBRkJnZDVyUW9HbWJ5cHR0djYydXlRMFE0?= =?utf-8?B?ekRKV1FORHhSV3VENUYwTE1nZXhkdzYxVGtxWmY4cTVmYjhrOXNGVjhTdHUv?= =?utf-8?B?ODJPazQ3RUMzcTRVVWFCVTdiditvd1R3SXZLWnF2YmhpMkc4MnlOZFhQNFVJ?= =?utf-8?B?ZHhWODlvdisvd2FWdkRmUVBtRk5CUXZEOHZtbDl2UHVma080VHpaSkFjMVZH?= =?utf-8?B?QlROcTF4OXlOMzdEL091NENxUHdUUGh1UEVPbXVxRUJSZWpHcFlJa2FCZ1Yy?= =?utf-8?B?MTBiSkh1ZWtKRmpvcVNTVVNad1ArR2tMcUdSL1BvYkdzMytlMzRqbVI3eFFF?= =?utf-8?Q?N6trY2ODfL1rlJYBhl2zdjMZ2?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 45770130-8cc4-4c14-53a0-08dd31addfb6 X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB5070.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Jan 2025 19:35:01.0282 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: pgEysxS1z+GQkgpALFiDgn/ROeOpCJTdjSB4V5AAOBByfolyPrR+rGFPPVDVqWnSKpcKrqvOy8AK9O8Qlu4WDg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB7648 X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 306B814000B X-Stat-Signature: 4cszdds3j95x9sczabk85rrmgebm1xzj X-Rspam-User: X-HE-Tag: 1736537704-709803 X-HE-Meta: U2FsdGVkX1+pXphnbTGezzq6BOanphjB56SsWeeXp/ZW/lFQqlmQ7K7MKATY5S7531IsneWI4E5vuu29z0YVug9XJsQ/z5U2X+DeXpHy/gm3ANOSTKRw+NrC4E8WKRGT7cxIjZ6fy8nE3WJlNKmCjVx/6amMyGvl/YYqRBwjtANhq4V/1T8skMhvWb5Gjgd35Rfxt3OSQExCJyNpGDiDs7i3brdcGEJkxOUviTNS/gUqBvnxyT+oo5+amikRA0QxL88elIXgiixKiQIg3jBqo38NwEufur+Bel7ptYKzyS+Jz8AelpkKZ9wnHzy1XlGRYB/ehAdFTTGIplh8VDj+7vfiAzSNZcU1KX4dDRevY21zH9WCCJS4kJgHpGg/wC0ABDMkBuNosjdXCayun+sU4fIRT0cMvir1TEqNhAlOiuWxtH25DEKuUlj+WekM4Axw0hXGTBGJfe/Ws29r3GeFLVPMIAJeeLcrCxyu3cqV7AaOiKit4qPF+uzPoXmC1mRjStg4KLeMhcpi5BO7/gOPbHXanlKCQaHhwthDL4lmrX8jWcrHhZfGMS8zajcWSiPIkgPz5VOL96zUylBRkl0HYkd7uAazzZLMXd9XtPg4i7sgxNn6oEAfeeN6J3gv9NCAZGyWBVIbewv6OuUf7ITdZzqO30QABJsaRm5BkOMAEScnGa9jvgdLVfd1l/ViVmEFj4W5WIT4p9SFBOKpJ5XIEh7qe2Tan6GRn9F3Hm5a/DbnOJafiu3iFC4R1QYIeijPN0lvD9GrGfnalyoVWuBDmFLDMbSPC924rPJn6k8ej5RdF+XPgV9AQ+Cgmb9YtSL+1gzNAi1eVLnFQOcxW9OSmzYl3ZEvRXErLvvfDTAkHhA2W4ylK0FePz57l4wPXK32xdvrZUeGQ7vIh8Q5HZtFzd/VR4693B4pfqpVUDCGGCnjZhLPxo9gxjA72o04dxC+ZL+jLJQ5A6PxGjXbgU9 kUKD9nps YYqMIUpKan94eiXQy8Bw6j4r0UrBGNpOjH2wHIRztvYEP3dsoUlx01jCtlr3wBg+VUToUOK9HX9q9AntyrNhwlS2vru3F+xtrm2MKGINtZcDBy2XqEqxkXbrDFULOk9wROOIW47whV/JgUTGazBokTydEsCJ20q6k2d0yTus3pJFYfUnpQOqGliwI/KyARf2QPw0kGMukTjQXlk7w6pZrbeuTSEVWZv6TwAy8ZW6qQ5JkZsQa1Rc+c35fKO000Yt26HEtxGVeXxNfFeJA3TqutlYcIfIUlVDt5yUG5Rt9hifFZ2QpVArK62oA2yu5QyWypK5MrX4iXQf97iwHHvlQ+8kBjMmLlkXl8aI/+mRSlMTKRTGBK6HbVZuvp8EXsM8o6AQHaCA14wTqkPQSsxhy55U7+xgRPd8xQJRXpo9NNaz3R9x2phZSKEElI32k8JOqopdC4mQRlTwm6/8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 12/30/24 11:53, Rik van Riel wrote: > With AMD TCE (translation cache extensions) only the intermediate mappings > that cover the address range zapped by INVLPG / INVLPGB get invalidated, > rather than all intermediate mappings getting zapped at every TLB invalidation. > > This can help reduce the TLB miss rate, by keeping more intermediate > mappings in the cache. > > From the AMD manual: > > Translation Cache Extension (TCE) Bit. Bit 15, read/write. Setting this bit > to 1 changes how the INVLPG, INVLPGB, and INVPCID instructions operate on > TLB entries. When this bit is 0, these instructions remove the target PTE > from the TLB as well as all upper-level table entries that are cached > in the TLB, whether or not they are associated with the target PTE. > When this bit is set, these instructions will remove the target PTE and > only those upper-level entries that lead to the target PTE in > the page table hierarchy, leaving unrelated upper-level entries intact. > > Signed-off-by: Rik van Riel > --- > arch/x86/kernel/cpu/amd.c | 8 ++++++++ > arch/x86/mm/tlb.c | 10 +++++++--- > 2 files changed, 15 insertions(+), 3 deletions(-) > > diff --git a/arch/x86/kernel/cpu/amd.c b/arch/x86/kernel/cpu/amd.c > index 226b8fc64bfc..4dc42705aaca 100644 > --- a/arch/x86/kernel/cpu/amd.c > +++ b/arch/x86/kernel/cpu/amd.c > @@ -1143,6 +1143,14 @@ static void cpu_detect_tlb_amd(struct cpuinfo_x86 *c) > > /* Max number of pages INVLPGB can invalidate in one shot */ > invlpgb_count_max = (edx & 0xffff) + 1; > + > + /* If supported, enable translation cache extensions (TCE) */ > + cpuid(0x80000001, &eax, &ebx, &ecx, &edx); > + if (ecx & BIT(17)) { Back to my comment from patch #4, you can put this under the cpu_feature_enabled() check and just set it. > + u64 msr = native_read_msr(MSR_EFER);; > + msr |= BIT(15); > + wrmsrl(MSR_EFER, msr); msr_set_bit() ? Thanks, Tom > + } > } > > static const struct cpu_dev amd_cpu_dev = { > diff --git a/arch/x86/mm/tlb.c b/arch/x86/mm/tlb.c > index 454a370494d3..585d0731ca9f 100644 > --- a/arch/x86/mm/tlb.c > +++ b/arch/x86/mm/tlb.c > @@ -477,7 +477,7 @@ static void broadcast_tlb_flush(struct flush_tlb_info *info) > if (info->stride_shift > PMD_SHIFT) > maxnr = 1; > > - if (info->end == TLB_FLUSH_ALL) { > + if (info->end == TLB_FLUSH_ALL || info->freed_tables) { > invlpgb_flush_single_pcid(kern_pcid(asid)); > /* Do any CPUs supporting INVLPGB need PTI? */ > if (static_cpu_has(X86_FEATURE_PTI)) > @@ -1110,7 +1110,7 @@ static void flush_tlb_func(void *info) > * > * The only question is whether to do a full or partial flush. > * > - * We do a partial flush if requested and two extra conditions > + * We do a partial flush if requested and three extra conditions > * are met: > * > * 1. f->new_tlb_gen == local_tlb_gen + 1. We have an invariant that > @@ -1137,10 +1137,14 @@ static void flush_tlb_func(void *info) > * date. By doing a full flush instead, we can increase > * local_tlb_gen all the way to mm_tlb_gen and we can probably > * avoid another flush in the very near future. > + * > + * 3. No page tables were freed. If page tables were freed, a full > + * flush ensures intermediate translations in the TLB get flushed. > */ > if (f->end != TLB_FLUSH_ALL && > f->new_tlb_gen == local_tlb_gen + 1 && > - f->new_tlb_gen == mm_tlb_gen) { > + f->new_tlb_gen == mm_tlb_gen && > + !f->freed_tables) { > /* Partial flush */ > unsigned long addr = f->start; >