From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C296EC77B7F for ; Fri, 27 Jun 2025 15:45:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 649C36B00B1; Fri, 27 Jun 2025 11:45:33 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 626A36B00B2; Fri, 27 Jun 2025 11:45:33 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 55DE36B00B3; Fri, 27 Jun 2025 11:45:33 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 491476B00B1 for ; Fri, 27 Jun 2025 11:45:33 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 9364E80138 for ; Fri, 27 Jun 2025 15:45:32 +0000 (UTC) X-FDA: 83601605304.30.F520912 Received: from out-179.mta1.migadu.com (out-179.mta1.migadu.com [95.215.58.179]) by imf06.hostedemail.com (Postfix) with ESMTP id A0908180003 for ; Fri, 27 Jun 2025 15:45:30 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=V+HDiJBX; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf06.hostedemail.com: domain of lance.yang@linux.dev designates 95.215.58.179 as permitted sender) smtp.mailfrom=lance.yang@linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1751039130; a=rsa-sha256; cv=none; b=PpaBkOouW/1a4utznTe+ye3HJBiZi77f6+0DtQp55FEDdWI0rBGz+ILRn6LUKYscMIOyAC j8PMO9rLq0tnk0Pn7lVL2kI/+hKWZlK8pSO4ajASq9iQ50UTJhklgzpts6NKoRL81qkvWT 060oMt7IMqP91mh57mOfb88ccuqw3TM= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=V+HDiJBX; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf06.hostedemail.com: domain of lance.yang@linux.dev designates 95.215.58.179 as permitted sender) smtp.mailfrom=lance.yang@linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1751039130; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ZRFpxZUqLbnyGQPCOgdy9ogKvNkTdMJpkHmLoXCE7sw=; b=gD1CsFFawes8x0zWr7oLIIzZxju3EkMqp6wS82aOUD05Vhd2TdxNbCnoZo5Aj3iZcMA5vS nZ/CI5be9iN0pj/kpYdSu0VvtemeHssm+gtTTcUQ7N40snRh9VdONyztjG9Kf/wN4rsafb aoA3Ij9GZPIa75HmfpDqoqLGF1sYjhI= Message-ID: <2cee98d1-bdaa-4252-a9a6-15b1bc864ba0@linux.dev> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1751039128; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ZRFpxZUqLbnyGQPCOgdy9ogKvNkTdMJpkHmLoXCE7sw=; b=V+HDiJBXLTL0WH1AkxHG9YhAVQhuDj2+GdXeZy0A5fCjCrZ9Z7OGImiy9nTZ5amX3VRIuJ hkZFSeOxy8ymkbygPQMSGBUhzV15J8fPCHd0aBJzbFN37uOfR4vsC9G6wfRzW+wlm49bZ1 ogp5jNl6yUrR6OwA8aeY4kj2SWoTM2I= Date: Fri, 27 Jun 2025 23:45:15 +0800 MIME-Version: 1.0 Subject: Re: [PATCH v1 3/4] mm: split folio_pte_batch() into folio_pte_batch() and folio_pte_batch_ext() Content-Language: en-US To: David Hildenbrand Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Andrew Morton , "Liam R. Howlett" , Lorenzo Stoakes , Vlastimil Babka , Jann Horn , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Zi Yan , Matthew Brost , Joshua Hahn , Rakie Kim , Byungchul Park , Gregory Price , Ying Huang , Alistair Popple , Pedro Falcato , Rik van Riel , Harry Yoo , Lance Yang References: <20250627115510.3273675-1-david@redhat.com> <20250627115510.3273675-4-david@redhat.com> <9eb26777-cdfd-49df-9e1f-e326454ab477@redhat.com> X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Lance Yang In-Reply-To: <9eb26777-cdfd-49df-9e1f-e326454ab477@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT X-Rspam-User: X-Rspamd-Queue-Id: A0908180003 X-Rspamd-Server: rspam10 X-Stat-Signature: nocscizs619rem7szyhku79kipubrxuk X-HE-Tag: 1751039130-877737 X-HE-Meta: U2FsdGVkX19It2uuvYh0iKy2+rs6/88Puf+/kWuhfh2B5hVVgy/QSj9kodRHUCE2ffjlpc/6cP/3XIY9ow1LH7e/7KE1HRz4LEdV0BDnjJq0QIsx6B+sQSrQlijSsrC0YUPuGTIk2wumTrPd0Xq6kc7/jQ6Rk0pfQfkkG2S374fETjtiwncLk0kUDE6L66DPWZC01IN7m4v8IbNMba0stZFSjPs42jYInEfcJUg4MW+RYWM5+8fIYpFc+IODVF2HU5lWvBNiNbBaPBUALCmErQ3QTK03yznPF9iniZwoSst99A4sPl2E+kF0u4It4WEMV3KZmcr26yVV4uGyqtz72hrAHUq+gulP6WJHIXvn5y6mp/Q+naLbrRvFi1IelNJTw1r2O56uLXZr55uaqViMMpJzSFibjPbFU1420EtIo9MZ3TTWReEbIMSsJGWP4+r4xt1KHMM2IvOILex7Y150GE3tIVK251kPBzYXFzWpytUNYcY06gexk9tkHjaCkq50+uFtnJIBrYvwEl5wVEZohqab0TO7QDhQyiLjNbdbhFwmhFkV1LBgWKiIRq1loHmCCiaoXdmu2E6UmfT99l5amujJQvfddSim5KH/7O1sEDNy/97nMjmjh3mH4WOe4B3+HXIAeKdD8BHvx1DR5HvYRUsS9G+NlR3dBX/KykVTw7pj5soe2O6ZAJPXdJiMd2NKDv64n10vqOiHdf+u0zNGRoXXHAgBEuVg6WR0dI3aJGw46AtKK5MhF/bHzDuDFfLQ5uqWFVSAiQjm1DWlB+s/9MN0BbE8ninpivjZbLbbIT38iSLS7ZhbQEuIBnCwNZDrgRRsn0x0M3tPjrJUr4SPFeW5HMIt3HfRIoziOnkr5HChXX2RkAMcX7gynrxXw9QGhT2qQLAqn4OMgRWe9AS9mBB7hmqEDwx676+Q7+EGZbXJK0LTaeISEr4i2zXvgOE/+FaBVSpCmo+qVccGsvE 5s2Ytf/E n2TJD1iggj1qn82A7IYaBxFt3B03OG+N1rlbFN6HVjTMNIDinHWtyRMePG+qIBmO6rGGsPZAkaL+PQPkRwo//xmBpk6LSvJx8EPZjm/vWaXOiHBdrEQYUSpUBNeX2dJmyUtMuo9FT8IX1bf6H1tBUXpgkUrnyS9ypKI3GdG3ruE7+KN7ry4tPO9qsJXjONPXAVHjOenyQhtC9ZI4fCbr8CAsglrdL+c04zuUY1gTp3zIMZPiVfuVDR8akytM/FN6jPDK1dupz8cyXoO73TUovuuCoRZZts7tMpvBoqg367L5uUFpJmdK9YkTUxTk55sGS5mKmG6Ik0Mm7he/BBkE+VyN5h/0aq/9KzK8Xp3b0eJgKzZSZ91s37jewBMw3/EkqxWhz X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2025/6/27 23:09, David Hildenbrand wrote: > On 27.06.25 16:19, Lance Yang wrote: >> On Fri, Jun 27, 2025 at 7:55 PM David Hildenbrand >> wrote: >>> >>> Many users (including upcoming ones) don't really need the flags etc, >>> and can live with a function call. >>> >>> So let's provide a basic, non-inlined folio_pte_batch(). >>> >>> In zap_present_ptes(), where we care about performance, the compiler >>> already seem to generate a call to a common inlined folio_pte_batch() >>> variant, shared with fork() code. So calling the new non-inlined variant >>> should not make a difference. >> >> It's always an interesting dance with the compiler when it comes to >> inlining, >> isn't it? We want the speed of 'inline' for critical paths, but also a >> compact >> binary for the common case ... >> >> This split is a nice solution to the classic 'inline' vs. code size >> dilemma ;p > > Yeah, in particular when we primarily care about optimizing out all the > unnecessary checks inside the function, not necessarily also inlining > the function call itself. > > If we ever realize we absolute must inline it into a caller, we could > turn folio_pte_batch_ext() into an "__always_inline", but for now it > does not seem like this is really required from my experiments. Right, that makes sense. No need to force "__always_inline" prematurely.