From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1AEC5C4345F for ; Wed, 24 Apr 2024 14:57:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7C0BF6B0271; Wed, 24 Apr 2024 10:57:23 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 770436B0272; Wed, 24 Apr 2024 10:57:23 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5EA526B0273; Wed, 24 Apr 2024 10:57:23 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 3F1A66B0271 for ; Wed, 24 Apr 2024 10:57:23 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id D8B07141099 for ; Wed, 24 Apr 2024 14:57:22 +0000 (UTC) X-FDA: 82044728724.11.52E6AD8 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf14.hostedemail.com (Postfix) with ESMTP id 7E636100015 for ; Wed, 24 Apr 2024 14:57:20 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=hDXVyX2v; spf=pass (imf14.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1713970640; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=FwvRffhX7cIiMUi51z+c8e8+dpJMfLyG8ODI+g3OF6I=; b=4EsNA/ZcwNAh75xXCQ+M8PPcly4l7X3KLCaHIN6yIkv/qS4lefjl4LBu6mLbzywe4wPpNG GQFcq9pYWfvADkoGm8fx8Dj4XLEnabpj0coPmK9ElPW2JlqVopTUvcfj32Uz+hc7Vq1pLx 6a6gG4baD8hkHwrMug70bBqGQoP1hAU= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1713970640; a=rsa-sha256; cv=none; b=wSpWncaF85Me/JrkKgXX2bhpIItP/fS9G32XN24WvhMN5dL3Hy8Ox3lJ90F/KFZ5X5z/VI UZbhZcGWDiUKMKjnR+hL4Fmu4yYURQitTLZjE1acCnk+6G1KJSMnr/nnZg7Zeq3GRAfHO7 tlzLsX/PiTbEA0PWwPlbAdalEL1FfpQ= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=hDXVyX2v; spf=pass (imf14.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1713970639; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=FwvRffhX7cIiMUi51z+c8e8+dpJMfLyG8ODI+g3OF6I=; b=hDXVyX2voZa0u+YpCu6+91zTV569JOTe2TDEkwqaORCLk+fxtS5IJWwVUjW7KI36suEswU CWgcFcuq8heJLpzqmGZ1tzuJkv0vegQIw2jwJRMZeuz4ad9DevOX4lLz6I7iytlbHVivm4 kkVsCXdne2WnQ4ZJQgsIBrGieuCgroY= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-279-zYB-t_VyM_WY-NiC-rymZA-1; Wed, 24 Apr 2024 10:57:18 -0400 X-MC-Unique: zYB-t_VyM_WY-NiC-rymZA-1 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-418f18458a0so37462825e9.0 for ; Wed, 24 Apr 2024 07:57:18 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713970637; x=1714575437; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=FwvRffhX7cIiMUi51z+c8e8+dpJMfLyG8ODI+g3OF6I=; b=ToUoFbZyAEUyroZP9Mxt6ICG23Z5rOOSTkHQeaCTVeyrp7LZ59AaudnFfLSn3vQ/xZ yu7Tfi7H/2vfZRIHxzR4xvFenA4xkGKao0detw8IY2R5tJmHOelDMkzCCAcOsxgfjP1U u1Q+ClK3aSdfUuQ067rcOqFZLdVfUPc8d/26NMcwE/1M+aGfmEdYAXjz+wWc2qobJEKW KEl9XqqafnXsOpDDATtEYMSQMQ8nduS8A6jUvi/NWHQ+hMYwY9ET5zSJ2i76hHUqxJRz /gyx59cszMhb2uUifCBkNFV2pq7juGfYj9NNLZLe2XEThnrgaXvepHoComYLbppRGFqB p+BA== X-Forwarded-Encrypted: i=1; AJvYcCUZwi6opWCWdtKVP+jIdNkhw11AxTXrSAhz7PrxW03mqzkoZyS9v8VDehR17Wj8SEESR8JEUXpnX4R4czUVH38womY= X-Gm-Message-State: AOJu0YwKXhSADFnSdTBJ4bre+Nw7fCEiC0OG7A2m4vjNyqFWjv5cmc8f +UrGhaz29HI+Lson+lc+lYFpFQc2M5UarYgpe7OrYr1Z3Kn6gIoL/uxjBTeWxM8ozPrzzi/+jRy 8A5ux3qBLo+Of/wE5oXZJ/RanepqIGH5TiRydANuC17Sc2LQD X-Received: by 2002:a05:600c:354f:b0:419:87ab:f6db with SMTP id i15-20020a05600c354f00b0041987abf6dbmr2091680wmq.23.1713970637129; Wed, 24 Apr 2024 07:57:17 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEWW1eEozMy5F0A8wpsbFIIfH0pblKP/u7v1VAPX/H3wYT68IdLTp9PLGdDLSKcqF88LjmG3w== X-Received: by 2002:a05:600c:354f:b0:419:87ab:f6db with SMTP id i15-20020a05600c354f00b0041987abf6dbmr2091665wmq.23.1713970636678; Wed, 24 Apr 2024 07:57:16 -0700 (PDT) Received: from ?IPV6:2003:cb:c70d:1f00:7a4e:8f21:98db:baef? (p200300cbc70d1f007a4e8f2198dbbaef.dip0.t-ipconnect.de. [2003:cb:c70d:1f00:7a4e:8f21:98db:baef]) by smtp.gmail.com with ESMTPSA id k29-20020a05600c1c9d00b00418948a5eb0sm28023496wms.32.2024.04.24.07.57.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 24 Apr 2024 07:57:15 -0700 (PDT) Message-ID: <2ce7e0cd-3023-4f4c-bb4b-992b5c667294@redhat.com> Date: Wed, 24 Apr 2024 16:57:14 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm: add more readable thp_vma_allowable_order_foo() To: Kefeng Wang , Andrew Morton Cc: Ryan Roberts , linux-mm@kvack.org References: <20240424140715.5838-1-wangkefeng.wang@huawei.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20240424140715.5838-1-wangkefeng.wang@huawei.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: d96pe5drzt8bssew7uzsnwaz7c4cgahd X-Rspamd-Queue-Id: 7E636100015 X-Rspamd-Server: rspam06 X-Rspam-User: X-HE-Tag: 1713970640-492864 X-HE-Meta: U2FsdGVkX19Bn3P6a5s89Rk8g3248cfsj4JxR584DMz3ZUkHrhyjDB5pyyl/kBUAaTpzMTEbyfw7PSaXRO2IvtOSKZYIBQlbBy6KWluacI9YCUOCp/uh0JEtx9T5SAUT3ha3rO2AfcyHT1N1hFDYJkTCSJPA5fogWCojZTEWps8zGNRJh4ewFLnt/zCsSgjDChOPl1hZQFmPzzIx7OGcZ2dXZNNii0pf/s3HsugtQKhWBqasqh43PzICRQFY/EW0v5d3qdnfVBBOmcfASUS3zR1M67rIo3XCWr2qPIr2EkOY+pTxFOeiNeRVxjNYCbMqhqGcUhjqyxLm04rDtRz7m6IZU4cms9v5QO+lEtf1PG5QNZPAn0I5F4rCnQVTXEQVS22gat352MhIwlHLzJW9vUag60IS1YzXdDRwrYSAVD9E1pQUXyxuZFMIgr35H1UloQxG0cqNymya7hvr/ufx2el/oK7OR29JWAKAnPonzqqLmg6+dsef1e8JZstRgbEcPfiMP9TH/4XdEfNfNkEymx+zoE24IReumAm64i6TMCcSjTd+Hnu1izLLauG4VQVrdUYhTKi73Q3Sac8kEIvXrPuryxkhJBKC/I56fWbLfCLCvoObAXAsUuBqqZb7qSQIydbtn40JyXjSgMxA7S/r87SY1erkaC88KQ65zlUCc/vWbEOneztp0ceiVSgL/1JnmLE720yCwjqnKSNxGB1+fVX9UW7ix9lByskgQgWH66u99QjEnV845lDR6dzpQ/RWXU+KaBw043iO4jpFjDgqyG20K4KxTFjW3/peZCKUW3rVNg72VZU/kx4E4VAPhjsPYf1MRd2bfqKCCQBqiM0CwmNHd8fdFycQIOradtZKdzulkzzKZp69OK+Bwf36+87d2OZWDrhdJnlvXrL1eIk3G2tCzo5gxKFFQyWK2GzleTTDyr0ImNSTKQGCUeXBkSFAZsFIMnMS1xjNLxhyzZV TuT+ny6s Doxa6EL06Rgfetby3RIJQABwApSEzUtKsy0z7EMc4Lrf9rQmCKYUzoNOFDz1F9t4SOp5FB11lgvTcdS+d6pf0+WUCLFJtfccnPLeUPSa3+vQkkznWIJWUfW2I/t1vJ9Z+wjS/ozKHyV4B0wAN1fsloXeV/Hyey7YfIcuVJ30CAcYwLLJARdh2BtXyGbSr+A9ZpTLfnG/Epy3RpORCmwmalOsBKLYhzxrt10s69TYqsvWT2XO01ZaXBB1OyhboFkNz8X1ZTtOiYS3/au4fE/Ik0DZ+jMQLWCvBkX7sOwDJuRD+JtyaPEgaaLtNKuccoeTEUxtQu5vTkkAFcX2AMBPm0lT/K249wRd41Uh0EoFkiqUnXCBTJi/u1DHVtiyreZyxNsZhkmV6U+EmFfHvRC9Gie4C1dYfivnwXc57S3ZRUVVuMysKypU3nUPr18Pw/+iaQR7QMBVbQNzkrA+fmtZ23M62gw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 24.04.24 16:07, Kefeng Wang wrote: > There are too many bool arguments in thp_vma_allowable_orders(), adding > some more readable thp_vma_allowable_order_foo(), Good, I had something similar in mind when talking about that with Ryan in the past (during mTHP development). > > thp_vma_allowable_orders_insmaps() is used in samps > thp_vma_allowable_order[s]_inpf() is used in page fault > thp_vma_allowable_pmd_order_inhuge is used in khugepaged scan and madvise I really don't like the "_in" stuff. And "inhuge" doesn't add any clarity. What about thp_vma_allowable_orders_smaps() thp_vma_allowable_order[s]_pf() thp_vma_allowable_pmd_order() -- Cheers, David / dhildenb