From: David Hildenbrand <david@redhat.com>
To: Kefeng Wang <wangkefeng.wang@huawei.com>,
Andrew Morton <akpm@linux-foundation.org>
Cc: Ryan Roberts <ryan.roberts@arm.com>, linux-mm@kvack.org
Subject: Re: [PATCH] mm: add more readable thp_vma_allowable_order_foo()
Date: Wed, 24 Apr 2024 16:57:14 +0200 [thread overview]
Message-ID: <2ce7e0cd-3023-4f4c-bb4b-992b5c667294@redhat.com> (raw)
In-Reply-To: <20240424140715.5838-1-wangkefeng.wang@huawei.com>
On 24.04.24 16:07, Kefeng Wang wrote:
> There are too many bool arguments in thp_vma_allowable_orders(), adding
> some more readable thp_vma_allowable_order_foo(),
Good, I had something similar in mind when talking about that with Ryan
in the past (during mTHP development).
>
> thp_vma_allowable_orders_insmaps() is used in samps
> thp_vma_allowable_order[s]_inpf() is used in page fault
> thp_vma_allowable_pmd_order_inhuge is used in khugepaged scan and madvise
I really don't like the "_in" stuff. And "inhuge" doesn't add any clarity.
What about
thp_vma_allowable_orders_smaps()
thp_vma_allowable_order[s]_pf()
thp_vma_allowable_pmd_order()
--
Cheers,
David / dhildenb
prev parent reply other threads:[~2024-04-24 14:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-24 14:07 Kefeng Wang
2024-04-24 14:05 ` Ryan Roberts
2024-04-24 14:11 ` Kefeng Wang
2024-04-24 14:58 ` David Hildenbrand
2024-04-25 1:09 ` Kefeng Wang
2024-04-24 14:57 ` David Hildenbrand [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2ce7e0cd-3023-4f4c-bb4b-992b5c667294@redhat.com \
--to=david@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=linux-mm@kvack.org \
--cc=ryan.roberts@arm.com \
--cc=wangkefeng.wang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox