From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9D1A9E9D416 for ; Wed, 4 Feb 2026 16:56:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E40F16B00A3; Wed, 4 Feb 2026 11:56:57 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E15EE6B00A4; Wed, 4 Feb 2026 11:56:57 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CF7D36B00A5; Wed, 4 Feb 2026 11:56:57 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id BC1506B00A3 for ; Wed, 4 Feb 2026 11:56:57 -0500 (EST) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 501FB8A655 for ; Wed, 4 Feb 2026 16:56:57 +0000 (UTC) X-FDA: 84407378874.11.D82CD5E Received: from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31]) by imf25.hostedemail.com (Postfix) with ESMTP id 74B98A0004 for ; Wed, 4 Feb 2026 16:56:55 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=n3b6fFMj; spf=pass (imf25.hostedemail.com: domain of david@kernel.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=david@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1770224215; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Mtqz5z2jXD+lSd4GCM8VYMfuLy1xVR51LL6dr3yDN6c=; b=l/P5GWinV0BXRgbEMGyh7DkXPds6gjbModqRAn4MUMkl24pFt9iUgo8Cq0CPeaN9G0047M /If2HntCp2NGRhRsIwZM2Nnp/3tnDX19ZF8D8TTLFW78+a2flYmA7nfPnLcqvGY4oXL7si PF+bFoy/h8KVZug/UqYVJY/b08ceXm4= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=n3b6fFMj; spf=pass (imf25.hostedemail.com: domain of david@kernel.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=david@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1770224215; a=rsa-sha256; cv=none; b=Yzm3WuBTx7+HG1qMALdyzcfg3o9aPWLC+oKPTIOuSZOh2P8/yyEtyuF0+5c2pFE1ln6Sjc iFvPzLbISEhA3YaZbnZYkoXJLQdkUeTwAQHqRjJfHJwXhzZgVsb42rHFMjGwnjT3zk5FZM vAAj7L1cAXzhLAgKdrjFDb0wfHOfH9Y= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id 67CA4432E9; Wed, 4 Feb 2026 16:56:54 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9369AC4CEF7; Wed, 4 Feb 2026 16:56:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1770224214; bh=PdJwL2FfZcrZlGmwfIl75VdtZDNdmDKvW0Pqu/rV0mU=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=n3b6fFMj5xAka9Jh+F8qYvBKS4/lBho0sJ4vU7OzTxn6zTyTDuW4AH581/BU6NVbt POaPOLGC6z4LIY/GqI0emhIU2Icmf84HWLDkd8F9dX92Y4I5K1oi0iHTDmffqqNjvx PHy01L791lxZTaXw7Y5VnhB4pofkh6rxofpjA63xJwQEkD9lDd7625LUoA84ZfDUko TxXtZHx6ugQRzJGIQIRZ0RzEsTh0/kWjXByqXVBZ1/3HSpGyP91d9H4BGzE+R58At1 x3obFM3m0s8LCh4QU7gv0ANGJnJibag29UlUvdQXsu8OUQSqiELG/wU+4zMbhYP01B vLdAeSVEdOHwQ== Message-ID: <2ce0e684-de54-43ec-be7d-c58bbffb3f4e@kernel.org> Date: Wed, 4 Feb 2026 17:56:45 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCHv6 06/17] LoongArch/mm: Align vmemmap to maximal folio size To: Kiryl Shutsemau , Andrew Morton , Muchun Song , Matthew Wilcox , Usama Arif , Frank van der Linden Cc: Oscar Salvador , Mike Rapoport , Vlastimil Babka , Lorenzo Stoakes , Zi Yan , Baoquan He , Michal Hocko , Johannes Weiner , Jonathan Corbet , Huacai Chen , WANG Xuerui , Palmer Dabbelt , Paul Walmsley , Albert Ou , Alexandre Ghiti , kernel-team@meta.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, loongarch@lists.linux.dev, linux-riscv@lists.infradead.org References: <20260202155634.650837-1-kas@kernel.org> <20260202155634.650837-7-kas@kernel.org> From: "David Hildenbrand (arm)" Content-Language: en-US Autocrypt: addr=david@kernel.org; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzS5EYXZpZCBIaWxk ZW5icmFuZCAoQ3VycmVudCkgPGRhdmlkQGtlcm5lbC5vcmc+wsGQBBMBCAA6AhsDBQkmWAik AgsJBBUKCQgCFgICHgUCF4AWIQQb2cqtc1xMOkYN/MpN3hD3AP+DWgUCaYJt/AIZAQAKCRBN 3hD3AP+DWriiD/9BLGEKG+N8L2AXhikJg6YmXom9ytRwPqDgpHpVg2xdhopoWdMRXjzOrIKD g4LSnFaKneQD0hZhoArEeamG5tyo32xoRsPwkbpIzL0OKSZ8G6mVbFGpjmyDLQCAxteXCLXz ZI0VbsuJKelYnKcXWOIndOrNRvE5eoOfTt2XfBnAapxMYY2IsV+qaUXlO63GgfIOg8RBaj7x 3NxkI3rV0SHhI4GU9K6jCvGghxeS1QX6L/XI9mfAYaIwGy5B68kF26piAVYv/QZDEVIpo3t7 /fjSpxKT8plJH6rhhR0epy8dWRHk3qT5tk2P85twasdloWtkMZ7FsCJRKWscm1BLpsDn6EQ4 jeMHECiY9kGKKi8dQpv3FRyo2QApZ49NNDbwcR0ZndK0XFo15iH708H5Qja/8TuXCwnPWAcJ DQoNIDFyaxe26Rx3ZwUkRALa3iPcVjE0//TrQ4KnFf+lMBSrS33xDDBfevW9+Dk6IISmDH1R HFq2jpkN+FX/PE8eVhV68B2DsAPZ5rUwyCKUXPTJ/irrCCmAAb5Jpv11S7hUSpqtM/6oVESC 3z/7CzrVtRODzLtNgV4r5EI+wAv/3PgJLlMwgJM90Fb3CB2IgbxhjvmB1WNdvXACVydx55V7 LPPKodSTF29rlnQAf9HLgCphuuSrrPn5VQDaYZl4N/7zc2wcWM7BTQRVy5+RARAA59fefSDR 9nMGCb9LbMX+TFAoIQo/wgP5XPyzLYakO+94GrgfZjfhdaxPXMsl2+o8jhp/hlIzG56taNdt VZtPp3ih1AgbR8rHgXw1xwOpuAd5lE1qNd54ndHuADO9a9A0vPimIes78Hi1/yy+ZEEvRkHk /kDa6F3AtTc1m4rbbOk2fiKzzsE9YXweFjQvl9p+AMw6qd/iC4lUk9g0+FQXNdRs+o4o6Qvy iOQJfGQ4UcBuOy1IrkJrd8qq5jet1fcM2j4QvsW8CLDWZS1L7kZ5gT5EycMKxUWb8LuRjxzZ 3QY1aQH2kkzn6acigU3HLtgFyV1gBNV44ehjgvJpRY2cC8VhanTx0dZ9mj1YKIky5N+C0f21 zvntBqcxV0+3p8MrxRRcgEtDZNav+xAoT3G0W4SahAaUTWXpsZoOecwtxi74CyneQNPTDjNg azHmvpdBVEfj7k3p4dmJp5i0U66Onmf6mMFpArvBRSMOKU9DlAzMi4IvhiNWjKVaIE2Se9BY FdKVAJaZq85P2y20ZBd08ILnKcj7XKZkLU5FkoA0udEBvQ0f9QLNyyy3DZMCQWcwRuj1m73D sq8DEFBdZ5eEkj1dCyx+t/ga6x2rHyc8Sl86oK1tvAkwBNsfKou3v+jP/l14a7DGBvrmlYjO 59o3t6inu6H7pt7OL6u6BQj7DoMAEQEAAcLBfAQYAQgAJgIbDBYhBBvZyq1zXEw6Rg38yk3e EPcA/4NaBQJonNqrBQkmWAihAAoJEE3eEPcA/4NaKtMQALAJ8PzprBEXbXcEXwDKQu+P/vts IfUb1UNMfMV76BicGa5NCZnJNQASDP/+bFg6O3gx5NbhHHPeaWz/VxlOmYHokHodOvtL0WCC 8A5PEP8tOk6029Z+J+xUcMrJClNVFpzVvOpb1lCbhjwAV465Hy+NUSbbUiRxdzNQtLtgZzOV Zw7jxUCs4UUZLQTCuBpFgb15bBxYZ/BL9MbzxPxvfUQIPbnzQMcqtpUs21CMK2PdfCh5c4gS sDci6D5/ZIBw94UQWmGpM/O1ilGXde2ZzzGYl64glmccD8e87OnEgKnH3FbnJnT4iJchtSvx yJNi1+t0+qDti4m88+/9IuPqCKb6Stl+s2dnLtJNrjXBGJtsQG/sRpqsJz5x1/2nPJSRMsx9 5YfqbdrJSOFXDzZ8/r82HgQEtUvlSXNaXCa95ez0UkOG7+bDm2b3s0XahBQeLVCH0mw3RAQg r7xDAYKIrAwfHHmMTnBQDPJwVqxJjVNr7yBic4yfzVWGCGNE4DnOW0vcIeoyhy9vnIa3w1uZ 3iyY2Nsd7JxfKu1PRhCGwXzRw5TlfEsoRI7V9A8isUCoqE2Dzh3FvYHVeX4Us+bRL/oqareJ CIFqgYMyvHj7Q06kTKmauOe4Nf0l0qEkIuIzfoLJ3qr5UyXc2hLtWyT9Ir+lYlX9efqh7mOY qIws/H2t In-Reply-To: <20260202155634.650837-7-kas@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 74B98A0004 X-Stat-Signature: eo71cuw9yp5qjq6u1wcn8q1bwyz3ewap X-Rspam-User: X-HE-Tag: 1770224215-856528 X-HE-Meta: U2FsdGVkX19tHa9BdExDDXOuAA1/iBjlG/Zn617c2zbhBP4JsgRxjBePKRUKiqmNjQOWcFNCLoXjD++GdcwlH7B4nvXMs1lcBqrjTaZJ5lZ3Y8/e1WYSJwfe1JZcyUYmQiyMTBA0KQaC9fBJdBbVkCyJPVfj+4/90ABW+5HlHzEFsdWjbZtSeLnGkb/W+lAtBvA8cayaD+m5CT78BOOEzlSajqIiIi14uEmZFaKoQbc3B90+iYhi9hDS/3EFfN2PBQV7EAlLghtcx5xr8+Paqz7WCntnn2C/bQKFoA/mx10wzLnGiDQwVsaVx9uf3uwFT+Pwo0CqrvUsssI3+0l/Nq0KAHd+SejRMbkIKyffkv4pbh9DoZ7KGUkryEnwSWUsQY8rlw9N68ylxICQQwGR2kvB5ll9IqnFfu9TPF9U7M/fZFwAg2jBTxhtzCxyA5cE7/4BsYcK5Rg+6XSNgyMHG4RUdPNfv7rmnYMWlNEqJRL5gFAKwPSxdktxlh0VNPbkyb03pbXOPX9FafiIiFjt0gjcgCcFYbQG3gxiRzdTeXV+F67w14ROVaU3HxdAFozWcrCTAiV1xznmaPxCyCY/rqKjFePJxA0Eau2pPOEJWE5Ey6Y97wWhEEruViTpZkGrT/g3nwMx6fN2HPzDtBy+HiWy5fJWrrxj7IG4VGR3TbNHEf1dtxNhJXpYGsosNQs3CIF/TORopoKMlBeY3PTMPvssSRjJBAJu+rqxeOI4Cdvx+ROcfAD8BDzSVJMDlFo36+N9BKGrgFC5yPTtvcx9+N0ID5zPWdwJ54h/v3tlwpVq66H9EhAuYJhsPisTQRKPEgt4cQMw81XwedToKry7Mj2EkQoM1TFsFF/NEjYIqOxw2U94BZKd9azUUPyqCcQuyF5wCw1oe+6ocMAs11dAt+htjzBGiMPnk0NGjDOG51Vku/TMLwYx9THErVHuFgGO7XstxZnnm0bj5W22+Ta I9FMTXJG KZl5jI1y4Rw+aPAlgEytQwvZBrJVtzWJkQRCBeaAYtLNL/HWFGlTgsFh3J/fegI2IJE0DKqtVu04ZXe/G2l6gDk7G92A4sIpobWBcO7c0jYTAnw0iZUt7H92PAkXLszbq7mcY1lqcUKMsnRCPkn+/fV7KN4r8qogmVsAsPBLoAFfgX7Wi6dIq2Dv1evNAVc4kUOkjA0iSTvFUIHvwLfWuNRy8f2Eea36ER3aHndVZV89QUs2w16+RBakofocnYLLjz4u2yvZxsKfBLDc8xNtCKIO7w99/qVf9+bt9 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2/2/26 16:56, Kiryl Shutsemau wrote: > The upcoming change to the HugeTLB vmemmap optimization (HVO) requires > struct pages of the head page to be naturally aligned with regard to the > folio size. > > Align vmemmap to MAX_FOLIO_NR_PAGES. > > Signed-off-by: Kiryl Shutsemau > --- > arch/loongarch/include/asm/pgtable.h | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/arch/loongarch/include/asm/pgtable.h b/arch/loongarch/include/asm/pgtable.h > index c33b3bcb733e..f9416acb9156 100644 > --- a/arch/loongarch/include/asm/pgtable.h > +++ b/arch/loongarch/include/asm/pgtable.h > @@ -113,7 +113,8 @@ extern unsigned long empty_zero_page[PAGE_SIZE / sizeof(unsigned long)]; > min(PTRS_PER_PGD * PTRS_PER_PUD * PTRS_PER_PMD * PTRS_PER_PTE * PAGE_SIZE, (1UL << cpu_vabits) / 2) - PMD_SIZE - VMEMMAP_SIZE - KFENCE_AREA_SIZE) > #endif > > -#define vmemmap ((struct page *)((VMALLOC_END + PMD_SIZE) & PMD_MASK)) > +#define VMEMMAP_ALIGN max(PMD_SIZE, MAX_FOLIO_NR_PAGES * sizeof(struct page)) > +#define vmemmap ((struct page *)(ALIGN(VMALLOC_END, VMEMMAP_ALIGN))) Same comment, the "MAX_FOLIO_NR_PAGES * sizeof(struct page)" is just black magic here and the description of the situation is wrong. Maybe you want to pull the magic "MAX_FOLIO_NR_PAGES * sizeof(struct page)" into the core and call it #define MAX_FOLIO_VMEMMAP_ALIGN (MAX_FOLIO_NR_PAGES * sizeof(struct page)) But then special case it base on (a) HVO being configured in an (b) HVO being possible #ifdef HUGETLB_PAGE_OPTIMIZE_VMEMMAP && is_power_of_2(sizeof(struct page) /* A very helpful comment explaining the situation. */ #define MAX_FOLIO_VMEMMAP_ALIGN (MAX_FOLIO_NR_PAGES * sizeof(struct page)) #else #define MAX_FOLIO_VMEMMAP_ALIGN 0 #endif Something like that. -- Cheers, David