From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 565C1C3DA4A for ; Fri, 9 Aug 2024 15:29:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id ACA5D6B008C; Fri, 9 Aug 2024 11:29:29 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A7A256B0092; Fri, 9 Aug 2024 11:29:29 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8CC706B0095; Fri, 9 Aug 2024 11:29:29 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 6D7776B008C for ; Fri, 9 Aug 2024 11:29:29 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 3AA53A11C1 for ; Fri, 9 Aug 2024 15:29:29 +0000 (UTC) X-FDA: 82433091258.24.B367077 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf27.hostedemail.com (Postfix) with ESMTP id EC8CD40007 for ; Fri, 9 Aug 2024 15:29:25 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=WM8s0Apg; spf=pass (imf27.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1723217314; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=IkaFtYOglx3SERuq0AG1B8o+eSlXUn20hFBeWUD5Y4o=; b=bXPUv3SM5rvWwYzdF/VJIBbiyE52MlW3khIAhFoAdymeIF1dQD2O3c39PGMNB7JYPfFNz0 IOQWY1InHAi0Iv1OfuBaqdcaSFT80+LNfOI8gWP6GhSKnf/ZJdjajs4S1+mJxZbq2jdpvc ivKCcSpKfro0xa3qWUSQ5L5hZeP8bCo= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=WM8s0Apg; spf=pass (imf27.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1723217314; a=rsa-sha256; cv=none; b=aSFH5ykBjzVtouH9b+IdoRyEkJF4NzIybjmyxkUt5Krl4HZT1AAo3lkEYywXL1OHQVoTUk l/GzPH+zuFAWbtwzmm3Rbw6o+DRlj70++iyz7g8t/mcBnDbZVW98oz62gmXe7+/TUKa8OE zqfab2jAGBl9GB+o20Jt4h5fxbPGRXQ= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1723217365; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=IkaFtYOglx3SERuq0AG1B8o+eSlXUn20hFBeWUD5Y4o=; b=WM8s0Apg+nptOhMneZfSAjBrCEw2aPcqy2n02Tc4ONG/fC2CkCrxI50r7b6ckD/P8bbMcc 9gxdzm2hUXmXbKYYvyOfDhdl3zgDdf4vaP/fnG/pO4CDbZGO/oWpyhPvxY/UeWTLJzjeu0 mHvJi0U0jO2MwmCFAhBQXMO1Ba4fRtQ= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-42-Ew1JzfNSPJC80NSduTD1CQ-1; Fri, 09 Aug 2024 11:29:23 -0400 X-MC-Unique: Ew1JzfNSPJC80NSduTD1CQ-1 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-428076fef5dso15392195e9.2 for ; Fri, 09 Aug 2024 08:29:23 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723217362; x=1723822162; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=IkaFtYOglx3SERuq0AG1B8o+eSlXUn20hFBeWUD5Y4o=; b=vlGjd99pfCeWklC6nvL7zv0/64kQfPL7NEY3KHVcmo/fP7Lu9QpXbwgWi2XM+foZrA wfGqZSfskpnMU4KmUYOTDcKIo6GqDPDroFp0sNuEsqtSNsED9ySZT3xIfw5/OvueBvqf AblXbZ9H237BY7UX1xOjbXRT7DMBYRjJ4I0o2XSX9Dzoyv/Fhf9UBDDT+7SQ84NnwqBF c0xBMABAW3Xi2ZDuqB10wDLu0MjV9e0/gypDVS4bAGn2dufMDm2dES1iHjwUmNmlRZ+8 OqlLRNf6QjuxVZX7ZFc6Ou2TQ/qkbGJjN2hlVuPqDNyQf9nhr4rX/p79G5WSZcvBkGVU hVtw== X-Forwarded-Encrypted: i=1; AJvYcCU4uXrRxXvxVkn7Rrlr3a+1IjshubtWlv2EbE+vrOGtHxyYNXYYZ/MgQnjQqa0FKIA4DpuHAWPodZ5R4rfzvTyYpPc= X-Gm-Message-State: AOJu0YwnPFsqKoo4wY7tbVHeE01NTPVYKBtD2UTrh8CZrkHJwM6+KBR0 jlNZScLqICxT8VQgVxFQuztOwFszPZUCUP6iFCG8NAxq2gXcwZI9hg415KhaLKAgIzg/3e+YXmz 67AtVCCMnmpSfjxBLJxhI4mNfLu0aPr6CV11TKmKM6ioNUZZA X-Received: by 2002:a05:600c:46ce:b0:426:5ddf:fd22 with SMTP id 5b1f17b1804b1-429c3a17f1bmr13036415e9.6.1723217362434; Fri, 09 Aug 2024 08:29:22 -0700 (PDT) X-Google-Smtp-Source: AGHT+IE9g/HImcMSBHo0q13rPpw/b1gOqisdmkCTPdK/rjlFupPIN6Eqj9sBoWS7cZ0WsvzucC7hMw== X-Received: by 2002:a05:600c:46ce:b0:426:5ddf:fd22 with SMTP id 5b1f17b1804b1-429c3a17f1bmr13036185e9.6.1723217361886; Fri, 09 Aug 2024 08:29:21 -0700 (PDT) Received: from ?IPV6:2003:d8:2f09:3f00:d228:bd67:7baa:d604? (p200300d82f093f00d228bd677baad604.dip0.t-ipconnect.de. [2003:d8:2f09:3f00:d228:bd67:7baa:d604]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-429059713adsm133237355e9.11.2024.08.09.08.29.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 09 Aug 2024 08:29:21 -0700 (PDT) Message-ID: <2cdc6d9a-0855-4209-9745-0ae15c4498a8@redhat.com> Date: Fri, 9 Aug 2024 17:29:20 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 1/3] mm/numa: no task_numa_fault() call if PTE is changed To: Zi Yan , linux-mm@kvack.org Cc: Andrew Morton , "Huang, Ying" , Baolin Wang , Kefeng Wang , Yang Shi , Mel Gorman , linux-kernel@vger.kernel.org, stable@vger.kernel.org References: <20240809145906.1513458-1-ziy@nvidia.com> <20240809145906.1513458-2-ziy@nvidia.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20240809145906.1513458-2-ziy@nvidia.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: 71xoyfd9hfg7i1d78nfbhna16suhm5f8 X-Rspam-User: X-Rspamd-Queue-Id: EC8CD40007 X-Rspamd-Server: rspam02 X-HE-Tag: 1723217365-948167 X-HE-Meta: U2FsdGVkX1+XiM5alRy4cb+9iCjnsw3riVGO4ML/kxmAZ4Wro6KRXMAl/i4u/6uqxPIUCMCdM0u4aUQx5WORTJsXZas7CW6PyPX+629OUqq6tuRp8cEMPwPRDk+DKsMWL7bwkXHB8PyMFkVZjA+8xHt2Dj+p+fa1FUXEE9YD36ZRUWTZvAVtdud+GeI9DN6zsUBq8ouRtMfG5gaqalRZg2xr4Pnvq6SlDLdHV1031LdDL1mO38uuF/a6KfXD+yoZPPQbQ2tTFPxOMJgr26M8jbhFlJFEKFS1lSziwoZZOUeN5fwd17YYEbLzmEY+QOPxPkUfpgZnMwewxFigWFb6cgXzudqFS0ovuZgogK5EUi0pddew3Po7Zc75BRziIVNuy0iM0upkUVER7tIhGKU9SCbApN7UbD5tq+3CkvgHsVu1IsKL+gwWRmYiGo9EX3nNNr0Jvx9v0UcZjbzMR840ClDLFcD6z/TIKvwhFYouUMzvPaotq081qUanRuffyCXYAoOA2hnkLAnBopnadyat40cCxfVOmTKu27kiMnpnhAJKrE5Tl09e2uvH1z1m9znfGfZL7u6N+yNM5hI3e891GPaIlLpXxckAE3aNV5undsSnxDmFHqDOwGJOnAp2b8fOl7WNqs2aLMrzWQ/9PfAFvVJ1OM3GJ0VIFYIVNsHH7uJI/htmCH6eEYVd27PWwcabohYlN03XKn8fy/Ym3KOUOLemKYamtGLrQWy7uvO3wTR/oWoWiv9S32LPjFpHUYgBJUGtmk+XCdu73qmY+AOkshGHyWjWIQDKqm1poW19Ihpva8Vya0HNK8/zJO/47nCRqN8l9+AidsMNFtByAhIrlXHmBhPLFoMei9Y6t7Gd1s8lZBvnCTrzbYBe9jAdLz7FGCipt21FRusLNVWR02fuOnJK8n1EWXlCTF0MIvgPZMqg11dO3ytk9/C2zFUVDKlyO6UD+Z+XsbXCuLWzPCd FoCea8SP 5dH1jOYWkW4Jgn9GeqBMmZsmpIveG521KsaHw+P5Rqjw5YI6tHrrdL2XnMvPbl1317yvwqqKGaWcGq5rn44+k9pr6YJT+4NHRFt3yLcjnsHqxruwQACy6kmN4LhlgizKGuH1ZpE8RNHq1R6SLKT7JVLtnNth9LQpO4bQe9e8Z/ABsY/FBwdS1oEfWuXxOJ0ZiLnZirqTMUQrPs5l4PPGpgpZwM/7eyPTZpjU6OF4471qCPiezAqpP2278z60u53l4PuuKdTmBm3Ig738su17+zfPruHtm8infB8HL6BV5h+K9bqGrsiS9bL0qq5Xpq3kFNbT3N/5NkLx+UWm35gp1CTLaejRs0fNELIGpTfi5TESi8+C+KvVKCD7RG6IKK+7gIJKv05qBX9DsN5lmX40q7OSJjsxUByAdvvCh1eyXwXi0cYErP9mdIm6WoL0DU49kSnQE3Gkrecb7aOnZN8jOSXvP190aWYFq6g9eLJfJpbcSYHwYqbIbovO8MJrHdYlnAig3fjzAKPuuReLHqH/BozkaJDiFwwkhUk6L3bylZoyF2P0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 09.08.24 16:59, Zi Yan wrote: > When handling a numa page fault, task_numa_fault() should be called by a > process that restores the page table of the faulted folio to avoid > duplicated stats counting. Commit b99a342d4f11 ("NUMA balancing: reduce > TLB flush via delaying mapping on hint page fault") restructured > do_numa_page() and did not avoid task_numa_fault() call in the second page > table check after a numa migration failure. Fix it by making all > !pte_same() return immediately. > > This issue can cause task_numa_fault() being called more than necessary > and lead to unexpected numa balancing results (It is hard to tell whether > the issue will cause positive or negative performance impact due to > duplicated numa fault counting). > > Reported-by: "Huang, Ying" > Closes: https://lore.kernel.org/linux-mm/87zfqfw0yw.fsf@yhuang6-desk2.ccr.corp.intel.com/ > Fixes: b99a342d4f11 ("NUMA balancing: reduce TLB flush via delaying mapping on hint page fault") > Cc: > Signed-off-by: Zi Yan > --- Acked-by: David Hildenbrand -- Cheers, David / dhildenb