From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5D3A8C021B1 for ; Thu, 20 Feb 2025 11:58:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E51B82802D8; Thu, 20 Feb 2025 06:58:42 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id DD8162802D7; Thu, 20 Feb 2025 06:58:42 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C51A82802D8; Thu, 20 Feb 2025 06:58:42 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id A9C252802D7 for ; Thu, 20 Feb 2025 06:58:42 -0500 (EST) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id CC0881C9142 for ; Thu, 20 Feb 2025 11:58:30 +0000 (UTC) X-FDA: 83140175622.16.6C5AFE4 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf06.hostedemail.com (Postfix) with ESMTP id 47F63180007 for ; Thu, 20 Feb 2025 11:58:28 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=JhJ50tEV; spf=pass (imf06.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740052708; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ChTPBy8eMOaAQYN+xSwJ0JGUBOJ/6/tYrgg1c9NkG+M=; b=qlRxogwnQMJdEQnuULbnbCfL00auqgRFbqKSBJajWeLBdUYpAVmgMr64eUTZ0LiDuOcCL+ ZpzW+SDbw2XJyOR7yXrOf8c+t17fSju20MxdrXxp/r3AkodPcAw8pPqt7J5UEi6QozXDRN +ePp2EFo16iocXf9KW0TQv9xXfE9UpQ= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=JhJ50tEV; spf=pass (imf06.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740052708; a=rsa-sha256; cv=none; b=UVmnud9W3ezd8I6zKKFgBZBrUWcPa0CmlYVtF8+fnvayebqH7GLH560oFgExaRXSESHaUJ P4UGcnuTVB1ZLOYUVh4pblu6+BouumW73aYUREbSAnJNa5oOmpNEbGiA+4KXwYN1xFM/pW 7oEgB4kooqfFD0f479sSlPC3aSbtr8w= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1740052707; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=ChTPBy8eMOaAQYN+xSwJ0JGUBOJ/6/tYrgg1c9NkG+M=; b=JhJ50tEVMfmN4nIbjI/S+jKKHxlKZA5mzMSGa2EzSpKGRWdrWspnwsaQ0CMqiAaFpTglVc k4eRSCXPBR5O/YsHVenX1Nd63SAHEqPEfgEhAoTFgIyag75ef74pShoADoBd/RPOJVLEbm myf2apC5raTCoFM54vEgqmww23GO/Iw= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-464-pIAbSxQqP0GfiqkgJ6kNdQ-1; Thu, 20 Feb 2025 06:58:26 -0500 X-MC-Unique: pIAbSxQqP0GfiqkgJ6kNdQ-1 X-Mimecast-MFC-AGG-ID: pIAbSxQqP0GfiqkgJ6kNdQ_1740052705 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-38f455a8fcaso569833f8f.2 for ; Thu, 20 Feb 2025 03:58:26 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740052705; x=1740657505; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=ChTPBy8eMOaAQYN+xSwJ0JGUBOJ/6/tYrgg1c9NkG+M=; b=MWO7tpXOHl6Pk8YmnJxmFYIvvLxtPdlzsmISC3oGXAa6o3Uid1pD++f/UOCjRLKRam Sdn6wwTmSSGBbuMEoMdS73RuNqIAxUNojl70ImuweaecczAPOOmmPc9coLl7DCcQY4PT fqsqkqFnf14gWzJ6FMYUQfoc3nRzHU5dmkVyitwqpU7Nvi8RwPeh6CMDfTsycQqbqr8/ UgQInlGtCDJsh7cu+YPJfl6m8YJXDxeLUn2L5Raayq+Nb8AN18FKF8C9fevUaeZcspzs yl4IfXNowPicxI8Q4DmII3Grnka6NEcsEBu6guitmHSjx9Pnlyq6BR17OBWpBumwuZYV UfeQ== X-Forwarded-Encrypted: i=1; AJvYcCWhORHeiWnOl0EYdWftg/wCDAHEb0hS3AY6m86/Mqzw3qGQMszgd5SflGRqRG7y5DAuK9oyRiwoiQ==@kvack.org X-Gm-Message-State: AOJu0Yxy1tjD0wWsbCETJw52JLeBuQOOkA7ZRqPqs2CmVItWPGTlASsC uga8BMzv3fAlTCto6k9hbByghh94bFE08g5Gu/ZY3mkOdj0wKVFR3KvMY4jH1Cv8J2GyIo5txt2 pi/Q1tE5y1Je0Zxx99FEUxEwTZjMp9U3pypo7U4tenIbfNCzRj2Uo7xLvn/g= X-Gm-Gg: ASbGncupGhLvUtAHHf9kdFkZ6EjUZ3uam90QMWdHHz+SPZxJ7lih0y+SmclLfbz4m6j 6LPpclJXnKENFjp9qLry422XIN2MrHL575uDTuH7DGjbpHJWgNCp5clzoRU6ycAlhafEPmmBZOb NZNayp5LVpq0pGPHeuJP/bZqfb5Xn6haq/0hrAxYhsLniGDKRoHNIk49e3NWJAnbB8uCiIB8j6u wphR4f0wx0d+M4jt8mUPXOIWxtBl1uttbAdUvj5A6F0jE3eg+JthQ56UM8ITQNC+4N/nbhm3VUf cGnZli/2lYkq9bXDrLBBlePfdWEOgpvz9ECdCiiTsKs1lUNiL0jnkG/HrxbMWQTjIqXm22uPYkP kbFx8QEHr9tOup744nSY94KoBoLk18g== X-Received: by 2002:a5d:6911:0:b0:38c:5cd0:ecd5 with SMTP id ffacd0b85a97d-38f587ca6aemr5426546f8f.38.1740052705175; Thu, 20 Feb 2025 03:58:25 -0800 (PST) X-Google-Smtp-Source: AGHT+IGfrC4AzDMY6jq/M+etgB2APRc/+SNG9GYHcPm4Xm3x4ed/XwE26HMx8TXBImXaH2qQnvfBrA== X-Received: by 2002:a5d:6911:0:b0:38c:5cd0:ecd5 with SMTP id ffacd0b85a97d-38f587ca6aemr5426515f8f.38.1740052704750; Thu, 20 Feb 2025 03:58:24 -0800 (PST) Received: from ?IPV6:2003:cb:c706:2000:e44c:bc46:d8d3:be5? (p200300cbc7062000e44cbc46d8d30be5.dip0.t-ipconnect.de. [2003:cb:c706:2000:e44c:bc46:d8d3:be5]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43986320899sm109955095e9.38.2025.02.20.03.58.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 20 Feb 2025 03:58:24 -0800 (PST) Message-ID: <2cdc5414-a280-4c47-86d5-4261a12deab6@redhat.com> Date: Thu, 20 Feb 2025 12:58:20 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 03/10] KVM: guest_memfd: Allow host to map guest_memfd() pages To: Fuad Tabba , kvm@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-mm@kvack.org Cc: pbonzini@redhat.com, chenhuacai@kernel.org, mpe@ellerman.id.au, anup@brainfault.org, paul.walmsley@sifive.com, palmer@dabbelt.com, aou@eecs.berkeley.edu, seanjc@google.com, viro@zeniv.linux.org.uk, brauner@kernel.org, willy@infradead.org, akpm@linux-foundation.org, xiaoyao.li@intel.com, yilun.xu@intel.com, chao.p.peng@linux.intel.com, jarkko@kernel.org, amoorthy@google.com, dmatlack@google.com, isaku.yamahata@intel.com, mic@digikod.net, vbabka@suse.cz, vannapurve@google.com, ackerleytng@google.com, mail@maciej.szmigiero.name, michael.roth@amd.com, wei.w.wang@intel.com, liam.merwick@oracle.com, isaku.yamahata@gmail.com, kirill.shutemov@linux.intel.com, suzuki.poulose@arm.com, steven.price@arm.com, quic_eberman@quicinc.com, quic_mnalajal@quicinc.com, quic_tsoni@quicinc.com, quic_svaddagi@quicinc.com, quic_cvanscha@quicinc.com, quic_pderrin@quicinc.com, quic_pheragu@quicinc.com, catalin.marinas@arm.com, james.morse@arm.com, yuzenghui@huawei.com, oliver.upton@linux.dev, maz@kernel.org, will@kernel.org, qperret@google.com, keirf@google.com, roypat@amazon.co.uk, shuah@kernel.org, hch@infradead.org, jgg@nvidia.com, rientjes@google.com, jhubbard@nvidia.com, fvdl@google.com, hughd@google.com, jthoughton@google.com References: <20250218172500.807733-1-tabba@google.com> <20250218172500.807733-4-tabba@google.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20250218172500.807733-4-tabba@google.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: _GB9vo_rWqEfyBMxevwYkCOKwtw_dVh8vIFYm18E8qs_1740052705 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 47F63180007 X-Stat-Signature: bb9epexeojqde5gzxzezxsdpnq483nin X-HE-Tag: 1740052708-716567 X-HE-Meta: U2FsdGVkX1/YQAmxpdpv8oWwlNHscyuoJTLaFiEOstOeUUmmGJD4Vl9alp814zMXTRI/peLrAR1w6AaLPJb/7aFj+hmeAqVgrkDuICNR+K/eGEsnxK6sOVgbhrlTqhEx+Pw/ePRY58+qqkpusNLRLiQCNp52WOgDLQy2QB79hPDn8nNHrtfOUggSdnhoi/qwm+k5t7jqvQfuYFZRK9c3dmqdbmJdR7EKDmsIXRboQqZD2VkehaXGjdewEfeYN+qV3PT8/DM5zlkFO0T7O00pujK+1EVx2sA6kAMDMHgnFYkcbqYJUnTN3oDkscM7qRE5xL3YJo5rwChDvHAVOtrkCQXaruKDjArkJrjueIVq4RcRjk6v8+rMICBL1UfQZApznlPA3RTo1QQlZWHuzCDHQW46FO6fvd9BpPY74q7CNxCsR3sbTa9g2kML/Jqk74RWLpzisUc8npYsbE4XMKyYzoyjIB8r3mj8Xo2vtPdkk4ys60+mmW+ZvgL6DYunHeEO2+DgWFI9nv2ntvOwJ8iwi+rLgQ6aMP/mnbAf/nSZ/niJpEUWWDAVyk6o+/5aUAQVy7QUHYuP+vfHH3yucFLADJva4YZGcnWyFAwJiJ4CddeC+Vw1o7xk+SZCgDcVwgHGNK4HhHlPvI05m1ho2f3IKx7xPcanj3NVdJSOPRv1VB/08EOc4pgWByJzxDIuD2IjLLXV5SX60VRyTudbK8fNfl94NlC7f7u1EIsPj/qkjpugzIzIAAQ8AqXcKsoKt/iQ59QAdNxlZMpUDd4LlwaFMQ4en/oSdgKW0kj0WY/QTGG+PHtLDj2NvxY6IF+LjYExOxz+5LVzu7TfFJHLFJVFBLjYP9d6M+JIcv0jECdc3yayH8K1AcDQl+29VAwMifDdo4+B92I/WwIe+UAQ+HhLWWAIbuo0wrwr8vQxPEcyw+P1mr+STS6JTum6WzKIi0oOMpu2qJy1l6Xb+IInE+5 6FfB5Cll so8BT155WrXasPROFbx/ByOrLgqaqFM1O1eBXmtRTOiiJw7HgyKUZvjNi/zXmeYXfeLHha2ZxJ/uXqROeK48kLcupXgXNKt3wZI0kCXjI5sQUVY1P5+XYkfRspYXcYqWgEl+kImHc6Ry78JZJj0NSZ6ELIBFUG4Xrb+qzTAc5B4xN3JkFydX0tQkzZPHocAVt5oOI8IjJra4if16gZ9aM4lGMCCgFk7/mbI7MqXgAnMLdkiqX0X3k/szlCweysWmft9YV5POp1MbnilzZQMYQ6NvjOeNoYKFZEqxin8NgK/DwnsPckQhjjjm107M0AggI8KEWZ7oD/a4l31JUxtAFAl7EVnnoA5vQnYa5TMRTBDFsfnCJfz34J5dFWIW7OT8oTMHPUbHp0nS1jHTYdtp6I6XVc04bl+Ulc4DkzP0g69BbC77Z1Kn+XHbVkcYu2X5ssRMC/48Vyxz4v9NjKpeKY6BYX/kC0U58VHQmNF/KLvWLeBRxAWrc4Kd3ANKp1IsxMPxHOmPfz6lno9THgbYVe18fBPFlZIBfJm+a X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 18.02.25 18:24, Fuad Tabba wrote: > Add support for mmap() and fault() for guest_memfd backed memory > in the host for VMs that support in-place conversion between > shared and private. To that end, this patch adds the ability to > check whether the VM type supports in-place conversion, and only > allows mapping its memory if that's the case. > > This behavior is also gated by the configuration option > KVM_GMEM_SHARED_MEM. > > Signed-off-by: Fuad Tabba > --- > include/linux/kvm_host.h | 11 +++++ > virt/kvm/guest_memfd.c | 103 +++++++++++++++++++++++++++++++++++++++ > 2 files changed, 114 insertions(+) > > diff --git a/include/linux/kvm_host.h b/include/linux/kvm_host.h > index 3ad0719bfc4f..f9e8b10a4b09 100644 > --- a/include/linux/kvm_host.h > +++ b/include/linux/kvm_host.h > @@ -728,6 +728,17 @@ static inline bool kvm_arch_has_private_mem(struct kvm *kvm) > } > #endif > > +/* > + * Arch code must define kvm_arch_gmem_supports_shared_mem if support for > + * private memory is enabled and it supports in-place shared/private conversion. > + */ > +#if !defined(kvm_arch_gmem_supports_shared_mem) && !IS_ENABLED(CONFIG_KVM_PRIVATE_MEM) > +static inline bool kvm_arch_gmem_supports_shared_mem(struct kvm *kvm) > +{ > + return false; > +} > +#endif > + > #ifndef kvm_arch_has_readonly_mem > static inline bool kvm_arch_has_readonly_mem(struct kvm *kvm) > { > diff --git a/virt/kvm/guest_memfd.c b/virt/kvm/guest_memfd.c > index c6f6792bec2a..30b47ff0e6d2 100644 > --- a/virt/kvm/guest_memfd.c > +++ b/virt/kvm/guest_memfd.c > @@ -317,9 +317,112 @@ void kvm_gmem_handle_folio_put(struct folio *folio) > { > WARN_ONCE(1, "A placeholder that shouldn't trigger. Work in progress."); > } > + > +static bool kvm_gmem_offset_is_shared(struct file *file, pgoff_t index) > +{ > + struct kvm_gmem *gmem = file->private_data; > + > + /* For now, VMs that support shared memory share all their memory. */ > + return kvm_arch_gmem_supports_shared_mem(gmem->kvm); > +} > + > +static vm_fault_t kvm_gmem_fault(struct vm_fault *vmf) > +{ > + struct inode *inode = file_inode(vmf->vma->vm_file); > + struct folio *folio; > + vm_fault_t ret = VM_FAULT_LOCKED; > + > + filemap_invalidate_lock_shared(inode->i_mapping); > + > + folio = kvm_gmem_get_folio(inode, vmf->pgoff); > + if (IS_ERR(folio)) { > + switch (PTR_ERR(folio)) { > + case -EAGAIN: > + ret = VM_FAULT_RETRY; > + break; > + case -ENOMEM: > + ret = VM_FAULT_OOM; > + break; > + default: > + ret = VM_FAULT_SIGBUS; > + break; > + } > + goto out_filemap; > + } > + > + if (folio_test_hwpoison(folio)) { > + ret = VM_FAULT_HWPOISON; > + goto out_folio; > + } > + > + /* Must be called with folio lock held, i.e., after kvm_gmem_get_folio() */ > + if (!kvm_gmem_offset_is_shared(vmf->vma->vm_file, vmf->pgoff)) { > + ret = VM_FAULT_SIGBUS; > + goto out_folio; > + } > + > + /* > + * Only private folios are marked as "guestmem" so far, and we never > + * expect private folios at this point. > + */ > + if (WARN_ON_ONCE(folio_test_guestmem(folio))) { > + ret = VM_FAULT_SIGBUS; > + goto out_folio; > + } > + > + /* No support for huge pages. */ > + if (WARN_ON_ONCE(folio_test_large(folio))) { > + ret = VM_FAULT_SIGBUS; > + goto out_folio; > + } > + > + if (!folio_test_uptodate(folio)) { > + clear_highpage(folio_page(folio, 0)); > + kvm_gmem_mark_prepared(folio); > + } kvm_gmem_get_pfn()->__kvm_gmem_get_pfn() seems to call kvm_gmem_prepare_folio() instead. Could we do the same here? -- Cheers, David / dhildenb