From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B2B6BEB64DC for ; Mon, 26 Jun 2023 01:43:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0FDC98D0002; Sun, 25 Jun 2023 21:43:52 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 089F48D0001; Sun, 25 Jun 2023 21:43:52 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E91448D0002; Sun, 25 Jun 2023 21:43:51 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id CC8488D0001 for ; Sun, 25 Jun 2023 21:43:51 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 93CCCAFBFF for ; Mon, 26 Jun 2023 01:43:51 +0000 (UTC) X-FDA: 80943202662.28.F060AA5 Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by imf27.hostedemail.com (Postfix) with ESMTP id 51C1040005 for ; Mon, 26 Jun 2023 01:43:48 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=none; spf=pass (imf27.hostedemail.com: domain of linmiaohe@huawei.com designates 45.249.212.188 as permitted sender) smtp.mailfrom=linmiaohe@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1687743829; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=PpBCNg38EGk9uRWk+K+DuxuVrYHP9wlxsowllHjyqcY=; b=ntVEVC9OHegtpbWqKnr6uSl6AGmZsYLqfzrT9NIThrWRtWTddfTEOdT2sMa7Q9iefmhTVz whlhqaEF/wDHywwK8xDxoTRN+F0dMt8cJjsrjCTxjnJBz/FnuxPZWPvWJIRHyxAP1lU/IN IWVULBfS2W9rHEs7gTWRK7jXtQVeqQc= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=none; spf=pass (imf27.hostedemail.com: domain of linmiaohe@huawei.com designates 45.249.212.188 as permitted sender) smtp.mailfrom=linmiaohe@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1687743829; a=rsa-sha256; cv=none; b=co6Fbf4zmJFId0JGQydkjop/GSGZccccxzJO+UWFbldLtt32CGJ1PeTOb93t/xYsLxzVeT jNHj9Z64GSv6z8vf70Ifk0bSyUf776WNOhEWT268Ax2zbuY4vs434jd70JS4m8tVt4CThE P3LANv8xuufUl6L4j68S4Pj3zLHCCAc= Received: from canpemm500002.china.huawei.com (unknown [172.30.72.55]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4Qq9XL4nh6zMpZD; Mon, 26 Jun 2023 09:40:34 +0800 (CST) Received: from [10.174.151.185] (10.174.151.185) by canpemm500002.china.huawei.com (7.192.104.244) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Mon, 26 Jun 2023 09:43:44 +0800 Subject: Re: [PATCH] mm: memory-failure: remove unneeded page state check in shake_page() To: Naoya Horiguchi CC: , , , , Matthew Wilcox References: <20230625113430.2310385-1-linmiaohe@huawei.com> <20230626005221.GA353339@ik1-406-35019.vs.sakura.ne.jp> From: Miaohe Lin Message-ID: <2cd57a67-1cb2-83b8-3f73-6da72cd6159d@huawei.com> Date: Mon, 26 Jun 2023 09:43:44 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <20230626005221.GA353339@ik1-406-35019.vs.sakura.ne.jp> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.151.185] X-ClientProxiedBy: dggems701-chm.china.huawei.com (10.3.19.178) To canpemm500002.china.huawei.com (7.192.104.244) X-CFilter-Loop: Reflected X-Rspamd-Queue-Id: 51C1040005 X-Rspam-User: X-Stat-Signature: 18gpacc11suxhoqo8o91c59fyqdmd9kn X-Rspamd-Server: rspam01 X-HE-Tag: 1687743828-90451 X-HE-Meta: U2FsdGVkX18ONaiVIRrWre+EWQrMjIhQdNXVqoH/3rueEGpIcdR9vlYAP3Z+q+Y2SOGuMH5ShxHGThsIqIy/fW14P+F7Gn9RikUbj6zaUhmzfIXxYPmfLl5XIOGEKuQMWo/I6WGpWafhCrQNQ4cyhORXMDiKTpGbaEOEeXEelgMm1FCeMZtUEmrDw/KRHpvmsTc/qmeEc3QTef3cGczttVVPBKEoDEjOoXFB2aYMMeUvNqvIdbsnCiyGBs4HeKMBDjbm41XUBWN0iu2Rz+BMQ1mvmnXD8br4r+cs55nHdPwOrVZZnv9A5UjqjW3TAmrJ5IgSkOhcfoN3eTsA3BMs7TEA/+jvgYEz1W64nmnAbLGuikgftbuWufzhr37czLLEwjX8YGzWsXDLIMSqHVT/JbORgKjYHCNphW/WMyI2HcTQaed0ok/XdgzqQ6eJoV9qIZxcuIAqie21JQNhptltl8YZRJyGRITBbpOpKw0AlSXC8k7oz7WxSTt10s6CH2pk2Ddy8MdUg6tOBdz/QlEPQUNZzKXLCcvppChAEdBIBy4UT6Z6q0hBXS9eMxCaEn3xrMhahrD0jwsGRZcOhPpibsJf72vZrmwLZXa2wnMyQd2lu9KFK/CJblgTT20R5DporNntl2M2YqtDpX2RoAAAxfUaAG8wtIF1H45/mePWKRFsKvXJiJ08kKbWoOUVfjtD2uT2dbOekjopFCnhnFl/Dhk3m02X2bCwxxFGY5Ud/YWOG6ssyXRzf8NaDItu1emdm06V9Aj8aPCu5gJOgKJ8yP35JxrI0JCBSeDz0aQo9F9p54+KONkZDAJCAND4X4FILskTBYJriC84L3g07M35ZUfOkLjgxFFYVv+7HUquppej0MPPMXG63PCpP+cZ/bYDE6lIIFme5uE7WfKseaYSS7fOPQYhBUqJhwzberHniWCQ6uxhFxkEK8sy1aCtSI1YBw0MrnC5oRAV/zmN7Oh yYvJW2mn sXFLZu79ihhUv1uOcL4cfMMf57QzcqwAG3l7+IQzDa+UF2RYCMtcZzMkNtwX2BrXP/sq8LA+xxALrBsyZ1XAy8pUJ9uJRhsJXv18FzCfjsX479uWjJqP+z9HX6HGVWdHcYA5WbPmPQ0gDERc8FaomRQZIK9L7k8lOSOumrVPI1BAA2dnE8miO2td+fMQg76U50BB0BTBsMGFIhiE= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2023/6/26 8:52, Naoya Horiguchi wrote: > On Sun, Jun 25, 2023 at 07:34:30PM +0800, Miaohe Lin wrote: >> Remove unneeded PageLRU(p) and is_free_buddy_page(p) check as slab caches >> are not shrunk now. This check can be added back when a lightweight range >> based shrinker is available. >> >> Signed-off-by: Miaohe Lin > > This looks to me a good cleanup because the result of > "if (PageLRU(p) || is_free_buddy_page(p))" check is not used, so the check > itself is unneeded. > >> --- >> mm/memory-failure.c | 9 ++++----- >> 1 file changed, 4 insertions(+), 5 deletions(-) >> >> diff --git a/mm/memory-failure.c b/mm/memory-failure.c >> index 5b663eca1f29..92f951df3e87 100644 >> --- a/mm/memory-failure.c >> +++ b/mm/memory-failure.c >> @@ -373,11 +373,10 @@ void shake_page(struct page *p) >> if (PageHuge(p)) >> return; >> >> - if (!PageSlab(p)) { >> - lru_add_drain_all(); >> - if (PageLRU(p) || is_free_buddy_page(p)) >> - return; >> - } >> + if (PageSlab(p)) >> + return; >> + >> + lru_add_drain_all(); >> >> /* >> * TODO: Could shrink slab caches here if a lightweight range-based > > I think that this TODO comment can be put together with "if (PageSlab)" block. Thanks for your comment and advice. Do you mean something like below? diff --git a/mm/memory-failure.c b/mm/memory-failure.c index 5b663eca1f29..66e7b3ceaf2d 100644 --- a/mm/memory-failure.c +++ b/mm/memory-failure.c @@ -372,17 +372,14 @@ void shake_page(struct page *p) { if (PageHuge(p)) return; - - if (!PageSlab(p)) { - lru_add_drain_all(); - if (PageLRU(p) || is_free_buddy_page(p)) - return; - } - /* * TODO: Could shrink slab caches here if a lightweight range-based * shrinker will be available. */ + if (PageSlab(p)) + return; + + lru_add_drain_all(); } EXPORT_SYMBOL_GPL(shake_page); Thanks.