From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CF262C71136 for ; Tue, 17 Jun 2025 09:27:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 740E86B0096; Tue, 17 Jun 2025 05:27:44 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 718466B0099; Tue, 17 Jun 2025 05:27:44 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 62E376B009C; Tue, 17 Jun 2025 05:27:44 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 5240F6B0096 for ; Tue, 17 Jun 2025 05:27:44 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id C595B8127C for ; Tue, 17 Jun 2025 09:27:43 +0000 (UTC) X-FDA: 83564365206.22.988C423 Received: from mail-wr1-f68.google.com (mail-wr1-f68.google.com [209.85.221.68]) by imf02.hostedemail.com (Postfix) with ESMTP id B164A8000A for ; Tue, 17 Jun 2025 09:27:41 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=suse.com header.s=google header.b=feu53kx5; spf=pass (imf02.hostedemail.com: domain of petr.pavlu@suse.com designates 209.85.221.68 as permitted sender) smtp.mailfrom=petr.pavlu@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750152461; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=boN3t4QQQ5CJaq9F2B9aIVemxFll5K0ZGpv67UpOwpI=; b=KpyTGwH+cFxSJs2CQ/a9CT1YGfGUiJUMaRVtzwmBXOg/e8JZeuf+MsxCgPjsqhsBCs3JjA L0iRoKerHIHRF+j/ShmYU/7S9mLsvs8saBDg+TWa8w/ntfI9aDmboNEfl/qRkQBKpwIHkS 711GxuYCvYaWFCmt7P0mpOXJiopvX10= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750152461; a=rsa-sha256; cv=none; b=b+R1CjB+YPCxUaO9GvnDqJchffkiu1HgMAvdV0f0pEwURq/wNx1H62Kq68ZHbXWY6Hes1q W/Qgqv0jCvB4IJTPkicv51Z5e0xesstSMS10k5NhwwiQrS2VoVVZ1CX0C1lMUZoUmzXeci 2iqxOEKfX1B9IWB3ZvWHaikSHDPrDEg= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=suse.com header.s=google header.b=feu53kx5; spf=pass (imf02.hostedemail.com: domain of petr.pavlu@suse.com designates 209.85.221.68 as permitted sender) smtp.mailfrom=petr.pavlu@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com Received: by mail-wr1-f68.google.com with SMTP id ffacd0b85a97d-3a365a6804eso3971754f8f.3 for ; Tue, 17 Jun 2025 02:27:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1750152460; x=1750757260; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=boN3t4QQQ5CJaq9F2B9aIVemxFll5K0ZGpv67UpOwpI=; b=feu53kx5MXK51TW0LPz69evKlSYhha3PQolsg5QwkPit/gUfduYCUsgVPrelI5aE5x cALM+7OYjxVgcjPrr8+mda12G/DKeXbHY5mxcDdjAySa/JHjwk7oUi4S4NLa9F+ZLp2U m+j0HWTCJwDKC4eAxCkjBFO4D0MuwrBlmEGPYBm82ekj17N9cz0a5gQ3XOE47YnINlGd DeNUbeu2sDnQ3cDvhSV1YuvqyhfkZP20vAJfZHMeug8EMX6+ugQrESvBC6hcpWRLSgwW tTo0Yr1smB2tESWjXAKuGhR/xqAn4NVXy6cN9SiYi2fRjNwkK8K1W7vQaszorCKU3N72 MSSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750152460; x=1750757260; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=boN3t4QQQ5CJaq9F2B9aIVemxFll5K0ZGpv67UpOwpI=; b=bQuCNyA8SE4eRUpllQ25bZREokcTgrxLeBGDtUUQHQ1MpGaEsF6jNY47A9gca8cj+L +BWVY+eGvPKoiaMhlUWXi4TpE6ZLyoOOdGwJXC93KDoDSO+87WekDoz8ohfe6sPvS8XA /zPtswzS01Q4uNVpiV2mWU3rvi1+AODJo2qx+iwdVAWxY/5myTt7lnYbe5aQVnaT28cN abUh798Wd70KjpmxtqQeYJWgjmus3hqX30SkQXoPCmUpSbazQGDmLRS/3Ya4vRnKuguA qKnR7/t69n/VghWyxE8FzVBEr/mecF9CM0xXppHK1DGPmH8o0v1Qhbd0B82Np9lJ0pNC ICDQ== X-Forwarded-Encrypted: i=1; AJvYcCXarxkvOgiqdjTqE12h9TfOblipa2gjAYeBDhlH5+0j6hoMn7fXhVq2uD3yyMfEMPIM9wOpoIkWJw==@kvack.org X-Gm-Message-State: AOJu0Yzgz6kpyNCehCtXHIStDFOhSPsxRKzVt2NeD1uQQmaevx6/FC+w 6v+7toDDAREV5yzscqlpABcHkp2P66o7JmMvI+po2ekCKNf1grsrk+O+g2eUv8/bGnw= X-Gm-Gg: ASbGnculamhfSEPKAgXZPK9oNkoM5/oQjkV3Dc3caZ/MeRelWoNj1ewIBX8NRUH1ZDU D0vKdqmLX5Dhu+/Pc/7XUICCgC0dk9rL439xLtfhY58A0KBuSppiBofVlfi/OQDdXjdB8Odjcbq DL8+/vF38HQQkQ1+QH1up48P9L+QPZRs/9HoZjK5G3ylQGGnAnazs+m3ml3Lw00CvdoB2yugRME 7ZBB4BHtAoR3A5Wb+yQvb5cEQjPQTe98/ErHNEQEorDB3hnYjcN3J3HxYGTpvVicLBxjBVMgblS 5cIuWHvHUx1QNTtswgGbsuLILQXMfgLJxA3FUU5Oirvlc0z4lfOpAH4JKhqLgEugzA== X-Google-Smtp-Source: AGHT+IFM9Lj5qJWTtP6+l5n+/04TRA1i4YBOucx2CbKedvvZJIa35JF0Mqa14giJEb7sodnjrvIhwA== X-Received: by 2002:a05:6000:708:b0:3a5:5278:e635 with SMTP id ffacd0b85a97d-3a572367577mr9469207f8f.3.1750152460099; Tue, 17 Jun 2025 02:27:40 -0700 (PDT) Received: from [10.100.51.209] ([193.86.92.181]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a568b18f96sm13555006f8f.66.2025.06.17.02.27.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 17 Jun 2025 02:27:39 -0700 (PDT) Message-ID: <2cd3947a-63d9-4a79-a24a-eb1ae8164169@suse.com> Date: Tue, 17 Jun 2025 11:27:39 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] alloc_tag: remove empty module tag section To: Casey Chen Cc: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-modules@vger.kernel.org, linux-arch@vger.kernel.org, surenb@google.com, kent.overstreet@linux.dev, arnd@arndb.de, mcgrof@kernel.org, pasha.tatashin@soleen.com, yzhong@purestorage.com References: <20250610162258.324645-1-cachen@purestorage.com> Content-Language: en-US From: Petr Pavlu In-Reply-To: <20250610162258.324645-1-cachen@purestorage.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Queue-Id: B164A8000A X-Stat-Signature: rbe6uebcr5em36jacnqrbgeh3wh33f3n X-Rspamd-Server: rspam04 X-HE-Tag: 1750152461-580130 X-HE-Meta: U2FsdGVkX18K/xnencqMZTh/CGDo68IugXdF2u0WukX+EDcU8UN1RXpkzbNxxNd8CEip7d9aKTkCMBHHv6KuqRh32tirtpcJ0ndkjEeYeURryM7y72jmEN1nhda1Fv4fgtNVh7XtWl4zz8Bvh57J732b9GP6Rem/fP/8CrReVVyYbLpBWUO1ysQOu+x8ZXd9tqnoX3ZwIvTuR4WIuwiOiBJ9RWjm0hrYDTWlQRBk6dKR9q4FCJKZUFtWoaKnRIV1CR6eg4RCQYiQsCwrT9ARVS6Ggc94LyBQbW5TVlLMr9rt1gzjfgZ/AeHlZ/Tj2n6n2Kpsvt0HU0wDjesJByzHZgSdpFNbjmi0ZhiglnZEoZxsEc60za2kzSz1DGTj6xzdWr9aAbtosK7V5S7+OCkKZMzAEhWdwNEQToscKeSkR4DLrWWTEwd8QAA+jhQuO9jUnZ4rVMpUUMSRf4WE78H9PmO18kTKaiccLO5Dyi3Zae4KBOcoW4BcTiOb3/Ql0YF3E+CrWA0rq+fYdfzwbi62nLshXbbJLnLK/eZwS5F2fpitZoRGa26F+gLe943q9WbdeJW0Bxkw5XBS62FmDTtfS1W+uONVV3DU4shos8OpjL7AhO+yiOLZza9P5LsgDzaucxxrqR3xAxsAY+UK8uFsc4RBoujNRY+1Yhxqyit5hhEOpkcnQ5flJk+T6fWaLdX83XKROQvI3qYLrEbQspCDKmBqAecjXiYC6HfhI4PsC0PxNqE3PswKxrTjKb4Dyl8poJql5BIErwwns8UNgni1GgA6H0AeO0sNVM9PxLFOKT7zjIPRGURlYx4LLbQYHv8IF0O6zlrpVBBZ8XM1gec3DLNCMEfhoktLrVmhOrOcBfipf2R0jW+SPjZZIBgIr65Hb8nFzTrglJqtUAboFEsGCc1IBoVEpphZ3zCuDsmYbo4MJew82CFETRVhaENFB8w3LX9dRYXaH0LixnNsfHz 1S9VGau8 c7UKrsnDRiYT4SAYToJuNll3sAuen8yftzlm6g0ztu+y5T1qgB4X+15a8QvODXS7axEO+AizRkeg9s59DJ+LPNVSw8D3lQCRTEgGcS3S44VI19ZCP3gSUy8cX1ndYCmZfNwXFfTOlcjTf4eS9b1ALRQmLmdNF9wmw4dvywdcAQ7ze08uV2inumGi7pZC5XUuyf5NJ8knlT9ZnAMglG7S9w8i9X4SbOEBOMrX5zlVkHeRWf2LIXD+93v7qn3xdmKx+YJfKAxicjbV67noEDvMikKSAPVy8ShoiveU+OufiYTYl6lBdstGy8sCRaVHNH21lZKyDkxj8nA/KlXy8cfl//pz97v5PsM4nFUvIjR2CJYXCyS6EqrxIsAmcflGnkh1hHA6YHRU2DNt+6FeA+a5Wi89ofA5LW7IV2Is1zlZHQMXlu36dwpGDvQP2LEcgz44AwQtW X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 6/10/25 6:22 PM, Casey Chen wrote: > The empty MOD_CODETAG_SECTIONS() macro added an incomplete .data > section in module linker script, which caused symbol lookup tools > like gdb to misinterpret symbol addresses e.g., __ib_process_cq > incorrectly mapping to unrelated functions like below. > > (gdb) disas __ib_process_cq > Dump of assembler code for function trace_event_fields_cq_schedule: > > Removing the empty section restores proper symbol resolution and > layout, ensuring .data placement behaves as expected. The patch looks ok me, but I'm somewhat confused about the problem. I think a linker should not add an empty output section if it doesn't contain anything, or if .data actually contains something then the extra dummy definition should be also harmless? This also reminds me of my previous related fix "codetag: Avoid unused alloc_tags sections/symbols" [1] which fell through the cracks. I can rebase it on top of this patch. [1] https://lore.kernel.org/all/20250313143002.9118-1-petr.pavlu@suse.com/ -- Thanks, Petr