From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 33CF9CF31B0 for ; Wed, 2 Oct 2024 10:33:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 946956B03C7; Wed, 2 Oct 2024 06:33:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8F6CD6B03C8; Wed, 2 Oct 2024 06:33:02 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7700744018A; Wed, 2 Oct 2024 06:33:02 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 4E3946B03C7 for ; Wed, 2 Oct 2024 06:33:02 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id B29C81C4BAB for ; Wed, 2 Oct 2024 10:33:01 +0000 (UTC) X-FDA: 82628299362.24.1A03145 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf04.hostedemail.com (Postfix) with ESMTP id 3D99540013 for ; Wed, 2 Oct 2024 10:32:59 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=Com6Ui7J; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b="ajY6s+j/"; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=Com6Ui7J; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b="ajY6s+j/"; spf=pass (imf04.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1727865114; a=rsa-sha256; cv=none; b=wyTWyHma4Tu78hvJQDpO5O2RUdqRXUn/00nq5CovRU/LeQ6pGYpUACPTRDYfZI7gF4E1Mk i6wnBGLjy59eUXHya3IcALWzyU3kIk+Vfk2taXo0lo8IV8YlRpRqDhP+zz/Mwqzhbz8UP0 F+3ha8JVYvKm4qlcYPQ22hcWwq5G8y0= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=Com6Ui7J; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b="ajY6s+j/"; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=Com6Ui7J; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b="ajY6s+j/"; spf=pass (imf04.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1727865114; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=86BxNHYY1HvgxklxD4Bu5J4puSU7ybJmC39mnNztmrw=; b=m+hQI8U8XV5v9sHMZFo1iGQtt6jyXtWa0Zx+fhZuABdJi5FU+7OoZqvB7kDIn+jncqoKp6 k746WRVnF35oeE8HpZmb0NgVzjkfu4c9afmdlIYGun7upZQsYGsEN0KMG8U3NNiVS6xtmP KQVa51N0DI6I9Jw8fENnmj9o3qkD4Tk= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 5F46F1FD49; Wed, 2 Oct 2024 10:32:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1727865177; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=86BxNHYY1HvgxklxD4Bu5J4puSU7ybJmC39mnNztmrw=; b=Com6Ui7JQFFU3blg3i6WUVbvM9qxwEizvrPQVCYQJz/OJpPw6V07KR8+4uQNu9+amOKnAP RFMZAgiaQd1rtIc3b/wqBGwGdrGoS94rgPuMYA52SbBvyW52wBhII9/qO8qH7bXnDUAa7Q MF3j2sCFIqpYOBtm300pqKbpIT5lGNs= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1727865177; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=86BxNHYY1HvgxklxD4Bu5J4puSU7ybJmC39mnNztmrw=; b=ajY6s+j/2Po3cYnR9Zn8KhWpE9MOWhBsnUSysEqS4sLxgrWzudat1fQcWmiyC+Mausjzrs p3BX7Sh8c41OEIDA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1727865177; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=86BxNHYY1HvgxklxD4Bu5J4puSU7ybJmC39mnNztmrw=; b=Com6Ui7JQFFU3blg3i6WUVbvM9qxwEizvrPQVCYQJz/OJpPw6V07KR8+4uQNu9+amOKnAP RFMZAgiaQd1rtIc3b/wqBGwGdrGoS94rgPuMYA52SbBvyW52wBhII9/qO8qH7bXnDUAa7Q MF3j2sCFIqpYOBtm300pqKbpIT5lGNs= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1727865177; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=86BxNHYY1HvgxklxD4Bu5J4puSU7ybJmC39mnNztmrw=; b=ajY6s+j/2Po3cYnR9Zn8KhWpE9MOWhBsnUSysEqS4sLxgrWzudat1fQcWmiyC+Mausjzrs p3BX7Sh8c41OEIDA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 3478F13A6E; Wed, 2 Oct 2024 10:32:57 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id y2xsDFkh/Wa1YwAAD6G6ig (envelope-from ); Wed, 02 Oct 2024 10:32:57 +0000 Message-ID: <2cbdf455-f12f-4c40-9d08-527857fb2621@suse.cz> Date: Wed, 2 Oct 2024 12:32:56 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3] SLUB: Add support for per object memory policies Content-Language: en-US To: cl@gentwo.org, Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, Yang Shi , Christoph Lameter Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Huang Shijie References: <20241001-strict_numa-v3-1-ee31405056ee@gentwo.org> From: Vlastimil Babka Autocrypt: addr=vbabka@suse.cz; keydata= xsFNBFZdmxYBEADsw/SiUSjB0dM+vSh95UkgcHjzEVBlby/Fg+g42O7LAEkCYXi/vvq31JTB KxRWDHX0R2tgpFDXHnzZcQywawu8eSq0LxzxFNYMvtB7sV1pxYwej2qx9B75qW2plBs+7+YB 87tMFA+u+L4Z5xAzIimfLD5EKC56kJ1CsXlM8S/LHcmdD9Ctkn3trYDNnat0eoAcfPIP2OZ+ 9oe9IF/R28zmh0ifLXyJQQz5ofdj4bPf8ecEW0rhcqHfTD8k4yK0xxt3xW+6Exqp9n9bydiy tcSAw/TahjW6yrA+6JhSBv1v2tIm+itQc073zjSX8OFL51qQVzRFr7H2UQG33lw2QrvHRXqD Ot7ViKam7v0Ho9wEWiQOOZlHItOOXFphWb2yq3nzrKe45oWoSgkxKb97MVsQ+q2SYjJRBBH4 8qKhphADYxkIP6yut/eaj9ImvRUZZRi0DTc8xfnvHGTjKbJzC2xpFcY0DQbZzuwsIZ8OPJCc LM4S7mT25NE5kUTG/TKQCk922vRdGVMoLA7dIQrgXnRXtyT61sg8PG4wcfOnuWf8577aXP1x 6mzw3/jh3F+oSBHb/GcLC7mvWreJifUL2gEdssGfXhGWBo6zLS3qhgtwjay0Jl+kza1lo+Cv BB2T79D4WGdDuVa4eOrQ02TxqGN7G0Biz5ZLRSFzQSQwLn8fbwARAQABzSBWbGFzdGltaWwg QmFia2EgPHZiYWJrYUBzdXNlLmN6PsLBlAQTAQoAPgIbAwULCQgHAwUVCgkICwUWAgMBAAIe AQIXgBYhBKlA1DSZLC6OmRA9UCJPp+fMgqZkBQJkBREIBQkRadznAAoJECJPp+fMgqZkNxIQ ALZRqwdUGzqL2aeSavbum/VF/+td+nZfuH0xeWiO2w8mG0+nPd5j9ujYeHcUP1edE7uQrjOC Gs9sm8+W1xYnbClMJTsXiAV88D2btFUdU1mCXURAL9wWZ8Jsmz5ZH2V6AUszvNezsS/VIT87 AmTtj31TLDGwdxaZTSYLwAOOOtyqafOEq+gJB30RxTRE3h3G1zpO7OM9K6ysLdAlwAGYWgJJ V4JqGsQ/lyEtxxFpUCjb5Pztp7cQxhlkil0oBYHkudiG8j1U3DG8iC6rnB4yJaLphKx57NuQ PIY0Bccg+r9gIQ4XeSK2PQhdXdy3UWBr913ZQ9AI2usid3s5vabo4iBvpJNFLgUmxFnr73SJ KsRh/2OBsg1XXF/wRQGBO9vRuJUAbnaIVcmGOUogdBVS9Sun/Sy4GNA++KtFZK95U7J417/J Hub2xV6Ehc7UGW6fIvIQmzJ3zaTEfuriU1P8ayfddrAgZb25JnOW7L1zdYL8rXiezOyYZ8Fm ZyXjzWdO0RpxcUEp6GsJr11Bc4F3aae9OZtwtLL/jxc7y6pUugB00PodgnQ6CMcfR/HjXlae h2VS3zl9+tQWHu6s1R58t5BuMS2FNA58wU/IazImc/ZQA+slDBfhRDGYlExjg19UXWe/gMcl De3P1kxYPgZdGE2eZpRLIbt+rYnqQKy8UxlszsBNBFsZNTUBCACfQfpSsWJZyi+SHoRdVyX5 J6rI7okc4+b571a7RXD5UhS9dlVRVVAtrU9ANSLqPTQKGVxHrqD39XSw8hxK61pw8p90pg4G /N3iuWEvyt+t0SxDDkClnGsDyRhlUyEWYFEoBrrCizbmahOUwqkJbNMfzj5Y7n7OIJOxNRkB IBOjPdF26dMP69BwePQao1M8Acrrex9sAHYjQGyVmReRjVEtv9iG4DoTsnIR3amKVk6si4Ea X/mrapJqSCcBUVYUFH8M7bsm4CSxier5ofy8jTEa/CfvkqpKThTMCQPNZKY7hke5qEq1CBk2 wxhX48ZrJEFf1v3NuV3OimgsF2odzieNABEBAAHCwXwEGAEKACYCGwwWIQSpQNQ0mSwujpkQ PVAiT6fnzIKmZAUCZAUSmwUJDK5EZgAKCRAiT6fnzIKmZOJGEACOKABgo9wJXsbWhGWYO7mD 8R8mUyJHqbvaz+yTLnvRwfe/VwafFfDMx5GYVYzMY9TWpA8psFTKTUIIQmx2scYsRBUwm5VI EurRWKqENcDRjyo+ol59j0FViYysjQQeobXBDDE31t5SBg++veI6tXfpco/UiKEsDswL1WAr tEAZaruo7254TyH+gydURl2wJuzo/aZ7Y7PpqaODbYv727Dvm5eX64HCyyAH0s6sOCyGF5/p eIhrOn24oBf67KtdAN3H9JoFNUVTYJc1VJU3R1JtVdgwEdr+NEciEfYl0O19VpLE/PZxP4wX PWnhf5WjdoNI1Xec+RcJ5p/pSel0jnvBX8L2cmniYnmI883NhtGZsEWj++wyKiS4NranDFlA HdDM3b4lUth1pTtABKQ1YuTvehj7EfoWD3bv9kuGZGPrAeFNiHPdOT7DaXKeHpW9homgtBxj 8aX/UkSvEGJKUEbFL9cVa5tzyialGkSiZJNkWgeHe+jEcfRT6pJZOJidSCdzvJpbdJmm+eED w9XOLH1IIWh7RURU7G1iOfEfmImFeC3cbbS73LQEFGe1urxvIH5K/7vX+FkNcr9ujwWuPE9b 1C2o4i/yZPLXIVy387EjA6GZMqvQUFuSTs/GeBcv0NjIQi8867H3uLjz+mQy63fAitsDwLmR EP+ylKVEKb0Q2A== In-Reply-To: <20241001-strict_numa-v3-1-ee31405056ee@gentwo.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Action: no action X-Stat-Signature: wti9kujc5pzywn1oguupm75fnu9ydhdq X-Rspamd-Queue-Id: 3D99540013 X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1727865179-576023 X-HE-Meta: U2FsdGVkX1+dXInPvkqlIAyHjvceXuCcfV6YGaEW3k6HyK7BItPKtzHyyipcujgVugX4GGU5rg9A842zKZg3GCfEDKc5gMfOlpdO5pyvyCYXCR7s6QvbXdNzSWGDDTkA8svzTPTr5jEuFL4sL9VAosZRxHDgGJ/O3zHxT3d/fNRahx5tqVQW1GbV2dXvXNMftEnhadJFol7Kfo8XTiBPy2NigRA4LS8ANNiG0Rlm62BNAxwFaNevBgaYL4Elh77Ri9IbNITaIqeTxOzXEbGGFTeKhMF26N7V2+2u8CS2t+GOUHa6kJZhU5Lo4eVqJ5IeWt5dDDiF1K7pQwGJ8UIV7JPVbQYLE5TZq5h99Pth4qG/XnKc28Pecnmw0R90NgyGwP+ZTatgZFjOBGxDU6XK9B+iFU0uzFwmkSzb4Y9uSB+qNowzC3xSUya/BRjGKxSe2q4vB7/nwIBqG4nE/RnIfam3j5WqvEN8+dhc3MWEuQTMZGUQGesPeY4aqr20adAb0nxYyZxlKYA7b4UwFKMFmiffhzTn77x403eK8HrOevO8k02wJDJCUZyE+MuPL2E1NST3TTJeubFmFcBlaSuSVgd2CtiN/X8EEUYsxFje5YQOInRo4N1CPJE1+lVViFkRZAJmidejsqU5mtOBarhk2L3RTejTfFdKY2XohgBGRiW+GPpxpGg9gEzL9aC1w3WqMduRGfYQbxP+n5IXff+6kdBRLVrCY2wz93Slbp2tzDSaj1CV0DKHfTZb/28VPEE93OIYeeqkp2ESsikv+ThZOvtmbik/BjSsAGRy6uQE4AFLQAqy2ktk5bpo6vfQ59+1yqM0N5kaCUA+H3TqtEn4ADlgSvWEENpUziw1wbmbDQ445ZSq8Vv0KmBBcBwjf9kBtKnauGlP9oL2VmHbP9q57f7R9MbhWorUkwdo1Q3Wd1gD1RFS38aAUWPsHjT5Er6LwSRfg1Ir23OcecIV9JS Vs7xqAMA rn/ITD1IbXpB+T6JQG0O+E+KhRAwwu/ZLM66R4SMI22o7q0/PmxnSQjAjC/RR/IlVFfw633i56qG6S6uOtwcDk8DEpfnhi/jm3P0LFusfOr2/JLSPg12T/LTWh53W++n1ES7wK0Vsehgslm4DEY5gZAgVlqwGmzIrcqmS6nBTLbVyCZwx8s9PfN2P/rk6aVLmNSCTwoYCOamOQSEOcC0WEGY7rQAvhvcvR2lWsFRbJiM+I9Tdw0l3NE/keDIgLuxKihrW3Txe3ybawvDjpDTNdpciRJq6rH1wo3NL6iTXmMneg5hHQwpsaAmTbucP9qBiPqpPhmyGjE6AN2koKTtV0xxX+H8XwXkJNqdDn3IID8QSR5znhWagSslIimj6e+bDfHyigcofikYr0zPYInPWM9h72QpQl7t9FsVxTovQd46wJvMIoqtSWS3YIl5NgT/BaHTdMysosJRSdGw5OgRvgzuj8jTBuFCIlugw10dNklkdLYXhOT4Ks80H4Q== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 10/1/24 21:08, Christoph Lameter via B4 Relay wrote: > From: Christoph Lameter > > The old SLAB allocator used to support memory policies on a per > allocation bases. In SLUB the memory policies are applied on a > per page frame / folio bases. Doing so avoids having to check memory > policies in critical code paths for kmalloc and friends. > > This worked on general well on Intel/AMD/PowerPC because the > interconnect technology is mature and can minimize the latencies > through intelligent caching even if a small object is not > placed optimally. > > However, on ARM we have an emergence of new NUMA interconnect > technology based more on embedded devices. Caching of remote content > can currently be ineffective using the standard building blocks / mesh > available on that platform. Such architectures benefit if each slab > object is individually placed according to memory policies > and other restrictions. > > This patch adds another kernel parameter > > slab_strict_numa > > If that is set then a static branch is activated that will cause > the hotpaths of the allocator to evaluate the current memory > allocation policy. Each object will be properly placed by > paying the price of extra processing and SLUB will no longer > defer to the page allocator to apply memory policies at the > folio level. > > This patch improves performance of memcached running > on Ampere Altra 2P system (ARM Neoverse N1 processor) > by 3.6% due to accurate placement of small kernel objects. > > Tested-by: Huang Shijie > Signed-off-by: Christoph Lameter (Ampere) OK, but we should document this parameter in: Documentation/admin-guide/kernel-parameters.rst Documentation/mm/slab.rst Thanks, Vlastimil > --- > Changes in v3: > - Make the static key a static in slub.c > - Use pr_warn / pr_info instead of printk > - Link to v2: https://lore.kernel.org/r/20240906-strict_numa-v2-1-f104e6de6d1e@gentwo.org > > Changes in v2: > - Fix various issues > - Testing > --- > mm/slub.c | 42 ++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 42 insertions(+) > > diff --git a/mm/slub.c b/mm/slub.c > index 21f71cb6cc06..7ae94f79740d 100644 > --- a/mm/slub.c > +++ b/mm/slub.c > @@ -218,6 +218,10 @@ DEFINE_STATIC_KEY_FALSE(slub_debug_enabled); > #endif > #endif /* CONFIG_SLUB_DEBUG */ > > +#ifdef CONFIG_NUMA > +static DEFINE_STATIC_KEY_FALSE(strict_numa); > +#endif > + > /* Structure holding parameters for get_partial() call chain */ > struct partial_context { > gfp_t flags; > @@ -3957,6 +3961,28 @@ static __always_inline void *__slab_alloc_node(struct kmem_cache *s, > object = c->freelist; > slab = c->slab; > > +#ifdef CONFIG_NUMA > + if (static_branch_unlikely(&strict_numa) && > + node == NUMA_NO_NODE) { > + > + struct mempolicy *mpol = current->mempolicy; > + > + if (mpol) { > + /* > + * Special BIND rule support. If existing slab > + * is in permitted set then do not redirect > + * to a particular node. > + * Otherwise we apply the memory policy to get > + * the node we need to allocate on. > + */ > + if (mpol->mode != MPOL_BIND || !slab || > + !node_isset(slab_nid(slab), mpol->nodes)) > + > + node = mempolicy_slab_node(); > + } > + } > +#endif > + > if (!USE_LOCKLESS_FAST_PATH() || > unlikely(!object || !slab || !node_match(slab, node))) { > object = __slab_alloc(s, gfpflags, node, addr, c, orig_size); > @@ -5601,6 +5627,22 @@ static int __init setup_slub_min_objects(char *str) > __setup("slab_min_objects=", setup_slub_min_objects); > __setup_param("slub_min_objects=", slub_min_objects, setup_slub_min_objects, 0); > > +#ifdef CONFIG_NUMA > +static int __init setup_slab_strict_numa(char *str) > +{ > + if (nr_node_ids > 1) { > + static_branch_enable(&strict_numa); > + pr_info("SLUB: Strict NUMA enabled.\n"); > + } else > + pr_warn("slab_strict_numa parameter set on non NUMA system.\n"); > + > + return 1; > +} > + > +__setup("slab_strict_numa", setup_slab_strict_numa); > +#endif > + > + > #ifdef CONFIG_HARDENED_USERCOPY > /* > * Rejects incorrectly sized objects and objects that are to be copied > > --- > base-commit: e32cde8d2bd7d251a8f9b434143977ddf13dcec6 > change-id: 20240819-strict_numa-fc59b33123a2 > > Best regards,