From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 39BDFC433EF for ; Tue, 12 Apr 2022 08:13:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C23E36B0078; Tue, 12 Apr 2022 04:13:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BD3A66B007B; Tue, 12 Apr 2022 04:13:53 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A73D56B007D; Tue, 12 Apr 2022 04:13:53 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0023.hostedemail.com [216.40.44.23]) by kanga.kvack.org (Postfix) with ESMTP id 952306B0078 for ; Tue, 12 Apr 2022 04:13:53 -0400 (EDT) Received: from smtpin21.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 47EB58249980 for ; Tue, 12 Apr 2022 08:13:53 +0000 (UTC) X-FDA: 79347513546.21.3211A54 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by imf19.hostedemail.com (Postfix) with ESMTP id A76461A0009 for ; Tue, 12 Apr 2022 08:13:52 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 945F81F856; Tue, 12 Apr 2022 08:13:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1649751231; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jcar0IU6PwGTrQSGDaDquWKKjYlZDyRkkpySjBoGCVQ=; b=hoKDZwsrvHWuqvedPT0DnBr4y+jyJBtwP+gpluiusRgPyYzdOnZ662DgSfRE36GOL3p0i2 IgSEFKM71YIymkOkxnf0YvOsWcIxsFAxWePEQRtceCQgP7EO2MaHMa+3z/Py8g103atCRo u2FWoxdsDl4+D+Y2IfeLtqOyjs3oyMw= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1649751231; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jcar0IU6PwGTrQSGDaDquWKKjYlZDyRkkpySjBoGCVQ=; b=/7xdxhDJHryQs7sEVoQ9Y7suIbX/9N+NThL6YemWrOI7WTegprVElyfNItktqa9lElIdDN gCMt4VsBR3CFyBCw== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 321A513780; Tue, 12 Apr 2022 08:13:51 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id dkOhC780VWI8DgAAMHmgww (envelope-from ); Tue, 12 Apr 2022 08:13:51 +0000 Message-ID: <2cbc3b75-e29e-bbd8-0522-a3757f81b5c6@suse.cz> Date: Tue, 12 Apr 2022 10:13:50 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH v3 06/16] mm/rmap: remove do_page_add_anon_rmap() Content-Language: en-US To: David Hildenbrand , linux-kernel@vger.kernel.org Cc: Andrew Morton , Hugh Dickins , Linus Torvalds , David Rientjes , Shakeel Butt , John Hubbard , Jason Gunthorpe , Mike Kravetz , Mike Rapoport , Yang Shi , "Kirill A . Shutemov" , Matthew Wilcox , Jann Horn , Michal Hocko , Nadav Amit , Rik van Riel , Roman Gushchin , Andrea Arcangeli , Peter Xu , Donald Dutile , Christoph Hellwig , Oleg Nesterov , Jan Kara , Liang Zhang , Pedro Gomes , Oded Gabbay , linux-mm@kvack.org References: <20220329160440.193848-1-david@redhat.com> <20220329160440.193848-7-david@redhat.com> From: Vlastimil Babka In-Reply-To: <20220329160440.193848-7-david@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: A76461A0009 X-Stat-Signature: wg4mmykfaje8ogae34m4tmrbrciy5ag4 Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=hoKDZwsr; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b="/7xdxhDJ"; dmarc=none; spf=pass (imf19.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.29 as permitted sender) smtp.mailfrom=vbabka@suse.cz X-Rspam-User: X-HE-Tag: 1649751232-443109 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 3/29/22 18:04, David Hildenbrand wrote: > ... and instead convert page_add_anon_rmap() to accept flags. > > Passing flags instead of bools is usually nicer either way, and we want > to more often also pass RMAP_EXCLUSIVE in follow up patches when > detecting that an anonymous page is exclusive: for example, when > restoring an anonymous page from a writable migration entry. > > This is a preparation for marking an anonymous page inside > page_add_anon_rmap() as exclusive when RMAP_EXCLUSIVE is passed. > > Signed-off-by: David Hildenbrand Acked-by: Vlastimil Babka