From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BFB5AC83F25 for ; Mon, 21 Jul 2025 11:00:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5D62F6B008C; Mon, 21 Jul 2025 07:00:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5ADC06B0092; Mon, 21 Jul 2025 07:00:02 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 49CF26B0093; Mon, 21 Jul 2025 07:00:02 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 36C916B008C for ; Mon, 21 Jul 2025 07:00:02 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 9BD221A06D1 for ; Mon, 21 Jul 2025 11:00:01 +0000 (UTC) X-FDA: 83687977002.30.26F5490 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf27.hostedemail.com (Postfix) with ESMTP id 2433840005 for ; Mon, 21 Jul 2025 10:59:58 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=bqEjcedO; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf27.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1753095599; a=rsa-sha256; cv=none; b=hhZ0+bMmpGdDV9PzeupXKCDaea6ll03Nruy1w5qIoXLBSHYPxUD9YmBTi3NZrscvebJN4Y GyfMeLhGz/WtXTCth5M1lnEnA7a/HR7EXHjJekPIN0QfUhJcCAmNH+vbDBf6uJreJ9jxcm BJE5UVDhB3ZTo6kuMX1ffFZMGdEfo1Q= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=bqEjcedO; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf27.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1753095599; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=YUwfrnEr54WO/D9KJE4ox7AeGC4PJKzGk6wzt45ZFEw=; b=S8JXOsPU0G3j3IurGlM+GX1/R6+oJpI3fsFXaQc+PPUWvynXoOeprTFR7zozqwS3DP4uFw HtrGZfL45LjDQOEgdOaXd4ybh9kXyJx3X1TBESe0RwQCfZzyNUC3ppZ+0m9mt27obSLwP1 vYFWERK3E09dBiklUXYLau4505Si9oI= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1753095598; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=YUwfrnEr54WO/D9KJE4ox7AeGC4PJKzGk6wzt45ZFEw=; b=bqEjcedOBYOwYj6h/htrNbXZwHnBFH1K2/533SxrwFk3qMrLXrHs7KUMSZmEGf2Oe0Tu08 tQf+TG6WrQD09cFUyTSl+xwUXkBiooLNRn7HMZmRaLTaNeV//GZXDqqX0a5+m4Cpsq3VgL 9iU2oa23ygmUYUuv14ZRsLF17nKp6ss= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-390-7b_HiIfrO9GjI1HFZBBNZg-1; Mon, 21 Jul 2025 06:59:57 -0400 X-MC-Unique: 7b_HiIfrO9GjI1HFZBBNZg-1 X-Mimecast-MFC-AGG-ID: 7b_HiIfrO9GjI1HFZBBNZg_1753095596 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-3b20f50da27so2046688f8f.0 for ; Mon, 21 Jul 2025 03:59:56 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1753095596; x=1753700396; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=YUwfrnEr54WO/D9KJE4ox7AeGC4PJKzGk6wzt45ZFEw=; b=CkuE6sMSvJ39UNqh+Qam7L3eiDFKRrhc6Ai8/E82ipc0sXH0EXFCoha/3FH0ijZLgz 3v6qFATePm9sctMsoCyH+WY9zPtI8xLiq/zd4jVEY2wgNMI0x4xbI2KGiw3B5/Zd3k+5 URFjecfpgb4eAUZV64qIV7jJmRiHmo33RJu2qO1CRTZ5z50tpW53NGFQ/om+HdgToM+R nXS97/HOpe11G7+TyPsdU4FIpVjyPXAn+GuhlzO1pFkMA43IFO52RvRR2mXCZWUfmGEg Qc4t1tK9houOmIVM+PdMVzUsNBtTcVvEl/7VH3aWSX08L8FjDSN6zguyT6Ntb+SjR59r v/MA== X-Forwarded-Encrypted: i=1; AJvYcCVt+V8Fw51RwjUfONrvj1CowIvrZAhqM/jNNCaNR19HZx35EM/R9QysU715t/csXvKSjMXzBismEA==@kvack.org X-Gm-Message-State: AOJu0YxYpn8NFcm7ndorq5udtFX0F4bCTExeyqNZQpCo66iYUyNvAQ+e io3Y5ce+H7dI6wMEaEDRTwgK3fIrx8MBcSC0hCNrWmaPa6t7Pxf4y0neYtYM7axflzI+SKDZfH5 i3CXl8r3KifPfuE7Pc3cjDRMM/79dpmBfS6YwktVvXgSf8SbH7CiD X-Gm-Gg: ASbGncuhhHSZytJ4Jjsq/VfOL2VqMcnk8sk+F0lOYZOdzXyzb8idmtO/LXmxESJRqLx kHKY4uwWQi6AtdS2xUIGP47h7KupowNZoy5wWdG0E3Kany/H7VOiqZIdkOtJnlteHckzERVGW/s LoK9YtWaR1Cx/CdYuehL7TXvMYRy/3ZoHenTeuZlTtfPWwRl/O4FlJVSH+12Cd8sbtVhGhwUkrF eDOBrtqJtTyS3rdNcbl2kWgfuIIE6TqaqYpixYi2RPz4uyERojFmCygP24v9NNAWM6M6/T5PSUA nbWSFU+ZHWXlOccAwLJJaTb7Ly8Ac5t3zF30f3IXU4KAfu2YJXqZg6rFlAcAFK0v8kkwKwAtg9j ZObznsNmV5XZ8ZNyQ2Dy9i+PR+fHZutiwhxkSHyE6urctOpb2urMGnuocLbE3vZ+X X-Received: by 2002:a05:6000:18a9:b0:3a3:7ba5:9a68 with SMTP id ffacd0b85a97d-3b613aca420mr13323146f8f.18.1753095595603; Mon, 21 Jul 2025 03:59:55 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGmVVaTtpJ46G9XBGQk7ELSRWjwZM1pjPX+4QunKQfxixsUoV7pyvlf4IJPfZzeI5Fg9IFNmw== X-Received: by 2002:a05:6000:18a9:b0:3a3:7ba5:9a68 with SMTP id ffacd0b85a97d-3b613aca420mr13323114f8f.18.1753095595096; Mon, 21 Jul 2025 03:59:55 -0700 (PDT) Received: from ?IPV6:2003:d8:2f4c:df00:a9f5:b75b:33c:a17f? (p200300d82f4cdf00a9f5b75b033ca17f.dip0.t-ipconnect.de. [2003:d8:2f4c:df00:a9f5:b75b:33c:a17f]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3b61ca48c40sm10197701f8f.58.2025.07.21.03.59.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 21 Jul 2025 03:59:54 -0700 (PDT) Message-ID: <2cae64a2-7fd4-46ae-b4ab-8924db99154b@redhat.com> Date: Mon, 21 Jul 2025 12:59:53 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/2] mm: cma: simplify cma_maxchunk_get() To: Yury Norov , Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20250719205401.399475-1-yury.norov@gmail.com> <20250719205401.399475-3-yury.norov@gmail.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAmgsLPQFCRvGjuMACgkQTd4Q 9wD/g1o0bxAAqYC7gTyGj5rZwvy1VesF6YoQncH0yI79lvXUYOX+Nngko4v4dTlOQvrd/vhb 02e9FtpA1CxgwdgIPFKIuXvdSyXAp0xXuIuRPQYbgNriQFkaBlHe9mSf8O09J3SCVa/5ezKM OLW/OONSV/Fr2VI1wxAYj3/Rb+U6rpzqIQ3Uh/5Rjmla6pTl7Z9/o1zKlVOX1SxVGSrlXhqt kwdbjdj/csSzoAbUF/duDuhyEl11/xStm/lBMzVuf3ZhV5SSgLAflLBo4l6mR5RolpPv5wad GpYS/hm7HsmEA0PBAPNb5DvZQ7vNaX23FlgylSXyv72UVsObHsu6pT4sfoxvJ5nJxvzGi69U s1uryvlAfS6E+D5ULrV35taTwSpcBAh0/RqRbV0mTc57vvAoXofBDcs3Z30IReFS34QSpjvl Hxbe7itHGuuhEVM1qmq2U72ezOQ7MzADbwCtn+yGeISQqeFn9QMAZVAkXsc9Wp0SW/WQKb76 FkSRalBZcc2vXM0VqhFVzTb6iNqYXqVKyuPKwhBunhTt6XnIfhpRgqveCPNIasSX05VQR6/a OBHZX3seTikp7A1z9iZIsdtJxB88dGkpeMj6qJ5RLzUsPUVPodEcz1B5aTEbYK6428H8MeLq NFPwmknOlDzQNC6RND8Ez7YEhzqvw7263MojcmmPcLelYbfOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCaCwtJQUJG8aPFAAKCRBN3hD3AP+DWlDnD/4k2TW+HyOOOePVm23F5HOhNNd7nNv3 Vq2cLcW1DteHUdxMO0X+zqrKDHI5hgnE/E2QH9jyV8mB8l/ndElobciaJcbl1cM43vVzPIWn 01vW62oxUNtEvzLLxGLPTrnMxWdZgxr7ACCWKUnMGE2E8eca0cT2pnIJoQRz242xqe/nYxBB /BAK+dsxHIfcQzl88G83oaO7vb7s/cWMYRKOg+WIgp0MJ8DO2IU5JmUtyJB+V3YzzM4cMic3 bNn8nHjTWw/9+QQ5vg3TXHZ5XMu9mtfw2La3bHJ6AybL0DvEkdGxk6YHqJVEukciLMWDWqQQ RtbBhqcprgUxipNvdn9KwNpGciM+hNtM9kf9gt0fjv79l/FiSw6KbCPX9b636GzgNy0Ev2UV m00EtcpRXXMlEpbP4V947ufWVK2Mz7RFUfU4+ETDd1scMQDHzrXItryHLZWhopPI4Z+ps0rB CQHfSpl+wG4XbJJu1D8/Ww3FsO42TMFrNr2/cmqwuUZ0a0uxrpkNYrsGjkEu7a+9MheyTzcm vyU2knz5/stkTN2LKz5REqOe24oRnypjpAfaoxRYXs+F8wml519InWlwCra49IUSxD1hXPxO WBe5lqcozu9LpNDH/brVSzHCSb7vjNGvvSVESDuoiHK8gNlf0v+epy5WYd7CGAgODPvDShGN g3eXuA== Organization: Red Hat In-Reply-To: <20250719205401.399475-3-yury.norov@gmail.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: I-0TJS6hFc91ZLQZASNu67TgV0FjuvpCrnQm-oZhiE0_1753095596 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 2433840005 X-Stat-Signature: qtw5itehoouqx6tady7nkcr4uw4qact4 X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1753095598-438607 X-HE-Meta: U2FsdGVkX1/8a/m1wQSIYtSC0b0Fn+pxSzV1ievoeoZSnV5vjF1wUagD2QRHYmwoBo5i2aDbj+05+25lTodRcDTvK+k4CvGE7OWUsepTTJ+aJKytg7KUx88r/JHekNUTKc1Yq+iPnGp/HcXNke0nxW8PmHKBgiW09J6tiTOC9IX5Rzf090pj+fYeBbTrZOQiiOVtLYmH7bfvf9zFjurLQcMZDkZfo1b0pHtAokETCMOXMCl45LXHUgg1NE5keQBbdiK+sQB8/DFwQ/nqOKPzEWVXeBqZNPJd3sNfm7vnP5JQwtBKVQWlivwUlcJGY7om+STfb15SHOp5penAWFCWJ7epz0Emujh4e8WmoJL6gls5/ZWdCDNIl/QVfqVz5RvezOOMEwdiyug2TUT5pVy0XHN/PHBaC0/N2y+neFMp04EtkhOZa/9y/2AoLjyVR5v3eHJpiK40i0/zFjVKT6z2pNVn9taVhWdqHLOR3QEV0ngVslocZz3KQMJfKQUu7OlQv12LxR5ks8TKydqBdE+RND+s6Qr+TU32kjM2JBeD+tZTd7QR9a3yvND3//Ky9uH2jodraFcm+neengjYKiXDLjU0aefK9cl5lvEnmjfZ6Iykc3zytbz3/roBPlrfG3JNMxzjQyLA40a9RVT1G29L3YOe+x7i5Q13nKJFIjw8fReHlxlDdLc3cl09ExZUlzppZWs0eySSGXAGnFE65JPJHbCs5ZlCY6h8tkngDONdmNaxSMcUwyBDrhWbBcL+5w7cVUUivgVHyc9I5kB27bW2UiMexR+4lctK/ZgP3jWkR5aKw57gm8qpdzYRFQ7UoYp5yUE9oLOZvHY4IP42ABEjFneHiWj+OE+4FlPjDNCCmzX2cCaLHjqsroH+al50sBso1/K6cbyXD+1b7snRGrvqoapsBzSU7BPYd5Ng2IthUY/tI+8q/0wnMlyjBWdvWqq8PS0n8ggWMWYpmqObwqB Xpc5VN4c 2d8XrzbnloRs7IYTTV4iM9YS/zgJV7IBr9eIpDcdd7dtEo8xg1c9wT5rhaQUqNn7wrmzLV5tFS045KvLb2UgNtCdqZWQS0nnIKsNh0yiwGHZD1JNBpzdX3JXLkrNMXOFhtiy2i5XtP7ZMARfTYiJHzjaMMR9ySSoMstMyefwKA+FZUw5oHfnRpe5xJ9C0eCoYHlbMvj25dRp7bWrEa24eI0e8XDQVfp+VPZLWkFQlO6SYAMaLwZQ5SHyUNt7zpvTqgh0WDI2lHv1jUb/A0y8PY8uRWBBFr2/ArmyVJKRSqj9vxNs7rXbYrDd7Z/qSFH09krUS4CjQB6cKcP5LORd06jAmAVx11SkfPYh8lk4RM2/yNsolF9qqcLZktI2rfO00JlnEirsDMYf7xXifx9nY1QnDKn023rgZifGrAAMYU1TGjTr6C9HV4ftnr7OZrgGs2sJ8tFAiPmcXg1ou/D5SskyEfHg6wz8Heucb+vFFhXROqQHXWH1r2vhf/ZpDLI+QeMNhgkeS4vFgDQCe4hz+rJ4xrPFVvCunZzqBYhTj7eA6dwPhqhD6DJC2gNAz4Jo/axlJCHA+6reTKegUiybe9sLwYTFn7mW9Wk9g2CMYlrDxeGqkAr0blRwIVw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 19.07.25 22:54, Yury Norov wrote: > From: Yury Norov (NVIDIA) > > The function opencodes for_each_clear_bitrange(). Fix that and drop most > of housekeeping code. Not sure if talking about a "fix" it the right word here. Acked-by: David Hildenbrand > > Signed-off-by: Yury Norov (NVIDIA) > --- > mm/cma_debug.c | 10 +--------- > 1 file changed, 1 insertion(+), 9 deletions(-) > > diff --git a/mm/cma_debug.c b/mm/cma_debug.c > index fdf899532ca0..8c7d7f8e8fbd 100644 > --- a/mm/cma_debug.c > +++ b/mm/cma_debug.c > @@ -56,16 +56,8 @@ static int cma_maxchunk_get(void *data, u64 *val) > for (r = 0; r < cma->nranges; r++) { > cmr = &cma->ranges[r]; > bitmap_maxno = cma_bitmap_maxno(cma, cmr); > - end = 0; > - for (;;) { > - start = find_next_zero_bit(cmr->bitmap, > - bitmap_maxno, end); > - if (start >= bitmap_maxno) > - break; > - end = find_next_bit(cmr->bitmap, bitmap_maxno, > - start); > + for_each_clear_bitrange(start, end, cmr->bitmap, bitmap_maxno) > maxchunk = max(end - start, maxchunk); > - } > } > spin_unlock_irq(&cma->lock); > *val = (u64)maxchunk << cma->order_per_bit; -- Cheers, David / dhildenb