From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.6 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B83F2C433E6 for ; Tue, 1 Sep 2020 08:00:03 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 79786208DB for ; Tue, 1 Sep 2020 08:00:03 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 79786208DB Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=csgroup.eu Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 06EF48E0001; Tue, 1 Sep 2020 04:00:03 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id F3AB96B006C; Tue, 1 Sep 2020 04:00:02 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E01C68E0001; Tue, 1 Sep 2020 04:00:02 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0158.hostedemail.com [216.40.44.158]) by kanga.kvack.org (Postfix) with ESMTP id C728A6B0068 for ; Tue, 1 Sep 2020 04:00:02 -0400 (EDT) Received: from smtpin12.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 7A3C68248D52 for ; Tue, 1 Sep 2020 08:00:02 +0000 (UTC) X-FDA: 77213744244.12.note00_4409f1727096 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin12.hostedemail.com (Postfix) with ESMTP id 32E9918015D99 for ; Tue, 1 Sep 2020 08:00:02 +0000 (UTC) X-HE-Tag: note00_4409f1727096 X-Filterd-Recvd-Size: 3754 Received: from pegase1.c-s.fr (pegase1.c-s.fr [93.17.236.30]) by imf46.hostedemail.com (Postfix) with ESMTP for ; Tue, 1 Sep 2020 08:00:01 +0000 (UTC) Received: from localhost (mailhub1-int [192.168.12.234]) by localhost (Postfix) with ESMTP id 4BgfcZ4pZKz9v4j6; Tue, 1 Sep 2020 09:59:58 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at c-s.fr Received: from pegase1.c-s.fr ([192.168.12.234]) by localhost (pegase1.c-s.fr [192.168.12.234]) (amavisd-new, port 10024) with ESMTP id jFpzCAZ8F1-s; Tue, 1 Sep 2020 09:59:58 +0200 (CEST) Received: from messagerie.si.c-s.fr (messagerie.si.c-s.fr [192.168.25.192]) by pegase1.c-s.fr (Postfix) with ESMTP id 4BgfcZ3qkxz9v4j8; Tue, 1 Sep 2020 09:59:58 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by messagerie.si.c-s.fr (Postfix) with ESMTP id 8B3A98B774; Tue, 1 Sep 2020 09:59:59 +0200 (CEST) X-Virus-Scanned: amavisd-new at c-s.fr Received: from messagerie.si.c-s.fr ([127.0.0.1]) by localhost (messagerie.si.c-s.fr [127.0.0.1]) (amavisd-new, port 10023) with ESMTP id sXuYaJ7qSsE1; Tue, 1 Sep 2020 09:59:59 +0200 (CEST) Received: from [192.168.4.90] (unknown [192.168.4.90]) by messagerie.si.c-s.fr (Postfix) with ESMTP id A8AAA8B75E; Tue, 1 Sep 2020 09:59:58 +0200 (CEST) Subject: Re: [PATCH v3 12/13] mm/debug_vm_pgtable/hugetlb: Disable hugetlb test on ppc64 To: "Aneesh Kumar K.V" , Anshuman Khandual , linux-mm@kvack.org, akpm@linux-foundation.org Cc: mpe@ellerman.id.au, linuxppc-dev@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org, linux-s390@vger.kernel.org, linux-snps-arc@lists.infradead.org, x86@kernel.org, linux-arch@vger.kernel.org, Gerald Schaefer , Christophe Leroy , Vineet Gupta , Mike Rapoport , Qian Cai , "Erhard F." References: <20200827080438.315345-1-aneesh.kumar@linux.ibm.com> <20200827080438.315345-13-aneesh.kumar@linux.ibm.com> <6191e77f-c3b7-21ea-6dbd-eecc09735923@arm.com> <68f90b44-b830-58be-3c21-424fee05da37@linux.ibm.com> From: Christophe Leroy Message-ID: <2ca78670-eb76-0192-7a83-1c1fa4a0fff5@csgroup.eu> Date: Tue, 1 Sep 2020 09:59:50 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <68f90b44-b830-58be-3c21-424fee05da37@linux.ibm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: fr X-Rspamd-Queue-Id: 32E9918015D99 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam03 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Le 01/09/2020 =C3=A0 08:30, Aneesh Kumar K.V a =C3=A9crit=C2=A0: >> >=20 > I actually wanted to add #ifdef BROKEN. That test is completely broken.= =20 > Infact I would suggest to remove that test completely. >=20 >=20 >=20 >> #ifdef will not be required here as there would be a stub definition >> for hugetlb_advanced_tests() when CONFIG_PPC_BOOK3S_64 is enabled. >> >>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 spin_lock(&mm->page_table_lock); >>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 p4d_clear_tests(mm, p4dp); >>> >> >> But again, we should really try and avoid taking this path. >> >=20 > To be frank i am kind of frustrated with how this patch series is being= =20 > looked at. We pushed a completely broken test to upstream and right now= =20 > we have a code in upstream that crash when booted on ppc64. My attempt=20 > has been to make progress here and you definitely seems to be not in=20 > agreement to that. >=20 > At this point I am tempted to suggest we remove the DEBUG_VM_PGTABLE=20 > support on ppc64 because AFAIU it doesn't add any value. >=20 Note that a bug has been filed at=20 https://bugzilla.kernel.org/show_bug.cgi?id=3D209029 Christophe