From: maobibo <maobibo@loongson.cn>
To: Matthew Wilcox <willy@infradead.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Anshuman Khandual <anshuman.khandual@arm.com>
Subject: Re: [PATCH v2] mm: add access/dirty bit on numa page fault
Date: Fri, 18 Mar 2022 10:17:35 +0800 [thread overview]
Message-ID: <2c9ef479-a371-3fec-4d1b-fc833d8bf3d4@loongson.cn> (raw)
In-Reply-To: <YjPkf704nT/T9S9i@casper.infradead.org>
On 03/18/2022 09:46 AM, Matthew Wilcox wrote:
> On Fri, Mar 18, 2022 at 09:01:32AM +0800, maobibo wrote:
>>> Is this a correctness problem, in which case this will need to be
>>> backported, or is this a performance problem, in which case can you
>>> share some numbers?
>> It is only performance issue, and there is no obvious performance
>> improvement for general workloads on my hand, but I do not test
>> it on microbenchmark.
>
> ... if there's no performance improvement, why should we apply this
> patch? Confused.
>
It is not obvious from workload view, it actually reduces one tlb miss
on platforms without hw page walk.
next prev parent reply other threads:[~2022-03-18 2:17 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-17 6:50 Bibo Mao
2022-03-17 12:23 ` Matthew Wilcox
2022-03-18 1:01 ` maobibo
2022-03-18 1:46 ` Matthew Wilcox
2022-03-18 2:17 ` maobibo [this message]
2022-03-17 12:32 ` David Hildenbrand
2022-03-18 1:17 ` maobibo
2022-03-18 8:21 ` David Hildenbrand
2022-03-19 2:58 ` maobibo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2c9ef479-a371-3fec-4d1b-fc833d8bf3d4@loongson.cn \
--to=maobibo@loongson.cn \
--cc=akpm@linux-foundation.org \
--cc=anshuman.khandual@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox