From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CC94DCF6493 for ; Sat, 28 Sep 2024 05:43:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 40E346B0190; Sat, 28 Sep 2024 01:43:55 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3969C6B0191; Sat, 28 Sep 2024 01:43:55 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 25FC26B0192; Sat, 28 Sep 2024 01:43:55 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 05F7C6B0190 for ; Sat, 28 Sep 2024 01:43:54 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 764481213E3 for ; Sat, 28 Sep 2024 05:43:54 +0000 (UTC) X-FDA: 82613055588.25.DB8B365 Received: from out-186.mta0.migadu.com (out-186.mta0.migadu.com [91.218.175.186]) by imf20.hostedemail.com (Postfix) with ESMTP id BAD991C000E for ; Sat, 28 Sep 2024 05:43:52 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=MvKtild3; spf=pass (imf20.hostedemail.com: domain of chengming.zhou@linux.dev designates 91.218.175.186 as permitted sender) smtp.mailfrom=chengming.zhou@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1727502170; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=WM4VZ3i3EB6b7hfc7us+bM3jDNW3II/yBjXBL1dQj8U=; b=1DMUmwxS2UZ23o6JBgErmyu31ajTLWSy4vDFgTv61S9ubMmBe65wSdg99F9gjMiT/VLYp+ gcv4rW+QUbzIf3Z0EJwTqRcV39unVr3M0KVykRoDEqmmJINQdenZlDsdXNl8VHehEvLfSM GpiNeBr/qUSOaTc0AmnPj1H1j7bD6tI= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=MvKtild3; spf=pass (imf20.hostedemail.com: domain of chengming.zhou@linux.dev designates 91.218.175.186 as permitted sender) smtp.mailfrom=chengming.zhou@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1727502170; a=rsa-sha256; cv=none; b=ashKVMmf2gnj3G2KvYoaVEyDDnzeGafo0aDWCOv+UVhoE5NxXTK5t4qt7cgFv3zCvPp5Yz +A0OXzgplvQ7T+CKfUqMrPMuMztG/6qVus4X3Ql5Jnk9avCbSgJOvFylP5qTB3o6B/8yQV rssTSjgmbkrQHn3hRNRZ50IdXzpgsZY= Message-ID: <2c9d403f-188b-4f15-93d7-36224ef31329@linux.dev> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1727502231; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=WM4VZ3i3EB6b7hfc7us+bM3jDNW3II/yBjXBL1dQj8U=; b=MvKtild31vJw513FoyxiEwqqwM++Y9ZZTTFAbV2BVnT+rdY+DS1y7npJNl4ikAvxM2YTg/ WtiSDKDAIooQE4iEWWDZhk/PZc82BO9IFHsbOLFOILv7pW8z2tQ0kZoQykAs1fGHDeo0+e kRnkF6bk2HVohv09sDFcBwl/3r6kWzQ= Date: Sat, 28 Sep 2024 13:43:41 +0800 MIME-Version: 1.0 Subject: Re: [PATCH v8 3/8] mm: zswap: Rename zswap_pool_get() to zswap_pool_tryget(). To: Kanchana P Sridhar , linux-kernel@vger.kernel.org, linux-mm@kvack.org, hannes@cmpxchg.org, yosryahmed@google.com, nphamcs@gmail.com, usamaarif642@gmail.com, shakeel.butt@linux.dev, ryan.roberts@arm.com, ying.huang@intel.com, 21cnbao@gmail.com, akpm@linux-foundation.org Cc: nanhai.zou@intel.com, wajdi.k.feghali@intel.com, vinodh.gopal@intel.com References: <20240928021620.8369-1-kanchana.p.sridhar@intel.com> <20240928021620.8369-4-kanchana.p.sridhar@intel.com> X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Chengming Zhou In-Reply-To: <20240928021620.8369-4-kanchana.p.sridhar@intel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_OUT X-Rspamd-Server: rspam03 X-Rspam-User: X-Rspamd-Queue-Id: BAD991C000E X-Stat-Signature: ohigj1c64k9i8nbr99xyqennp9awke5z X-HE-Tag: 1727502232-69171 X-HE-Meta: U2FsdGVkX18ZSs9WNfeFTcl9VsjRDsz9vSgDIewAfgMonhRX7vnJjDBMPiOpqJPy0z8eXqyFxAgBZgmuLWph1rkoqwUtB2+Ca01COHD/P0rHH4EdlteBSNqAk/dcD4zbhf9PqGmThpCUsWiTNYYCnwTNDO6RUfg1HnKnMG2BapYxVTxDkcAfN1b0lv4l7w3szfd+HOstwe40xOBoldyRu2KvEYGUn4K10JSBiLxpANXj5OiAEtgWZGFfyWl4vuijLGsXCs+dY3fBT5fJTMkWqBPPfq+dIpXsn9yHA/P3/HZQwOXaP+yHHJrHOrnGIglIkYfq9hTRLN8RZa3On1pgw3uWBjkg6Lm182AD+rCPbeDBi0F2ra5SqNVyus/bXWgWFCPqhGf1h28/a+a4RK2Wefu1wAJWr1uPHXUrDWsi/KjYkDKOlm+2L4IyQRYNzC66gq4y9DgpYNBn6PRDr9j0iwrXvE4xpnG22DtDnYa0nQbIB6CedRWGaMz0XAzoAZtlKk7ooWrd6pY30gQnOZdQP44M3nk0aurX9pKIDois28BEr6q0lvsLrtHxRAPwzGJsDV/AmJFDrmfC6g+e/qnTCr6DLIQbivx45DhS02cJiZQG0oCKSiT/V1dUPqgPs1ZD8Jcl90QNqy7OEeiMNu3upwt96RBjX+Sk0utnMuukX7u6Ee3R3OuNqLerrnQ3n5kVAkZD259s9a+pv+IAy3Jto4DP7QSqL0RA3euqqPqOcTxZngcwUINRC5gTW55dX0GHtsr5/t8KNjTb5bRD5+VJcVgF4q+D1dj7Tr1WijdWRRA/rv6rS2u7y/qAcZEKKApDAb1nRi7tBZCwRophA0ToX53DRPaamPDokw5yngea/D3sjpu8H+LU7G2Q5L6QIBcOhJpDHuJ8VJf7B3hU7LfnmaKQ8wjqI+EoENWL/6No+S5pWmGqDkJKQTbfw6MKqUCQ+m/GaJrnnxNi+3fq160 0kbeQEIX wj1Bn32prfKmDfR/oZl82ZfUeGLqEvd4CwdJnchpdPtLqb+rR5/eGKv/ETQHBpuOGmQtJYbqFzWiwGyT8w4+XunvCUGb8pms6e9ehHclLhwIsWE2JsMQNh91X2RadpwPOsgZaLtd0e3TMWB5Mhtow1GMvZt87C8aRcsXVAVYj+skUUnD0JkrM5tkqKmx32hnOXDZ5nEW1bp8uQSfvke9vmd88sXZQEPMKLeDD X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024/9/28 10:16, Kanchana P Sridhar wrote: > Modify the name of the existing zswap_pool_get() to zswap_pool_tryget() > to be representative of the call it makes to percpu_ref_tryget(). > A subsequent patch will introduce a new zswap_pool_get() that calls > percpu_ref_get(). > > The intent behind this change is for higher level zswap API such as > zswap_store() to call zswap_pool_tryget() to check upfront if the pool's > refcount is "0" (which means it could be getting destroyed) and to handle > this as an error condition. zswap_store() would proceed only if > zswap_pool_tryget() returns success, and any additional pool refcounts that > need to be obtained for compressing sub-pages in a large folio could simply > call zswap_pool_get(). > > Signed-off-by: Kanchana P Sridhar Reviewed-by: Chengming Zhou > --- > mm/zswap.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/mm/zswap.c b/mm/zswap.c > index fd7a8c14457a..0f281e50a034 100644 > --- a/mm/zswap.c > +++ b/mm/zswap.c > @@ -403,7 +403,7 @@ static void __zswap_pool_empty(struct percpu_ref *ref) > spin_unlock_bh(&zswap_pools_lock); > } > > -static int __must_check zswap_pool_get(struct zswap_pool *pool) > +static int __must_check zswap_pool_tryget(struct zswap_pool *pool) > { > if (!pool) > return 0; > @@ -441,7 +441,7 @@ static struct zswap_pool *zswap_pool_current_get(void) > rcu_read_lock(); > > pool = __zswap_pool_current(); > - if (!zswap_pool_get(pool)) > + if (!zswap_pool_tryget(pool)) > pool = NULL; > > rcu_read_unlock(); > @@ -462,7 +462,7 @@ static struct zswap_pool *zswap_pool_find_get(char *type, char *compressor) > if (strcmp(zpool_get_type(pool->zpool), type)) > continue; > /* if we can't get it, it's about to be destroyed */ > - if (!zswap_pool_get(pool)) > + if (!zswap_pool_tryget(pool)) > continue; > return pool; > }