From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EC667C02181 for ; Mon, 20 Jan 2025 16:15:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 745F36B0083; Mon, 20 Jan 2025 11:15:35 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 6F5FD6B0085; Mon, 20 Jan 2025 11:15:35 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5BCCC6B0088; Mon, 20 Jan 2025 11:15:35 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 400DF6B0083 for ; Mon, 20 Jan 2025 11:15:35 -0500 (EST) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id E23DE437A7 for ; Mon, 20 Jan 2025 16:15:34 +0000 (UTC) X-FDA: 83028330588.14.C653CD1 Received: from shelob.surriel.com (shelob.surriel.com [96.67.55.147]) by imf10.hostedemail.com (Postfix) with ESMTP id AB42AC001B for ; Mon, 20 Jan 2025 16:15:32 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=none; spf=pass (imf10.hostedemail.com: domain of riel@shelob.surriel.com designates 96.67.55.147 as permitted sender) smtp.mailfrom=riel@shelob.surriel.com; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1737389732; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=SOd9di4mKcr4upVdN+Ya+wn6PSLEjexXsJ4eVdpNqpE=; b=eSPNNDchK/zvNt3R7Ifvg+hshwrvJIIdwXRi3cXDd4G7HdVOKnOflPM3iw6WaRNq+FXvWr xEYpg87i2nrdNX1uOMRYSIFgRv/QzUCVmKpkTu5f62Jj2F1PyTys6moiPOXGtwVOFDbyUN QafWG8jbDfr56bCg5hbVt4caz/hfMmE= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=none; spf=pass (imf10.hostedemail.com: domain of riel@shelob.surriel.com designates 96.67.55.147 as permitted sender) smtp.mailfrom=riel@shelob.surriel.com; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1737389732; a=rsa-sha256; cv=none; b=hVUCrTINEMMh7nu+4Qb2JiH42FXP92DKm9zccgL4aUMWzdKCTSjHG70ECsXyMMpcXqUm5l icquVIdQLCLVZU6srylRI4JqC2qyoXhTL2gfkAMB7AkwPZJV4iqQWw5inAooCSIb/KdURB 0bjCtoqpuy2GfJWnKPhAra6UqF60bbk= Received: from fangorn.home.surriel.com ([10.0.13.7]) by shelob.surriel.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.97.1) (envelope-from ) id 1tZuMo-00000000109-2o0p; Mon, 20 Jan 2025 11:11:10 -0500 Message-ID: <2c93b3f17e658483e3ea03ca3f0a717668fd117d.camel@surriel.com> Subject: Re: [PATCH v5 10/12] x86,tlb: do targeted broadcast flushing from tlbbatch code From: Rik van Riel To: Nadav Amit , x86@kernel.org Cc: linux-kernel@vger.kernel.org, bp@alien8.de, peterz@infradead.org, dave.hansen@linux.intel.com, zhengqi.arch@bytedance.com, thomas.lendacky@amd.com, kernel-team@meta.com, linux-mm@kvack.org, akpm@linux-foundation.org, jannh@google.com, mhklinux@outlook.com, andrew.cooper3@citrix.com Date: Mon, 20 Jan 2025 11:11:10 -0500 In-Reply-To: <2975f6a4-58ef-4499-b177-4b73ead4c670@gmail.com> References: <20250116023127.1531583-1-riel@surriel.com> <20250116023127.1531583-11-riel@surriel.com> <13bc0c49-09a4-434e-bd35-1ea50be38e25@gmail.com> <4dcf2b4ecaede883e2c7f6af3db58a4f6afaf4ad.camel@surriel.com> <2975f6a4-58ef-4499-b177-4b73ead4c670@gmail.com> Autocrypt: addr=riel@surriel.com; prefer-encrypt=mutual; keydata=mQENBFIt3aUBCADCK0LicyCYyMa0E1lodCDUBf6G+6C5UXKG1jEYwQu49cc/gUBTTk33A eo2hjn4JinVaPF3zfZprnKMEGGv4dHvEOCPWiNhlz5RtqH3SKJllq2dpeMS9RqbMvDA36rlJIIo47 Z/nl6IA8MDhSqyqdnTY8z7LnQHqq16jAqwo7Ll9qALXz4yG1ZdSCmo80VPetBZZPw7WMjo+1hByv/ lvdFnLfiQ52tayuuC1r9x2qZ/SYWd2M4p/f5CLmvG9UcnkbYFsKWz8bwOBWKg1PQcaYHLx06sHGdY dIDaeVvkIfMFwAprSo5EFU+aes2VB2ZjugOTbkkW2aPSWTRsBhPHhV6dABEBAAG0HlJpayB2YW4gU mllbCA8cmllbEByZWRoYXQuY29tPokBHwQwAQIACQUCW5LcVgIdIAAKCRDOed6ShMTeg05SB/986o gEgdq4byrtaBQKFg5LWfd8e+h+QzLOg/T8mSS3dJzFXe5JBOfvYg7Bj47xXi9I5sM+I9Lu9+1XVb/ r2rGJrU1DwA09TnmyFtK76bgMF0sBEh1ECILYNQTEIemzNFwOWLZZlEhZFRJsZyX+mtEp/WQIygHV WjwuP69VJw+fPQvLOGn4j8W9QXuvhha7u1QJ7mYx4dLGHrZlHdwDsqpvWsW+3rsIqs1BBe5/Itz9o 6y9gLNtQzwmSDioV8KhF85VmYInslhv5tUtMEppfdTLyX4SUKh8ftNIVmH9mXyRCZclSoa6IMd635 Jq1Pj2/Lp64tOzSvN5Y9zaiCc5FucXtB9SaWsgdmFuIFJpZWwgPHJpZWxAc3VycmllbC5jb20+iQE +BBMBAgAoBQJSLd2lAhsjBQkSzAMABgsJCAcDAgYVCAIJCgsEFgIDAQIeAQIXgAAKCRDOed6ShMTe g4PpB/0ZivKYFt0LaB22ssWUrBoeNWCP1NY/lkq2QbPhR3agLB7ZXI97PF2z/5QD9Fuy/FD/jddPx KRTvFCtHcEzTOcFjBmf52uqgt3U40H9GM++0IM0yHusd9EzlaWsbp09vsAV2DwdqS69x9RPbvE/Ne fO5subhocH76okcF/aQiQ+oj2j6LJZGBJBVigOHg+4zyzdDgKM+jp0bvDI51KQ4XfxV593OhvkS3z 3FPx0CE7l62WhWrieHyBblqvkTYgJ6dq4bsYpqxxGJOkQ47WpEUx6onH+rImWmPJbSYGhwBzTo0Mm G1Nb1qGPG+mTrSmJjDRxrwf1zjmYqQreWVSFEt26tBpSaWsgdmFuIFJpZWwgPHJpZWxAZmIuY29tP okBPgQTAQIAKAUCW5LbiAIbIwUJEswDAAYLCQgHAwIGFQgCCQoLBBYCAwECHgECF4AACgkQznneko TE3oOUEQgAsrGxjTC1bGtZyuvyQPcXclap11Ogib6rQywGYu6/Mnkbd6hbyY3wpdyQii/cas2S44N cQj8HkGv91JLVE24/Wt0gITPCH3rLVJJDGQxprHTVDs1t1RAbsbp0XTksZPCNWDGYIBo2aHDwErhI omYQ0Xluo1WBtH/UmHgirHvclsou1Ks9jyTxiPyUKRfae7GNOFiX99+ZlB27P3t8CjtSO831Ij0Ip QrfooZ21YVlUKw0Wy6Ll8EyefyrEYSh8KTm8dQj4O7xxvdg865TLeLpho5PwDRF+/mR3qi8CdGbkE c4pYZQO8UDXUN4S+pe0aTeTqlYw8rRHWF9TnvtpcNzZw== Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.54.1 (3.54.1-1.fc41) MIME-Version: 1.0 X-Rspam-User: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: AB42AC001B X-Stat-Signature: rmq3s94rts3s8jbihfke7uf7b8ywjsnb X-HE-Tag: 1737389732-780184 X-HE-Meta: U2FsdGVkX19QWrSm2GSzbuU2rM2fqcpi98tKvraioDpJpC5e/RECHLe5k5D78j9cPkdcacLdKD8lBAHR9Oq2/9+ySOBMj/vjoISff6kwCEip0atkDK3FYnTmbtEA0vCOkLFGDCjHacNO/52EdZTwxFwbcfoFDnXpWOVBoi0liM8jcM9fcBedyoYh+WY3ztINhRKSnQaua3+mvQYy6sT9S5otzhutjkeLPmRsRkvuyCmcweHWiByHtJauiObDwB1VAHdfkjoKl11Nn40LfI8iRplHrrncjAIajy+kNk/MKiRHAV7wGxibBTJ7zvDkqPxDFbdASZvo1L2dtA+2Yno8E7fprkd0bECGoz+fa4XbUGvUmtdZsbzdJoeRqEUxwgaO9cWLBZDuGHj9tSBYsQfQJTJoZits3Q6Syfv4p8aJZmQn93dRpPXIfa/9e1hsFoSPQJ27gsOUKUQUj9f6e+TW6XLKUWfcdaF6ZIZwJdc1AcbA9qsgG38+m8AA40nuLds67cr1WneMhZLQpcuMlM1h/DjlEttCXQlUrC6xgWSAMckM7gemJ9YtJi7WL4cl6Bl8vtkPWb7g5jRUfx193B5AYIplMfgy1WglQ+gfBRazBlBrHoaGMWEWQo7UAmBb8zmUNgbIsfTB2k9LHi3bzjx8bwYbU+vBEMuG9IHi0HoqLi4Ivg2F+fN4XOWCt9Vo8hYCKmGFewoef24eaQMzlZFEZmPJt+EiVxuzQYmcdtlNMTK8cECZ+Cp2WilgFJWXp+6FfttCpBOtwckfiBgWjMc9IjCbxJ15pKT+pfKByG9/wGPsbbq88dVWzd+E9chwHoUVVArnjHJROZLiIUv9839Bd9UqnX/v3mUo0v4F8btgxl+gLYlqw492928jZwAr/rAAQtCVuIREV9Jw8MrVRwZEF4Wfm+fHl00oFnCuDdjk6+bXVYeMbaz6HZARfPs7OWZAxUAdLlDNx0U3oKN+GRn xcJivoO7 f3d8UFRHF1r9xMXEedLPCh77YCPowI57ZI33ehFfL5HkPVUMSCGCRAetV0fbq81K3loTmcUBGskjeIoTTCP91cObEbmBIMTSAFVEYsRiX4PlSss8MnzXeXCmvd80KRytvAzNqQgOgPvpDslxkhZJboM5Ok+5qMLimX/RhEoDQiJePcid4du9zcZnQIqsCVTA2EbvxVdyuQnmZ6/Rbn11xUtgu5yChI3AnOVd0np3xzEkihnuwLhfCVoLOXgsGbvWeaT58wNrAWGwAMkHrZ9rKZQ1rEIbm62/X0vAr7a9kNKz4LL5Q6YU37zLk7EMNDXNvODRp6pu64zPfsvG1a/znD32fvg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000014, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, 2025-01-20 at 16:14 +0200, Nadav Amit wrote: >=20 > I am not sure we are on the same page. What I suggested is: >=20 > 1. arch_tlbbatch_flush() would still do tlbsync() > 2. No migrate_enable() in arch_tlbbatch_flush() > 3. No migrate_disable() in arch_tlbbatch_add_pending() > 4. arch_tlbbatch_add_pending() sets > cpu_tlbstate.pending_tlb_broadcast > 5. switch_mm_irqs_off() checks cpu_tlbstate.pending_tlb_broadcast and > if=20 > it is set performs tlbsync and clears it. >=20 How does that synchronize the page freeing (from page reclaim) with the TLBSYNCs? What guarantees that the page reclaim path won't free the pages until after TLBSYNC has completed on the CPUs that kicked off asynchronous flushes with INVPLGB? --=20 All Rights Reversed.