From: "Arnd Bergmann" <arnd@arndb.de>
To: "Niklas Schnelle" <schnelle@linux.ibm.com>,
"Baoquan He" <bhe@redhat.com>,
linux-kernel@vger.kernel.org
Cc: linux-mm@kvack.org, linux-s390@vger.kernel.org,
"Dominik Brodowski" <linux@dominikbrodowski.net>,
"Jonathan Cameron" <Jonathan.Cameron@huawei.com>,
"Linus Walleij" <linus.walleij@linaro.org>,
"Thomas Bogendoerfer" <tsbogend@alpha.franken.de>
Subject: Re: [PATCH 1/2] pcmcia : make PCMCIA depend on HAS_IOMEM
Date: Thu, 16 Feb 2023 10:37:03 +0100 [thread overview]
Message-ID: <2c8d97ad-126d-4912-b4eb-37437d8c3407@app.fastmail.com> (raw)
In-Reply-To: <4f98164406cfd6da084f9ef617a6668dc4e8d44b.camel@linux.ibm.com>
On Thu, Feb 16, 2023, at 10:05, Niklas Schnelle wrote:
> On Thu, 2023-02-16 at 15:34 +0800, Baoquan He wrote:
>> diff --git a/drivers/pcmcia/Kconfig b/drivers/pcmcia/Kconfig
>> index 1525023e49b6..7c412bbe8bbe 100644
>> --- a/drivers/pcmcia/Kconfig
>> +++ b/drivers/pcmcia/Kconfig
>> @@ -20,6 +20,7 @@ if PCCARD
>>
>> config PCMCIA
>> tristate "16-bit PCMCIA support"
>> + depends on HAS_IOMEM
>> select CRC32
>> default y
>> help
>
> Not sure how many PCMCIA drivers only use I/O memory but not I/O ports
> the latter of which are badly stubbed out on s390, though at leat they
> compile. I have a series on that part that I intend to send a new
> version for soon™. That said yes this does solve the compilation issue
> and there could be drivers which rely only on I/O memory and are not
> broken in principle.
There are no platforms that have I/O ports but don't set HAS_IOMEM, so it
doesn't really matter.
> Reviewed-by: Niklas Schnelle <schnelle@linux.ibm.com>
Acked-by: Arnd Bergmann <arnd@arndb.de>
prev parent reply other threads:[~2023-02-16 9:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-16 7:34 Baoquan He
2023-02-16 7:34 ` [PATCH 2/2] dmaengine: make QCOM_HIDMA " Baoquan He
2023-02-16 9:06 ` Niklas Schnelle
2023-02-16 9:05 ` [PATCH 1/2] pcmcia : make PCMCIA " Niklas Schnelle
2023-02-16 9:37 ` Arnd Bergmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2c8d97ad-126d-4912-b4eb-37437d8c3407@app.fastmail.com \
--to=arnd@arndb.de \
--cc=Jonathan.Cameron@huawei.com \
--cc=bhe@redhat.com \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux@dominikbrodowski.net \
--cc=schnelle@linux.ibm.com \
--cc=tsbogend@alpha.franken.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox