From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EBBDFC021B2 for ; Sat, 22 Feb 2025 04:00:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 69AEF6B0083; Fri, 21 Feb 2025 23:00:03 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 64A6C6B0085; Fri, 21 Feb 2025 23:00:03 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5399B6B0088; Fri, 21 Feb 2025 23:00:03 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 34FE16B0083 for ; Fri, 21 Feb 2025 23:00:03 -0500 (EST) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id B46EF1A0261 for ; Sat, 22 Feb 2025 04:00:02 +0000 (UTC) X-FDA: 83146227444.03.2BB2429 Received: from szxga05-in.huawei.com (szxga05-in.huawei.com [45.249.212.191]) by imf30.hostedemail.com (Postfix) with ESMTP id 8BE5F80005 for ; Sat, 22 Feb 2025 03:59:59 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf30.hostedemail.com: domain of mawupeng1@huawei.com designates 45.249.212.191 as permitted sender) smtp.mailfrom=mawupeng1@huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740196801; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1onRk4K7NkJCVcERJR+VZExUPJnf8vrOF+vE26/WLW0=; b=FPM9XR3VrqFf6GWHrJHctZbUV6vN1E9q+KLMOVsNTcI8rFOwsP8vBjgKsHMe2KfDnXBoDi ClSua93Tfd+xGZHSd41VEc/vIrDLLrLzTJ52EaITJymoq5ZZ1tbfg7FgYtv+ni5uI/SI99 Pt2zFxIsMkfolYYM5sH/EtKKoQzmX+w= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf30.hostedemail.com: domain of mawupeng1@huawei.com designates 45.249.212.191 as permitted sender) smtp.mailfrom=mawupeng1@huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740196801; a=rsa-sha256; cv=none; b=C6txP5fHb6Ru1S8w+LonFz5k/F9+adeBDlMxJVqphSwgZX0HjWMxhxYFDwVCNdB9ub95mn k/qU0AfMVPZuCVIvMEkEE+MrTc+Ptqf+SLuPUTBI7Rs28E10+D+t8JkdEye7yLp/0+pyJ3 8x3fWBshqsJYPm+Ig3GFW9rHQTxj+YE= Received: from mail.maildlp.com (unknown [172.19.162.112]) by szxga05-in.huawei.com (SkyGuard) with ESMTP id 4Z0CsB0Jllz1PGhX; Sat, 22 Feb 2025 11:58:22 +0800 (CST) Received: from kwepemg100017.china.huawei.com (unknown [7.202.181.58]) by mail.maildlp.com (Postfix) with ESMTPS id 219D714051A; Sat, 22 Feb 2025 11:59:55 +0800 (CST) Received: from [10.174.178.114] (10.174.178.114) by kwepemg100017.china.huawei.com (7.202.181.58) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Sat, 22 Feb 2025 11:59:54 +0800 Message-ID: <2c7dfa44-266a-4aa6-9401-7528368f171e@huawei.com> Date: Sat, 22 Feb 2025 11:59:53 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird CC: , , , , , , , , , , , Subject: Re: [PATCH] mm: swap: Avoid infinite loop if no valid swap entry found during do_swap_page To: References: <20250222024617.2790609-1-mawupeng1@huawei.com> From: mawupeng In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.178.114] X-ClientProxiedBy: dggems705-chm.china.huawei.com (10.3.19.182) To kwepemg100017.china.huawei.com (7.202.181.58) X-Rspam-User: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 8BE5F80005 X-Stat-Signature: qos5x1afkwctyyq8t9ytnyu1nyah7ogk X-HE-Tag: 1740196799-38416 X-HE-Meta: U2FsdGVkX1/haUVMHw+xc3nuU/h0r3CO3ab7M560aHK4YTV7G+DlqWVxncWht6e75FKl10MR+G99X3NNMeI+OJq5knzFvhUYOSNZrz8UsAXrSpxpDPXQerBow3Oubv2IxdIMUmzhD92fstI10nuU3inyK3mWNVqCSMwLpmHwMxBens/6itBNyKSN4fv0cGeOvvtM3QLJfBxoNsRpTMBbFRVmJ8SXD7HPLlauUa4tLrVjKTmdFL+QwGV7HnEhjLcCXK7925hmBF4nWmLcPnZlUCHlAfKImcNQLkjWdhZ9B8svrzAS2szDne4KQoou73eMIbUvs2jmTOOjDRUWiZ8fXeX2JQkllatoe9LooeUVLiszP6GpSni9Cvd70Pd7qfMmh8oZ/mNSeVv/JyV1PVIw5frIEVhIQes0KBPDP9LnCHykuvbgp8AO7jU9GQrm2eJLglbVfzzaOTk6my5rFC0BUSvdXS2Kyaw+5XhgPgnFkuXRQeFsHEwvD+dwvgqtSjN5w5DgDTxEKwWm/bal1HFnI3rdX2iq6sVMeC0qr5pbFwSgr94xRc2ewOPKDAnctAThm1Sunlmz0d7FsEB2J96kGLGNBkelKEGjEXIjdCXQ9hhDYHa/dM6V8m5KshJCTfck1g9cwVa5Ox50sG6DHSUeFut1vivfNCe/n0bxRImRIMfYRZbkf/wct7Qo1zqEHGCHeU+Aiz0wcqdsavT9cYZP4DnW/EZVLuCZMtzm2fOfQqMJrgNZqdYrDngnwCY4y7fBv2ODIAHXGWkiHlCKpGlbYfIcEUiYn0QjuMFv9AoCTeI99McrPpJvkpMp2eibm/Io/XNGFcP34bFYtD3m5Ui9fMKB7tJ4KQs2Av9twuIpBNyYgRpX79RvqNkhoHycuUizcXdodU2bSCX9V+yo81rMRD9gCHDNj1C022B4KRS/pag+w28+ljGN+4y3LkeU/4UTsFIfKO911DN8cGjW3nr ef0ULZjb yivWic1kSZ52KtAr3rpGP9XBszgRVYywr0qga5jhSLy/bS80a8rAradcUsvgo+rFSzL5kz4JxiljNtxki/rJ+CWtjww5WS3sCGGkO2/eBYWOjCeDJwEapDayFHLr+Q1Osp52iLaxTzZAvvFBu3I2tKAklUwpAEWasVLLw9Ykke3R1WUNYx5+iZMAz6PVmjxg1jPnpDH3VxsgHFz1QQOgxO97GLEuzLriqK5PQqsd0CASDUiv0L/bp+19RjSn9bPZVlmygrOkjU7KP6JQdj1BWWUKQPgRuhMRSgaWw X-Bogosity: Ham, tests=bogofilter, spamicity=0.016699, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2025/2/22 11:45, Matthew Wilcox wrote: > On Sat, Feb 22, 2025 at 10:46:17AM +0800, Wupeng Ma wrote: >> Digging into the source, we found that the swap entry is invalid due to >> unknown reason, and this lead to invalid swap_info_struct. Excessive log >> printing can fill up the prioritized log space, leading to the purging of >> originally valid logs and hindering problem troubleshooting. To make this >> more robust, kill this task. > > this seems like a very bad way to fix this problem Sure, It's a bad way to fix this. Just a proper way to make it more robust? Since it will produce lots of invalid and same log? >