From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CB19EC369D5 for ; Mon, 28 Apr 2025 13:32:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 397D16B00AD; Mon, 28 Apr 2025 09:32:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3464A6B00AE; Mon, 28 Apr 2025 09:32:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 20FA36B00AF; Mon, 28 Apr 2025 09:32:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 0024D6B00AD for ; Mon, 28 Apr 2025 09:32:03 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 9D622B5A9F for ; Mon, 28 Apr 2025 13:32:04 +0000 (UTC) X-FDA: 83383540968.04.C624287 Received: from out-177.mta0.migadu.com (out-177.mta0.migadu.com [91.218.175.177]) by imf07.hostedemail.com (Postfix) with ESMTP id 92A8340012 for ; Mon, 28 Apr 2025 13:32:02 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=Lf9J4TLd; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf07.hostedemail.com: domain of lance.yang@linux.dev designates 91.218.175.177 as permitted sender) smtp.mailfrom=lance.yang@linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1745847123; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=1I1m/NMRedzmoEPaCinaZP4GnU/mr3udTbmFVWL9GKc=; b=yOOvWHhldGPr4KNJT6f1Z6FphBOi3Py25Vlzv4bzVdpuUby7wa5YS/7iCRKLvONRMVt7Pj JjkSKD7LK662jHzGw1nS1QniYESbpFiN2nnxAaLH5cXlIXflDtJfWWbxKbXudsCxfHiPY8 ly0+E1EZkl6eM7/rexzpwTg24ZundgI= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1745847123; a=rsa-sha256; cv=none; b=vDeJLik95zh37t6qsXgln3UnsdbOlZd2xB51nwJUcQzCEo7sg++3g9vTtNRo9qqtTtiOY8 znY3ged2vzKiAoeAY4hMs+kEcX70MuxFiI8PP/ken9hX4jUBDXSfomuPhu6jxCXd28/1sR sBvS9xHRsS07Snqb2Nu4hb4+WeJ57Ig= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=Lf9J4TLd; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf07.hostedemail.com: domain of lance.yang@linux.dev designates 91.218.175.177 as permitted sender) smtp.mailfrom=lance.yang@linux.dev Message-ID: <2c70d515-f02e-477a-afc5-d3a25f6c9c0d@linux.dev> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1745847120; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1I1m/NMRedzmoEPaCinaZP4GnU/mr3udTbmFVWL9GKc=; b=Lf9J4TLdsEL7qv8tRkyxqwiS2Mw9EzoicQ9mUKrPz/9krGq7uE4l+FoLo/dfhvmzEJc7fM QtCdib57F8JZyzFQz9LA46XNFAA9ff00znw8ix8cwaIvQEZ9a98oRTz79TZeqPNdii253h UhnJw+hpU0rcz3+blGmfL5Wg0DM6Tyg= Date: Mon, 28 Apr 2025 21:31:40 +0800 MIME-Version: 1.0 Subject: Re: [PATCH 0/7] Optimize mprotect for large folios Content-Language: en-US To: Dev Jain , akpm@linux-foundation.org Cc: ryan.roberts@arm.com, david@redhat.com, willy@infradead.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, catalin.marinas@arm.com, will@kernel.org, Liam.Howlett@oracle.com, lorenzo.stoakes@oracle.com, vbabka@suse.cz, jannh@google.com, anshuman.khandual@arm.com, peterx@redhat.com, joey.gouly@arm.com, ioworker0@gmail.com, baohua@kernel.org, kevin.brodsky@arm.com, quic_zhenhuah@quicinc.com, christophe.leroy@csgroup.eu, yangyicong@hisilicon.com, linux-arm-kernel@lists.infradead.org, namit@vmware.com, hughd@google.com, yang@os.amperecomputing.com, ziy@nvidia.com References: <20250428120414.12101-1-dev.jain@arm.com> X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Lance Yang In-Reply-To: <20250428120414.12101-1-dev.jain@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 92A8340012 X-Rspam-User: X-Stat-Signature: dinnqmxw5jwnjbpgza3u1t8si18pauua X-HE-Tag: 1745847122-316217 X-HE-Meta: U2FsdGVkX198OgmFx+0Vtzyo90Q1IRHtUwZeD8+k2oc3swr/Px7Kn1mPRs83dlVCIz0UTHsBP3fe0SUgj8+xRumfXgBAIzuX9NJxng8ZCTrXNaNk0Qcv1uop5j+/TOmNlJEaGDpvWn9nXeajr4AHffA3V+VnyJYi1aQbe0rngO3opE35PKTBTm0somTclPe0mcH951b9NJ6670sfIdOnnKGhG3DqASiOIYvEfYYlITGzhpKlH7uAWqx2cfnJIEy07rErCZS0wrtLtYBVGp2pGPVMA5o9D5EqBYq2fJ0aNxQt8FauihByDyQhnIRtnPTApWVAk+C3aH1d9D07OXs6Wr06Zv6EkRxTRAVPt69IYhm8amWrXTpi/s/TAmnYoduaoGFgm4y072CJqiqLsGJNmegpCjmPdav78PbhDQr6Sw6685h0dmsT0f54opiTKPH3YN8iI1MP1+0Ehqf/fVNmFGVrjxJCKcUUDxgOBe3aVDOYmfVVbc0yda9R9ix5/zG8a/RVmoEKijXLXZh1PRwy6b+dnxzX5r/4soCM+h8JMx/QQoP1zD6QtfPb405bbGA6iKtfVBeqZBitj8GaVgImPWKbhm8YT1fsq+ZjSL7s68JKJ/6HS8MklIQcYv/wNFj8I0/HHuxk3dMF5ci0v0gJm3KtJGfp9VCVGolEZPa56z22F3dcYFqltulVud1xcFjkQ8iwAYpDzcZSqIN4XXFNst69Vwbge9jUWlz0viuamSUOSeSXQ11PJtlsfL0AEKNXtoWYwN0Hot+IrUwoWLewSRaR0oLZTJCJO9YnyX3RbzQDpUGHssYz6SLx8ls76vdmQsMwOkcWN3fMNrWjqfG7Gh2/DlVX4k5PAZcPKK+5Wq72bKg5ZpZlfQfkVvecLDyC6sQ2EQlsulJwygzyJZRWWDgYaoIeHQkol5ah4PVYWbLg610Ge0MTeffDy4tY4+AVL6v8X2F8GouQezK+K8L EISkW0td 56QQ7e4lG3bYo63fJK7/8vdpHMd5+2ONc9Ts1Vt9JlnrMCwJU7WvwuzVZC9QtZc8DeEoD3bcIpUcASObebdj7fxkCl8HM2i7kxvfvFkZEZgNxsrRie6NEuhyTf4Qe6WRv4i9yrCnr5dia0GUi0o5WM3fLwl6QUylVmpn6x0MsoWftt5Ij4JyH99jp+AuHdp3ZDXaCJy2wdVD4AWaJFHRUKW3Mpg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: I'm hitting the following compilation errors after applying this patch series: In file included from ./include/linux/kasan.h:37, from ./include/linux/slab.h:260, from ./include/linux/crypto.h:19, from arch/x86/kernel/asm-offsets.c:9: ./include/linux/pgtable.h: In function ‘modify_prot_start_ptes’: ./include/linux/pgtable.h:905:15: error: implicit declaration of function ‘ptep_modify_prot_start’ [-Werror=implicit-function-declaration] 905 | pte = ptep_modify_prot_start(vma, addr, ptep); | ^~~~~~~~~~~~~~~~~~~~~~ ./include/linux/pgtable.h:905:15: error: incompatible types when assigning to type ‘pte_t’ from type ‘int’ ./include/linux/pgtable.h:909:27: error: incompatible types when assigning to type ‘pte_t’ from type ‘int’ 909 | tmp_pte = ptep_modify_prot_start(vma, addr, ptep); | ^~~~~~~~~~~~~~~~~~~~~~ ./include/linux/pgtable.h: In function ‘modify_prot_commit_ptes’: ./include/linux/pgtable.h:925:17: error: implicit declaration of function ‘ptep_modify_prot_commit’ [-Werror=implicit-function-declaration] 925 | ptep_modify_prot_commit(vma, addr, ptep, old_pte, pte); | ^~~~~~~~~~~~~~~~~~~~~~~ ./include/linux/pgtable.h: At top level: ./include/linux/pgtable.h:1360:21: error: conflicting types for ‘ptep_modify_prot_start’; have ‘pte_t(struct vm_area_struct *, long unsigned int, pte_t *)’ 1360 | static inline pte_t ptep_modify_prot_start(struct vm_area_struct *vma, | ^~~~~~~~~~~~~~~~~~~~~~ ./include/linux/pgtable.h:905:15: note: previous implicit declaration of ‘ptep_modify_prot_start’ with type ‘int()’ 905 | pte = ptep_modify_prot_start(vma, addr, ptep); | ^~~~~~~~~~~~~~~~~~~~~~ ./include/linux/pgtable.h:1371:20: warning: conflicting types for ‘ptep_modify_prot_commit’; have ‘void(struct vm_area_struct *, long unsigned int, pte_t *, pte_t, pte_t)’ 1371 | static inline void ptep_modify_prot_commit(struct vm_area_struct *vma, | ^~~~~~~~~~~~~~~~~~~~~~~ ./include/linux/pgtable.h:1371:20: error: static declaration of ‘ptep_modify_prot_commit’ follows non-static declaration ./include/linux/pgtable.h:925:17: note: previous implicit declaration of ‘ptep_modify_prot_commit’ with type ‘void(struct vm_area_struct *, long unsigned int, pte_t *, pte_t, pte_t)’ 925 | ptep_modify_prot_commit(vma, addr, ptep, old_pte, pte); | ^~~~~~~~~~~~~~~~~~~~~~~ cc1: some warnings being treated as errors make[2]: *** [scripts/Makefile.build:98: arch/x86/kernel/asm-offsets.s] Error 1 make[1]: *** [/home/runner/work/mm-test-robot/mm-test-robot/linux/Makefile:1280: prepare0] Error 2 make: *** [Makefile:248: __sub-make] Error 2 Based on: mm-unstable b18dec6a6ad3d051dadc3c16fb838e4abddf8d3c ("mm/numa: remove unnecessary local variable in alloc_node_data()") Thanks, Lance On 2025/4/28 20:04, Dev Jain wrote: > This patchset optimizes the mprotect() system call for large folios > by PTE-batching. > > We use the following test cases to measure performance, mprotect()'ing > the mapped memory to read-only then read-write 40 times: > > Test case 1: Mapping 1G of memory, touching it to get PMD-THPs, then > pte-mapping those THPs > Test case 2: Mapping 1G of memory with 64K mTHPs > Test case 3: Mapping 1G of memory with 4K pages > > Average execution time on arm64, Apple M3: > Before the patchset: > T1: 7.9 seconds T2: 7.9 seconds T3: 4.2 seconds > > After the patchset: > T1: 2.1 seconds T2: 2.2 seconds T3: 4.2 seconds > > Observing T1/T2 and T3 before the patchset, we also remove the regression > introduced by ptep_get() on a contpte block. And, for large folios we get > an almost 276% performance improvement. > > Dev Jain (7): > mm: Refactor code in mprotect > mm: Optimize mprotect() by batch-skipping PTEs > mm: Add batched versions of ptep_modify_prot_start/commit > arm64: Add batched version of ptep_modify_prot_start > arm64: Add batched version of ptep_modify_prot_commit > mm: Batch around can_change_pte_writable() > mm: Optimize mprotect() through PTE-batching > > arch/arm64/include/asm/pgtable.h | 10 ++ > arch/arm64/mm/mmu.c | 21 +++- > include/linux/mm.h | 4 +- > include/linux/pgtable.h | 42 ++++++++ > mm/gup.c | 2 +- > mm/huge_memory.c | 4 +- > mm/memory.c | 6 +- > mm/mprotect.c | 163 +++++++++++++++++++++---------- > mm/pgtable-generic.c | 16 ++- > 9 files changed, 198 insertions(+), 70 deletions(-) >