From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0BE8DE7849A for ; Mon, 2 Oct 2023 06:47:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 71A278D0003; Mon, 2 Oct 2023 02:47:34 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6A3A88D0001; Mon, 2 Oct 2023 02:47:34 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 544B68D0003; Mon, 2 Oct 2023 02:47:34 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 405F98D0001 for ; Mon, 2 Oct 2023 02:47:34 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id C863680145 for ; Mon, 2 Oct 2023 06:47:33 +0000 (UTC) X-FDA: 81299590386.25.D7928A3 Received: from mail-lf1-f42.google.com (mail-lf1-f42.google.com [209.85.167.42]) by imf25.hostedemail.com (Postfix) with ESMTP id D53CEA000E for ; Mon, 2 Oct 2023 06:47:31 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=EnqxY5vN; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf25.hostedemail.com: domain of lstoakes@gmail.com designates 209.85.167.42 as permitted sender) smtp.mailfrom=lstoakes@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1696229252; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=p3BqCO4mWF10nilDa/c4wHmj/s6v9lbe+j6TGDexzDI=; b=e76QgOfpf5St33ECpsRDCCqbzV6iN/ow0EtpQOze2VsbDdXHseQMtk7aNVU7B9VZPmahvn VvbmeHsTWc9JadBhVaPdvC8x4dm0K0YrqeIx7gWLvrwcIqp6c2Cc8icCgOYba39M3armrk RLfWEmvyiDWIIBpU0y9NUjAwZQrp5Dw= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=EnqxY5vN; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf25.hostedemail.com: domain of lstoakes@gmail.com designates 209.85.167.42 as permitted sender) smtp.mailfrom=lstoakes@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1696229252; a=rsa-sha256; cv=none; b=gTRkfKCSlswKGwf0uEKAsHUZbotA0m9aqScsAoS5vZ11hLnvkX/pT8LfdYqSSrEYTG28XE k2v3oe//0l5ISAHvIt13hhHgPwVpykpgZQypjct0VS2j9EZfh61bPdu6zG/jlWZ3WfB8D2 aOW5m3gUdvYvbIilBJ7KRFb7ElKTFEw= Received: by mail-lf1-f42.google.com with SMTP id 2adb3069b0e04-503f39d3236so24831706e87.0 for ; Sun, 01 Oct 2023 23:47:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1696229250; x=1696834050; darn=kvack.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=p3BqCO4mWF10nilDa/c4wHmj/s6v9lbe+j6TGDexzDI=; b=EnqxY5vNO8P+FWO7fzBDJv1HyeZxYyo7Ru0ft49pInm6JaZQZvHWB3+VlD8XdDgdQi KffNpGTHZfuE7TvJ8VsHH3hdg5v/mFpW34H3EbEUa1iht6w3+d4DmnpyyN6qZguUI6Vd w1Zp/zs0r69oim0pOPDftYAbHsvDpWS4RE09OeoxNi34jmsUaS8BSCLB5SYBZQi4c0sx Tgxri+rBt9WBn9BC1okusnG/jhYMTgf5E8dSWznmSyiZCN8Q5zzocXtDcti9CXCQLo/D XMuvDMERwzQmpzhjNCCeD8iDSrJKwM5w5FVFnNYWr6e057xUN01MtECgG/Zzr557XSQY Oy/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696229250; x=1696834050; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=p3BqCO4mWF10nilDa/c4wHmj/s6v9lbe+j6TGDexzDI=; b=uRNOl+bKfkhUlhzuej4xke/LF98mZ/N6nbtVPhdHHchNhhHbYWQSBjRykegpAfLYj5 1pgWpxLOSMv1a2SEDfysytp2WeTiwe4PANFj/RiyvqbQ3r8j/6WbCHxmImH7tF/gnF66 zXI3MHZOowOaLmcEad8nOQEeh+O13S6StAzZvBwlTEfFOMwjMriXzdaUEc9y3SLTxGB2 cBkiebTHQmnbI2Nj93e4TiCIgnC2At2YjoPNXt3tEj0r/5KZPNSL41yZueILvleS+42h 6l2OoWpjIG106ztx0FjsKrW5bvoWpawILRIQ9IFka1DmZ4jcwANyXmRrM9oE9rCtC63d E/SA== X-Gm-Message-State: AOJu0YxanXCSpe9GEC0axOLyLKmQmhfAANJeq1fhxBn0yAzu0HIh/h5V /LF7YsjwSNFX+kIiaLArF/s= X-Google-Smtp-Source: AGHT+IHsxKu3Mwdi8HUlGe8r9wq8AQQVFVKf9Si3zNtkB00GPO9m9ZUV3I2Ppi4/1jHfKMNdCpJj0Q== X-Received: by 2002:a05:6512:3e14:b0:500:c128:66d4 with SMTP id i20-20020a0565123e1400b00500c12866d4mr10113631lfv.67.1696229249682; Sun, 01 Oct 2023 23:47:29 -0700 (PDT) Received: from localhost ([2a00:23c5:dc8c:8701:1663:9a35:5a7b:1d76]) by smtp.gmail.com with ESMTPSA id n16-20020a05600c3b9000b003fe29f6b61bsm6623325wms.46.2023.10.01.23.47.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 01 Oct 2023 23:47:28 -0700 (PDT) Date: Mon, 2 Oct 2023 07:47:28 +0100 From: Lorenzo Stoakes To: Christoph Hellwig Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andrew Morton , Matthew Wilcox , Jan Kara Subject: Re: [PATCH] mm/filemap: clarify filemap_fault() comments for not uptodate case Message-ID: <2c7014c0-6343-4e76-8697-3f84f54350bd@lucifer.local> References: <20230930231029.88196-1-lstoakes@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: D53CEA000E X-Stat-Signature: bmx75bc6aepbrr9wf5n6gbyk5tixu9sf X-HE-Tag: 1696229251-201806 X-HE-Meta: U2FsdGVkX1/fdc5Vwzw6ho2VqShACiz4vdFI78KrV1ZJuGPynsgZk30eOdeweyOoMzfDb5opFN29sZTi294I0a8jmNr73ja9OlcR25IwKrRyjAs/oJeUwUHnuCXocgFr4tUwKWONvisAVWtiF6ujhPw0LJkP3yV6Ac5U3T5ScVJxdWxwIKoSCosroq/WTobu3BORZ+zro5vyb+1XGEA6CRm5ONZofWMUlfgrnqGYS9XaNt63TN2GQYahWr+iO1PVMepq2HwAHb+Fg9AVhsH7vcpuCoYdFX5f1i1Phb7YtEuGARvSFxRn9F4lVM3FMVTZDxYixDaAyEznhGGZaiCRgT9/q/KpPZ8yFmWiXD8g1jZiIIRQDeo6uuaxBDof+oL/9RRdHgYGOvh7SbjeVB8cewzMFfTMABpYY3fpJeRywjugB/BmfWPu3xHqXm+fVso9x8z6PkG1OLSYqi3UDlFftSGcyfqATHfU8jeiz49lOVQuToIA4DXiMQMeBitWxkOJsJ8r6N8v5BHY88iFDShAUZWEQBjZCx+KqylD/K3gswZlj0qVZzjc2aIyU0ktAHWXH68NiPFm9ItwjY3zNcMz4OOoUIqzSw2u+FiaO55jeyW72hPAv7sglKz9zf2p60KSsu1cQJcPv3lCVHI28K4t52wMXr9gQXaHquhCzKjqSBq1hZBhUl2+mt8KRwbPNCU7NSX/5OtC/TwlptWJgBpIUa32OhFpnypuh2TZ1yo+te45roXpkKBI1+UhD4/ywHNVp3NrkMq5pPlwU2F9a58ObDT0dLoxECA924mIHZPzsUoI1MwNTN9TuzdfTqU6BthwLAXSTGoiGGj1pizX9q9VlhfC7uNhAZRRB9p4rSecMnjK2kzvSwKzi3etYOuHsJtoolOoYxcKbW3TBqvsQPEGIyQaoAIa9IwfNzIU14FhacV8VmEvstnwdFi3heRifZQ+g8quGMNKbvwdCl+tj6R 85Vk2mq3 KCAhx/hGU9ILBXPoYhfSw+wOn+bP2r3V+3dhxjkZWNoSbGBwe5V01h1fP5zjXa3TSUucJspOYrHksztJTFQYkgdLzsgeTaqvj8U8tzL6ulsSC0VbeAnK0FCpu7FgY6pPCE1E8U/nc6K2rK5+DSaC6p1C511Vgy3V2ixTPohanA/LVU9PD8lyPuwTivDVQJcIP8u8fS2hhS553faslraQXXcBY7AF5ppT731tw+UxPK7XyderpSt/UQ9n5Wux9qNC6uACwgkwiNTzIOJWGM0Eq0ChcdN5/6sTEsBfSvmwllFRM1iYZt9qO7Xkc8olwHwLmndehQE8+g5TqgVVJDS2tHbOGIl+fey6r4TKkShCtttEHsODJeiUY7WZXZBDzsi4HAv4rJJ3Z72EmyIfICNo1jR5VdYjl+jel/2CP9/quPc5kGjCPrMk+UnAaGxQKNz5pz3tNxi3Zh/brNa5qQJ4fJP6Cow== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000072, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, Oct 01, 2023 at 11:26:18PM -0700, Christoph Hellwig wrote: > > + * If the invalidate lock is not held, the folio was in cache and > > + * uptodate and now it is not. Strange but possible since we > > Please don't spill block comments ôver the 80 charater limit, that makes > them impossible to read nicely. > Yup this was because checkpatch ok'd it, I've aliased the strict 80 char param so it won't happen again. Fix patch enclosed ----8<---- >From 3abb740abb67505b6f83d7602f7b4a8dcd29977f Mon Sep 17 00:00:00 2001 From: Lorenzo Stoakes Date: Mon, 2 Oct 2023 07:37:24 +0100 Subject: [PATCH] mm/filemap: clarify filemap_fault() comments for not uptodate case Correct identation as per Christopher's feedback. Signed-off-by: Lorenzo Stoakes --- mm/filemap.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/mm/filemap.c b/mm/filemap.c index 959694a2ade7..951709089f38 100644 --- a/mm/filemap.c +++ b/mm/filemap.c @@ -3314,10 +3314,10 @@ vm_fault_t filemap_fault(struct vm_fault *vmf) */ if (unlikely(!folio_test_uptodate(folio))) { /* - * If the invalidate lock is not held, the folio was in cache and - * uptodate and now it is not. Strange but possible since we - * didn't hold the page lock all the time. Let's drop everything, - * get the invalidate lock and try again. + * If the invalidate lock is not held, the folio was in cache + * and uptodate and now it is not. Strange but possible since we + * didn't hold the page lock all the time. Let's drop + * everything, get the invalidate lock and try again. */ if (!mapping_locked) { folio_unlock(folio); -- 2.42.0