From: Lorenzo Stoakes <lstoakes@gmail.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
Matthew Wilcox <willy@infradead.org>, Jan Kara <jack@suse.cz>
Subject: Re: [PATCH] mm/filemap: clarify filemap_fault() comments for not uptodate case
Date: Mon, 2 Oct 2023 07:47:28 +0100 [thread overview]
Message-ID: <2c7014c0-6343-4e76-8697-3f84f54350bd@lucifer.local> (raw)
In-Reply-To: <ZRpiiq/pUB6hGTl/@infradead.org>
On Sun, Oct 01, 2023 at 11:26:18PM -0700, Christoph Hellwig wrote:
> > + * If the invalidate lock is not held, the folio was in cache and
> > + * uptodate and now it is not. Strange but possible since we
>
> Please don't spill block comments ôver the 80 charater limit, that makes
> them impossible to read nicely.
>
Yup this was because checkpatch ok'd it, I've aliased the strict 80 char param
so it won't happen again.
Fix patch enclosed
----8<----
From 3abb740abb67505b6f83d7602f7b4a8dcd29977f Mon Sep 17 00:00:00 2001
From: Lorenzo Stoakes <lstoakes@gmail.com>
Date: Mon, 2 Oct 2023 07:37:24 +0100
Subject: [PATCH] mm/filemap: clarify filemap_fault() comments for not uptodate case
Correct identation as per Christopher's feedback.
Signed-off-by: Lorenzo Stoakes <lstoakes@gmail.com>
---
mm/filemap.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/mm/filemap.c b/mm/filemap.c
index 959694a2ade7..951709089f38 100644
--- a/mm/filemap.c
+++ b/mm/filemap.c
@@ -3314,10 +3314,10 @@ vm_fault_t filemap_fault(struct vm_fault *vmf)
*/
if (unlikely(!folio_test_uptodate(folio))) {
/*
- * If the invalidate lock is not held, the folio was in cache and
- * uptodate and now it is not. Strange but possible since we
- * didn't hold the page lock all the time. Let's drop everything,
- * get the invalidate lock and try again.
+ * If the invalidate lock is not held, the folio was in cache
+ * and uptodate and now it is not. Strange but possible since we
+ * didn't hold the page lock all the time. Let's drop
+ * everything, get the invalidate lock and try again.
*/
if (!mapping_locked) {
folio_unlock(folio);
--
2.42.0
next prev parent reply other threads:[~2023-10-02 6:47 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-30 23:10 Lorenzo Stoakes
2023-10-02 6:26 ` Christoph Hellwig
2023-10-02 6:39 ` Vlastimil Babka
2023-10-02 9:43 ` Joe Perches
2023-10-02 6:47 ` Lorenzo Stoakes [this message]
2023-10-02 6:50 ` Christoph Hellwig
2023-10-02 9:55 ` Jan Kara
2023-10-02 16:02 ` Matthew Wilcox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2c7014c0-6343-4e76-8697-3f84f54350bd@lucifer.local \
--to=lstoakes@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=hch@infradead.org \
--cc=jack@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox