From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1C0ABC02199 for ; Sat, 8 Feb 2025 03:30:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 680D8280004; Fri, 7 Feb 2025 22:30:49 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 63081280001; Fri, 7 Feb 2025 22:30:49 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4F829280004; Fri, 7 Feb 2025 22:30:49 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 31BC3280001 for ; Fri, 7 Feb 2025 22:30:49 -0500 (EST) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id A4F5F14159D for ; Sat, 8 Feb 2025 03:30:48 +0000 (UTC) X-FDA: 83095350576.08.1C06E77 Received: from 009.lax.mailroute.net (009.lax.mailroute.net [199.89.1.12]) by imf05.hostedemail.com (Postfix) with ESMTP id 8585C100007 for ; Sat, 8 Feb 2025 03:30:46 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=acm.org header.s=mr01 header.b=oUzX2LCC; spf=pass (imf05.hostedemail.com: domain of bvanassche@acm.org designates 199.89.1.12 as permitted sender) smtp.mailfrom=bvanassche@acm.org; dmarc=pass (policy=reject) header.from=acm.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1738985446; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=RVKhMhCrCiF7cTahIfA/LJQvs9msb8eHK+pa/CbYEMY=; b=GbpxhWVGHU9EVIw12kWGz+rkHTWq+5SOzHEL8ZQ7uJkB2JvX51YZJhYxe+JEQcqcoX2rwR 6iOpivIfdh1rkbB/I17YRb2Vgcoolo47mSV8M7DolvzPrUW4aporq12wnoEx4/ERuEM5wP YJttCy72vS76RzyHWIQnHwJtaytG7NU= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=acm.org header.s=mr01 header.b=oUzX2LCC; spf=pass (imf05.hostedemail.com: domain of bvanassche@acm.org designates 199.89.1.12 as permitted sender) smtp.mailfrom=bvanassche@acm.org; dmarc=pass (policy=reject) header.from=acm.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1738985446; a=rsa-sha256; cv=none; b=JEaP3KVwJEOOFes+o7DhBhWQkjKEK+jlo2QIGB0s1+NNP6rXv+3GWi23l7vfd2ay0H4kBu 6eEip8fm0NVt6XoZgk27Vuy4/rSp0Za5dcPDNHVbllONI8Z3RvHP7ji68jN4JfVUnQ7WBK 0jMf24iXflf1SpzFrWDmNUJCEheJ4Ps= Received: from localhost (localhost [127.0.0.1]) by 009.lax.mailroute.net (Postfix) with ESMTP id 4Yqbvk5BXPzlgTwZ; Sat, 8 Feb 2025 03:30:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=acm.org; h= content-transfer-encoding:content-type:content-type:in-reply-to :from:from:content-language:references:subject:subject :user-agent:mime-version:date:date:message-id:received:received; s=mr01; t=1738985436; x=1741577437; bh=RVKhMhCrCiF7cTahIfA/LJQv s9msb8eHK+pa/CbYEMY=; b=oUzX2LCCCkc43VAl0vxFoDUgxIeaaVwXkAd1unvK SA9QUpND71wojWu9ZU2ufusGYI7Tjz082j1VS8SI1103//bsgpUOBC+8v+51RI/0 SuWuVX60a7CEqqxuhSiSbDqauU2I7EzOGAJYZuw5A8kf/W0zVXJlzgLOdbune2Z6 odK+pi+9cX9xNb95TfHSS9845eN09ba9CHhE0BQj+Qd2NLGoPXBHFWpdgV7gUZy7 ha4Dpb8e9cqmUYHCf76AH0XeJpJ7Ye5mfzGoe4lJKjviIP5fGS80v8QeRt5hJ1uT h4AMg6muQysCh7ZnWScDJdEFMxDsJVqyGcWXBqTglTQE2w== X-Virus-Scanned: by MailRoute Received: from 009.lax.mailroute.net ([127.0.0.1]) by localhost (009.lax [127.0.0.1]) (mroute_mailscanner, port 10029) with LMTP id hDlB8VcSCWdx; Sat, 8 Feb 2025 03:30:36 +0000 (UTC) Received: from [192.168.51.14] (c-73-231-117-72.hsd1.ca.comcast.net [73.231.117.72]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: bvanassche@acm.org) by 009.lax.mailroute.net (Postfix) with ESMTPSA id 4YqbvW4dbrzlgTwQ; Sat, 8 Feb 2025 03:30:31 +0000 (UTC) Message-ID: <2c6e79cd-f9aa-451e-b84a-67c211d62aff@acm.org> Date: Fri, 7 Feb 2025 19:30:29 -0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm: Fix clang W=1 compiler warnings To: Linus Torvalds Cc: Jakub Kicinski , Andrew Morton , linux-mm@kvack.org, Ivan Shapovalov , Vlastimil Babka , David Laight , Nathan Chancellor , Pasha Tatashin , David Rientjes , David Hildenbrand , Kaiyang Zhao , Joel Granados , Sourav Panda , Johannes Weiner References: <20250131191231.1370466-1-bvanassche@acm.org> <20250207164926.6daeac77@kernel.org> Content-Language: en-US From: Bart Van Assche In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 8585C100007 X-Stat-Signature: 1rwhxrf7kwr6ia8i19136obzjmtpkkdf X-HE-Tag: 1738985446-938069 X-HE-Meta: U2FsdGVkX19Ac3yorj44bk1RPfTFrZWyY4CvQdkz90lZKtXOX5GQsXRJF/JBaeosgtCkX0+AdcRdcypHaAnqDmYo3bPPDLMEBCV2tNsX117JU0KY9GC7pPc6ceNoYSMvjPsqqjBISBKk9jkOqWpnGzbIcS5RfmNQRfqwVmVuQkPjBSE/p241+R+fZQRTL7WHQYirkHHepyhQzmCF9AykpjHeEJZH2Rdbtq1t6OoFe1CAcGcAqHLq3Mhg03eee8HBTpvaDcqdQ9h4e6DsQDp6uohCiOIJEZSKx+HO1Kz4ixwJ2LNPGhCJx/XFC2wDA8bORKR4XM/4fpqLdX/GlCK1BIRWduSvYJfDd0qu1p/6J6uaDBg/IGQKTI1DdlhE/QBMNG18z4P0v9SqDll8NNLMomkDF1gJXlcOrSvrvTKUfDaPNv6vlgZX39ZBua0mCXMp3pjfRm9hGfTDjqTf2DxDcNOOHiLBVqQzkyDnM1PN4m2ETZoglUDf2bMjU58aUE6RAfvloKjeqVvpSiWEWY8AI5NXfE49cGMD0MI6wVYCf3a6EUs4nCooNKodZY0y/yOXoIawHlizZI4DHXSPyMayFmi4HHtSDLJxEyfXuWknA2RoegfyQyV2Si7/g7mdWxbSuKO3ywWdbZD7pKCcNYLgttJk//OwzyRVT8YmgVlmELqov46Dxi5VOWhNpurRc9sG1QBQXmMsT+rDKwLev+tPpIj86gcarGg1CccFKQW3tNHLVD2WSZeWuRVqx1jDUe1L9fVAAsASaOuljCnfkD0YcPWPqiq1qd/VjBBvn4vV21qYH4dGo7pConD1symSWhidQfwgJkO9OUBK5LilWY4gwxWf6LwdSSPLQigILQKd2CeKXsejxRr7X7r8Y/uLp4ZdWwWSrWv1M7QmU7maRc/5S/3ljt5f2CgRFVol6vSemQn19nIIHLcWk3ySCh40o+wSZejOBNxVJ3XbG9XcAsg LHoVK+qd JJZrqVxZarJUTY1ygsNwLIafJmf94o427ciPsknfI85t/zTPFhLRPa5H4QRJ2ic1Wuow/rwaEZObLRT27cozr/udmQu88BARiiQ8Wcce94wVgLGBbaXrIf1YeT5xbOJx8hj2o9D5QLQFyAAb7lwYeG9MM6p0Ca4Zz4/2xJL4ooEAWUXq0PF7REn8zQMSCmvOuhFxvlN+jGtth5pMgoxl9RVxAk0KCOE8CG0lISfE+VBV9VVmkFeF6HQzDODDPfxWd6cxLbpvukYynQM/rZnTNUEVhkS6xbDgQCEAs X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2/7/25 7:22 PM, Linus Torvalds wrote: > So if it's _so_ rare that these are the *only* cases of that warning > happening in the whole kernel build, then I'll just concede that while > I still think it's a fine pattern, if it's *so* rare that we only had > two cases of it, then it's worth fixing those two cases. > > Because at some point "really really unusual" might be worth warning > for, even if the unusual case isn't wrong per se. > > But I don't have any visibility into whether this is just one header > file fix and we're done, or whether it's actually more common, and the > one header file case is just a "this causes lots of noise because it's > included everywhere". Hi Linus, That's an interesting question: how often -Wenum-enum-conversion warnings are triggered. I ran into these warnings while building the code in the block/ directory with W=1. For almost every source file in the block directory that was built, -Wenum-enum-conversion warnings appeared for the header files include/linux/mmzone.h or include/linux/vmstat.h. This is why I posted the patch at the start of this email thread. Of course, moving -Wenum-enum-conversion from W=1 to W=2 is also fine with me. Thanks, Bart.