From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A12BDC3DA4B for ; Thu, 11 Jul 2024 19:20:57 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 366B06B009E; Thu, 11 Jul 2024 15:20:57 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 316986B009F; Thu, 11 Jul 2024 15:20:57 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 190606B00A0; Thu, 11 Jul 2024 15:20:57 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id ED9BD6B009E for ; Thu, 11 Jul 2024 15:20:56 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id AFECD1C1087 for ; Thu, 11 Jul 2024 19:20:56 +0000 (UTC) X-FDA: 82328439312.29.D26D6B9 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf09.hostedemail.com (Postfix) with ESMTP id 6B1DD140021 for ; Thu, 11 Jul 2024 19:20:54 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Nz7r3rov; spf=pass (imf09.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1720725638; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=7N+tm8RAmvVoK/4zFvMkE00hvcBw8YJQoI04ZpFePNc=; b=H4eHg5VJBLficc0MN28QZAemmDtBui0RvH6eSbq3hBynXYefv86eAZY9Z8R9uuC9OXtZB0 dWCbWq4YY4z+EuJ6P4J+5BmcMJmqIq0IxtYm99t9HG1HFJ8fhGEiTdr1zOjXTTvhAK+sCs P+hMeboIpp7oCjkXsohFTco5y+eJ6W0= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Nz7r3rov; spf=pass (imf09.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1720725638; a=rsa-sha256; cv=none; b=dk+V29QEP4laAMLFqeX/tMUz/uTdX98R50OQNhX8IKKWkDhvCxeBY3BDE7G68AvXn6cJTM Q3TCSBsEoBPNBiaC2rKvqQxc/GD0+kZJMp6OYCwJtW4B0QBfztXPbz/xl4JVcCM7191DNR dnmdWOmgHooQNWsq9f0JANE44wrk5A4= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1720725653; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=7N+tm8RAmvVoK/4zFvMkE00hvcBw8YJQoI04ZpFePNc=; b=Nz7r3rovfmkWGOxx0mIAIzw6cBDs6aNrOspcRyifjCKA8EAqekS5369XDH5gWpeCU5iBVp qc9QCxymyyVzB/bvHLyGKi8W/6ACsmeTzmiZC1UsBGouHOPHWUN4A2eg7+hkrCQjcSAXTN 6QQ9eYjR7ROmekdxjkjKshRwkbdPhW0= Received: from mail-pg1-f198.google.com (mail-pg1-f198.google.com [209.85.215.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-177-3XSwq747NsSTwy2f14EV4A-1; Thu, 11 Jul 2024 15:20:52 -0400 X-MC-Unique: 3XSwq747NsSTwy2f14EV4A-1 Received: by mail-pg1-f198.google.com with SMTP id 41be03b00d2f7-715e59afb63so911942a12.2 for ; Thu, 11 Jul 2024 12:20:52 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720725651; x=1721330451; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:from:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=7N+tm8RAmvVoK/4zFvMkE00hvcBw8YJQoI04ZpFePNc=; b=GUY7wpqiQTsuswjacIJoXQ3ro8dtZM7R084X7KapaCdjPAWtad2J4Onsk9b+K5Fo4y nuaBIx4ZJizat+TE2iW6U+M8yzV4z8RdqpuiNJpUgyQ0zAGTpU7hmSIzhxB5d6VXhFOI fGkD4JGV+v4cP4yrslPdeX2rl08H9BUR7lO1JlppwBqvTxMJpS+kUDYJAZceNjYOvWEm C9AeWjcoT+B4OnMXGB100Vv05lOIsZ+qgGZE9FJqjdbrICmwT6r+AO15SW+V7iieeHW0 JsjiCGcEKyrZPtmspnFsMX8Kh3E2AzmR24sXYf0ScQpxoZChkqqKYHWF9lG2jE+ikc3J 5o8w== X-Forwarded-Encrypted: i=1; AJvYcCXUfwbm7BJOzKc8Cqop/s8FK/m7b2Tse4lnCte/ukE3Frm82LokpUo1PHcLVdzp7CSD+JdL/MZ7FfE+W2xdhvZuRv0= X-Gm-Message-State: AOJu0YzVWdO47D2fsWPgzn6TapvTN+Xh583OKs495Gf1IMDbYPl+2gkV juQAyuG8KCq7Dsev/nYPGvor7EO40nnU4D9pNERV9s/NFJ9L/PdxQ39bbFGzFgcQf4ybfxP/u9H dKwtMs7+b2vtWujzflYvoM3CznS/W23rC7thAOR/KZmzJ4G+4 X-Received: by 2002:a17:90a:66c5:b0:2c9:b72:7a1f with SMTP id 98e67ed59e1d1-2ca35c72dbcmr7135109a91.28.1720725651053; Thu, 11 Jul 2024 12:20:51 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGI0uMgSW1u3GFAz0lYiKmF1ks96H89oy9S4U/cwkivkF8t14iRSKoIcA541WBK+7eLWOipKw== X-Received: by 2002:a17:90a:66c5:b0:2c9:b72:7a1f with SMTP id 98e67ed59e1d1-2ca35c72dbcmr7135094a91.28.1720725650605; Thu, 11 Jul 2024 12:20:50 -0700 (PDT) Received: from [10.35.209.243] ([208.115.86.77]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2c99a97c196sm14214633a91.26.2024.07.11.12.20.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 11 Jul 2024 12:20:50 -0700 (PDT) Message-ID: <2c464271-1c61-4cd8-bd4e-4bd8aa01fa00@redhat.com> Date: Thu, 11 Jul 2024 21:20:48 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v22 1/4] mm: add MAP_DROPPABLE for designating always lazily freeable mappings From: David Hildenbrand To: "Jason A. Donenfeld" Cc: Linus Torvalds , linux-kernel@vger.kernel.org, patches@lists.linux.dev, tglx@linutronix.de, linux-crypto@vger.kernel.org, linux-api@vger.kernel.org, x86@kernel.org, Greg Kroah-Hartman , Adhemerval Zanella Netto , Carlos O'Donell , Florian Weimer , Arnd Bergmann , Jann Horn , Christian Brauner , David Hildenbrand , linux-mm@kvack.org, Yu Zhao References: <98798483-dfcd-451e-94bb-57d830bf68d8@redhat.com> <54b6de32-f127-4928-9f4a-acb8653e5c81@redhat.com> <8586b19c-2e14-4164-888f-8c3b86f3f963@redhat.com> <443146f4-9db8-4a19-91f1-b6822fad8ce8@redhat.com> <1c8632b4-06a5-49da-be0c-6fc7ac2b3257@redhat.com> Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <1c8632b4-06a5-49da-be0c-6fc7ac2b3257@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 6B1DD140021 X-Stat-Signature: gftodjf1sckw45bbtnfi1knj9tkyoifo X-HE-Tag: 1720725654-583356 X-HE-Meta: U2FsdGVkX18WTLc7j9ENFVNYMWjY4xs4SA8vVJSTsrJH3yNX9y0bfQG9f9MQVdxBq1KZqgnrQZsomKCBtgUAPFDM9oKNIXJoSMjQg1qJOUrPRSWms0jqAWo7CZjwU44TKoWtg23Tw3QbMWY3QIoP9oDwAQLNZVgcM2XFYTHb40ALPqLWGEFBZBtiMYWdXI4HfBhuL/C/713Yg5X6iX8uSOMMZv+btcDM4WTxGGxdWo0tJZtaePbhz4QVSU4UId/Z2w6tRAgVaKz2aX92bTr+/9LTAIBPWjdJuX29vMSYDOglNfylF58ePA0ElelRg7awjlVNC32lg/96MUkTDy4zcmsezJea6orAQre4emSwIFim9MQ+rCkJM0naw6QK3/RWL7LU4v1Sz3uO+nIJoGUAtuzMOt6Yn9yEWMuidquadsMdeN1wZR25QvsNVfGRsVSyFPB6ZutjVfRlUEdRvCc7hyKUhPSopdI73Vv1p/h8YR30T6pNafZYH2YmRWl4bGo+HBCgBL0q7880oNB/4pPCWhTnkbnCBbY++5hIgJX7reaSYhqMLy9rtJlYczkyieyCr2ZLEoWR9tpDHw8D6Vogm2s3hU2inJEXvlY+qv9ZUbJ2qUvvuTyc1zjfZpllyfyy9ElVUUBLeMZLtVb0x/stqIrhtzRLtT75RpEdin7LtPCgagk8qObh62FvbRa0uhiLva6xLef1aC/rUrU+LG/Isx8+A3WYLC+/ukol0DDvzBP2S2tBhEuVvcJk/nQkP7SGei0k+tHAfzTjX6XMcvHjGyogHBuoLp9S+Y6w7HdAG/afMIAqYqPJR7ozU0iLTL6RqXAbLltQ7oNaQOIpyW0VmXY21gbs0JZnAXjuXZMbMuwUknYVYFup4jdGTnHZVFRsmhwor6W2/prNiVktGqjd5mHKJGz6ChWtlMNPNgm9qEp7oIVYFAjadBf9bu0A05OcLUsJq0AR7/2iFQOx1G1 T2Sj+HFp rRvuJzRmhoApdmXPXJcfvvN07EXl5wuxls0DTp5z9b8LCX7dhWWDKYCZARpelU1RhdglJVXpKgjt3BBcqKNZ9g/DI1+6OrhUqypWFwvxTId8Bbh7LPwaurZhezDNc6pFDbXtkOm0yaNwp07lyZPI+48NNOgqvxDCwMlV6nJjUqhWoQji/Uei1yShzi24WQY5gE/fc6srmUyrriPTKPf2u2nsmDjH59hQnkn+gzcMZ2/NHX6MFi7R9KtyJb+WyY9OY1G/TXm6lY7AyXMnhY9rMFVQtlFWiL2sPiClO8J7q7cpoDttJUAjg4Z+qKw1GJTCCBY1zqPCIpCGE8M8lXbuc96L10tglJTJNhC9U2Bxon7X/TU/FdRZJ7hnu3yw594U/MslDTnLNsnl3PybAHYjVIbXvRT8XNXE2WJwbdKOVv4ktBKeP+8QDGQysbw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 11.07.24 21:18, David Hildenbrand wrote: > On 11.07.24 20:56, David Hildenbrand wrote: >> On 11.07.24 20:54, Jason A. Donenfeld wrote: >>> On Thu, Jul 11, 2024 at 08:24:07PM +0200, David Hildenbrand wrote: >>>>> And PG_large_rmappable seems to only be used for hugetlb branches. >>>> >>>> It should be set for THP/large folios. >>> >>> And it's tested too, apparently. >>> >>> Okay, well, how disappointing is this below? Because I'm running out of >>> tricks for flag reuse. >>> >>> diff --git a/include/linux/page-flags.h b/include/linux/page-flags.h >>> index b9e914e1face..c1ea49a7f198 100644 >>> --- a/include/linux/page-flags.h >>> +++ b/include/linux/page-flags.h >>> @@ -110,6 +110,7 @@ enum pageflags { >>> PG_workingset, >>> PG_error, >>> PG_owner_priv_1, /* Owner use. If pagecache, fs may use*/ >>> + PG_owner_priv_2, >> >> Oh no, no new page flags please :) >> >> Maybe just follow what Linux suggested: pass vma to pte_dirty() and >> always return false for these special VMAs. > > ... or look into removing that one case that gives us headake. > > No idea what would happen if we do the following: > > CCing Yu Zhao. > > diff --git a/mm/vmscan.c b/mm/vmscan.c > index 0761f91b407f..d1dfbd4fd38d 100644 > --- a/mm/vmscan.c > +++ b/mm/vmscan.c > @@ -4280,14 +4280,9 @@ static bool sort_folio(struct lruvec *lruvec, struct folio *folio, struct scan_c > return true; > } > > - /* dirty lazyfree */ > - if (type == LRU_GEN_FILE && folio_test_anon(folio) && folio_test_dirty(folio)) { > - success = lru_gen_del_folio(lruvec, folio, true); > - VM_WARN_ON_ONCE_FOLIO(!success, folio); > - folio_set_swapbacked(folio); > - lruvec_add_folio_tail(lruvec, folio); > - return true; > - } > + /* lazyfree: we may not be allowed to set swapbacked: MAP_DROPPABLE */ > + if (type == LRU_GEN_FILE && folio_test_anon(folio) && folio_test_dirty(folio)) > + return false; Note that something is unclear to me: are we maybe running into that code also if folio_set_swapbacked() is already set and we are not in the lazyfree path (in contrast to what is documented)? -- Cheers, David / dhildenb