From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E509EC3DA42 for ; Mon, 8 Jul 2024 07:57:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7376E6B009C; Mon, 8 Jul 2024 03:57:00 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6E8936B009D; Mon, 8 Jul 2024 03:57:00 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 588776B009E; Mon, 8 Jul 2024 03:57:00 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 3A3376B009C for ; Mon, 8 Jul 2024 03:57:00 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id AC635C0904 for ; Mon, 8 Jul 2024 07:56:59 +0000 (UTC) X-FDA: 82315829358.18.25528BF Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf29.hostedemail.com (Postfix) with ESMTP id 7A81112000D for ; Mon, 8 Jul 2024 07:56:57 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=WlzLSURW; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf29.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1720425395; a=rsa-sha256; cv=none; b=t9/a775FTxZRDGrHiEAhvSlytByvbGusd7YGKLAYqccz1z/ch2R1podFVqSmzKw2lu6Sk5 iBom8wn7C6nlksb+EzI7oLL9yEIHVX1DgF2Fxk2HqIvEr4vbGT1uUVSYPARA+Hf0Jkz11L 7kWLWJ9OEZ6C7Xg1nX6vpqrtWJ8FaA8= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=WlzLSURW; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf29.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1720425395; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=P7UDcDhukCIjE6XPPyKqc3c1bo3guv4e9HYq+Y1TocI=; b=26h8OiDrxmh+y2MPfJtAsiwhQFSppJ/E8HqA2h3U/K3VRxf4ldsQdPMlXf9TtRvhPSkKuG cnFn/aDFuPzv2m3vokkWC+0Dxv0YSav2loEyie+izevt2WzU+Od+pbWONoAs+yFZ+GBXDb dHXiB1fgJ0cmRr2zYWmXGB32weeaWlg= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1720425416; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=P7UDcDhukCIjE6XPPyKqc3c1bo3guv4e9HYq+Y1TocI=; b=WlzLSURW8zEiooPNnVyijMiWm9I0UqY20BcO9MjnuEpnC7o/ZoXO1IjUoiiUxTYs74AYSx GuiX+EafKw6d033WBfNKj4iseSTZDDxtMDYH06I0el9KmaaCQ716OeR/p45vAw+tm6JxNA 2Xvr9P7QIyck68tbi9PXwrTENN2zl+E= Received: from mail-ed1-f70.google.com (mail-ed1-f70.google.com [209.85.208.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-343-60NMYiEYPBWS5osJ3J46MA-1; Mon, 08 Jul 2024 03:56:55 -0400 X-MC-Unique: 60NMYiEYPBWS5osJ3J46MA-1 Received: by mail-ed1-f70.google.com with SMTP id 4fb4d7f45d1cf-57cad6e94e5so3389015a12.3 for ; Mon, 08 Jul 2024 00:56:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720425414; x=1721030214; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=P7UDcDhukCIjE6XPPyKqc3c1bo3guv4e9HYq+Y1TocI=; b=bAkGP1ng/4oECyX2sWOed6+kDSELRE78JTZ7u3iref5IA0ThzXuiOLDrhc+IO+h871 NW3NRiiRu8wqdWRqRxklJ1WsPP7diPKqe43PwFKf4aBi/tmvVQRBjMSvEifbqIh2e6na hRYWcWkXinLAiOxIFvKSv1dMNTLe4vMJQi/elVLQMXECopr3ATgWB+eqE0EnR1/3EWzk K49gObkQiaxUg9772EZiXcAfxyVBdiT1SCbSZ1zN2E1ZrpTEHpdbHpeueaoqx/gv7cgN p1vcWhqGxmMA9hQ3pkUSuumvaqZuVYvH+KjR0njZ0Mba40XUXVX6fOjfMllZtqIkb6O0 ar/A== X-Gm-Message-State: AOJu0Yzdo9Y3nJED8eplbtHoS0xYSSSBQuhqqbghIR+x720SbfS7Wbvt oZarci8ggyy8KAp+oq+7qKdmKokjNvfpXvikuLnU6p87VR+GRref4+7u4RYlNb14X8D3enskR45 BMHISuZ7Zj/B/FWbj2DydF63UEtt4E80bvP7g79IAqMH9BZLJ X-Received: by 2002:a05:6402:40d1:b0:58c:3af3:cb0a with SMTP id 4fb4d7f45d1cf-58e5a7e8646mr8360705a12.1.1720425413949; Mon, 08 Jul 2024 00:56:53 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGLbfeeHCf6YTjePK3wWZC00uu/o3RjMFt3X0ObUkAous1koHNbqabHGWLN+EKwGc0tzeWb+Q== X-Received: by 2002:a05:6402:40d1:b0:58c:3af3:cb0a with SMTP id 4fb4d7f45d1cf-58e5a7e8646mr8360695a12.1.1720425413565; Mon, 08 Jul 2024 00:56:53 -0700 (PDT) Received: from [100.81.188.195] ([178.24.249.36]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-58dfd5aeda6sm5290033a12.78.2024.07.08.00.56.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 08 Jul 2024 00:56:53 -0700 (PDT) Message-ID: <2c3ebd1a-09d7-4521-9dea-684d38272a29@redhat.com> Date: Mon, 8 Jul 2024 09:56:51 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 2/3] kernel/fork.c: get totalram_pages from memblock to calculate max_threads To: Wei Yang , rppt@kernel.org, akpm@linux-foundation.org, brauner@kernel.org, oleg@redhat.com, mjguzik@gmail.com, tandersen@netflix.com Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20240708010010.32347-1-richard.weiyang@gmail.com> <20240708010010.32347-2-richard.weiyang@gmail.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20240708010010.32347-2-richard.weiyang@gmail.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 7A81112000D X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: wdj1j9e6o6f48gxsbqkjbdtwsfiinoz1 X-HE-Tag: 1720425417-288399 X-HE-Meta: U2FsdGVkX19eeHeeBgn/o8+pAAdGL6sPa8CvQnSYvYNH0TkLSJfwl/7Bm2/nrsC03LuGHxouzTDXngn3mfueualrkF95ZCcdMXP1oncKe0kM8lCOGy91yISigLBdipGuPANZs9kxwOizJ6ig0T94M1ApGX8yx1XIdDLzd2Y/nLGNlNn2cQjZbi5ZiSFpexjjQzAvLgWcNpSH0her6En5vJmZeQMVwDpT29WD3Oscca6jdTfRaE/Wf6PetWEZxt2ScDzH8GP/7vKTjf/qy2f1Ix6EL++ZPuoeLWrHV5h/0sRzEiHIYQ3s5SyZx6RJMd7hMQaujhxvJpIJt6H1ZpOw/E9WqtqzSMsNbkbUlQCVDM/UvHgiLjRwXeeGt1+PE9xwkPFRNj3DtKg2TkanT/Rt4ALrq+SoF0P10vdtqwad/CSQvhrwra6gwvxlgfkUtVB2ep+CQG6qgWeew2Xp4UauB0FwaQGvi8wapvoKyPMVFNhj/cfGKz8ck9wTzZiTHqugA3MeU9fW3SBGm2EX8gDQtMmk0zNTw4T6zxSFvDuLrxA8655kFJoqBG6nupV3EoHEBq2Kc9POWvHVc3ZLghI77vY4pKoRQhwYGCih+77+z8E64g2RwKDs0YkBCmx+F5K00s6fuslo7957NVWZ1ko7u/hLMUQ6TCOPPtSAWs6kbpuRMtjmC6wvr74LMNwm3/IEhccGCIB0h3VEYk99Xcr4S+fRuDf1pbfXIKcxU5ToW/6vVDiqjs7yW5HnDpXLDX14axdfo+ZsCDkiBMjvobPZRbnCSz573SnitRILgYHIlHlJjtbszT/9uMvtXHcI7k4UK0ekgKxhLUSOJfXtQIEnOMfgMbVWlIEH+6vlxpODn9joXsmSGmv+YKPTnOMQk2Jn0CgyKlasni0PcbzAy7fsD63PCamGbQgyHVGD+stnWr+fLhisIvmPweTRzFJbsynWmuGJSksBQDvXLP0gXCZ 99RKtPUd 2ohd2PkcYroSLWRqX5y4/SxZ6BkpY08TBqVwlOywS5nCMt/2EYMz23porEjHvxXGd/UORqdXWj2QZmMTisH31vt3pm7vtBbHf72f4ebkCnA9lyxeR7/6TQRq3YHvNMEJQ4oaW1XOEuBem6GPD9ZjOpQ+b6K4TuVvOHZP2KFr6c6r7idj7nxtkmSdetp2WLBiKqt/2z+B4knmUaUN5JlPk5tCCgR9iGVuSY+yuwEs7zPSu2XbPuc6dghyO0dLow7vCC3iDWK12E1ZsnXz//ew3VnKNvfAY2bE+vW8fMws1Ybd9dY6XEJnBiYSErPuj43rEO+6o6o80cuau4BsLWCu5nEN6/7v4HTZSAfQMkmO8K3MYTjI2KNviAuAWiioyS6OGtbcjJ/1SkGKvPREqH7OhpSlHORagvK0SmAPFvD0ROa1G5Tz0DQCDEzPmZBi3mBZdbveEi3zj6ROUItOB6/jugPkIwscMBFvIkYNzSOY73+zaVshIbWihws4b/6DyMTOMJOmrKw1SGoHgovwg447a4ivJDJzQYZk7hw+nb4D+daMWyF859kc6fiZaNLU3rk0NEgKOzdvffsLECuMPjV3wVAKXnh9gdXlcTXhob72PRfvq0O0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 08.07.24 03:00, Wei Yang wrote: > Since we plan to move the accounting into __free_pages_core(), > totalram_pages may not represent the total usable pages on system > at this point when defer_init is enabled. > > Instead we can get the total estimated pages from memblock directly. > > Signed-off-by: Wei Yang > CC: Mike Rapoport (IBM) > CC: David Hildenbrand > CC: Oleg Nesterov > --- > kernel/fork.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/kernel/fork.c b/kernel/fork.c > index 99076dbe27d8..e80e889543f3 100644 > --- a/kernel/fork.c > +++ b/kernel/fork.c > @@ -44,6 +44,7 @@ > #include > #include > #include > +#include > #include > #include > #include > @@ -999,7 +1000,7 @@ void __init __weak arch_task_cache_init(void) { } > static void set_max_threads(unsigned int max_threads_suggested) > { > u64 threads; > - unsigned long nr_pages = totalram_pages(); > + unsigned long nr_pages = memblock_estimated_nr_pages(); Stale name -- Cheers, David / dhildenb