From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7686CEB64DD for ; Tue, 11 Jul 2023 14:48:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D87FE6B0072; Tue, 11 Jul 2023 10:48:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D37FF6B0074; Tue, 11 Jul 2023 10:48:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C27096B0075; Tue, 11 Jul 2023 10:48:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id B394E6B0072 for ; Tue, 11 Jul 2023 10:48:47 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 84EEC1602EB for ; Tue, 11 Jul 2023 14:48:47 +0000 (UTC) X-FDA: 80999612694.07.D9E5A8B Received: from wp530.webpack.hosteurope.de (wp530.webpack.hosteurope.de [80.237.130.52]) by imf07.hostedemail.com (Postfix) with ESMTP id 53E5A4000E for ; Tue, 11 Jul 2023 14:48:44 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf07.hostedemail.com: domain of regressions@leemhuis.info designates 80.237.130.52 as permitted sender) smtp.mailfrom=regressions@leemhuis.info ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1689086925; h=from:from:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=YdhAfjHYq5/0VjH2I0WNu119xBViTrKkb8U2uUZU+jY=; b=BtWbVjYZFDxUlTJcpoC5fljIvUWP1jcTS/YJS8rpXwvAOQ8YGi3neD1QlJeRGhsUvzxEqX b6mPl3EA6qtmFj8TFIcHOOiRcPyuFELs+FO+bYhtGvQRemOdfthxIQlYF4QE3eEY6UtFSi aTm4U6ve1pxPwrebQYDwaTHQboUaA1U= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf07.hostedemail.com: domain of regressions@leemhuis.info designates 80.237.130.52 as permitted sender) smtp.mailfrom=regressions@leemhuis.info ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1689086925; a=rsa-sha256; cv=none; b=uUMLLs7quw4Z9jyKd5HfOTBqZdtqXkwLOLviLjrFjEi4JmhSZMHQidMQHmw0uHb65rmvWG 4h2VE/Q0yMiCBJXuvmSTSgdmhuOROpTNUqjrDgrI+zItQbT0CndVEVlezo9UtCdhTomkeZ wqJfWXcwaKibbQGDTyMXegnJY+LSQMg= Received: from [2a02:8108:8980:2478:8cde:aa2c:f324:937e]; authenticated by wp530.webpack.hosteurope.de running ExIM with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) id 1qJEf2-0003Uo-GS; Tue, 11 Jul 2023 16:48:16 +0200 Message-ID: <2c3ab284-fd11-d6c5-c03c-60d54ad227b5@leemhuis.info> Date: Tue, 11 Jul 2023 16:48:14 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH v2 12/32] mm/vmalloc: vmalloc_to_page() use pte_offset_kernel() Content-Language: en-US, de-DE To: Mark Brown , Hugh Dickins Cc: Andrew Morton , Mike Kravetz , Mike Rapoport , "Kirill A. Shutemov" , Matthew Wilcox , David Hildenbrand , Suren Baghdasaryan , Qi Zheng , Yang Shi , Mel Gorman , Peter Xu , Peter Zijlstra , Will Deacon , Yu Zhao , Alistair Popple , Ralph Campbell , Ira Weiny , Steven Price , SeongJae Park , Lorenzo Stoakes , Huang Ying , Naoya Horiguchi , Christophe Leroy , Zack Rusin , Jason Gunthorpe , Axel Rasmussen , Anshuman Khandual , Pasha Tatashin , Miaohe Lin , Minchan Kim , Christoph Hellwig , Song Liu , Thomas Hellstrom , Ryan Roberts , linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org, Linux kernel regressions list References: <696386a-84f8-b33c-82e5-f865ed6eb39@google.com> <42279f1f-7b82-40dc-8546-86171018729c@sirena.org.uk> From: "Linux regression tracking #adding (Thorsten Leemhuis)" Reply-To: Linux regressions mailing list In-Reply-To: <42279f1f-7b82-40dc-8546-86171018729c@sirena.org.uk> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-bounce-key: webpack.hosteurope.de;regressions@leemhuis.info;1689086925;12a016a3; X-HE-SMSGID: 1qJEf2-0003Uo-GS X-Rspam-User: X-Stat-Signature: gjnymk9s3k8tqegsa169ke19dsdzrpgq X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 53E5A4000E X-HE-Tag: 1689086924-165137 X-HE-Meta: U2FsdGVkX195p4NrJbM94mDwKtyWkTscYg20ERkvs8DHSOpO+xrBLjgkQ1+k66iWA0eJxrlNM3ksDduKoGd1fF9lU1GK/pI5r1WVNQahLCmkMNj8epTwXy4sufRGThLhvlDbQCDDQWgztLVojW8gXOsIMCb37uUtCCpeEO1yYVqXEyqCGdOBX4Uvm5g9R0FW499ednWPjFotqxophhxrXJuHLeWfZJ44fVHreuhdGXvLU9pujeYf26JQUKyfzFrys3dvv6ODwxffcSMHQS8ULTwGbZ6rdAKOlupdE2039g/l/T8p3djiebkVXDDipc84b0Mg+iYvV6WOT34vZiP+qmmALZVsrYMc6vDi6d3sm8cENG5Yd8lCgtjHxf/nJyzW1+fQTxRBAweoxRjDZyeZT0EljDSPbLKmy0kCFqmbbUOaGiQWOy9arXy+hoF9BSaKH4EJxCpW28kc3gITglL7X1Rn4+XtZTd23drg2TR7v088MbBdhSGjxztVDzNNmg/N+B22hbsXzHmQ4nhiQ+b0DlItCSxlHxmNqfSV2B2Lf3SyNC9jAlZoM/YYeuvQ8FPdtUklb3BBFjl1ZPVTxvLFc53UXoInaIMB3klzsR/MWdRgHy/rRVsd7uSbk+e2VrFRxm/2JMxNSZpSy3n2J00yyqzzCkjKGpNa5SbMQ5186qS1VxTAq9P2CO7vI5DLvG1r1DYH9Ih3xzo0LNi0C9pQ8CCkbGgEh2pZv3wBCTinLaiRcaPjYRukG2nrbn00/EfaUTNnxJivksDbT7EVmqEVzw2qruP58KHFmgopWEnWlBs8E831bFUhvcccWZPHReBxTUUW7yQx/niZkUbf3bTLXeGZlS37jpeHVsOYaAXhGDTfujS1ei40TfTfNyQe8hBkYibdxTecSXNJtzW92dcbjMU/ZqfZduUJi0jJ8W8fjuYwpyN2ENzPw/mUUhMprxCQZ2cH0RVYLZKD5h6Suss H9tMwvQz PPwfIj9aArj8HeorlTPJXlyhDupLd8SbKe+e/+b2KRrCfmYxUWmvHz/RlzMe6rcPxP4oNA4p6Kx3sj4gP7LmJ/mEKT6FVfOYbiGXABDCvwJfBiZ9oR+UbkDOqbi7z6SN6N6M5o7Km0oDi4Se3UgKZhdXE6Qb/w9p92QwtKeVgjWCN5ZwryIIoz99FzTp/yFsrnvXAtmZ6cZnJug5bqITq4nzYRIxMGeG67A2P/FJOvB3h4dfNvsyABi+50U9C45xrBBCL5Izi+MNDoETxDrpks7keaSXPyeMEkgyfVPoYBV9k31EliqKe6QN0P38VC9HZxhzb7discpzFx1eVaRyKzgHHuifJ3v6igdxqi/h4J91u05z6AX6RqKzAGWBt+o+UhgufX0P7fp6aBc9h7vsQjdTamNOrlRHDhkOFr+Bsc6wnILpD7GOvJqRIdITXqwY++inuO95N3mZeh8W1HIE1FptrWBI7+d6nQY3nULwhap4qlPfzFRd9DdeWrQ+jPiTYiXaf64DSBwlm9eDJuDxVghTwXA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: [CCing the regression list, as it should be in the loop for regressions: https://docs.kernel.org/admin-guide/reporting-regressions.html] [TLDR: I'm adding this report to the list of tracked Linux kernel regressions; the text you find below is based on a few templates paragraphs you might have encountered already in similar form. See link in footer if these mails annoy you.] On 10.07.23 16:42, Mark Brown wrote: > On Thu, Jun 08, 2023 at 06:21:41PM -0700, Hugh Dickins wrote: >> vmalloc_to_page() was using pte_offset_map() (followed by pte_unmap()), >> but it's intended for userspace page tables: prefer pte_offset_kernel(). >> >> Signed-off-by: Hugh Dickins >> Reviewed-by: Lorenzo Stoakes > > Currently Linus' tree is reliably failing to boot on pine64plus, an > arm64 SBC. Most other boards seem fine, though I am seeing some > additional instability on Tritium which is another Allwinner platform, > I've not dug into that yet and Tritium is generally less stable. > > We end up seeing NULL or otherwise bad pointer dereferences, the > [...] > # first bad commit: [0d1c81edc61e553ed7a5db18fb8074c8b78e1538] mm/vmalloc: vmalloc_to_page() use pte_offset_kernel() Thanks for the report. To be sure the issue doesn't fall through the cracks unnoticed, I'm adding it to regzbot, the Linux kernel regression tracking bot: #regzbot ^introduced 0d1c81edc61e553ed7a5db18fb8074c8 #regzbot title mm/vmalloc: NULL or otherwise bad pointer dereferences on ARM64 #regzbot ignore-activity This isn't a regression? This issue or a fix for it are already discussed somewhere else? It was fixed already? You want to clarify when the regression started to happen? Or point out I got the title or something else totally wrong? Then just reply and tell me -- ideally while also telling regzbot about it, as explained by the page listed in the footer of this mail. Developers: When fixing the issue, remember to add 'Link:' tags pointing to the report (the parent of this mail). See page linked in footer for details. Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat) -- Everything you wanna know about Linux kernel regression tracking: https://linux-regtracking.leemhuis.info/about/#tldr That page also explains what to do if mails like this annoy you.