From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D73E1C3DA4A for ; Mon, 15 Jul 2024 16:13:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 406A96B0085; Mon, 15 Jul 2024 12:13:32 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3B6D46B0088; Mon, 15 Jul 2024 12:13:32 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 22FB76B0089; Mon, 15 Jul 2024 12:13:32 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 05CFF6B0085 for ; Mon, 15 Jul 2024 12:13:31 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id EA9FBC1672 for ; Mon, 15 Jul 2024 16:13:30 +0000 (UTC) X-FDA: 82342482180.07.36F88E2 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf12.hostedemail.com (Postfix) with ESMTP id A09D940017 for ; Mon, 15 Jul 2024 16:13:28 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=FsnSwjlJ; spf=pass (imf12.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1721059958; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=eMQDoOvPaudwg87cd/MCmAjG7MuyuOwLJH3IIe8WBJ8=; b=8HBYPkeo6MVAcaIDPaw0YdzGoY5ZsaVn6iv8gFMQCwpUTkKUfEFodHTEtM+TH4LdAwuJgu a2GIlcMms1EK2yW+aMcirozamSXEOLVpCHC7PkXae8691YWvsGzz/kgbK71uu2UDY3HeGA dhTCw/Tj4yuDmUBvyM9z08EWXA4RVdY= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=FsnSwjlJ; spf=pass (imf12.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1721059958; a=rsa-sha256; cv=none; b=T5AKMjuitiMEKvdQTRHQlL0E0JoSSJ67P7IVKP5R+dckiIL2ZdiES0vPiOMAxqohBJh0iV PavlEOOjSn9hGmtYGQjpRa/O4wGM9eKekeGLedQNvLTv4Jm856ZoAwisIGxys4h5xSZlx8 DYy/VYd5zl8UtwF9OGfYucKfOqVPbpA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1721060007; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=eMQDoOvPaudwg87cd/MCmAjG7MuyuOwLJH3IIe8WBJ8=; b=FsnSwjlJ5nRXT5kraDUFGyPNaDVlvfmyZI55u4wzbWIesV+x6zf3WoS22hFtViD6rNB9lh Ij07BR7cFnxrxx93KkFlEkiEs4uMC9RcfkJWK7IIS/vngyBvXRf9E9MUFA/E4Ts6h583Rl Ph8q8FYcvXmhKa2dj3rCIXH7niszfkA= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-344-xJdwT2AwMoqFVL-j3-ZO-Q-1; Mon, 15 Jul 2024 12:13:24 -0400 X-MC-Unique: xJdwT2AwMoqFVL-j3-ZO-Q-1 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-4279c75c44dso27311865e9.2 for ; Mon, 15 Jul 2024 09:13:23 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721060003; x=1721664803; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=eMQDoOvPaudwg87cd/MCmAjG7MuyuOwLJH3IIe8WBJ8=; b=Nnru95By1LH1NDdScQC22m5xpX4EzJzsAY9j/7cbV4jrqmVTbH6yaQ4MDwrT8EJ08V IqDaarEAb8NRRS+IyLI/26+JHYDOAwCpj33OAuvzEzEaJGLkYmuFUo2S2t1LOXPycUdY htifpeKHwoNnqLokthFe1uar2YoIedbxxonADeBik1V7B8PJ6SbkP6fyDAbIC3UP8SCt 2VbXD/XDou8SWugmbfOGIzfAPgnX9avhrFcg/n/Xq3vRyeckS+h6Q94qGnjluPmVj9Rz wWgC1ES2SP23GohkXXc40OI6DeydxbM5Fv4UXvgpizSCfH7e/U8dizKzOyRbqlAvrlyl hxYA== X-Forwarded-Encrypted: i=1; AJvYcCU/Rs203xpLZUCM2sXOqD6uOhoxwUfjTa3LVNpRndMlDdK/6eUXT3UwVNOr2Xr3btrG62xeNXvN0CXSTbTH19Atn3E= X-Gm-Message-State: AOJu0YxKabazMzlD9LSKKmeYGhk+Qt/Wxhh9THW2ZI93q8yrT7ueDjai DMh0t9kqS13hSWTrrHbxLR/ljZmrOfiKSCGw9grpMiuuwuQUt9RYWbgtUDy255TbzaISA1lUlj+ M4wzrBEoWOhWR8ztshU3iY3YsROj8biNGoXWo8JS5Xhz38F4s X-Received: by 2002:a05:600c:524a:b0:426:6f27:379a with SMTP id 5b1f17b1804b1-427b8891044mr919645e9.13.1721060002985; Mon, 15 Jul 2024 09:13:22 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGQjwYkzdJSfx95XkYjFANBsRchdvLjh8+4GPYb9A3EiFNIrWgmU1j6VXyHmDh6mAZ9Fu7Hrw== X-Received: by 2002:a05:600c:524a:b0:426:6f27:379a with SMTP id 5b1f17b1804b1-427b8891044mr919485e9.13.1721060002622; Mon, 15 Jul 2024 09:13:22 -0700 (PDT) Received: from [10.0.229.2] (ip-037-024-227-121.um08.pools.vodafone-ip.de. [37.24.227.121]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4279f2d6ef8sm126339895e9.39.2024.07.15.09.13.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 15 Jul 2024 09:13:22 -0700 (PDT) Message-ID: <2c3a5213-ca64-48fb-845a-78aae3e8f15f@redhat.com> Date: Mon, 15 Jul 2024 18:13:21 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] mm/huge_memory: Avoid PMD-size page cache if needed To: Ryan Roberts , Gavin Shan , linux-mm@kvack.org Cc: linux-kernel@vger.kernel.org, akpm@linux-foundation.org, willy@infradead.org, baohua@kernel.org, peterx@redhat.com, ziy@nvidia.com, william.kucharski@oracle.com, baolin.wang@linux.alibaba.com, ddutile@redhat.com, shan.gavin@gmail.com References: <20240715000423.316491-1-gshan@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: A09D940017 X-Stat-Signature: utw6awuq1f11me19d5iyqjmb5f1ay633 X-Rspam-User: X-HE-Tag: 1721060008-73595 X-HE-Meta: U2FsdGVkX18SLIVlxtLwG0x0GmUiExSI+AUaSfxLlQQJNXBWZIoQYYSfz5EtYDNMe2K+6AQ8uI1MKLTVg3lyiIDWxJUegMwlLL5iHkIzfxYdrPgm1EpVU3wbrWN5FCgVPZWD0i0agM+2h+xpDsT+mTl3N7dEMdKbtBRGlSzQcGkQV/wgwR9PkuNPZk/nz7cR/O4Lv+fOhf+zstziGrAgay29jMAi/H3qraYquTE0BBA3ugHsWcMk+3/yAYrF1eTA5XUPouJyUNwtpo61I/lL0a67MEOqYLT4yPjRum2UsWlvgimozPV86ZsrbhcA78j9fxtfRmKQM/DH/M/w7eECnqKQiHWcnHh0rUTNL7jDgw/Sp8W4aevcQeB7tfHPNoUeMyzLBybEK8NyWwhB0edqZkWaGVOhvRZrwUqPREYni5+pdGPB84nhNnfBok18MPfkWizNARS5PpLZmrwiZB06udxEr71n55cRQltgrPwB3ygayTJgVr34lkCSNz/tmboLzUqw76+OHx0j0hvCIMFE1PN7hJoRse4GIutMjGJy3CF+Z0KlnpnIYMXCRIoDcsS4ygUalfZeHInVcmImJPuZhwAmt2CkRp77zGRJ+e12h7UL0slfqwRELuPC4dGvjkmA9ER5ig+0m2fDABcHgNrqREOHclXysl8ndhq6rmmmXZtPSgjt4o3i/PAkaMHGmY+4Zr7Qx42QnjHHHEbKlyxXIIPQtpOXIFnq53kx78aVsLBGYZqECr/r9UBOo241NJU+9N3P/gPtowHGAUmQjKoNVtTOKNzR1fC1Zzr6SvRwlB/gAXr/a0Flk5UEfLSAPFdjJwl/ni2Fx8Ut9aaoKop2/YE2JknbL71eXg1xR2y8kyg3qhHoIVOIrTDJcfBZg9ajImqvkFfELCmiyfuTh6nedHiZ5IyWjjMMuw4BCVLuJCYbM5apoZqRKLwVFfL5hqN83NbIY5cCsHe/xoTMSFK VCBrUvy+ 757qVSThbSfSb5RbvsXUBe6p/iV2yiYV6Ldxsv0Ut7MfeagscMNw/6sI/hhRGEaKgVgSnuj9sw8D/nCZqyuXKYkDWv39h0zM4300qnP8uFZyFRCoLYqhBfaqkpQyLx+gh7rxctyqIP8UVHdswBRCZdqPijGp7PWG/WXydQ0eEjS6tMYY2kUf++wxG/6Dvau7xTki+AyyB7zueSf6tNN9UoWDZhI6L0IWFfb2LugRMyLQUohyJSy2rLHVUXDA7vBs4WsX/Wf37pUzjXLRGSOy3QnjCA6heoXp1pZBax0ak0oxCpdjpDEcojLKiYlll+MBshUf4DzebLVatJ8qVIIrZ6D+aCBbqIEMtm8UDLpCXTzsdDjkiA7TouCJc8RW75B4g5hfqatc44Vckc5PwUlaOLsjoMBKLWvMYdb5Fvab/Pazl6TYpOhp5fFmQqvM1Le2wuyiIi7kDnHPPaGTzjsnuklUZAzjPI/Sb5uNN2hILyoPrR9NovcsibJEaeCR2yWjmHzbTaxPHkfVyn2eY7+YZrikeoQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 15.07.24 12:41, Ryan Roberts wrote: > [...] > >> diff --git a/include/linux/huge_mm.h b/include/linux/huge_mm.h >> index 2aa986a5cd1b..c73ad77fa33d 100644 >> --- a/include/linux/huge_mm.h >> +++ b/include/linux/huge_mm.h >> @@ -72,14 +72,20 @@ extern struct kobj_attribute shmem_enabled_attr; >> #define THP_ORDERS_ALL_ANON ((BIT(PMD_ORDER + 1) - 1) & ~(BIT(0) | BIT(1))) >> >> /* >> - * Mask of all large folio orders supported for file THP. >> + * Mask of all large folio orders supported for file THP. Folios in a DAX >> + * file is never split and the MAX_PAGECACHE_ORDER limit does not apply to >> + * it. >> */ >> -#define THP_ORDERS_ALL_FILE (BIT(PMD_ORDER) | BIT(PUD_ORDER)) >> +#define THP_ORDERS_ALL_FILE_DAX \ >> + (BIT(PMD_ORDER) | BIT(PUD_ORDER)) > > Appologies if this was already discussed, but if changing _FILE_DEFAULT to > advertise all orders 1-MAX_PAGECACHE_ORDER, shouldn't we also change _FILE_DAX > to advertise all orders 1-PUD_ORDER ? Or is DAX literally limited to PTE/PMD/PUD? It's limited to that. IIUC, it's simply some physical memory area that can be interpreted as small folios, PMD-sized folios or PUD-sized folios, and someone (fsdax?) makes the decision "how" it is interpreted/setup these folios. These folios can only be mapped entirely (single PMD/PUD) or via PTEs, so PMD_ORDER+PUD_ORDER is correct. Thanks Gavin! Acked-by: David Hildenbrand -- Cheers, David / dhildenb