From: "Huang, Kai" <kai.huang@intel.com>
To: "tianwentong2000@gmail.com" <tianwentong2000@gmail.com>
Cc: "linux-sgx@vger.kernel.org" <linux-sgx@vger.kernel.org>,
"bp@alien8.de" <bp@alien8.de>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
"jarkko@kernel.org" <jarkko@kernel.org>,
"dave.hansen@linux.intel.com" <dave.hansen@linux.intel.com>,
"mingo@redhat.com" <mingo@redhat.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"x86@kernel.org" <x86@kernel.org>,
"tglx@kernel.org" <tglx@kernel.org>
Subject: Re: [PATCH v2] x86/sgx: use vm_flags_t for vm_prot_bits
Date: Fri, 23 Jan 2026 07:58:27 +0000 [thread overview]
Message-ID: <2c33338d030f086d490f6e8e8d02667ff37143ec.camel@intel.com> (raw)
In-Reply-To: <CAGPELS7JdxTY5hthmTyU_yDxdG7xR2k0hoA1ZqV_Lj+8LEkO2w@mail.gmail.com>
> > With vm_flags_t I think "theoretically" it could stop being integer type
> > someday. But I guess the advantage is when someone does that that can
> > trigger build error here (so that we can be aware) which perhaps isn't a
> > bad thing?
> You're right, the build error would be a useful early warning if
> vm_flags_t ever becomes incompatible.
>
Agreed. It's what type safety means IMHO.
> I'm fine either way, let me know
> if you'd prefer keeping
> unsigned long and I'll send a v3.
It's up to maintainer(s), but v2 makes sense to me, so:
Acked-by: Kai Huang <kai.huang@intel.com>
next prev parent reply other threads:[~2026-01-23 7:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-22 13:36 Wentong Tian
2026-01-22 20:56 ` Huang, Kai
2026-01-23 6:23 ` TwT pupupu
2026-01-23 7:58 ` Huang, Kai [this message]
2026-01-25 14:46 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2c33338d030f086d490f6e8e8d02667ff37143ec.camel@intel.com \
--to=kai.huang@intel.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=jarkko@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-sgx@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@kernel.org \
--cc=tianwentong2000@gmail.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox