From: Levent Serinol <lserinol@gmail.com>
To: Martin Hicks <mort@bork.org>
Cc: linux-mm <linux-mm@kvack.org>
Subject: Re: [PATCH] min_free_kbytes limit
Date: Wed, 23 Mar 2005 16:17:32 +0200 [thread overview]
Message-ID: <2c1942a705032306177b0a9ebe@mail.gmail.com> (raw)
In-Reply-To: <20050323140049.GC19113@localhost>
init_per_zone_pages_min() function. The problem with min_free_kbytes
is, it's integer and accepts signed values. There should be something
to like this to avoid problems for example setting min_free_kbytes
value to below zero.
On Wed, 23 Mar 2005 09:00:49 -0500, Martin Hicks <mort@bork.org> wrote:
>
> On Wed, Mar 23, 2005 at 01:34:19PM +0200, Levent Serinol wrote:
> > =================================================================
> > --- linux-2.6.11.4/mm/page_alloc.c.org 2005-03-16 02:09:27.000000000 +0200
> > +++ linux-2.6.11.4/mm/page_alloc.c 2005-03-23 13:13:47.000000000 +0200
> > @@ -1946,11 +1946,16 @@ static void setup_per_zone_lowmem_reserv
> > */
> > static void setup_per_zone_pages_min(void)
> > {
> > - unsigned long pages_min = min_free_kbytes >> (PAGE_SHIFT - 10);
> > + unsigned long pages_min;
> > unsigned long lowmem_pages = 0;
> > struct zone *zone;
> > unsigned long flags;
> >
> > + if (min_free_kbytes < 128)
> > + min_free_kbytes = 128;
> > + if (min_free_kbytes > 65536)
> > + min_free_kbytes = 65536;
> > + pages_min = min_free_kbytes >> (PAGE_SHIFT - 10);
>
> Who says 65MB of free ram is enough? Where did you get these numbers
> from?
>
> mh
>
> > /* Calculate total number of !ZONE_HIGHMEM pages */
> > for_each_zone(zone) {
> > if (!is_highmem(zone))
> > =================================================================
> > --
> >
> > Stay out of the road, if you want to grow old.
> > ~ Pink Floyd ~.
> > --
> > To unsubscribe, send a message with 'unsubscribe linux-mm' in
> > the body to majordomo@kvack.org. For more info on Linux MM,
> > see: http://www.linux-mm.org/ .
> > Don't email: <a href=mailto:"aart@kvack.org"> aart@kvack.org </a>
>
> --
> Martin Hicks || mort@bork.org || PGP/GnuPG: 0x4C7F2BEE
>
--
Stay out of the road, if you want to grow old.
~ Pink Floyd ~.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"aart@kvack.org"> aart@kvack.org </a>
next prev parent reply other threads:[~2005-03-23 14:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-23 11:34 Levent Serinol
2005-03-23 14:00 ` Martin Hicks
2005-03-23 14:17 ` Levent Serinol [this message]
2005-03-23 14:23 ` Martin Hicks
2005-03-23 14:34 ` Levent Serinol
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2c1942a705032306177b0a9ebe@mail.gmail.com \
--to=lserinol@gmail.com \
--cc=linux-mm@kvack.org \
--cc=mort@bork.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox