From: "David Hildenbrand (Arm)" <david@kernel.org>
To: Sunny Patel <nueralspacetech@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>
Cc: Zi Yan <ziy@nvidia.com>, Matthew Brost <matthew.brost@intel.com>,
Joshua Hahn <joshua.hahnjy@gmail.com>,
Rakie Kim <rakie.kim@sk.com>, Byungchul Park <byungchul@sk.com>,
Gregory Price <gourry@gourry.net>,
Ying Huang <ying.huang@linux.alibaba.com>,
Alistair Popple <apopple@nvidia.com>,
Balbir Singh <balbirs@nvidia.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org
Subject: Re: [PATCH] mm/migrate_device: fix double unlock
Date: Tue, 14 Apr 2026 12:03:49 +0200 [thread overview]
Message-ID: <2c0c00aa-7fb2-4d7b-90b3-0309c13468ce@kernel.org> (raw)
In-Reply-To: <20260413211559.20969-1-nueralspacetech@gmail.com>
On 4/13/26 23:15, Sunny Patel wrote:
> migrate_vma_collect_huge_pmd() calls spin_unlock(ptl) after
> softleaf_entry_wait_on_locked(), which already releases the ptl.
>
> Fixes: a30b48bf1b24 ("mm/migrate_device: implement THP migration of zone device pages")
>
> Cc: stable@vger.kernel.org
>
> Signed-off-by: Sunny Patel <nueralspacetech@gmail.com>
> ---
> mm/migrate_device.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/mm/migrate_device.c b/mm/migrate_device.c
> index 8079676c8f1f..7eb2f87ea39d 100644
> --- a/mm/migrate_device.c
> +++ b/mm/migrate_device.c
> @@ -177,7 +177,6 @@ static int migrate_vma_collect_huge_pmd(pmd_t *pmdp, unsigned long start,
>
> if (softleaf_is_migration(entry)) {
> softleaf_entry_wait_on_locked(entry, ptl);
> - spin_unlock(ptl);
> return -EAGAIN;
> }
>
As raised by Matthew, the entire code block is dead code:
https://lore.kernel.org/linux-mm/20260212014611.416695-1-dave@stgolabs.net/
And I even Ack'ed it /facepalm
So we should take that (cleanup) patch instead. Thanks!
--
Cheers,
David
next prev parent reply other threads:[~2026-04-14 10:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-13 21:15 Sunny Patel
2026-04-14 10:03 ` David Hildenbrand (Arm) [this message]
2026-04-14 11:53 ` Balbir Singh
2026-04-14 13:13 ` Sunny Patel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2c0c00aa-7fb2-4d7b-90b3-0309c13468ce@kernel.org \
--to=david@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=apopple@nvidia.com \
--cc=balbirs@nvidia.com \
--cc=byungchul@sk.com \
--cc=gourry@gourry.net \
--cc=joshua.hahnjy@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=matthew.brost@intel.com \
--cc=nueralspacetech@gmail.com \
--cc=rakie.kim@sk.com \
--cc=stable@vger.kernel.org \
--cc=ying.huang@linux.alibaba.com \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox