From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BD7F4C3271E for ; Thu, 4 Jul 2024 15:37:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D64FC6B0082; Thu, 4 Jul 2024 11:37:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D14416B0096; Thu, 4 Jul 2024 11:37:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BB4576B0098; Thu, 4 Jul 2024 11:37:40 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 9F77B6B0082 for ; Thu, 4 Jul 2024 11:37:40 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 4882C1A147E for ; Thu, 4 Jul 2024 15:37:40 +0000 (UTC) X-FDA: 82302475080.07.C38C061 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf20.hostedemail.com (Postfix) with ESMTP id 08A661C0025 for ; Thu, 4 Jul 2024 15:37:36 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=xxteEm+m; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=MclA0BBB; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=xxteEm+m; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=MclA0BBB; spf=pass (imf20.hostedemail.com: domain of hare@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=hare@suse.de; dmarc=pass (policy=none) header.from=suse.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1720107433; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=65H5k5hn17k/Q6t1nmNt687lwrCYMhgfHjot9SPgp4A=; b=XGDgHZ8j4Nfi5BL6Q5XNX0/YyzE8L99EqtpGf/+I0624lyQEP3M4vzXlNWvGMjwY2D7cDd WZavVHY5rVSn1+bXmDc+vBEe++PhK1UECALbtvIfCXKPjtqNd9U8g33NRLvm3tx2ofy06X IgVUAtH+dPQfT7G7GGhlvBoEGKoR/lc= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1720107433; a=rsa-sha256; cv=none; b=5zxbvObmxomut09Su4cqmgw39wp+zDDVQ7N1MR3SkO05ZOh7UPpoItod18vjIrKiU2ubB2 V6tveeoX1AFalT1Cp2iJ6nU9K4Qxldkm2qXOukUslAlZUd3NXqFyBqUfzG7c/Zp2uYLCgl J+GNXEgUPoN9xTVgAvrnRN6DCd54uaw= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=xxteEm+m; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=MclA0BBB; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=xxteEm+m; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=MclA0BBB; spf=pass (imf20.hostedemail.com: domain of hare@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=hare@suse.de; dmarc=pass (policy=none) header.from=suse.de Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 24D3E21BAE; Thu, 4 Jul 2024 15:37:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1720107455; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=65H5k5hn17k/Q6t1nmNt687lwrCYMhgfHjot9SPgp4A=; b=xxteEm+muxQ6xQ5W4wzo7OSGywE8UZCZ2Jw6C4wVUrgLqi7pDYTWj1p7gvtE/G+dBL5tda yJyIvJzydqJR7X5hCkVmwrlIY8O8++SdPAzzS/jc5Sit4ESbz/eMlafTuG2LVvWMQYz7Jq HXVgB9vDYxzO7R+MlEdgd/pSHOxqAHg= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1720107455; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=65H5k5hn17k/Q6t1nmNt687lwrCYMhgfHjot9SPgp4A=; b=MclA0BBBumTYPxMCItA/7dEXtz3Aa0cBhwEjXaJzAWqpsDisAWyzgvA5QerIzs40QYquVG KFdkBHT5oKIdrXBw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1720107455; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=65H5k5hn17k/Q6t1nmNt687lwrCYMhgfHjot9SPgp4A=; b=xxteEm+muxQ6xQ5W4wzo7OSGywE8UZCZ2Jw6C4wVUrgLqi7pDYTWj1p7gvtE/G+dBL5tda yJyIvJzydqJR7X5hCkVmwrlIY8O8++SdPAzzS/jc5Sit4ESbz/eMlafTuG2LVvWMQYz7Jq HXVgB9vDYxzO7R+MlEdgd/pSHOxqAHg= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1720107455; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=65H5k5hn17k/Q6t1nmNt687lwrCYMhgfHjot9SPgp4A=; b=MclA0BBBumTYPxMCItA/7dEXtz3Aa0cBhwEjXaJzAWqpsDisAWyzgvA5QerIzs40QYquVG KFdkBHT5oKIdrXBw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id C38601369F; Thu, 4 Jul 2024 15:37:33 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id zlDxLb3BhmZERQAAD6G6ig (envelope-from ); Thu, 04 Jul 2024 15:37:33 +0000 Message-ID: <2c09ebbd-1704-46e3-a453-b4cd07940325@suse.de> Date: Thu, 4 Jul 2024 17:37:32 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v9 06/10] iomap: fix iomap_dio_zero() for fs bs > system page size Content-Language: en-US To: "Pankaj Raghav (Samsung)" , david@fromorbit.com, willy@infradead.org, chandan.babu@oracle.com, djwong@kernel.org, brauner@kernel.org, akpm@linux-foundation.org Cc: yang@os.amperecomputing.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, john.g.garry@oracle.com, linux-fsdevel@vger.kernel.org, p.raghav@samsung.com, mcgrof@kernel.org, gost.dev@samsung.com, cl@os.amperecomputing.com, linux-xfs@vger.kernel.org, hch@lst.de, Zi Yan References: <20240704112320.82104-1-kernel@pankajraghav.com> <20240704112320.82104-7-kernel@pankajraghav.com> From: Hannes Reinecke In-Reply-To: <20240704112320.82104-7-kernel@pankajraghav.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Action: no action X-Rspamd-Queue-Id: 08A661C0025 X-Stat-Signature: fq9t4h1sd85dhkcow8zfy38k5nkuke1a X-Rspamd-Server: rspam09 X-Rspam-User: X-HE-Tag: 1720107456-166341 X-HE-Meta: U2FsdGVkX18oWyuYbmCS5ddXcDSonqlpdmxCF+EY/IoHGwWRik1naFD5hlWp0EShPd/JJle0YL18EzAj9/tY233TewuVMmU2AxWcPY4nhSO2wRt6vfWptYd5/du8zC/HI4TIBEYkKcPKiaSvp/+FN8YJgEUPrup5wFD7dawHrOP7RxhyRC7JBbUKz0/hBdSAFJLYu9pfwSVeiBm5/xQgmINK43LBWuw8eMwIqso0lidULVeUwTDT5FJXmzbcEPKt8ih+L1wTyP+Kx6bYkvQdM3QEkaN+E37aA//ekItB8UkzgU0r3dAtqypMN9rCBmIzg30j5U8wHMdWYorGiu4PiYU5wAJXT714091mG7/1zlwTRH+INufY8tzJveehWyrjv+aAswh3gZ3lJYk7zCMc+MmUGd7ZDRbv+JaeG0sDqXqeI1bQ0i9KBcqGNcJlUVcpViXZR5qFzErgkkLH73qWxIzxNXsinJoqxfNpL5W7nvAOc+9zf6yeaJqZY6QMEqmkWcPzVnbnI94DCnKS4vIW7awO52BhDACp4OONqkWex+FWkXnvG9M/2SbMu8dLTd+eAF1hOsv4BXPsuoq+NIS/i+9IxvmZmY3IP1qk7ke4nJcqtxHfM513L6ZkMhIAWg+2Cr3bh0lDEyPyTBckdb2eTawvLDlLRB6vKWbC0caZdJl+Nrdwb+5IMoVNIuBy7ta8klVHfNg1IcDFsnlz2nc2lgjWcFWx+14F0A4tErutHAd1RxfjegtMPKFdhgMB0zJy75zqfZ73cUDmFfTh/12VPdfFYa0JUgVgCZj0gqh40GhFGWloByofpPw1IXZvC9+GxgcLAoNmO9mxi4C5jerC33zIUA153SjFC1wBVGhargikTU25fiw+Jz4HNVBlw7/Wy25NH3cK4kZlRwlQWf3dmT8AooskdDj99rzC4FeqVqXsujcAVZzGt1hZnMisT5toFZQ9cjAe8nTaJHh31Kq ue1zsMxF pUuzK4cYJBvHufwPGITFWu2T5g53U9MSTBvQ+2kGhuJyOe1b5ehzk1KcTuCxUAMKK54GyhmJZY8Gonhx2tHtK+EdjWP5BKjLw/982l6d3q9YTP5sjLQoT8NuBJjCUNDnZ2W2GS2JHDVCbS9RDfntTTu3h4fJ7acIQ+1m7kKeWQor+mJx83jvTFSuNtLbdSa3GVGMk8nKYoBffCnW+g4L8EnkabIItjjnShacM3Tfdup9Y9di9gDoTMYn/OAtrlaXyNinBAzRL7EHD8QhVOT70lpY/13OTtnNh9jNyk6qYrib3hbCr4YCkK0F59K6m0SyC5GLoIDcyEanek1ta9hWTMfr63EPr7BcKtrI2I4sts+lHtMPE6qMR7aeQ/x9qfw0dalWW X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 7/4/24 13:23, Pankaj Raghav (Samsung) wrote: > From: Pankaj Raghav > > iomap_dio_zero() will pad a fs block with zeroes if the direct IO size > < fs block size. iomap_dio_zero() has an implicit assumption that fs block > size < page_size. This is true for most filesystems at the moment. > > If the block size > page size, this will send the contents of the page > next to zero page(as len > PAGE_SIZE) to the underlying block device, > causing FS corruption. > > iomap is a generic infrastructure and it should not make any assumptions > about the fs block size and the page size of the system. > > Signed-off-by: Pankaj Raghav > --- > fs/iomap/buffered-io.c | 4 ++-- > fs/iomap/direct-io.c | 45 ++++++++++++++++++++++++++++++++++++------ > 2 files changed, 41 insertions(+), 8 deletions(-) > > diff --git a/fs/iomap/buffered-io.c b/fs/iomap/buffered-io.c > index f420c53d86acc..d745f718bcde8 100644 > --- a/fs/iomap/buffered-io.c > +++ b/fs/iomap/buffered-io.c > @@ -2007,10 +2007,10 @@ iomap_writepages(struct address_space *mapping, struct writeback_control *wbc, > } > EXPORT_SYMBOL_GPL(iomap_writepages); > > -static int __init iomap_init(void) > +static int __init iomap_buffered_init(void) > { > return bioset_init(&iomap_ioend_bioset, 4 * (PAGE_SIZE / SECTOR_SIZE), > offsetof(struct iomap_ioend, io_bio), > BIOSET_NEED_BVECS); > } > -fs_initcall(iomap_init); > +fs_initcall(iomap_buffered_init); > diff --git a/fs/iomap/direct-io.c b/fs/iomap/direct-io.c > index f3b43d223a46e..c02b266bba525 100644 > --- a/fs/iomap/direct-io.c > +++ b/fs/iomap/direct-io.c > @@ -11,6 +11,7 @@ > #include > #include > #include > +#include > #include > #include "trace.h" > > @@ -27,6 +28,13 @@ > #define IOMAP_DIO_WRITE (1U << 30) > #define IOMAP_DIO_DIRTY (1U << 31) > > +/* > + * Used for sub block zeroing in iomap_dio_zero() > + */ > +#define IOMAP_ZERO_PAGE_SIZE (SZ_64K) > +#define IOMAP_ZERO_PAGE_ORDER (get_order(IOMAP_ZERO_PAGE_SIZE)) > +static struct page *zero_page; > + There are other users of ZERO_PAGE, most notably in fs/direct-io.c and block/blk-lib.c. Any chance to make this available to them? Cheers, Hannes -- Dr. Hannes Reinecke Kernel Storage Architect hare@suse.de +49 911 74053 688 SUSE Software Solutions GmbH, Frankenstr. 146, 90461 Nürnberg HRB 36809 (AG Nürnberg), GF: I. Totev, A. McDonald, W. Knoblich