From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 102B5E7717F for ; Thu, 12 Dec 2024 15:49:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 97B586B008A; Thu, 12 Dec 2024 10:49:49 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 92B8E6B008C; Thu, 12 Dec 2024 10:49:49 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7F4B16B0092; Thu, 12 Dec 2024 10:49:49 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 61F686B008A for ; Thu, 12 Dec 2024 10:49:49 -0500 (EST) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 7B1E1C010F for ; Thu, 12 Dec 2024 15:49:48 +0000 (UTC) X-FDA: 82886741322.19.4D5D8CF Received: from mail-io1-f53.google.com (mail-io1-f53.google.com [209.85.166.53]) by imf16.hostedemail.com (Postfix) with ESMTP id 8D11B180005 for ; Thu, 12 Dec 2024 15:49:21 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=kernel-dk.20230601.gappssmtp.com header.s=20230601 header.b="q1/JIIau"; spf=pass (imf16.hostedemail.com: domain of axboe@kernel.dk designates 209.85.166.53 as permitted sender) smtp.mailfrom=axboe@kernel.dk; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1734018560; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=YVaKQZU7nloKckjwhdDnxOF9PtevW4t5K7qzUvbh2h8=; b=UWBuUmljUG0NLXtW0bSkVBzm88ohf0c/imoNvNSJPRrzkM8sZ7/jstl7cDINThWBXdJdOp PgpI+3Ve/I/cWJJkqemvHKmK7A3gUH6f0bJeu05rRQlzbO4a8TUVjGtcrJ1NyY4DdsKFfp dQ4rbR8ky5+rZfL1oFE0HMdy5BOnYCQ= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=kernel-dk.20230601.gappssmtp.com header.s=20230601 header.b="q1/JIIau"; spf=pass (imf16.hostedemail.com: domain of axboe@kernel.dk designates 209.85.166.53 as permitted sender) smtp.mailfrom=axboe@kernel.dk; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1734018560; a=rsa-sha256; cv=none; b=yqgFbu7Qrq+cm9Ge+jvblsDOD8meMi57u67HxHVeumzR2XX9lJZzyQr34uG6jK5t+IN1f8 CYACC5hmyE8NFxBhKjP9UO3F+Zo/iNSUDnmkGAXUuQ+7zMcGArFiuKeKRdF5oPN5H7LMeV qo7s6Irnyfm2Oik9JbCAhCefxkiReMk= Received: by mail-io1-f53.google.com with SMTP id ca18e2360f4ac-844e394395aso13049439f.3 for ; Thu, 12 Dec 2024 07:49:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20230601.gappssmtp.com; s=20230601; t=1734018585; x=1734623385; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=YVaKQZU7nloKckjwhdDnxOF9PtevW4t5K7qzUvbh2h8=; b=q1/JIIautzwJMVR3SU4mkFrL81Sr7+5rm/UywfluYa3n5eaKTmkXFXCIJbyaexoXcX qwcRUas2EAVin4hydZoUie9Pew78IyxwjACltoLv6QrRofL9P+UZwzGryLf473fNTJ5S KjB61orBOF2KorVlOKUQLXG2VWNd3695VnXPXfZUJyT3V1gVggi3iYu3K3dTUaVBItlu WV495UJRYYJWptIQbZTAa7lflRyySdmiR0YzNzFI8LC6RGVDu1OUmlWjzQpe1WNTK1Nu cEyEyi3HjOpSeqYAclZFlIseCL6hGt4AqJndUR8AaxIkMV0AWxwKcfgJvThiy7jlFU7F 6liA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734018585; x=1734623385; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=YVaKQZU7nloKckjwhdDnxOF9PtevW4t5K7qzUvbh2h8=; b=Iyfo7FKPoXgK5027IIXdh+0d4ovrY6I8BNi3hW4VKePwj4IfNtW7x05XgkGi+r/iGP 3gw4ZiBfHnI9tJFyKCm/n0Gypn+1BLSquw8fcgv4V4W3WWGxkIJAOksc9YTbfVDVe7/M 4ahPEnqM3P3A0Zzu4X5ogmDFEuub1nC2vHInBN6NCCjpLecVtNfvSMMzloxufguXNuAZ Xnk3nAwIlEC6fwPYIPIDkQYYV5FYh5vq90Ak69YO9BUhOU7sBKx4zjNAF1kg6hkAAch7 xV2rLtTlskyH4QR3gM269Vbbv572g7nUuYvwfDS4NBbj5nakWccrJXnnBzjydm4oPXFf w3zQ== X-Gm-Message-State: AOJu0Yz2/E0PLDaLBFUHdU8FBhOvF50CgTDiFShfJ0IKz8cabUqnoGVS I4KaZWJsph1s9JeTq+UWlwRTLWsuFT9LAsXpmmhmYyBAst5fjvPiTSfk9jfD/5A= X-Gm-Gg: ASbGncvryS54AoeTeelKRJO/W01kRxdpMEF8UkAz4p/UEWEi92kj4NMpou+JhdYzxdb NRyc9nubn/q06MdNaE+pPnJOA5R2JMiexhN9BqtmnlOt6qF8AfW9y3DCWO3NE9A09tdSiqYZxXp HPxtV2dBmUf1chdp/3ZqRqd2N9gGdViTtTPffSOrXl+yoOjLAKEhxJw0oHHwtju23ZynEW+3WaO MCU1vp1EZPajeyirKJGUMR4NSNgNwcXKVIN93Bb5S07uQMEZ16X X-Google-Smtp-Source: AGHT+IGmxw/YiyqxPRIzbjFmn/JAK77sZXtipYzHL1BIv7+IHJ3asyE+OvBsoy5xKnX8eBVpXS4m2Q== X-Received: by 2002:a05:6602:14cb:b0:82c:d768:aa4d with SMTP id ca18e2360f4ac-844e56595f5mr70126339f.9.1734018585556; Thu, 12 Dec 2024 07:49:45 -0800 (PST) Received: from [192.168.1.116] ([96.43.243.2]) by smtp.gmail.com with ESMTPSA id 8926c6da1cb9f-4e2d57dbf74sm1247971173.54.2024.12.12.07.49.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 12 Dec 2024 07:49:44 -0800 (PST) Message-ID: <2c009af9-a92c-464a-aeea-50c2520b4a04@kernel.dk> Date: Thu, 12 Dec 2024 08:49:44 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 01/12] mm/filemap: change filemap_create_folio() to take a struct kiocb To: Christoph Hellwig Cc: linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, hannes@cmpxchg.org, clm@meta.com, linux-kernel@vger.kernel.org, willy@infradead.org, kirill@shutemov.name, bfoster@redhat.com References: <20241203153232.92224-2-axboe@kernel.dk> <20241203153232.92224-3-axboe@kernel.dk> Content-Language: en-US From: Jens Axboe In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 8D11B180005 X-Rspam-User: X-Stat-Signature: eptkdhe8ztaziok5dg73q9fgk6zpnj9s X-HE-Tag: 1734018561-771292 X-HE-Meta: U2FsdGVkX19bzPiJQOd8zuYHDZcx/AhD7g/LCRmJ40Xscb03vO8jqbJ9qEXAQ9222PAvVicL6eLkMNJAJCaEGrdKRzq4iWk5pHIq39Qpatd5u0bOAqnCHVf7tY/GM5Snc6znJZeo7bOPk2qLuB/ZsjLSgJ89FQYn77uuxM421kEQdK2N/veo7T/OENtCHy7/krwhWkXmdAeWgv5KAA1fVmHZQ6pTQWiVhYfbmUkRHdyGF70qjtK3PHvZ9e2K63KCHkYQCvST3Z0XiqnOqGgTQYxmOPlHVDtRs44s4SupLhBtHHTWvS9H+JIt7Ez7JBvGp6rNVqx3TQozVXSeQSMAaqiLdTRlYosmO7nB02MDf5qjfjGz3SL+46cZ6dy/K0PJe6Vw/sRho/1YjyZ1XxnbBaU8QQAandcMUDE+/4OLjr0KjciuKN7Qb45XZvGXhjmKQfrgr+1shndNOz0S9kNnSB5CDJK8KxP0p1OL0zm83miiWSQtBXeT8KyOwUScHWC3qhx9n5UBNXuw6uzQrTMfpoXogNlIo4TAEJ8TTLWefRP7bz/XGle7P86mCo46Bvw3bUcAFrOBv70USvH6BcBTgMCIvA4iWAMYo5kjiF8qFAg5rFq5bZolAHPkSzUCaLCJjTN0+QstR6kasacyr3TINUtfOod/jmqKcTSBsQ1yBDAhiYbbnEtKZNEe6+KZ1YV3b1DKpUjyMK9udKEKLDqAVD0E0CJdJEf7TWd3QMXseZucsVb4l5FJM7+Sh0ZKRMi1bOHqse3aHVyuhSuLejvEpl8z4iSdB+9XWUeOMj/M9LPiZHJRHBaAcOxmwNr6/kQVi7FAAZVkZytDJe+ELJBnx7reKK1mh3bJP1MEdBVKf5MXse3DGiZjbz/FvszdiTBlMH7PQ9LDa1zSqRe1sYaTkbgJVff1XEEcuIFekx7GsTBde+cJV9KJWUMOzu01YvDvIghSLEVPPVwJCRgj7cs 9xbqmZ8a aF7ljduTHslY900mGtwJ//uEyJbvXLE8dEM603FHJums6vxi+AnRdmF1AIeVLCv2CjRmrkdQZKiOT1wV45vShgsWWC0mDKeea8w7UOB2PiCHRJrH/hs0PTeWBTCrOVw94uDhF6uoh1optYcud7sMqXQqdJZ8biJHwjLNFQJRku3C5VDdaAtH/9xWm407yZCmzHtEio8jguEm1gNYFbxIxvPJo/OYHQ4r0D58T14ypKWb7r5sapiOcODfRDCr+9EHp88xOjINLf8178K1B7wpqSexjJ3jcoXtORa4tAUfIr8U0QSkyUEsWWc2dlE+wxDtXv6/15fBEzbS17tTtwSi5g79oOurDel9ndttxMdaoaoW7Mfz/f4pW3aBqRY0UrirjtuSO92W69cV5WHEXe1IUJVhYow== X-Bogosity: Ham, tests=bogofilter, spamicity=0.038955, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 12/10/24 4:13 AM, Christoph Hellwig wrote: > On Tue, Dec 03, 2024 at 08:31:37AM -0700, Jens Axboe wrote: >> +static int filemap_create_folio(struct kiocb *iocb, >> + struct address_space *mapping, struct folio_batch *fbatch) > > We might as well drop passing the mapping and deriving it from the iocb > as well. > > Otherwise this looks fine to me. Sure, I can do that cleanup at the same time. -- Jens Axboe