From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CDEF9C10F1A for ; Tue, 7 May 2024 13:59:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 666EA6B0092; Tue, 7 May 2024 09:59:35 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6170A6B0095; Tue, 7 May 2024 09:59:35 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 505DE6B0096; Tue, 7 May 2024 09:59:35 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 344FD6B0095 for ; Tue, 7 May 2024 09:59:35 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id D445116138B for ; Tue, 7 May 2024 13:59:34 +0000 (UTC) X-FDA: 82091757468.15.0A39428 Received: from out-175.mta1.migadu.com (out-175.mta1.migadu.com [95.215.58.175]) by imf04.hostedemail.com (Postfix) with ESMTP id E4C0F40018 for ; Tue, 7 May 2024 13:59:32 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b="w4/5Kf26"; spf=pass (imf04.hostedemail.com: domain of shakeel.butt@linux.dev designates 95.215.58.175 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1715090373; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=a5mTNRe4LMZAhS4pUCYAVz2ek9U2ALsnFQIig+p2+qg=; b=btunkVGbHLiXKJdkV5KJvWZCh5gvFhWZFbxVZjm/PRAKUb7OIqRttOX5nmILWficxbbec+ fcF8PacLjlY4TWatUkYCX951vVmtmK+AMGTbRb2zKh9QfoFk80BNFCEk6dICIn29z+gJxF jdUHTrqSV/Q7pcIEFAz32QISgiFOn+U= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b="w4/5Kf26"; spf=pass (imf04.hostedemail.com: domain of shakeel.butt@linux.dev designates 95.215.58.175 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1715090373; a=rsa-sha256; cv=none; b=UmYwEo4zdE7E99TPCq7CkmOZ8Ich7f7s9nvplwsDZVn8v/p7nqDUFjfXHbO3uU1m8Cp1bj JAc+/ZefellUDkENPwLhnOB7sjjHQ3f1BQ/80In0e9ZoWdMxc8EBvka/iHfKC3cemir8cR 5oXUm2w9Aiwi1Znpl4rYD0R3t8sGwRw= Date: Tue, 7 May 2024 06:59:10 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1715090365; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=a5mTNRe4LMZAhS4pUCYAVz2ek9U2ALsnFQIig+p2+qg=; b=w4/5Kf26tT3UzHWq+DJj0YASUMNXid3U6M0LUF9SBZrWflJ55cZCRHCoWEHBN0Qz6Ct9At KGvidyYUNrvpt0c62rXi60jUGHfXEMJjSuPJ8Hm0kOB5fYaJngokaybEzcsqeA23Q37sEg lXMueCQqzHk8AyLgwkGV2eOPM3nqZ0Y= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Shakeel Butt To: Xiu Jianfeng Cc: hannes@cmpxchg.org, mhocko@kernel.org, roman.gushchin@linux.dev, muchun.song@linux.dev, akpm@linux-foundation.org, cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 -next] mm: memcg: make alloc_mem_cgroup_per_node_info() return bool Message-ID: <2bvwvb2w2z7hpoagdeus6gpuwmx26xber7tgkp7rxrq4uuttzm@bnl4x2rve3zu> References: <20240507132324.1158510-1-xiujianfeng@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240507132324.1158510-1-xiujianfeng@huawei.com> X-Migadu-Flow: FLOW_OUT X-Rspamd-Queue-Id: E4C0F40018 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: hh8wy5e1qk33gdnbqds6touy9w3qd8gq X-HE-Tag: 1715090372-398769 X-HE-Meta: U2FsdGVkX18BEvg7I9u2CXmS5wk42SsPicrlNingtHZA0X/opsVVRIGtht5nGQw2hT0UX5RgXYHJb1krizrdCZkg2Ysz79FgUAoMfRJAdsGaWx3sLhC/l9hw7/heVXj7Y40JH1xFBdxhJdnVd4OfDt+1R32izvEz+by2hejCHH83nz+esGCZvFsumnZgAlDoBLZK2rBPhzNsg/Nv0UYnR7m/ve5O35E7JWkpRguEMKIXmXSppEZhRBBiXdDrUW5JZA5zHF6y7RPcRbdhNoSp1b9SQAx+ZORqxutSCwx3FgjkttGRHUDDUxDTakfBOikvXXFO8HLdAHfAMImZgsIMbppmJ1ZsAaeFqHKQPL7YWVgn/YZ3WQs9YJ2z3+VjVY3ySwy+OU3J8DCQe+xYSwBu1VipKrrCLF62BzWXV++iJjWtuhdctsBeYMfVaqvKe+FEWHYgAfgD+NuXtDkuC1vEe2gihUHz8nitz5jTEZNKHN6aXqHRUYk7+c9ASJ20LSSpgz7zo6vqybbt03aSFoJwXphZuYDaKVyKWemg7kUgsvZFfyMnsHthzEF7/cXuBS+Ho9rz3mgLtIUYZ3wY+fn8qCRBLyj4EMF0UlaunF/LVHliMqJBJtcbt+wKaHeI5Yi2Ua3U0vj0bEsVM9aMGU4ES4GSvf3k8w3l4R9qH0ARnTCEjDKbJ8PHW4QNgmboo6TsPFPS+ZQiMJv5QG9LeVwiuLYT7/ujuyr0siG0QVDJsfIbSv3V6+fPLKH0m7S7f2UhamlpvHzt7D2ucmRu92zcRUwj2br+7OBdLv6JeaV64uTgHM2gzIjPOxL1i3xT/I2+ZqnUES0R0MqLoaBl/fhIYUTXVp/Ahecj71qo48sM1Wdsw9ALvsqN2q/2lopExUi6dnFy97I6SnaNI4mu1BT9HZCjR+9tPffbjGz67iRUn0u/tZQlEzTtlImgJ1VGZTNMbm9LOmBxOOHWp7vQO68 LEfgY+zs iodFSWoQVU3SorQ6cw1Qsi9FDBkAgpfgJULsCLll3EzreWgJppushmZXx51Ri8eo9NAs65vJp1/CaMfEofBC65/8Mjli/52bQ7HM3+vZ6fo9Rdd0N2x0Rqq2hirUrWKnD9C9jn719iBxaFC1dpJN1Rz+95GJUzdFl5uz2Pd6yKFgFkHY6Iq2F+43Tjlgx3UoSTGuMukfj8qzyGt07SVq7A8rU4g== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, May 07, 2024 at 01:23:24PM +0000, Xiu Jianfeng wrote: > alloc_mem_cgroup_per_node_info() returns int that doesn't map to any > errno error code. The only existing caller doesn't really need an error > code so change the the function to return bool (true on success) because > this is slightly less confusing and more consistent with the other code. > > Signed-off-by: Xiu Jianfeng > Acked-by: Michal Hocko Acked-by: Shakeel Butt