From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D4298E77184 for ; Thu, 19 Dec 2024 17:54:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4C7CB6B0083; Thu, 19 Dec 2024 12:54:48 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 4737C6B0085; Thu, 19 Dec 2024 12:54:48 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 33B586B0088; Thu, 19 Dec 2024 12:54:48 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 1614A6B0083 for ; Thu, 19 Dec 2024 12:54:48 -0500 (EST) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 4DA961A014C for ; Thu, 19 Dec 2024 17:54:47 +0000 (UTC) X-FDA: 82912457712.25.FF55EC4 Received: from out-188.mta0.migadu.com (out-188.mta0.migadu.com [91.218.175.188]) by imf03.hostedemail.com (Postfix) with ESMTP id 3AFEF2000C for ; Thu, 19 Dec 2024 17:54:29 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=pkrYbA5H; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf03.hostedemail.com: domain of shakeel.butt@linux.dev designates 91.218.175.188 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1734630854; a=rsa-sha256; cv=none; b=BbqF6Qp7rST0QComxq4Y+Rfbgb4X9ioJeVzUiBS4Rj5twl5tvW0KqmCkT41t0zda0qQpxj zedTs46FoNcgb4a4aO788s29Xx55v8s5/lMxjEVm8QymUDeJopVBJL5c7XE+bsCF/ftSSK 1ye4BbJcWxp7RpLhg/k8skcljBEwuwc= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=pkrYbA5H; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf03.hostedemail.com: domain of shakeel.butt@linux.dev designates 91.218.175.188 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1734630854; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=9Lw4IPAij3tp3i78gRJgMk6al8HXCXv1KaFKHJliJ10=; b=Ans6oJ7aA0e9lr3hEoYFE8TXm3hLdxk5bElraDazZqJfGaq3e2OqgwJ/l18qHLZloPtqG8 hlGsYuOpr7RQN+0wzTTX+iLwzCgH7myd8NB+PL1x6bnDsVbnAmXnz/SOK3g6h7c8o8Ry1+ E+gBE8e/ZwZgsgKxbhGo6F0xxxORKF4= Date: Thu, 19 Dec 2024 09:54:38 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1734630882; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9Lw4IPAij3tp3i78gRJgMk6al8HXCXv1KaFKHJliJ10=; b=pkrYbA5Htsgt2HBkWjXQ2C6SYUk9xVqd67BaTeAzUmcEXq+6F7115NsZ8bRG7lSg1wrcfg pnX37TRRyU8xISw7aVmh+P/JmDyRroZnETr/+99rbayv5qXIDKb+eT1oP8XFlVh6+DE8aU re8oukJks6LhlEfOwJUUk9DaLCd4Wng= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Shakeel Butt To: Joanne Koong Cc: Bernd Schubert , David Hildenbrand , Zi Yan , miklos@szeredi.hu, linux-fsdevel@vger.kernel.org, jefflexu@linux.alibaba.com, josef@toxicpanda.com, linux-mm@kvack.org, kernel-team@meta.com, Matthew Wilcox , Oscar Salvador , Michal Hocko Subject: Re: [PATCH v6 4/5] mm/migrate: skip migrating folios under writeback with AS_WRITEBACK_INDETERMINATE mappings Message-ID: <2bph7jx4hvhxpgp77shq2j7mo4xssobhqndw5v7hdvbn43jo2w@scqly5zby7bm> References: <43e13556-18a4-4250-b4fe-7ab736ceba7d@redhat.com> <968d3543-d8ac-4b5a-af8e-e6921311d5cf@redhat.com> <7b6b8143-d7a4-439f-ae35-a91055f9d62a@redhat.com> <2e13a67a-0bad-4795-9ac8-ee800b704cb6@fastmail.fm> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Migadu-Flow: FLOW_OUT X-Stat-Signature: 8mxm8prx7qdhcgkpxumnrhodjkdmkxw5 X-Rspam-User: X-Rspamd-Queue-Id: 3AFEF2000C X-Rspamd-Server: rspam08 X-HE-Tag: 1734630869-470686 X-HE-Meta: U2FsdGVkX180uWPmz/iTztqjLbj4+4hhyT1qMUfx/uRHRAYPpj18VRqcI9ajED49iUt/C86FOOsJ/27Clcu6uc3bcVwiIdDRnc3DBejNFPXzGq0GD7HENJekAE9vaZem8f1ASxx1sURGBUg9zU6fb+BiicmtWzra9Ftjb7DPuqOsFXDe5owpSptbfOQ3o8ql6vnH+4u2paojIIMYJK8MREYl/6joWNvYbRzc+OVADHdkaqy9hS6tkCctEZYuZ4B3Oz2mf7DxJxe+EGCThv2gwD2B+wibF1ackMKcBAejHLD85I6itJs0ErVwe2HP1F2tsB5owhgsu1rmaUkedUQHUviWa5cl0yMfd7wppZd23JDFKVs+8vkP481ehVSLzfzspGq4PXc8asaPCIsdy1gSC3UlL3v6YveR67RiXLuns+DmhM+RzrUWGAWsHCwYKHj8kk4HOdvAMMf22izzs/rQmR8qw7oOSnj3J6uxulYxVe3eNwe5Mbc+Yho+MAOX5/xApHjIVTy+TIml0Mj8cOdvcVO4Ti4A4+VO+8MwFwQ0f4BajUkIhWUTAOhyszWGPDm8Mr6U709hq1lygwAouECjnLf6aUvFELEw88K+mxxfiCSxzRAyDulzKySMPlUl7WW2Vixx5JnLSvHlF+APWuavV0SLoff+HaziiuuXumFkjZQCFRN1swZxSENdBY0DswFWxo6qtORgg/GdVq3IZfP7uy3LHxv7Gt+LsyxAMHg5SAdJHQ0YFAvabfM9vJV4tWp2o7/Z+hEyVbobRNNNH3LLv8Qlzuwk/meRRtm/w0aTgFBmk0L2LYH20Skq9S5dw13+wzGlyP4/HUUBgLwTh5sHsp7CYB++h7AJc8DzgpA0V3gf1hv6apgU/P+8gRUqzzIXZ00ukktx4U7B15az1mU6kwlblIU6xqCqeFD1KXBctB7JTRYMIbjtiZUwHA79Sk+ER/0tXpVagfj4/8N6Xu8 PVGk4LaE bxfuCRDsBzNjwPg1CoNoEQInjYjfe0+QpDpjYvxuhOMKuDjxODiH6n2dszbzAiJDOBO/4/e7FlG7vWwa8uGN+EYU4WaWZFWuhjW3puUlrIGMBpJ+ZlSksWu9p8oejBniVuSIgAggjnb7VUYyv7oR5e12KZDIKnZ6qjnCbN14MS4ObvSh0HkT9ic8PYJhftA225NnEwn2j4yXS7bJaDtb1+Y+oIt3QE8+Xrf61 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Dec 19, 2024 at 09:44:42AM -0800, Joanne Koong wrote: > On Thu, Dec 19, 2024 at 9:37 AM Shakeel Butt wrote: [...] > > > > > > The request is canceled then - that should clear the page/folio state > > > > > > > > > I start to wonder if we should introduce really short fuse request > > > timeouts and just repeat requests when things have cleared up. At least > > > for write-back requests (in the sense that fuse-over-network might > > > be slow or interrupted for some time). > > > > > > > > > > Thanks Bernd for the response. Can you tell a bit more about the request > > timeouts? Basically does it impact/clear the page/folio state as well? > > Request timeouts can be set by admins system-wide to protect against > malicious/buggy fuse servers that do not reply to requests by a > certain amount of time. If the request times out, then the whole > connection will be aborted, and pages/folios will be cleaned up > accordingly. The corresponding patchset is here [1]. This helps > mitigate the possibility of unprivileged buggy servers tieing up > writeback state by not replying. > Thanks a lot Joanne and Bernd. David, does these timeouts resolve your concerns?