From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9829BC77B7C for ; Sat, 13 May 2023 03:34:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D8A186B0071; Fri, 12 May 2023 23:34:28 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D13B06B0072; Fri, 12 May 2023 23:34:28 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B8D186B0074; Fri, 12 May 2023 23:34:28 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id A550D6B0071 for ; Fri, 12 May 2023 23:34:28 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 5DC0F1C828F for ; Sat, 13 May 2023 03:34:28 +0000 (UTC) X-FDA: 80783814216.02.1E87746 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf20.hostedemail.com (Postfix) with ESMTP id 2EA0B1C000B for ; Sat, 13 May 2023 03:34:25 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=EvgwzWD4; spf=pass (imf20.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1683948866; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=5iuN8vfyC5tHnzEyX8BlDAD7L1Af+tn1GvUhlcPzN64=; b=bJTag5QdZYB0P9/AIjXDby4RdCYEfzjvVKRnV1Oxa15h91q4joOsxuKZvwcnBUqX2MRaoR 84L8kdJwBxwooBibHmveb/VJuaQT88QecGZHn+aahb0t0oTJvACvgiSZaFyO/FCbQAJ5F5 cAx+beRBJj8q0qw9eIBF1ebad5258sc= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1683948866; a=rsa-sha256; cv=none; b=0x8ujmVuCBkkHz3mFxsUNm9fQXPHBH1PWu8O1RUtsBUk0H/uUaVixpqxcVaig37j28m/9Z bxkcuJNWACTHqRd507ulG5Br3fMsqJWzDlTf439K/z5cQHNSeGtFZYpS/xOOeFMii1hgfe 40r2Kv0SuhFVANGpT86r1zs7nKPoFoA= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=EvgwzWD4; spf=pass (imf20.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1683948865; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5iuN8vfyC5tHnzEyX8BlDAD7L1Af+tn1GvUhlcPzN64=; b=EvgwzWD4YR+cWgBTCium9Bx7slgFAUQ1gptH2ooizYeup3nOmt2t3oIQZANP7+li07xsU6 bVhuIdAql8N22nfjBZv/zQkM/B+5AhgDCNpfxoyF3H7ZpePuBQK9qm5VhoqdbWO6eD+CpN bqI70gfj/ddHFC2LRcOQM+LcG9Lgb1c= Received: from mail-qv1-f71.google.com (mail-qv1-f71.google.com [209.85.219.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-128-ar8601FcPGKgtFIocVL37Q-1; Fri, 12 May 2023 23:34:24 -0400 X-MC-Unique: ar8601FcPGKgtFIocVL37Q-1 Received: by mail-qv1-f71.google.com with SMTP id 6a1803df08f44-621247fde5cso38007596d6.0 for ; Fri, 12 May 2023 20:34:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683948863; x=1686540863; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=5iuN8vfyC5tHnzEyX8BlDAD7L1Af+tn1GvUhlcPzN64=; b=EjvoZfIlsRixa5Iob8fRMWgs/2DXmX3m9ilMbsCjwqwxbb3wFwK1Ps6PrqzkB9exiE DtGdtsVTi5wHmsCf7+Jskd/yyKRgnWJ/t0wz3ykX+nCCsVfvLyxprZ5JP8xFDPNrmew+ svPccrpfR379Lz06Wmhy9O56/jyTsY1ZxI4UHCNfep+K4bBsdHqEqN9F+YhAGiE2eBBz FezhRLPoBqjiFROHT9h4UJ0QK3TB7evnDsn6EmLorcyJ/niy4oyZNWLBAJbDIJrQAIrm vu/yEs1Mn+VcGDrMCm2Lr9j8AJJzh6vrrmoTMLgHKNiHzLI7aklXLZIAgp0/rO4hnjIU b4HA== X-Gm-Message-State: AC+VfDxCIX8GipxE8e4/VK4OD9BTMG3YLxCmz4RPXr0GQm28E+EXPP4F HYYH9JYFSMLLtsfbKti5wGCkLGjUdWJ/bdDnJsJBPVnzV0UriF4YTOZBCvv5CZqJaXTjboCNNJF i0BppeFRzNA4= X-Received: by 2002:a05:6214:c8e:b0:621:5e3b:8eb1 with SMTP id r14-20020a0562140c8e00b006215e3b8eb1mr15765390qvr.21.1683948863656; Fri, 12 May 2023 20:34:23 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7UkLU8K72jYx94erbkeqa4wc7P/xk0KqcPVxSx7Ix59QYYVZTGfmcAZGLxvCO/qrtHHN4mSw== X-Received: by 2002:a05:6214:c8e:b0:621:5e3b:8eb1 with SMTP id r14-20020a0562140c8e00b006215e3b8eb1mr15765364qvr.21.1683948863330; Fri, 12 May 2023 20:34:23 -0700 (PDT) Received: from ?IPV6:2603:7000:3d00:1816::1772? (2603-7000-3d00-1816-0000-0000-0000-1772.res6.spectrum.com. [2603:7000:3d00:1816::1772]) by smtp.gmail.com with ESMTPSA id a11-20020a0ce34b000000b0061b62c1534fsm3391537qvm.23.2023.05.12.20.34.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 12 May 2023 20:34:22 -0700 (PDT) Message-ID: <2bf4062d-b3f1-671f-0aa4-7f3e98402160@redhat.com> Date: Sat, 13 May 2023 05:34:19 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH 2/3] mm: Call arch_swap_restore() from arch_do_swap_page() and deprecate the latter To: Peter Collingbourne , Catalin Marinas Cc: =?UTF-8?B?UXVuLXdlaSBMaW4gKOael+e+pOW0tCk=?= , linux-arm-kernel@lists.infradead.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, "surenb@google.com" , =?UTF-8?B?Q2hpbndlbiBDaGFuZyAo5by16Yym5paHKQ==?= , "kasan-dev@googlegroups.com" , =?UTF-8?B?S3Vhbi1ZaW5nIExlZSAo5p2O5Yag56mOKQ==?= , =?UTF-8?B?Q2FzcGVyIExpICjmnY7kuK3mpq4p?= , "gregkh@linuxfoundation.org" , vincenzo.frascino@arm.com, Alexandru Elisei , will@kernel.org, eugenis@google.com, Steven Price , stable@vger.kernel.org References: <20230512235755.1589034-1-pcc@google.com> <20230512235755.1589034-3-pcc@google.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20230512235755.1589034-3-pcc@google.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: sptmrb9owz93fauog6akuq7ay4ps6c49 X-Rspamd-Server: rspam03 X-Rspam-User: X-Rspamd-Queue-Id: 2EA0B1C000B X-HE-Tag: 1683948865-886067 X-HE-Meta: U2FsdGVkX18YH4bfzQwEx1qjYP6/ZW4T3+uZXqr68OiJo+YJ7GB2V47esB6VIID4vzSf9w0cbU5RYGIxnflcSWzC1WjNgrB5L7LUsBrKDy1E8L9ojLrM+nqOQ+6lJE/sgykRI3TBluNKsBY+lUUjD0WanBWVyyfz/5DQ0Gte9jK4bGd9u7AYZvyVJWLSL/gXgvynxjN3XnhvYcHeAEXLkSlG52k2MXv4azMRtcwQLTShvSMDudZCjnOdLTKGbpEB8OFPparMfcbH+j+pVW8EHxzqWsZChV1EK1C1ThKeux1VKxXbfz+kz/qkjQLvamJv7wcJLRilZ+sefdWa0MBZUGj086QQGbknVGs2SJUnPvniJ1d/xeY0ISC+Pz36ZnyE4LWmd7doWtnRgNdy9370hqdq+m+Hlg8BtBFhEBGY08Y7iCdunMjn6iAp9oApjAQG0pSmIRCsj6SxRW90nKw1gy8MXmbxeyOeRjepNkCMpNs3+2yu/vSIOdopcCmFt3wm9SVTXyGTqRrtEz5reT/8GCLMvF9MWO1FOaQwhgjScfcpKaN5V51/Yx39c/cMN6UmysEcXw6kWRwkcu78zsgTYEt9Ut+rk2uPHzihTf3mVSKKzEu6ST7o9Zj4JlS6Y5uhOa77jhr/9CAYGyZyL3zH+wKsIWZFDqpc5JQq+7L3jAFaxAIacTH/xs0NCwQVnMOQ6z0fMji2gb6YnhuMqJYSuww5EDPkkupSYQVXB2xzeOfq68THoHEYJFaxlVaPV0qdyojM8Qo1sIJSg3K/E80O6JzLCwpJd6K9Jhw8xXtg82HyE8TNAcNBD0jBoyUv3ug5oAcDWisGC/jKuLzQyNtAwuBZJ7byqVhShnBdaQhs5ysu/mQWcd/lPi0O95PkyARPQA2WdL9D0L9L4FgowFlOLciGcEpt9sYrfEuJc+z70P6SzOYzl0EWvwzoAZYvdK5zYLYeuLd7KJNX/x7ispB 2VR8PrXE RgHzBraJssSN7NlY/6xyMGgXpAalJ4jW4mKnKsYmwdLNt9dnFWCnB00VwigqUhhmziTTyqaCzj0RwSESugyzgplMnVBHhW8SlYQ1HnGp1yg8MIvGopKWSokXfWp0rmWDWnGTIUrUr4ypCEeDh31NRnpNxLtLMv62DQ8L7Hel6HRFi9dPzsPjeBrEpmvUvf2a1JlIFAfId8OP2+Ds/gytZAkKGUtw4qQy4qXcp9CtWxvJ5k0qkgQZgmiH5XquhOj6IB4pIXYXiKNMmYZuBDFAHzOIl0jPEU9gaXLz2jQB/XGMnYtSIRgCJ4H0H2jd6N+QhDaJUkMsUmvuO3thpl33sxq1f4sQnSQIVxgvBNdIJOGiAfliOh4TgiVXo9B0jIh3n3h3KM8VmWHdMKOY1qkLs3RBRI/naHm6cMImxgrLDQwqIXW33ZNEq/HXb1jxiEFozhKr8kzCRJXLnzBL4F+L4gcKwiw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 13.05.23 01:57, Peter Collingbourne wrote: > The previous patch made it possible for MTE to restore tags before they > are freed by hooking arch_do_swap_page(). > > However, the arch_do_swap_page() hook API is incompatible with swap > restoration in circumstances where we do not have an mm or a vma, > such as swapoff with swapped out shmem, and I expect that ADI will > currently fail to restore tags in these circumstances. This implies that > arch-specific metadata stores ought to be indexed by swap index, as MTE > does, rather than by mm and vma, as ADI does, and we should discourage > hooking arch_do_swap_page(), preferring to hook arch_swap_restore() > instead, as MTE already does. > > Therefore, instead of directly hooking arch_do_swap_page() for > MTE, deprecate that hook, change its default implementation to call > arch_swap_restore() and rely on the existing implementation of the latter > for MTE. > > Fixes: c145e0b47c77 ("mm: streamline COW logic in do_swap_page()") Can you enlighten me how this change fixes that commit? I'm afraid I am missing something important. What is the user-visible impact of the problem, how was it caused by c145e0b47c77, and how does your change fix it? -- Thanks, David / dhildenb