From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id ED210C4167B for ; Tue, 12 Dec 2023 15:02:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 68CD06B02F4; Tue, 12 Dec 2023 10:02:51 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 63CAF6B02F5; Tue, 12 Dec 2023 10:02:51 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4B7BB6B02F6; Tue, 12 Dec 2023 10:02:51 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 3A40F6B02F4 for ; Tue, 12 Dec 2023 10:02:51 -0500 (EST) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 0BB191C125B for ; Tue, 12 Dec 2023 15:02:51 +0000 (UTC) X-FDA: 81558483342.10.9DD5A99 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf20.hostedemail.com (Postfix) with ESMTP id 95C331C001B for ; Tue, 12 Dec 2023 15:02:43 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Lpm6uXwT; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf20.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1702393363; a=rsa-sha256; cv=none; b=uRcsHwQ0fLNQ+aIxhCxvDQtBWxrky0BEt3ORdktwui1VB8kLQc+6yxYJVYRsCkYZKn7VmO oGMkxwOwb0ik5byYZXFq4RV4Dl9l0cOMQr3EFGFOFTJyroRdIWRqQwsvjAn4jZR3RKRUN+ IMNGMoIvXLPze6VhY97fDL/eBqsLVeI= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Lpm6uXwT; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf20.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1702393363; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=pd+2BJ89l5gV7XQZROFyWY0zE3vo5AEgALgsi5pHZ+A=; b=D8DsqvMCeVadCOQzCNrdo1eB+nxkU32svoW2jqFHVWqvcnsqrXs8ALom9dcx65RNlQOSKX rO03DaEKGef15IdL2xxrbTyDrslUpF/DJwqWd1kdOo0/HsebJMjUd4GTHTStJaHo+SfeYb CM1CAkwEv2REoZTv7ESlZueJNpHNvL4= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1702393362; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=pd+2BJ89l5gV7XQZROFyWY0zE3vo5AEgALgsi5pHZ+A=; b=Lpm6uXwT+sI1GibXwZRjEoG7jM6OxgzrVuh60VpliSQZso8G20DVcn0dZydDQsnYznqrWC toCyaoISk3emPrvzphsMjqN95UGEG3Wv5UQ5d0rSEa1D3kh+fPRU4m5gKTxC+x7H//qDsV RViM49fsv+t0xJYreDV8WwkRABNFwY0= Received: from mail-lf1-f70.google.com (mail-lf1-f70.google.com [209.85.167.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-61-5D1sdrpqPt-R0YagPRacNA-1; Tue, 12 Dec 2023 10:02:41 -0500 X-MC-Unique: 5D1sdrpqPt-R0YagPRacNA-1 Received: by mail-lf1-f70.google.com with SMTP id 2adb3069b0e04-50df8e031f2so2646585e87.3 for ; Tue, 12 Dec 2023 07:02:40 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702393359; x=1702998159; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=pd+2BJ89l5gV7XQZROFyWY0zE3vo5AEgALgsi5pHZ+A=; b=V4oUZWytuPCU46WulaFamQy4BCvyfhFtYK2HC0uLfm4reI2qf48an5XSKsP004uQ7K nkN3Cqj/teYjL7DvDTWuWMX98JTqCMrlXSSQTw/noeXYunCYaiSXRwsi9wcKfkBC2Dfe p+xu1sTFpg0m8IHK8wqzUZ9SxS55pEMFytYUa5MYqk05oaMdQTn1WdNbrQEUvZRzxoCt g6V+kXbJXUfbAfsZYr+xxRxZK0U6rPh8GsC/W2lnRBKrDHCUmLUTkYRrYmSIz1lRkf35 ruZGHXczhfDZtM5HTToO8m5CwCRP6sPbJJjjSCErloMv4pWVHfS0ItTc5qtcR3mJWID4 RVCQ== X-Gm-Message-State: AOJu0YwFoqv4+Ke7J67zuoiFB6NmPEn+2j91EMFjE1pRQeZj8j5A0t6D 1/r7iVGM6agRaXL4bc4n3xY2Xm/4/7iPSO1vmPxkEe5V5fR6OOm63qdO420NuQDrvkhnevjuNAx CNGn6nK7K7AM= X-Received: by 2002:ac2:424d:0:b0:50b:f864:dbab with SMTP id m13-20020ac2424d000000b0050bf864dbabmr1194317lfl.237.1702393358827; Tue, 12 Dec 2023 07:02:38 -0800 (PST) X-Google-Smtp-Source: AGHT+IGM2E9EYPBMSZqa4AVbro5zznKGu3v1rbt6OU/+Dh3D93lvE2ucox7XLK9HXTt1RRk+6+M9ww== X-Received: by 2002:ac2:424d:0:b0:50b:f864:dbab with SMTP id m13-20020ac2424d000000b0050bf864dbabmr1194293lfl.237.1702393358346; Tue, 12 Dec 2023 07:02:38 -0800 (PST) Received: from ?IPV6:2003:cb:c74b:ca00:4ca2:ff2c:9092:f070? (p200300cbc74bca004ca2ff2c9092f070.dip0.t-ipconnect.de. [2003:cb:c74b:ca00:4ca2:ff2c:9092:f070]) by smtp.gmail.com with ESMTPSA id t11-20020a05600c450b00b0040c495b1c90sm6451920wmo.11.2023.12.12.07.02.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 12 Dec 2023 07:02:37 -0800 (PST) Message-ID: <2bebcf33-e8b7-468d-86cc-31d6eb355b66@redhat.com> Date: Tue, 12 Dec 2023 16:02:36 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v9 04/10] mm: thp: Support allocation of anonymous multi-size THP To: Ryan Roberts , Andrew Morton , Matthew Wilcox , Yin Fengwei , Yu Zhao , Catalin Marinas , Anshuman Khandual , Yang Shi , "Huang, Ying" , Zi Yan , Luis Chamberlain , Itaru Kitayama , "Kirill A. Shutemov" , John Hubbard , David Rientjes , Vlastimil Babka , Hugh Dickins , Kefeng Wang , Barry Song <21cnbao@gmail.com>, Alistair Popple Cc: linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20231207161211.2374093-1-ryan.roberts@arm.com> <20231207161211.2374093-5-ryan.roberts@arm.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20231207161211.2374093-5-ryan.roberts@arm.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 95C331C001B X-Stat-Signature: mdd664n8u6653xnyd17eeuy3rmua6bm7 X-HE-Tag: 1702393363-27015 X-HE-Meta: U2FsdGVkX1/A8CpV7iDJpJmCTJgnov1lAfuP6asKTk9jSVpd7Ek5BiyHCvfJzTIpfEM5tVcU0cUtx6YcPEXUepTziJRrjsqG568IjVG+ENahPF8tJ91BVKNiHQUljxw/NNTx9NfQJhGLRkcoUTSJ2E284azEgAlNma4pRtyPkLQetGRVCmqGCP+sIPqq7bT7lP0O2n9gpuL4M2+00UjW2AJExxRVInBbyPL0NR8W0r0mc9hJJ2e+y9vT00PxSFJnupmjKnLwasHLeXQdTtFHIRBUlZkey+MH/BN+S6FfdiuxN9gO9JbC5wDa9PaaOYsFXpOyZSmBgnKCoot1V9Qtf7Vgm5deKTiP0WtoEYXKtCfF/98nVUQ74kcf5/be2TlKiKr0zQaK4S+SonT5To1JcmrKJr3QfZVlcIW7/hbLPuacpipMZjCvA0JouWbuE9NKsGD08hJEI77Q6YPSPhXW4+HzIziV49gToyllk8Fjw8Lisaz8Zz8YDhqWME3f3TLl0YeZ1nB97E4hPuGdMhowtikGS0gSEKdWOXDh1WU5l+ef0WcoX/keo0L7P2KgtZHoruXT3yhCqjkXMM8Emnwi/NZJMUWuMCZh3uFvEzCx7rMHrqoX15+zfnRFRaO7vKh/pvKTZ8JOF1lPXoMtduW5EGiCtnzRjoV+qaC3vJ74kcX9XCSZuIExIUQeWNFhjKe0SSCjAY/eGtrtrhp/+5FUzNEjmTnnR+kZZeYV9uNUR6sO+LwHkGqGO/f/5Va9A5yx3KO3iM9DS4ehFW0RIGx0Ux2zXIBmbGuMTFnD5VmhDAd18cKODQuUZFhF9rQVIiKQR3/YpW8r4r6iERpW4lZFhTynSBEtYPk2NgxdstMrZ9jfK+5K286JcjCW3303Wm4Lgbuq4n/O0bI6KaK97cT/VcM/gM0obe9o2u3jzjvNVlPOvFFAngsWhvm2kZEsjfj/obiqWJsIy7yhCiEDkJT 81Wwkuqm TphoE8o4HLoYguLVM5XG4WGouDjtPGPXtRwaleON1YOhOgezFCCdBJgJ9Z45eGMX5loTvomzgf/MbW3CpcZ9z9nmoiIZ+aWmaCF3NAMk7gAZBAYtMRJsme/l9oRCoDo5q/zbXRHQtoAb/qFlDAIHo2YerkXohY9gpggDi0orhqJaExdjuR+dSz/Xx5Z45HKBJstwqh2qjGz4SjOABdCq7u3HCwxXgGZTUDcwjix//5+C1zZbyAzAQ3hXvB3pN2f9mrbYWQ9KZzz2TpBKGLLlt8BFCQKALmZgQljFc5KccQRLA8E2byKU/V0eXfppU8whBixtJJdUA+dK8wtEKOTKrz1N/8UArG8KOdX1fxOM/6htvfSXEaf6Cy3p4uIilc5tLMJm7ID2OYkzy4kpScZwQdCb6siQ7WBauii+G5yQNqU3wPi8R8g2suc28FSi6Zf0KPW1mpidfEwiIRhVHNQYySdMfF1WlVldTiv0G1IZ0tnXWBxhk5qJX6QMdS3nBJqH/U/1+08jszqziXih3nuvi6mWKdoiSf3AOyHYZQN3UpQmGQl43+sBCEr2ZhUVTftGQFHNItLonInQ//A2AXrT/RAN0NxCfFGuokIHeLIvqJ3R/Rtm/U1gvpRgnRw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 07.12.23 17:12, Ryan Roberts wrote: > Introduce the logic to allow THP to be configured (through the new sysfs > interface we just added) to allocate large folios to back anonymous > memory, which are larger than the base page size but smaller than > PMD-size. We call this new THP extension "multi-size THP" (mTHP). > > mTHP continues to be PTE-mapped, but in many cases can still provide > similar benefits to traditional PMD-sized THP: Page faults are > significantly reduced (by a factor of e.g. 4, 8, 16, etc. depending on > the configured order), but latency spikes are much less prominent > because the size of each page isn't as huge as the PMD-sized variant and > there is less memory to clear in each page fault. The number of per-page > operations (e.g. ref counting, rmap management, lru list management) are > also significantly reduced since those ops now become per-folio. I'll note that with always-pte-mapped-thp it will be much easier to support incremental page clearing (e.g., zero only parts of the folio and map the remainder in a pro-non-like fashion whereby we'll zero on the next page fault). With a PMD-sized thp, you have to eventually place/rip out page tables to achieve that. > > Some architectures also employ TLB compression mechanisms to squeeze > more entries in when a set of PTEs are virtually and physically > contiguous and approporiately aligned. In this case, TLB misses will > occur less often. > > The new behaviour is disabled by default, but can be enabled at runtime > by writing to /sys/kernel/mm/transparent_hugepage/hugepage-XXkb/enabled > (see documentation in previous commit). The long term aim is to change > the default to include suitable lower orders, but there are some risks > around internal fragmentation that need to be better understood first. > > Tested-by: Kefeng Wang > Tested-by: John Hubbard > Signed-off-by: Ryan Roberts > --- > include/linux/huge_mm.h | 6 ++- > mm/memory.c | 111 ++++++++++++++++++++++++++++++++++++---- > 2 files changed, 106 insertions(+), 11 deletions(-) > > diff --git a/include/linux/huge_mm.h b/include/linux/huge_mm.h > index 609c153bae57..fa7a38a30fc6 100644 > --- a/include/linux/huge_mm.h > +++ b/include/linux/huge_mm.h > @@ -68,9 +68,11 @@ extern struct kobj_attribute shmem_enabled_attr; > #define HPAGE_PMD_NR (1< + > +#ifdef CONFIG_TRANSPARENT_HUGEPAGE > +static struct folio *alloc_anon_folio(struct vm_fault *vmf) > +{ > + struct vm_area_struct *vma = vmf->vma; > + unsigned long orders; > + struct folio *folio; > + unsigned long addr; > + pte_t *pte; > + gfp_t gfp; > + int order; > + > + /* > + * If uffd is active for the vma we need per-page fault fidelity to > + * maintain the uffd semantics. > + */ > + if (unlikely(userfaultfd_armed(vma))) > + goto fallback; > + > + /* > + * Get a list of all the (large) orders below PMD_ORDER that are enabled > + * for this vma. Then filter out the orders that can't be allocated over > + * the faulting address and still be fully contained in the vma. > + */ > + orders = thp_vma_allowable_orders(vma, vma->vm_flags, false, true, true, > + BIT(PMD_ORDER) - 1); > + orders = thp_vma_suitable_orders(vma, vmf->address, orders); > + > + if (!orders) > + goto fallback; > + > + pte = pte_offset_map(vmf->pmd, vmf->address & PMD_MASK); > + if (!pte) > + return ERR_PTR(-EAGAIN); > + > + /* > + * Find the highest order where the aligned range is completely > + * pte_none(). Note that all remaining orders will be completely > + * pte_none(). > + */ > + order = highest_order(orders); > + while (orders) { > + addr = ALIGN_DOWN(vmf->address, PAGE_SIZE << order); > + if (pte_range_none(pte + pte_index(addr), 1 << order)) > + break; > + order = next_order(&orders, order); > + } > + > + pte_unmap(pte); > + > + /* Try allocating the highest of the remaining orders. */ > + gfp = vma_thp_gfp_mask(vma); > + while (orders) { > + addr = ALIGN_DOWN(vmf->address, PAGE_SIZE << order); > + folio = vma_alloc_folio(gfp, order, vma, addr, true); > + if (folio) { > + clear_huge_page(&folio->page, vmf->address, 1 << order); > + return folio; > + } > + order = next_order(&orders, order); > + } > + > +fallback: > + return vma_alloc_zeroed_movable_folio(vma, vmf->address); > +} > +#else > +#define alloc_anon_folio(vmf) \ > + vma_alloc_zeroed_movable_folio((vmf)->vma, (vmf)->address) > +#endif A neater alternative might be static struct folio *alloc_anon_folio(struct vm_fault *vmf) { #ifdef CONFIG_TRANSPARENT_HUGEPAGE /* magic */ fallback: #endif return vma_alloc_zeroed_movable_folio((vmf)->vma, (vmf)->address): } [...] Acked-by: David Hildenbrand -- Cheers, David / dhildenb