From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 56AA8C021B8 for ; Wed, 26 Feb 2025 20:06:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DA5A36B008A; Wed, 26 Feb 2025 15:06:07 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D561D6B008C; Wed, 26 Feb 2025 15:06:07 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BCFD56B0093; Wed, 26 Feb 2025 15:06:07 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 9D72E6B008A for ; Wed, 26 Feb 2025 15:06:07 -0500 (EST) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 58D3144266 for ; Wed, 26 Feb 2025 20:06:07 +0000 (UTC) X-FDA: 83163177174.28.FA02285 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf03.hostedemail.com (Postfix) with ESMTP id 6680420008 for ; Wed, 26 Feb 2025 20:06:04 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=cgr0cl4J; spf=pass (imf03.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740600364; a=rsa-sha256; cv=none; b=mk78h2uiiC38yx0/q0AAoQSqlzXLl6wQJxLWn8ecwAZ/Wk3wEfrPGBlf6KAEEjODSu5Q/z tLPnaxzo1U/rELvTxflbSCPUXyT0G44x9vOTCkpvSgKZBziK+/G2GlzfSK5/HEa4M18eYS qghn1Z+BiP0rwpkakfl2MTpVDutGzX0= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=cgr0cl4J; spf=pass (imf03.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740600364; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=VkP4TuFVcedC8r8X6iUSdW1moEur4w/J0xKrd7lJWeA=; b=h81EPWSXfpIxjneH3MpUM4KqCAqrQd/fMCMud7A1dBXtVXc0bPJsUCMXxByMXpfLhO0ecC oYV0JkTOA2KjPFxJM5B7pRgG91rr0dKBXkzLDQWoEuHvcAQG+sKTNGT72Jk8qmG8r+Opgr dZhMONKx1ZWikc7/UZZMm8ZwL2g6wM0= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1740600363; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=VkP4TuFVcedC8r8X6iUSdW1moEur4w/J0xKrd7lJWeA=; b=cgr0cl4JyGILmdMqaia6RBFIkBiU6Wyqu1kQuzIHHUcH7SdKABEQjYt9lxnB+Fpt/Y5e17 meJaea0+343TeiNPBQUt9lxuarF6PwcIxfvh3DNYtbJ7eQ7Cerp7wnecxxSteni7yNgl9s T5XHwiF4cRzUdKXNODgRVPUVg9UH6sI= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-635-dyaIbo1oNO6PBZ7z9vkejQ-1; Wed, 26 Feb 2025 15:06:02 -0500 X-MC-Unique: dyaIbo1oNO6PBZ7z9vkejQ-1 X-Mimecast-MFC-AGG-ID: dyaIbo1oNO6PBZ7z9vkejQ_1740600361 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-4399a5afc95so727985e9.3 for ; Wed, 26 Feb 2025 12:06:02 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740600361; x=1741205161; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=VkP4TuFVcedC8r8X6iUSdW1moEur4w/J0xKrd7lJWeA=; b=nsLTu7fXy/pdf4hekomvYeInBfYwDmRCsjG5hbk3zQZ9ssWM1GWVim890ValKYNefG NvMj3bj9zI/fM81+yG5MN2MKBQ5c7Zwk7d00Q5A/Vw6iS/4lbisOJt92BY9ipgg2lWTS t1LR/uMbf1iBRvijXTX7oQp1B9J+N4mPSO/TkApRIoMw10VljquReILs5O3kdWPtkN9B 5EzDNZBtnZpFfa8UAHEeP+/Bz39rUR1KoND3bsSvW9eQdnm7ai0VhIPNn6f5cP+f3Sds gw0DDh8MYQO4vkxTWitMg1vN0ZoRqTcKZhKrtLhJDU3AOCq5qC4F1zpi2Umx+2rGoeHC K2zg== X-Forwarded-Encrypted: i=1; AJvYcCV0Lv8Tz+1sXQeXy/kYRebodE5drg608up45y2v6SeMLxWbGDfr0jOdOKniAo+ENZfpOmQWxmYSYA==@kvack.org X-Gm-Message-State: AOJu0Yz7oq47Rm486WhPJTh4PNt1cKtnvbpnIt6NlyEqUmU19ZH12bPE q0Y6BICMaJg1ERzOcgoYA+lneV0csxKwY3OoKpZv5RbhMn54Rti40vWjVFyCdIfjTXiHdf15nP6 eCE7WrKm2EbcC4h7Y0umaagO649PLPH1+0wILXnLpCJ7S0JGr X-Gm-Gg: ASbGnctH8BGP6FYYw2KE7h9szdXoJwEOS1h210nbsvuhRmBpE8DItSpSTF/J9fYDiOU HEBzZ3+1w5XY0sLQ1TEf/2NI5mJiaSItmKcATr7nxCNsQOg6QtywncAnbxCvLp/TZQabb1Zh+dq 2MIjfhD8uABdu9dANrTI3yLR8OOkhjaqJoQPaUuFjLauCd5hGbPRohBc4uvkg4Fs4zHeL2Wz4qo 61i4jJQFsOJZ/J1G0t83zxT732n1HlBc9qeteKvpXC+rDEjBuJspJwFW7hAEGPhaa43q45U60KK vPI6j2IH6kibSLIytwj7h5nYLu8C35yq0ecpH1up6hcu X-Received: by 2002:a05:600c:4ed1:b0:439:a155:549d with SMTP id 5b1f17b1804b1-439ae1eacfdmr199361665e9.12.1740600361056; Wed, 26 Feb 2025 12:06:01 -0800 (PST) X-Google-Smtp-Source: AGHT+IGSLrbCY8KNtNI+AO0sxh7vDOX9ToRLiD06mZNoQeMc6k2mNBytgFCMdXePpXFhkuvOF0ZMYA== X-Received: by 2002:a05:600c:4ed1:b0:439:a155:549d with SMTP id 5b1f17b1804b1-439ae1eacfdmr199361515e9.12.1740600360655; Wed, 26 Feb 2025 12:06:00 -0800 (PST) Received: from [192.168.3.141] (p5b0c6611.dip0.t-ipconnect.de. [91.12.102.17]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43aba5711dfsm32306775e9.27.2025.02.26.12.05.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 26 Feb 2025 12:06:00 -0800 (PST) Message-ID: <2be79033-187f-4dff-af2b-d97a52a450a8@redhat.com> Date: Wed, 26 Feb 2025 21:05:59 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 5/6] mm: Provide address mask in struct follow_pfnmap_args To: Alex Williamson Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org, peterx@redhat.com, mitchell.augustin@canonical.com, clg@redhat.com, jgg@nvidia.com, akpm@linux-foundation.org, linux-mm@kvack.org References: <20250218222209.1382449-1-alex.williamson@redhat.com> <20250218222209.1382449-6-alex.williamson@redhat.com> <3d1315ab-ba94-46c2-8dbf-ef26454f7007@redhat.com> <20250226125435.72bbb00a.alex.williamson@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20250226125435.72bbb00a.alex.williamson@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 1EQXNodP1mKMblrUa0QsXKUP0J1xJWZmXgstYI71_68_1740600361 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 6680420008 X-Stat-Signature: k8ffi3kyagcqf35gniwm886oz7mxhcdk X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1740600364-200802 X-HE-Meta: U2FsdGVkX189t+H9DUMFQ/XxdEkdXlZch8VSlGw0v/RUDeBpzM+qO+vyvHJcCbj9lXsM5jJpL43QMNT4aWcrVxo2L5SBBTeQErPapbLLXoTCPQK1DBEIZYIEbA7SRidA6DGFijJG8n1uKi0vkoXr3zC8ivgt8YmKQnVLJZeX/etNNJPvL3jmHqYPOVdJoN/w9I3jJpyTcc4peMbX0w1FmnQOFG/zY8k+u4c8yDU1VP6EtVMyUxvM9M1mbVTImnbagDDOcZWwCs/1lYEz8CJl9GIEttu5ozpnT2XX5+iTcqHH9/B+NuvOVYPQ4ltkYK4/7LTgmvRk/VxssZDVMC4p4jHMhQ13RhfntdtXM29bM1t/UpaYkoAFO9HarG0zV25MwIfPlifWONdWeRkQMgEZFsLaEXuyg/KXrDZwE7XlX2VT1lNpYYR386+v1is/6YQ7VmFRM2twDP2aD/uo94FeBERcdgy1KShKLzGWqzGK8MthmViaTrkQ3YZzBhF4UDiiOQMdt4PK2+czT8rViRHhzL+F6+yMWMFz7xXuynMYjAHxsbKo0RQfIWcSsLtBhK9HponFZ2OMHFG4+HAeu+wxUutl+cXzADT+lhOVzo3UCvJIPUbKJg0+e/l9eiTI5gYf1kmFo6YUudJIOjj20yHkHVy33ysyKdOr7YH64++kPwoAov51LtqmwdlQ82LNBaaN39CrzuD8e7d5mhNBzdSD5IhgNzUZA96cUjRZmDAUxS6UWWTIPzQUYFfNPvd4bo7U7qoW4exyEWJNfS9SxsMjb4UFI64f2d8kNRrTmtq87WS56YYkkXBWVIkiq0NzoE1BFO0aMS6NyA8+CgRBOYtRCYgNi6cjUtDZwMUdSnOjGMVljUKYJdJokeKCe+ccJvcgh6sdIlNrN+BfPbe9RO0JmNTjTvjHg++jJDg5syZCQYis9HD736T3OhXy1CJMciLWH1xy2MD+ppp7u9d1oTy AodklVvX EI3I66SkK82NarQNlvVj6LOqk7cIytrGuCh7CrUrYin6sW1yqnQibEIpEPnaUkYgbpPjboX6Nz0WwtGE6TOqPEUXlzMDTYkiHIRripA/DeaPKG4WpdN42Oe86GbfczGItJPF/2ju89vNU0cvvp+s+q2oPYlhGQq3PjJlIkRTN+55PT/yd2y5yfU7T8+2qY6rl6I0EhN2B6VwmFmBLFtttfbeirPEBCIJuGto9OPcUsptKSDzndcjcAKCqy5AMsauopwCi6ne47/JBQFqUZ/7VKfkUMVBKJmaYmLEOIJIH2hU4rp3TkWdjmwq97EHdOAcP+o2Phqz+0/rGLSiUtFJt4+sPHBjfAVWUNSlc5MDRxvEri3iYt+rpwuenT5ZcvWTudepfyrhs7PYKOfM3NMPN3Q/VOSDutuR6NV4rH1y8dKEwOcik+do5fR3x0cxfaPVaq8SSKwL8OxvAA1MX6UV36GD8gs0T4wqZaGv1rnIZELUeT7H21F45B+IXcW3r/lPm5/YPuqHiKv1gfY34E4IPuSHxx3Cfa46hp/XjmAsaYhtdYrgqUl/QQLjcQY4e1qtlaRg2H/3mqWDQziddst/S8FLUHpw3vc1+LbqTZsluwXIh3KFnfoWUwFzQuOBAF/7KTgWOV5FckySS4kdTH9ECndzOaCguDBxFfKDlT2j/nOTyAy5GJF3XYiz75Q== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000023, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 26.02.25 20:54, Alex Williamson wrote: > On Wed, 19 Feb 2025 09:31:48 +0100 > David Hildenbrand wrote: > >> On 18.02.25 23:22, Alex Williamson wrote: >>> follow_pfnmap_start() walks the page table for a given address and >>> fills out the struct follow_pfnmap_args in pfnmap_args_setup(). >>> The address mask of the page table level is already provided to this >>> latter function for calculating the pfn. This address mask can also >>> be useful for the caller to determine the extent of the contiguous >>> mapping. >>> >>> For example, vfio-pci now supports huge_fault for pfnmaps and is able >>> to insert pud and pmd mappings. When we DMA map these pfnmaps, ex. >>> PCI MMIO BARs, we iterate follow_pfnmap_start() to get each pfn to test >>> for a contiguous pfn range. Providing the mapping address mask allows >>> us to skip the extent of the mapping level. Assuming a 1GB pud level >>> and 4KB page size, iterations are reduced by a factor of 256K. In wall >>> clock time, mapping a 32GB PCI BAR is reduced from ~1s to <1ms. >>> >>> Cc: Andrew Morton >>> Cc: David Hildenbrand >>> Cc: linux-mm@kvack.org >>> Reviewed-by: Peter Xu >>> Reviewed-by: "Mitchell Augustin" >>> Tested-by: "Mitchell Augustin" >>> Reviewed-by: Jason Gunthorpe >>> Signed-off-by: Alex Williamson >>> --- >> >> Acked-by: David Hildenbrand > > Thanks, David! > > Is there any objection from mm folks to bring this in through the vfio > tree? I assume it's fine. Andrew is on CC, so he should be aware of it. I'm not aware of possible clashes. -- Cheers, David / dhildenb