From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BBBBEC48BC3 for ; Wed, 21 Feb 2024 09:22:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 539666B0080; Wed, 21 Feb 2024 04:22:00 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 4E9216B0081; Wed, 21 Feb 2024 04:22:00 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 38B086B0082; Wed, 21 Feb 2024 04:22:00 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 28AD66B0080 for ; Wed, 21 Feb 2024 04:22:00 -0500 (EST) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id B71991409B9 for ; Wed, 21 Feb 2024 09:21:59 +0000 (UTC) X-FDA: 81815269158.19.3437A47 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf20.hostedemail.com (Postfix) with ESMTP id A15811C0009 for ; Wed, 21 Feb 2024 09:21:57 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=USQKapm9; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf20.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1708507317; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=P28Fq0JrXGeyJdQJQF7vTKqPybUH7oxtv7SEgj52+bA=; b=ArN0zstaCbKNJ8mihlKWzRUumWLCH1AEn7lV6umMgFgdhFq7xUmzbXp79Za9fkwwEPH3LJ n7tFeyknzvAzbNjetBB5LGZHdwJpK7wd4J2M0JjHry6lGyvC9NYKJqC+jb1eD4gWxdeEJE 7bB2AxUpPMpnAc9kyG6ToZqa4465bVY= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=USQKapm9; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf20.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1708507317; a=rsa-sha256; cv=none; b=adKwWITt4+nmWMVgpX1pBSASF/ER9uLfBBjrr/KL9ioxXAnv9E2eU+saoST8AFuwchiH/D fjDW7MTzTAvc+Iom2OVG/+tkNVT3+etHfBWCPqzsG/WDU20ZHI0qVktKPx0XR5PzbfI8YO ptznphWCPtdj3fxpdKLIs3ZJE9takMA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1708507317; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=P28Fq0JrXGeyJdQJQF7vTKqPybUH7oxtv7SEgj52+bA=; b=USQKapm9DrAFwAKgaE4JujTLPm6SZM8IPpyD6Ac7u/7U/qKNpjcbbqk7DQEVlycjNwAzGN HCll56K/0hisr4B0fZie7uuwYPFCEqjMGVz3RmimclAbEL8CDkamJbf6FfSJcTMPSQlA4E DbEguzNmsHRoHpoR5/s4Zn/tbxSHQTU= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-290-Z60DlZfwPKKxkV_ZX4bYig-1; Wed, 21 Feb 2024 04:21:55 -0500 X-MC-Unique: Z60DlZfwPKKxkV_ZX4bYig-1 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-33d7e755f52so129416f8f.1 for ; Wed, 21 Feb 2024 01:21:54 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708507314; x=1709112114; h=content-transfer-encoding:in-reply-to:organization:autocrypt :references:cc:to:from:content-language:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=P28Fq0JrXGeyJdQJQF7vTKqPybUH7oxtv7SEgj52+bA=; b=RjMTGF9s63vbsLNBe/lrnIb1xq8kEtbfE3whJw602N6CgRSu7eJ6EjgfyNm2nqxDKc 5kObnCad+FuB0nG5wVDtP1WWX8sGtcTolKrRgt686kYiOYBHDQ+uTdfca8JjUkKCYRTX ORLfV7ZDTzaJIEyTduszLi3S0jfKiJcYf6BhWeh2L6RaoVgoJpXC2192+gQA+XQfg5eW xtWFDhqmqh/jS6Hjvn92YjWIYdx04rCHg7LRoD578LyL74DUBvTGHvmbBbUCBqKdPF2M pLesdj2cr294rxhSHPHoq9ZSUUTP0QJZYpindrS5SPdo6naLtEHOAry9h/ZBHO/Pgqbf OUpw== X-Forwarded-Encrypted: i=1; AJvYcCVJwjl++hEL1z5fxCBg6vOP01UCKxrgUdSF1qj5l6XpwhdUAYgqzlEnRwvQSmrq4cqyhJP9KBESMV8lyldujt2A7UU= X-Gm-Message-State: AOJu0Yx91twlbm+cTJcdzqfckiB3mzszIMxHQdigVKaMSIREZSRHWHZH Iin7H3j6wM18ER5Svz6QawSPp0fIxUcQpT33BowFqL6eZVaEKMXYHDcgsRl3pKdmN70rLGJc2uH BX4lHihinZDvUTSha9tj/KSKjGui0QlO9BZB3KaB2fbjnNsTS X-Received: by 2002:adf:ec4a:0:b0:33d:82c2:ad8d with SMTP id w10-20020adfec4a000000b0033d82c2ad8dmr308003wrn.56.1708507313865; Wed, 21 Feb 2024 01:21:53 -0800 (PST) X-Google-Smtp-Source: AGHT+IHrcSHwbkcZMHd7SCXXxT5nn1F/BZ1IhnCxVe0JaavtnOYrFz1cY0G2mwM9GnXlRROiXShn2Q== X-Received: by 2002:adf:ec4a:0:b0:33d:82c2:ad8d with SMTP id w10-20020adfec4a000000b0033d82c2ad8dmr307981wrn.56.1708507313407; Wed, 21 Feb 2024 01:21:53 -0800 (PST) Received: from [10.32.64.237] (nat-pool-muc-t.redhat.com. [149.14.88.26]) by smtp.gmail.com with ESMTPSA id bj29-20020a0560001e1d00b0033d5c454f03sm7502886wrb.114.2024.02.21.01.21.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 21 Feb 2024 01:21:53 -0800 (PST) Message-ID: <2bdc8a6e-fa7d-4893-951a-7212c5e04f9a@redhat.com> Date: Wed, 21 Feb 2024 10:21:52 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] madvise:madvise_cold_or_pageout_pte_range(): allow split while folio_estimated_sharers = 0 From: David Hildenbrand To: Barry Song <21cnbao@gmail.com>, akpm@linux-foundation.org, linux-mm@kvack.org Cc: linux-kernel@vger.kernel.org, Barry Song , Yin Fengwei , Yu Zhao , Ryan Roberts , Kefeng Wang , Matthew Wilcox , Minchan Kim , Vishal Moola , Yang Shi References: <20240221085036.105621-1-21cnbao@gmail.com> <4c1224e3-5c02-4d5d-9379-d3b74b1174dd@redhat.com> Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <4c1224e3-5c02-4d5d-9379-d3b74b1174dd@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: A15811C0009 X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: pe5guq7err9wscq15ay59y4aiwtmgash X-HE-Tag: 1708507317-140562 X-HE-Meta: U2FsdGVkX1//fKJIbQgQKXTfcFM2OeanACAAkRhssoC4TDBRWi0mcCJYFU38ta9wQxldE17VwydZgtHfVrPthXbi4oWY0/YNTUOHguHj70P5cTauG0WPx99mL7pG/vhHL3zWGeRE7cL6b0dZBeMY2r8mM91ril8GQhRwGDg91xzfGu+SP2A4BiASTFKtfqg9BbOrdXf+GL4ZNBEhgxrwUtFHah8xVxBwrlKcneGpaYQmpSmcS30qivopQmuVa0w1i2Pi3O/d6c8PoOfkTV1QjInA8hw263eirF7nDaTvm6kwH2thEi/KmyOM7fjM3d4Y8B3iYgBDCGNoBQNE+QlT8PXjXmW4Z4xakfcfuPbMuJtnhJx1D9gecIJS1xOKWqycxLaFy1ZfCmXj8IDlQ3UpPiDzERk6fSMwlJmG5OT5QH13q7uApv9dWPdvlpJFfc7GMPRXpsjn0l7Hpst8SMzv8mw8gDYM6xSYdSuisvuIa9xhAwkHwbKcOreET9z5mb4jdA+V2ZFtAORLpT2xRHOqTXpegoc2Gm2DmpJ+AvIeCjjeUIUJfR3LtXqVJiK7Z+OsiQsEhDvmXcOtT67FkUz9SL1mYIniBZE62rzd0ZX3onJtkmq4YqEcoUBQXxfMu8AO6GTVMgDdyoUtlbDBynZ6H6zTVYvo98INB/qjIT01A3qjDnrUNLOT6xuPz4SBj3ddN5tm+pKakzaWOCwxzrfd73vau/DUZOS+S+M7WpOJTmyRjxEwHYdXYkSIbvNNnL6dZ/NtA22KRMi/KufAg6yNUfGY14YRg2mhm00vhjLmt734jYO7n8Kat61lYkv8A6GVrYvW/MmUcMChSfxc9jsSeCbmHLpEow5ZhlseeJo1afkVncgO0pghSkdDRrQpwvL679qd+DVF5vOFUOaLFRK9gzqz4Ilg4S0vaqwvSHPiTllH2MYE+KbYHKOpXNh3BwaWYX9m1ueNQXDe+2HAklZ 9LeBgTfu ad6CnN/q94TFGiUOWhjFEgZFNEoHhp7m8RKmHWjURuSq+gLw0Urb5TT0bgtOZJLjS5L0+KKQe3bFbvkBCYPp+zU3KYGwucF5j19HBqgp6151GtQLZ5gEj+UZFh7phN3fQJaJWQX6vN1KFdG6dwJOVnB9o/53cwqCfTJMjnjUdBEmfejcg0TZ0Z9MJl1PVzmP9Sc1fe0I9HUMH6iFW0JegKqxkWS3Jq0MzovTNF5Y6EkfxssuHl8eBr38UC+f5DWJiSBoV7EDqj0Z2dtVL55S6IduMjCBZLk0fCTAG X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 21.02.24 10:15, David Hildenbrand wrote: > On 21.02.24 09:50, Barry Song wrote: >> From: Barry Song >> >> The purpose is stopping splitting large folios whose mapcount are 2 or >> above. Folios whose estimated_shares = 0 should be still perfect and >> even better candidates than estimated_shares = 1. >> >> Consider a pte-mapped large folio with 16 subpages, if we unmap 1-15, >> the current code will split folios and reclaim them while madvise goes >> on this folio; but if we unmap subpage 0, we will keep this folio and >> break. This is weird. >> >> For pmd-mapped large folios, we can still use "= 1" as the condition >> as anyway we have the entire map for it. So this patch doesn't change >> the condition for pmd-mapped large folios. >> This also explains why we had been using "= 1" for both pmd-mapped and >> pte-mapped large folios before commit 07e8c82b5eff ("madvise: convert >> madvise_cold_or_pageout_pte_range() to use folios"), because in the >> past, we used the mapcount of the specific subpage, since the subpage >> had pte present, its mapcount wouldn't be 0. >> >> The problem can be quite easily reproduced by writing a small program, >> unmapping the first subpage of a pte-mapped large folio vs. unmapping >> anyone other than the first subpage. >> >> Fixes: 2f406263e3e9 ("madvise:madvise_cold_or_pageout_pte_range(): don't use mapcount() against large folio for sharing check") >> Cc: Yin Fengwei >> Cc: Yu Zhao >> Cc: Ryan Roberts >> Cc: David Hildenbrand >> Cc: Kefeng Wang >> Cc: Matthew Wilcox >> Cc: Minchan Kim >> Cc: Vishal Moola (Oracle) >> Cc: Yang Shi >> Signed-off-by: Barry Song >> --- >> mm/madvise.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/mm/madvise.c b/mm/madvise.c >> index cfa5e7288261..abde3edb04f0 100644 >> --- a/mm/madvise.c >> +++ b/mm/madvise.c >> @@ -453,7 +453,7 @@ static int madvise_cold_or_pageout_pte_range(pmd_t *pmd, >> if (folio_test_large(folio)) { >> int err; >> >> - if (folio_estimated_sharers(folio) != 1) >> + if (folio_estimated_sharers(folio) > 1) >> break; >> if (pageout_anon_only_filter && !folio_test_anon(folio)) >> break; > > That's also what I do in > > https://lkml.kernel.org/r/20231124132626.235350-4-david@redhat.com > > I'll revive that soon. Forgot to add: we can pull this in early. Reviewed-by: David Hildenbrand (I'll do the simple folio_estimated_sharers() to folio_mapped_shared() conversion first and optimize with total mapcount separately) -- Cheers, David / dhildenb