From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.8 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1B39BC2D0A3 for ; Wed, 4 Nov 2020 08:50:37 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 7F56E2220B for ; Wed, 4 Nov 2020 08:50:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="OsMZKWk6" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7F56E2220B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 9515C6B0036; Wed, 4 Nov 2020 03:50:35 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 9025C6B005D; Wed, 4 Nov 2020 03:50:35 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7CAC46B0068; Wed, 4 Nov 2020 03:50:35 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0247.hostedemail.com [216.40.44.247]) by kanga.kvack.org (Postfix) with ESMTP id 4D3A96B0036 for ; Wed, 4 Nov 2020 03:50:35 -0500 (EST) Received: from smtpin17.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id D7203181AC9CB for ; Wed, 4 Nov 2020 08:50:34 +0000 (UTC) X-FDA: 77446114788.17.edge16_210b231272bf Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin17.hostedemail.com (Postfix) with ESMTP id BD8EF180D0181 for ; Wed, 4 Nov 2020 08:50:34 +0000 (UTC) X-HE-Tag: edge16_210b231272bf X-Filterd-Recvd-Size: 4737 Received: from mail-wr1-f66.google.com (mail-wr1-f66.google.com [209.85.221.66]) by imf21.hostedemail.com (Postfix) with ESMTP for ; Wed, 4 Nov 2020 08:50:34 +0000 (UTC) Received: by mail-wr1-f66.google.com with SMTP id e6so3882993wro.1 for ; Wed, 04 Nov 2020 00:50:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=rb5+9Uu5Pextlzz28MhD13qyqn/S8yH6ObfjNiHXu9M=; b=OsMZKWk6API99ut4fdwjboNr+6mH122uBWsHSEeLEzBJ2/JHKBZMheoHwcEmiaCJ+a 6zgXIKL5hWM/tTnynAFcCrYAShQ/EV11D+LvWEGbBCKmiTx1zMRI1eIfyBEtnztem5MZ KeZ1qR3O4HRdg7PPkdSMUuxhlCukI711ZtwwGEnvOSyawakesItvR57naIzLJ7IWSSZQ 7rUQ3l61niHRazUr0u93egm8VpkEtNsvTRmos4TzPDIFWr2OQxXSUOThBqUoBNV3qVmH M33dtj14JicyN31dudzygBMkchcX2rGnt3KVma9k5e6G4EN89c04Xi3SxWLi2Mh+3Lh5 I05A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=rb5+9Uu5Pextlzz28MhD13qyqn/S8yH6ObfjNiHXu9M=; b=bSCgD0mKAySVt6Dk75c3NGAg7CqK50DaFt/ckqr62X0P2FzVsJid9d5H3gAwDk2vtF NfSBTO+5kcqeOc4CH3NYuANR95Vk/1ZpDv1kBHHZJTxtrK2SQRVgAHTL47weBBexO9a/ 9CpS6jo99YA94A7DygQ24UIZihhSlhZFmWFUZxGs+KSTF7/AKytUXv0m9oPn1ak1i9G3 muHPRZDQlHLqCfq8jsZK9QMUImiIaaQMeuOMnbF6zmOvtLrR5mMRHOUpLKfbe+YAxVjq YzPGxiH7IlXVtogEgPGu7jCcjM0Znx3JIw31/PO5wVoct/+9X1NGadRZdtx52USMpdzM lUbA== X-Gm-Message-State: AOAM531W7vYArbWAzrrNoaMduH4pxaWEfKAj/3Dp+bcE951ahc+Sl9FE jAf5NamucOaqemv32OKRjvc= X-Google-Smtp-Source: ABdhPJwIaJwaDd5dlm6XkBJ424PxxvIm7rtGoOuLm192Wv1qUSuLJ3vrfQjzeQLqxYUXNvHGOAC9FA== X-Received: by 2002:adf:ebc6:: with SMTP id v6mr29596142wrn.427.1604479833095; Wed, 04 Nov 2020 00:50:33 -0800 (PST) Received: from [192.168.212.98] (104.160.185.81.rev.sfr.net. [81.185.160.104]) by smtp.gmail.com with ESMTPSA id k18sm1608302wrx.96.2020.11.04.00.50.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 04 Nov 2020 00:50:32 -0800 (PST) Subject: Re: [PATCH 1/1] mm: avoid re-using pfmemalloc page in page_frag_alloc() To: Rama Nichanamatlu , Matthew Wilcox Cc: Dongli Zhang , linux-mm@kvack.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, akpm@linux-foundation.org, davem@davemloft.net, kuba@kernel.org, aruna.ramakrishna@oracle.com, bert.barbe@oracle.com, venkat.x.venkatsubra@oracle.com, manjunath.b.patil@oracle.com, joe.jin@oracle.com, srinivas.eeda@oracle.com References: <20201103193239.1807-1-dongli.zhang@oracle.com> <20201103203500.GG27442@casper.infradead.org> <7141038d-af06-70b2-9f50-bf9fdf252e22@oracle.com> <20201103211541.GH27442@casper.infradead.org> <20201104011640.GE2445@rnichana-ThinkPad-T480> From: Eric Dumazet Message-ID: <2bce996a-0a62-9d14-4310-a4c5cb1ddeae@gmail.com> Date: Wed, 4 Nov 2020 09:50:30 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.3.1 MIME-Version: 1.0 In-Reply-To: <20201104011640.GE2445@rnichana-ThinkPad-T480> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 11/4/20 2:16 AM, Rama Nichanamatlu wrote: >> Thanks for providing the numbers.=C2=A0 Do you think that dropping (up= to) >> 7 packets is acceptable? >=20 > net.ipv4.tcp_syn_retries =3D 6 >=20 > tcp clients wouldn't even get that far leading to connect establish iss= ues. This does not really matter. If host was under memory pressure, dropping a few packets is really not an issue. Please do not add expensive checks in fast path, just to "not drop a pack= et" even if the world is collapsing. Also consider that NIC typically have thousands of pre-allocated page/fra= gs for their RX ring buffers, they might all have pfmemalloc set, so we are = speaking of thousands of packet drops before the RX-ring can be refilled with norm= al (non pfmemalloc) page/frags. If we want to solve this issue more generically, we would have to try to copy data into a non pfmemalloc frag instead of dropping skb that had frags allocated minutes ago under memory pressure. This copy could happen in core networking stack, but this seems adding more pressure to mm layer under pressure.