From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4E03DC64EC4 for ; Mon, 30 Jan 2023 17:09:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CC3806B0071; Mon, 30 Jan 2023 12:09:33 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C4CBA6B0072; Mon, 30 Jan 2023 12:09:33 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AEE236B0074; Mon, 30 Jan 2023 12:09:33 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 146456B0071 for ; Mon, 30 Jan 2023 12:09:32 -0500 (EST) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id DA7E21A0B01 for ; Mon, 30 Jan 2023 17:09:31 +0000 (UTC) X-FDA: 80412101742.22.B52529C Received: from mail-pl1-f179.google.com (mail-pl1-f179.google.com [209.85.214.179]) by imf23.hostedemail.com (Postfix) with ESMTP id E4C6A140021 for ; Mon, 30 Jan 2023 17:09:29 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=none; spf=pass (imf23.hostedemail.com: domain of bart.vanassche@gmail.com designates 209.85.214.179 as permitted sender) smtp.mailfrom=bart.vanassche@gmail.com; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=acm.org (policy=none) ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1675098570; a=rsa-sha256; cv=none; b=craRK0rC4BMSrHZM9ynXnDpBHnno6OLfH//32meLxwQBH15yUDmmBVGI/9Br7fDDNZp1S1 wPgdjjaNrO0+xvpAv3EElCQnbGHsF901XbVuRbKlwNEkqNLsX2MvGvffZBbW4eCmmFv+6J Krxu2YO0OPCjEHaCyuid7ee5vWaEVXQ= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=none; spf=pass (imf23.hostedemail.com: domain of bart.vanassche@gmail.com designates 209.85.214.179 as permitted sender) smtp.mailfrom=bart.vanassche@gmail.com; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=acm.org (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1675098570; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=VcAkkG+7EQ87q1yuQfzrNQ/CVfL1BPFACyrSB5AzC9E=; b=C0hadRZnK9cxLsE4cY/fElT3qe3Vl1Ubd1ltMX0YapHTr/PAYTm/4irzx118npebBcW7/1 n2JzujOSeUmBhjhjObjp4fkh4o2qd2w9BSjGFywRQPJzXxGLUjhtQ5pazdp5ZRlAwKw9Dm 3GLtHxlYnBQ4BhWXiOSeo3/8ptJzRQU= Received: by mail-pl1-f179.google.com with SMTP id p24so12274631plw.11 for ; Mon, 30 Jan 2023 09:09:29 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=VcAkkG+7EQ87q1yuQfzrNQ/CVfL1BPFACyrSB5AzC9E=; b=IVJcgLr/2Vb2HbHVuSt64Z/AQrbDeDOpqccbuvoUL1FxxuRCX19sNoZ6gLfyajDML7 0seQHGMRKAIvykGww8XeU4b4XRcYxNoKdArItp9f/zn6YYOc3wF2oUHe4+Zj8+ECIimG L/gR2aE+xlJHZubkkLt1X1Fq6DF2L9etXuOjI1NsiPc+EVknK/8uMGYfoidK2dUgbh+k ehsUzWYmpe537QsZ9OWZqmOJz4SowJgolRvl6FvR5v4vhjkOzq8gDCFDBZNp1DlVucdx rOUFQfYUp5TJYQ8b3ImBGhhFBe/gxeSjcMrn7ssHwTSaDZx/eWg7I89P5bHAc7w8YejZ TZIg== X-Gm-Message-State: AFqh2kruxaf9u9lq3OW9DPr9XfSMmW1/c6PK3hhQjiZebXC15w0xL1b0 su740wpgCUy8G1IsHZFIJ10= X-Google-Smtp-Source: AMrXdXsoThEeXwb5X9zNdrMM/dBzAwAKgsQUh4DVjXEWAVyR5f6ZoR++CGV0u6k+ufH+Ks5WBdnq6g== X-Received: by 2002:a17:902:f646:b0:194:46e0:1b61 with SMTP id m6-20020a170902f64600b0019446e01b61mr52496709plg.63.1675098568615; Mon, 30 Jan 2023 09:09:28 -0800 (PST) Received: from ?IPV6:2620:15c:211:201:5016:3bcd:59fe:334b? ([2620:15c:211:201:5016:3bcd:59fe:334b]) by smtp.gmail.com with ESMTPSA id y16-20020a170902b49000b0019602263feesm8042186plr.90.2023.01.30.09.09.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 30 Jan 2023 09:09:27 -0800 (PST) Message-ID: <2bab7050-dec7-3af8-b643-31b414b8c4b4@acm.org> Date: Mon, 30 Jan 2023 09:09:23 -0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [PATCH 01/23] block: factor out a bvec_set_page helper Content-Language: en-US To: Christoph Hellwig , Jens Axboe Cc: Ilya Dryomov , "Michael S. Tsirkin" , Jason Wang , Minchan Kim , Sergey Senozhatsky , Keith Busch , Sagi Grimberg , Chaitanya Kulkarni , "Martin K. Petersen" , David Howells , Marc Dionne , Xiubo Li , Steve French , Trond Myklebust , Anna Schumaker , Mike Marshall , Andrew Morton , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Chuck Lever , linux-block@vger.kernel.org, ceph-devel@vger.kernel.org, virtualization@lists.linux-foundation.org, linux-nvme@lists.infradead.org, linux-scsi@vger.kernel.org, target-devel@vger.kernel.org, kvm@vger.kernel.org, netdev@vger.kernel.org, linux-afs@lists.infradead.org, linux-cifs@vger.kernel.org, samba-technical@lists.samba.org, linux-fsdevel@vger.kernel.org, linux-nfs@vger.kernel.org, devel@lists.orangefs.org, io-uring@vger.kernel.org, linux-mm@kvack.org References: <20230130092157.1759539-1-hch@lst.de> <20230130092157.1759539-2-hch@lst.de> From: Bart Van Assche In-Reply-To: <20230130092157.1759539-2-hch@lst.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Queue-Id: E4C6A140021 X-Rspamd-Server: rspam01 X-Stat-Signature: ywcis34e68duixm4p7z7mk73wnmiyrjq X-HE-Tag: 1675098569-557443 X-HE-Meta: U2FsdGVkX1/uhOCzOnBqxSzlbjtDoybURXX/HCyd5ZfA0xdBH+twdDDig4eDq9V6frlFLOeOIwAxgmfxp0UEXwN3MyGlc73/F0rN3PjMvC3Pe2h+pgy1n41XASaIiD/V+58YCYmWQeTtZnMhIxpDYUUcWOp1hxikPIJLw5B0pTbNFw/bt/Ld66YO19nzIXUh0PJkbGaP2BhPSyISzaPpDiMICHtbrDgSb2S7IukY4cv8u4Na6BXdd8JBn7LTZWRMAQe20WW3yu+1Emavh733wQ3IzcJuiKdrld7y25ha/QF4U7E1OwhTw8mRShH71yurka2O943F4yg9qFdauD9WXdpVbFkMxwIAzoCioFrKLUeMaeXC1r1wNrbO4X0zh4uQcPxwlsv3QTF7r2Igjmcz6DBr1IvnutWOaWReo6/BEssDnjoQ+Lk/P8V4BCo6tT5oAFu78/6BoQzkK3gF+j0FV1gyuL7XCrTDuglaDXF3WWVA+abv+93w34KF/F1I6+5BENH+dFNk8r4faRMdoXWfydSitbLuEkuT+PPPUY8SQkhMjp0PWtmdrz5pcGQHbCCGeEFsOIxYiLFTyaLc64CB5gsbqPFrFyGXJNDQs7eZJu07umQrxF4Wxbxh8sOCtsKq52a6lx1fUh4vSyA+tX8msYaNanTMHKAgQWwQv/eZVQI08D7hVpRJRrZyidWIEvMp/u60smkpDZLSsHf5HH/MNVLLj9a322VhU4T/Ti90Ti/KdiWgWdTnCInxAXCeNCzoG39Fk5GW3EL2SBwdaAh8J/ByNRldGsxKG7RPsV+oH9GIuUv8n8W/8sHua15N6Y/bxGG7QpBwi1NKOVIUtFtwhXL7jBzfN0A3JZXzsWk7hsAFMexkzVmqxWOJAjtFO3BJmAcA8PZowjBRI5yGI3aKDWnyOS+mLhfxz0QzbM6zMsm2FWM5eFGWdqI5x8bJ37jDh9OLi3xOOa19aRYRoNr Wf22doVm iZK5+8vXteR8ciHbY6DwYytBphvD+97sE9zZ+LyGjQr73tfcwxoV4V6mzi5xfeSCxbgaO2n5aGKnpNcykLQTwag0r8s6Cv/lnBt3braPzwBqTJ1Hq8KjF7wdXTVKohhOSsZt0cw6C9HHZUM+lfDbnNRqK/vkLn53t7ozOPafKb9qw5IehJS0xW/T+w3zon2r5eMzocUDaLk8sBZtIIMTXEeXFnN3lQP7RgjD2jENWrYR0g0apz0Qy6IxXdYkAXu2Tm5fUja2re5iIhzGu/pQ9KLUcQ3ZMn5Sty8NcjfOW7Pd8sabFXmLKs6WYNyw7efm8+12HP09IPXPUN8BCzsnYq3mitL4eVl1Laxt2+GJlbUZ1G9umlGkWAP8o+SJk0I9YKedB3/6DIXwckAfPAjzwUaxgre4jYAg3mWOQuC5F67EDLA4G7xfumYufeOb46uU4dg9cAdJm9PHyyzHLZo2zb8qx//uwqdWZa0T/OWc7AcAMts5X2UOx3KUlFYKyiEphTiNE44TPn+EYvUGjH67MKAAXXyyfpYuhcvNHIyIceYur8lU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 1/30/23 01:21, Christoph Hellwig wrote: > Add a helper to initialize a bvec based of a page pointer. This will help > removing various open code bvec initializations. Why do you want to remove the open-coded bvec initializations? What is wrong with open-coding bvec initialization? This patch series modifies a lot of code but does not improve code readability. Anyone who encounters code that uses the new function bvec_set_page() has to look up the definition of that function to figure out what it does. > - iv = bip->bip_vec + bip->bip_vcnt; > - > if (bip->bip_vcnt && > bvec_gap_to_prev(&bdev_get_queue(bio->bi_bdev)->limits, > &bip->bip_vec[bip->bip_vcnt - 1], offset)) > return 0; > > - iv->bv_page = page; > - iv->bv_len = len; > - iv->bv_offset = offset; > + bvec_set_page(&bip->bip_vec[bip->bip_vcnt], page, len, offset); > bip->bip_vcnt++; Has it been considered to use structure assignment instead of introducing bvec_set_page(), e.g. as follows? bip->bip_vec[bip->bip_vcnt] = (struct bio_vec) { .bv_page = page, .bv_len = len, .bv_offset = offset }; Thanks, Bart.