From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 82256C27C75 for ; Tue, 11 Jun 2024 10:50:57 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 063E56B009B; Tue, 11 Jun 2024 06:50:57 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 014136B00A3; Tue, 11 Jun 2024 06:50:56 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DCFC26B00A7; Tue, 11 Jun 2024 06:50:56 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id BBE306B009B for ; Tue, 11 Jun 2024 06:50:56 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 5A95EC1428 for ; Tue, 11 Jun 2024 10:50:56 +0000 (UTC) X-FDA: 82218290112.15.965C44E Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf01.hostedemail.com (Postfix) with ESMTP id 1BEB540008 for ; Tue, 11 Jun 2024 10:50:53 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=VXW5fyT7; spf=pass (imf01.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1718103054; a=rsa-sha256; cv=none; b=1EN0xRGnlRtlOKnHBNQaJaMd+xLdUa2pEuqjQpUibynTX9srs5lP7JccSNtF94TATnhHSs brfmsbxKoJP0fKlIItl17oaZCNu7Nkzclx/56GJG+Af5Ww98yZxkGxuh83V+RGDtR9Pite wCBrHhvV7C7c6Vg99noF05IIHbtRstE= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=VXW5fyT7; spf=pass (imf01.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1718103054; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=3ysdFsrtDcDxrPLWReLHv5ssrGeZHQvSPRbBF339uAA=; b=gLmorl88Ge7yfhBTX7b2BkC7vG8F+nO5MzvLJ+Dk1X2sDAi+RY5HBEJJAEDzSrMtwoxZ23 BnpnOrtnuVbhHxJ17zIiwVB5NzBH7ITkXv/4skSKiZl1jRKihk334Wbk2m5pBscIuuh0vm yFd3ng6H6uuVlmuVwo4SHV09GYYetdw= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1718103053; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=3ysdFsrtDcDxrPLWReLHv5ssrGeZHQvSPRbBF339uAA=; b=VXW5fyT7AjsKQmQdikRbnX5ohq3WJ7iXLVNgRPSu6JpYu25gYfHwMq+wENV5QKmaZWPKGZ iZFkkHE2KnTkCKGB+T4yT8+Ozq+DB6P2H7J7YOn+nnWu/MI3M/lVioKNuz6BN4PX9p074n dD70i8uHoXQg7mK5HaA4nHa2sorZfdU= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-564-czEZosQHNb-PB3Un35DXBg-1; Tue, 11 Jun 2024 06:50:50 -0400 X-MC-Unique: czEZosQHNb-PB3Un35DXBg-1 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-35f1ddd8a47so1335887f8f.3 for ; Tue, 11 Jun 2024 03:50:49 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718103049; x=1718707849; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=3ysdFsrtDcDxrPLWReLHv5ssrGeZHQvSPRbBF339uAA=; b=pXA/f2ZdvIl318YUWu1N6SxWRf1FFGUnhY5Wi/o8sjLmGv3zgNvwCfoTzBW3TMkjxe AlNWb4MmRw4rhckfSV6c5RNJkrUrdqC3feXuWSnp+PhyTpmIEvdj4/8YiE8lvu05Ihah 1G8fdcO76Ugjm4PS1oKYtm3HJQSMZXNi3NSlBo+Z35Eqqr95NAXNRgfNG8Hj1md9tdcH 4hcMU7g7aMtDGwXL4LYqk1Ehq7d4Px0GPDhNdcdn0QJPn3uSt+daHZ5hegixGr7OHwGI Q7Tj7QqgrWzCBt+Ng4F4pUl/DNlh5yZ5DWaXAzysvj2zNuFGQOaP8xXkDwNWLMd9t+la EkXw== X-Forwarded-Encrypted: i=1; AJvYcCVNzltwBysQnRmt0G+Q/Coa821bfCls5MG3GS+Z51jLtOQOehQUHGIFxuwMd9croxNBWL0aVMiwr9U2xpMwoV+uLb4= X-Gm-Message-State: AOJu0Yyfa+XaeNZN0DRx07FNPwyb14IcJ1io2aCEgUfy5uVCNwTc7GVk Y4sM9InXA1jWIGeegB9gDeNQvXOf5nNdggsICWRWkYytqBetTRGVeIFGi9dbuiJGjbLbyKpqNIx kKcpDKQDZhCnd1voBCpagCIUO7ozuvP2enUDw23UlkuOjS6tu X-Received: by 2002:a5d:5254:0:b0:35f:159e:5ec2 with SMTP id ffacd0b85a97d-35f159e6186mr5609428f8f.39.1718103048812; Tue, 11 Jun 2024 03:50:48 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFXDhdkA/eYdpilHthDuW6/sqyY7YL810c3QO5B5dWAJ2pffJ1e96n0xCMflbdVhb7aOmh/NA== X-Received: by 2002:a5d:5254:0:b0:35f:159e:5ec2 with SMTP id ffacd0b85a97d-35f159e6186mr5609419f8f.39.1718103048419; Tue, 11 Jun 2024 03:50:48 -0700 (PDT) Received: from ?IPV6:2003:cb:c748:ba00:1c00:48ea:7b5a:c12b? (p200300cbc748ba001c0048ea7b5ac12b.dip0.t-ipconnect.de. [2003:cb:c748:ba00:1c00:48ea:7b5a:c12b]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-35ef5d2e73dsm13674969f8f.16.2024.06.11.03.50.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 11 Jun 2024 03:50:48 -0700 (PDT) Message-ID: <2b912e12-8289-4ce8-99bb-103a289a23cb@redhat.com> Date: Tue, 11 Jun 2024 12:50:46 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 2/6] fs/proc/task_mmu: don't indicate PM_MMAP_EXCLUSIVE without PM_PRESENT To: Oscar Salvador Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-doc@vger.kernel.org, linux-fsdevel@vger.kernel.org, Andrew Morton , Jonathan Corbet References: <20240607122357.115423-1-david@redhat.com> <20240607122357.115423-3-david@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: q1qaj8nb5aazo3j3k8mpo6iwbznzukyp X-Rspamd-Queue-Id: 1BEB540008 X-Rspamd-Server: rspam04 X-Rspam-User: X-HE-Tag: 1718103053-23613 X-HE-Meta: U2FsdGVkX1968Gtq054YuA+tCj+7FplRazZbheD+CaTQ5NeCjlDgMCmsUGkFiEEANvZRESl22H/gJpK6sloH6sBEMwkXXuRcPm2rWiY7lIY6oRJPn9oih3//MbyBCus3r4FTenn9krbJrX4fJ1BgSKfiVtnPvHZwd9Ao85e4wSK905X1e8huJzUdQcZueW4S8rtnNDCEGrVSSi5L35PgKwgiSUsahgas4QjoyqbKbPITi+gs1FkUmzS8ww2JL3wdUITlyTn+r3LiPvqUIVd/2sKPU3RrbofOoxs5W8jO/wCT9hLtVFgDhCQCNFFi6EfCChVkD47kHgQIDLdogvWViiVKpewp8i/TJ43xOY9JnHdK8nEU4KPA5TAfyl6Q8M3l1vOb0g5cCst9MADnSr5AsboDDCYWWUAY/4TUbVB99xy4CdxwReg/pjH1m7OasJPFbezl1OrNoKr7zU6t0zE6AO2RcsBphRWm1SoAG15Q/e5V7LFQgL5tccksQprfEcunPE0mNDcjJ5LDdlx37tvlv5YG6Swe6RAWETmxmZKQBF8ooGhVtB9VU+nTgYLHjHpTkOW6ffG3yrU7GlujFI0S06TkArsWbH+DUuchyNL3pQO3kFV+Sf9eAvvbe6iC7/u9wGUt5W4/vkRdItkvf0ZrFDSCwsxBRvAI8VqgmZ1t1GtePpFIJjTxH1MtqznRfoauUIPvM7apK0/SICVn/4QJ9ku0W2DNIxMY81hvuZNbQIpx1Va067aJS/q8YyadfsBS6ZMT0LlutfeJup8aB/eGA7n9MX6thSIozOq4WE1WJ2sbRkbKU6gNNDJevddUjsF7TOQXiHtGkakZI8glZt5HuFdx6Ug6GbLG8P+ShZa6iMRe4sJ09oGHER6A6hfgo3d9CIlkwGzYY8vNWjsjBGGir6F2+N1s1vQ/GC2lLZGB/NJsL3NBW9S08Vfj4J4O9EBq3xXrmdKwDZSZ5dIBB+B xq9MtUn3 bieWEOWFxfTcfa/QBsBMXQ4p6sKvep/nBayEegqtXGg3R4+hXZCUSUQKx82ey+i6tDZD5A4KzdxrU3bJft1cVbcBwOL8gAEmmEkrbQo7ST+9WGFVsYJyahnQdoTqeIpAlSeOV/z7Qn5jGpFJvfyHq58EADhqkrod/DHJDlk6QDa/4AqMsWBMXAuFL7pTIRWCNdgHbH/th/pt62A82Q0k/DO8joUWuWpBP7UGEmbUMFtQ4mdzjy8gFSfK1xg3ikWitch9K9TZn+LzgLGqnWDNzpZchArH+yaGiShCzKkbi7DR2rZaw/vYIPAGW6yrprWMvqsXMD3+v4Hftzp1RrA991tQNB/waVnzbk2k0ElFx/uaQ2UMgdOy7zi6ksGXB75iNpbd55IH9kVPzkdclEJoKcDOI0MgWLNjB1gygBYDfywjJ5vtRi1gTPMfzaojak3YBHOXN X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 10.06.24 06:49, Oscar Salvador wrote: > On Fri, Jun 07, 2024 at 02:23:53PM +0200, David Hildenbrand wrote: >> Relying on the mapcount for non-present PTEs that reference pages >> doesn't make any sense: they are not accounted in the mapcount, so >> page_mapcount() == 1 won't return the result we actually want to know. >> >> While we don't check the mapcount for migration entries already, we >> could end up checking it for swap, hwpoison, device exclusive, ... >> entries, which we really shouldn't. >> >> There is one exception: device private entries, which we consider >> fake-present (e.g., incremented the mapcount). But we won't care about >> that for now for PM_MMAP_EXCLUSIVE, because indicating PM_SWAP for them >> although they are fake-present already sounds suspiciously wrong. >> >> Let's never indicate PM_MMAP_EXCLUSIVE without PM_PRESENT. >> >> Signed-off-by: David Hildenbrand > > Forgot to comment on something: > >> @@ -1517,14 +1514,13 @@ static int pagemap_pmd_range(pmd_t *pmdp, unsigned long addr, unsigned long end, >> if (pmd_swp_uffd_wp(pmd)) >> flags |= PM_UFFD_WP; >> VM_BUG_ON(!is_pmd_migration_entry(pmd)); >> - migration = is_migration_entry(entry); >> page = pfn_swap_entry_to_page(entry); > > We do not really need to get the page anymore here as that is the non-present > part. > > Then we could get away without checking the flags as only page != NULL > would mean a present pmd. > > Not that we gain much as this is far from being a hot-path, but just > saying.. I *think* we still want that for indicating PM_FILE after patch #1. -- Cheers, David / dhildenb