From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B5EF6C369C2 for ; Fri, 18 Apr 2025 01:09:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 98FD16B02A0; Thu, 17 Apr 2025 21:09:05 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 93D8C6B02A1; Thu, 17 Apr 2025 21:09:05 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 806C56B02A2; Thu, 17 Apr 2025 21:09:05 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 6193F6B02A0 for ; Thu, 17 Apr 2025 21:09:05 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 72BF9BB2C0 for ; Fri, 18 Apr 2025 01:09:06 +0000 (UTC) X-FDA: 83345380692.27.F051D50 Received: from out30-130.freemail.mail.aliyun.com (out30-130.freemail.mail.aliyun.com [115.124.30.130]) by imf09.hostedemail.com (Postfix) with ESMTP id 80E69140002 for ; Fri, 18 Apr 2025 01:09:03 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=linux.alibaba.com header.s=default header.b=RcjaKIaF; dmarc=pass (policy=none) header.from=linux.alibaba.com; spf=pass (imf09.hostedemail.com: domain of baolin.wang@linux.alibaba.com designates 115.124.30.130 as permitted sender) smtp.mailfrom=baolin.wang@linux.alibaba.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1744938544; a=rsa-sha256; cv=none; b=N5KAZ9iEs6aRS8Nq4zAQN2WJSm915eK/fEpfP+cgXTbcPNvQ8+9vw3JKwQVWFtqfjPTtQD WcCNVNw2f7/UyMkevMoPn7GPB/xMq7Z5fCZLwXBME2QrBLLOu6iolZuP4phZB7dG9NnhEW zzELPNNBjQtbenF26Gf6JvCPKzzqk4c= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=linux.alibaba.com header.s=default header.b=RcjaKIaF; dmarc=pass (policy=none) header.from=linux.alibaba.com; spf=pass (imf09.hostedemail.com: domain of baolin.wang@linux.alibaba.com designates 115.124.30.130 as permitted sender) smtp.mailfrom=baolin.wang@linux.alibaba.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1744938544; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=/zpmOaOeab+ITuItqENzqv6ySxnros0qeyQCTC95Sbo=; b=Hz+6rTDyDfR1qKeWKob7AsFPWRlOH7ANA0C+EC6q5eIeJUTkpiG7cMcPWJ0VnAHBdPxqwB IBjEhllSIOjI0kaWcuF/85Ec1ZtUrl3X7KsiG10YX/en1uZfmslMNPYDtNfW0OwJFtvgwz 4/wuWSl62VDswAoA9r8S1ir3W7GdGQY= DKIM-Signature:v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.alibaba.com; s=default; t=1744938540; h=Message-ID:Date:MIME-Version:Subject:To:From:Content-Type; bh=/zpmOaOeab+ITuItqENzqv6ySxnros0qeyQCTC95Sbo=; b=RcjaKIaFuUYAOVr94ma8I6lglRdebO1yg2zO6QOa6/tbZOEOtMex3vytdrJyysMdLjl6/QeSgBL6iZ61PKIi26ncFurlyI1Be3t/j/mff3HVETjzLEfetheLhs8tndmq82lP7Pf66cglxzDZ2xvglaN/TG4uHA9ua1G6UADgboQ= Received: from 30.74.144.122(mailfrom:baolin.wang@linux.alibaba.com fp:SMTPD_---0WXH6Ihr_1744938538 cluster:ay36) by smtp.aliyun-inc.com; Fri, 18 Apr 2025 09:08:59 +0800 Message-ID: <2b8d048a-7089-41b4-b256-e061af10216d@linux.alibaba.com> Date: Fri, 18 Apr 2025 09:08:58 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] khugepaged: Refactor trace_mm_collapse_huge_page_isolate() to take folio instead of page To: nifan.cxl@gmail.com, rostedt@goodmis.org, mhiramat@kernel.org, willy@infradead.org Cc: akpm@linux-foundation.org, david@redhat.com, fan.ni@samsung.com, yang@os.amperecomputing.com, linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-mm@kvack.org, npache@redhat.com, mcgrof@kernel.org, a.manzanares@samsung.com, dave@stgolabs.net References: <20250417171758.142745-1-nifan.cxl@gmail.com> From: Baolin Wang In-Reply-To: <20250417171758.142745-1-nifan.cxl@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 80E69140002 X-Stat-Signature: 5mssnksq5m3gxf9nrb78o1pc6jfupzah X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1744938543-889632 X-HE-Meta: U2FsdGVkX1/JnaeXcY4ncD9EKMuRL8vvT35ZwPOVw1P6bbhaNRWWuagtuiLGfZu2HTQdZRAREk8wW+4bqL7T8L/2OQFweDSbhMGbo79gpkPQkhrguo9lcIgocnKTCQMT+wUfYJMzgSowDUFiaC8slL9n5oP90+I5HKTOQBYeLLIaTQXfnI82LHeBI3QP/+Ufy32lGrxWiVpod7xaTUPx0Cd6dyuymaP8TUPOaGjAR2lxbgNcog599t7YY8ChOJqwp5UEo1i+ugcQuLwZF3SO5TxA2gU3Ns9/tI02C222HI/i3oZaJOQzH408uUG52i7slhVrzEuSVkBHQxhjIkWPqJ2RdCFHuPTedJippLyt3lD4CE2wkHwyt+3qlmrsTGvryE8YBtpeFtPO9k7u0sBOXG5E87pVD1TOJ8YvN/UTDu36XvzRcb9kTHYygsiNDalMCTcSgKcy1qLui3v2/ZNPXdsHbA3kUDAwLj1ujVO7kmWRTNMNLazHx07ivcx0peikvudIYYeRoe3QHjU5v8cW/AsPygn6fc53xvUaQBG/9RZNbi3K/arXq5W9wIej+YVJOYq24SPFSG5p8cCb98Ut0bgmRAyBHlgtKabdrQ08qvZ0TFkM8/8p1DyYd5ESSZRIoniSLkYHhE3VoRSvDU2S5w/0fLlZExKoK5G4CjJr6XekqKAWsdpH15dbZJBR9cPBSXIZy/CsjGe5Q/H6mX/BiuU0wnoTOM8aAp90VOXrrct3mj50YFktcvWWzeiQW1GoNGEusIa3XL4RmnIrlzad7dLg7NqnHb7uxvNvmb9Wm9JJqPJLWN50MED7NClpaPhxBFfrYHevrOI+jL7H2htt5K1xlGM65ztaA7rq6rI/uAaHpBCZZhMxbTsJU0+8GEAtIiOTmbaAixTBXCJWg1BohNf6fuwzI0vuf+Jlh+MiA2ks9um5A8kkkFgiFu/8pPlx3J0eAo6EOOzmzZx1Wuj YUBXrC6j 2IJDXh9fbj5OcivIyWAHv1/rJVYswu27Km4IuTSHGTs0/6iNcv+5y5L2wKhFwBAJtxY6NxNEcr1ojTmU5dXICdaeXehmDVH9SArUncu8pFs2OE9adFkoVZZ9m8x/+4wKaG3pd2nDWYChjwDcr41ggiP2CddEM9wuUF2Ft7E6QY67WwlpsQ35gryJetIIckpuF1CoORSXCaqI/PLtsuAKxjjab/G6DDYa+3Dk2DIs43iwc6L1YEeUMmCHxPGJWZBodkRTUVw7Eaqouef1efdKmjGH1TplXK9E+N75zHc1TVr2OQSyR/F37o0hchzTv9jBrBOZ5O0FIA/AE6XhkyK8QmQR8YjgBiaSN7nm3Wh1CJ+4rXGJdbliyIjQQybk4U2Du3wXDeTr2p5TuTvWrsy+yA40QzZTQnlYAwGXAFvuR6HrMkyVDqlERPfzbAqgXJsPPls5r X-Bogosity: Ham, tests=bogofilter, spamicity=0.000553, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2025/4/18 01:17, nifan.cxl@gmail.com wrote: > From: Fan Ni > > trace_mm_collapse_huge_page_isolate() is only used in > __collapse_huge_page_isolate(), which passes in the head page of a > folio, so refactor it to take folio directly. > > Signed-off-by: Fan Ni LGTM. Reviewed-by: Baolin Wang > --- > include/trace/events/huge_memory.h | 6 +++--- > mm/khugepaged.c | 4 ++-- > 2 files changed, 5 insertions(+), 5 deletions(-) > > diff --git a/include/trace/events/huge_memory.h b/include/trace/events/huge_memory.h > index 9d5c00b0285c..a73699f000de 100644 > --- a/include/trace/events/huge_memory.h > +++ b/include/trace/events/huge_memory.h > @@ -116,10 +116,10 @@ TRACE_EVENT(mm_collapse_huge_page, > > TRACE_EVENT(mm_collapse_huge_page_isolate, > > - TP_PROTO(struct page *page, int none_or_zero, > + TP_PROTO(struct folio *folio, int none_or_zero, > int referenced, bool writable, int status), > > - TP_ARGS(page, none_or_zero, referenced, writable, status), > + TP_ARGS(folio, none_or_zero, referenced, writable, status), > > TP_STRUCT__entry( > __field(unsigned long, pfn) > @@ -130,7 +130,7 @@ TRACE_EVENT(mm_collapse_huge_page_isolate, > ), > > TP_fast_assign( > - __entry->pfn = page ? page_to_pfn(page) : -1; > + __entry->pfn = folio ? folio_pfn(folio) : -1; > __entry->none_or_zero = none_or_zero; > __entry->referenced = referenced; > __entry->writable = writable; > diff --git a/mm/khugepaged.c b/mm/khugepaged.c > index b8838ba8207a..950d147cd95e 100644 > --- a/mm/khugepaged.c > +++ b/mm/khugepaged.c > @@ -696,13 +696,13 @@ static int __collapse_huge_page_isolate(struct vm_area_struct *vma, > result = SCAN_LACK_REFERENCED_PAGE; > } else { > result = SCAN_SUCCEED; > - trace_mm_collapse_huge_page_isolate(&folio->page, none_or_zero, > + trace_mm_collapse_huge_page_isolate(folio, none_or_zero, > referenced, writable, result); > return result; > } > out: > release_pte_pages(pte, _pte, compound_pagelist); > - trace_mm_collapse_huge_page_isolate(&folio->page, none_or_zero, > + trace_mm_collapse_huge_page_isolate(folio, none_or_zero, > referenced, writable, result); > return result; > }