From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 97C75C19F2D for ; Wed, 10 Aug 2022 03:30:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 15E568E0002; Tue, 9 Aug 2022 23:30:18 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 10CE58E0001; Tue, 9 Aug 2022 23:30:18 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F16288E0002; Tue, 9 Aug 2022 23:30:17 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id DFB268E0001 for ; Tue, 9 Aug 2022 23:30:17 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id AA95D12122F for ; Wed, 10 Aug 2022 03:30:17 +0000 (UTC) X-FDA: 79782254874.11.C503A62 Received: from szxga03-in.huawei.com (szxga03-in.huawei.com [45.249.212.189]) by imf01.hostedemail.com (Postfix) with ESMTP id 74C0240183 for ; Wed, 10 Aug 2022 03:30:16 +0000 (UTC) Received: from canpemm500002.china.huawei.com (unknown [172.30.72.57]) by szxga03-in.huawei.com (SkyGuard) with ESMTP id 4M2b4t1nXqzGpKS; Wed, 10 Aug 2022 11:28:46 +0800 (CST) Received: from [10.174.177.76] (10.174.177.76) by canpemm500002.china.huawei.com (7.192.104.244) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Wed, 10 Aug 2022 11:30:10 +0800 Subject: Re: [PATCH v2 04/16] mm/page_alloc: Move set_page_refcounted() to callers of post_alloc_hook() To: "Matthew Wilcox (Oracle)" , References: <20220809171854.3725722-1-willy@infradead.org> <20220809171854.3725722-5-willy@infradead.org> From: Miaohe Lin Message-ID: <2b836465-939c-b257-6dde-5bafb3cc3812@huawei.com> Date: Wed, 10 Aug 2022 11:30:10 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <20220809171854.3725722-5-willy@infradead.org> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.177.76] X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To canpemm500002.china.huawei.com (7.192.104.244) X-CFilter-Loop: Reflected ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1660102217; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=086KjreuPyPQ9G/GTpgnKvgPzD92KfoT5CrxGyrX/V8=; b=pzHFc8nUNhtSJkOw6mKquoLrrq3bRNsxqXBR388PkF6pAM1IZ42dD2BMRVc+6m7eok0nY4 W3vRnIICaEdIn+0cM6ZcNmq/KKM1Gkq7UxH1r5pBjNTV+qyoNvUeegFESPBLV1+8zAuYYO MhUd5gzbphbdp3oXOkPTedqvN398QPA= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf01.hostedemail.com: domain of linmiaohe@huawei.com designates 45.249.212.189 as permitted sender) smtp.mailfrom=linmiaohe@huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1660102217; a=rsa-sha256; cv=none; b=NbFTfNG55sV0YRylEJttC876S3tiQSQEVPj4COfQoAXShbj9o654WHGCq5Pnn60KQ6D+1I qySFePT4L4paaMq9Nrb8b9VfXnH1B9IMAU/DGb+0bTTToFieLwtWO+DOMWMYFy9iPmyCue DUROWwIwCbVmZ5dorUZ4mUCXN/+AR3Q= Authentication-Results: imf01.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf01.hostedemail.com: domain of linmiaohe@huawei.com designates 45.249.212.189 as permitted sender) smtp.mailfrom=linmiaohe@huawei.com X-Rspamd-Server: rspam02 X-Stat-Signature: m83xp9hsxcnymxkw1c6f7mwywdma5uxf X-Rspamd-Queue-Id: 74C0240183 X-Rspam-User: X-HE-Tag: 1660102216-386050 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2022/8/10 1:18, Matthew Wilcox (Oracle) wrote: > In preparation for allocating frozen pages, stop initialising > the page refcount in post_alloc_hook(). > > Signed-off-by: Matthew Wilcox (Oracle) Looks good to me. Thanks. Reviewed-by: Miaohe Lin > --- > mm/compaction.c | 1 + > mm/page_alloc.c | 2 +- > 2 files changed, 2 insertions(+), 1 deletion(-) > > diff --git a/mm/compaction.c b/mm/compaction.c > index 640fa76228dd..63dc6abdb573 100644 > --- a/mm/compaction.c > +++ b/mm/compaction.c > @@ -97,6 +97,7 @@ static void split_map_pages(struct list_head *list) > nr_pages = 1 << order; > > post_alloc_hook(page, order, __GFP_MOVABLE); > + set_page_refcounted(page); > if (order) > split_page(page, order); > > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > index 30e7a5974d39..d41b8c8f3135 100644 > --- a/mm/page_alloc.c > +++ b/mm/page_alloc.c > @@ -2465,7 +2465,6 @@ inline void post_alloc_hook(struct page *page, unsigned int order, > int i; > > set_page_private(page, 0); > - set_page_refcounted(page); > > arch_alloc_page(page, order); > debug_pagealloc_map_pages(page, 1 << order); > @@ -2536,6 +2535,7 @@ static void prep_new_page(struct page *page, unsigned int order, gfp_t gfp_flags > set_page_pfmemalloc(page); > else > clear_page_pfmemalloc(page); > + set_page_refcounted(page); > } > > /* >