From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 209C9C47422 for ; Wed, 17 Jan 2024 06:27:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9880D6B00B2; Wed, 17 Jan 2024 01:27:54 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 9370D6B00B9; Wed, 17 Jan 2024 01:27:54 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7FF126B00BB; Wed, 17 Jan 2024 01:27:54 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 6CD136B00B2 for ; Wed, 17 Jan 2024 01:27:54 -0500 (EST) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 470824044C for ; Wed, 17 Jan 2024 06:27:54 +0000 (UTC) X-FDA: 81687822468.22.5513E3E Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf19.hostedemail.com (Postfix) with ESMTP id 63FE71A001A for ; Wed, 17 Jan 2024 06:27:52 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf19.hostedemail.com: domain of anshuman.khandual@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=anshuman.khandual@arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1705472872; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=VEdphBCHZ/nKF48ZsW/nWVCeB+A6M2MoiBd4FbIEbBw=; b=hPWJfYPRcw0uxR5fqqAsji90D3qG9fjjvGCBkIJGyygL/88fCM71Xt+FsjcQg7rg2xWXxr BLd4F/tamm0EE6t+cqDp5SvShtAD6G6e1DGUf/Cc0W8TpY7CSfRKbdlozOUmrZ4Qfpz23s nCEbttIjIObxv+fyFD4u/08nWyZmF0s= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf19.hostedemail.com: domain of anshuman.khandual@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=anshuman.khandual@arm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1705472872; a=rsa-sha256; cv=none; b=WmjoNS8QdjLVD15Q3DtslExJsmlAck5I2XwyiuearkPf4tmyqHl9Fqy9ucduJE9BZF5Ry5 ynYl2dbjgS47M7TTRycOEcPtj5rVY4YtDG6MtrgA+aJFAJUszzaJllGbSf2Mpe5L3samzI 0xJX/0cSqxUBjLplqB8C2ozmM+FQq8I= Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 728B42F4; Tue, 16 Jan 2024 22:28:37 -0800 (PST) Received: from [10.162.43.8] (a077893.blr.arm.com [10.162.43.8]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 4C2603F5A1; Tue, 16 Jan 2024 22:27:47 -0800 (PST) Message-ID: <2b81f323-c4b1-4580-8f2f-1654b6c1d016@arm.com> Date: Wed, 17 Jan 2024 11:57:44 +0530 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/1] mm: vmalloc: Fix a warning in the crash_save_vmcoreinfo_init() Content-Language: en-US To: "Uladzislau Rezki (Sony)" , linux-mm@kvack.org, Andrew Morton Cc: LKML , Baoquan He , Lorenzo Stoakes , Christoph Hellwig , Matthew Wilcox , "Liam R . Howlett" , Dave Chinner , Oleksiy Avramchenko , kernel test robot References: <20240111192329.449189-1-urezki@gmail.com> From: Anshuman Khandual In-Reply-To: <20240111192329.449189-1-urezki@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 63FE71A001A X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: gznedp8cm6sefbqfpdjfaqby7pswkez6 X-HE-Tag: 1705472872-262153 X-HE-Meta: U2FsdGVkX1/EB8P+wilyKVli8HqBLvGSNiNpylA0TQIxxsvTLA3fjfyrG6y0exwqQfzbdQcarWpCS4t3Zp1qRsRle2MO6ZwcgpGT3eZgP9sEzE8SsOmUV7YSscINoyxVlTvuuSa/enSNuyErjG4xoLaoVdxDAgx1Aq924WJP7CK7Eumbbw1ALiB+pyLZQKKiL5cmZ6Cnyq6ITqhKbs1m4t2pmxr8dqkNUrDg0D+9z+FQz1FFhYNGeEMqms6Dl9itjngPAw490x841YXriEDWDkcTjQydP2vkDB0W9kRhfHK7xAt8DSayIAaq04BtIbhzEpEj/RIHE+8v4P+skNEFf0y6i1wxwMtwHuiP5FcxAujXYqz+2pyL/7oA5xmzh14qUR+p/ubzzqSs6OEqFsNxY2rz8St3962SFTtyER58eqC3Zw8AvhYMVdwYyezmWyLZSjqsaXP/54pAPr0mfDD5iXM5jOgJT7wFO3rKw7kuWMSIh9B0H5TW7d3LlmU8gRbPqIqAj6tQngOlgs5vblsMVhUa2x5LYGQzrBiIUJoSbiz9nrd9YAO0o9PAms/j9EVLXn1c0TYmZsQpNC99OKIHudLfkoFHxCbI1FmGCpFfC4UuJNbaAkFSKpNxF+JwNByKHvL8S8wOpSsD5cfN0E9B02pYmU2Jf0gUh+lqStRNoGhtrG5ZE+inSCizPJQwrA8noqHjWrxAu6D9JNg7oKGdvQfvpylz/ja372B/ogrihYwtaWQ12+QPLpUaZPVVkpVGu5rbuWND27CgUv6vdBm8cuq9NfcSw6nCPsv0/jdpJ9DU3aTd+v1IOVhSwfztMlM2QrAed9WCu/UxwxwMs7dJBkY86srbXVDETq4B2a3M7KrlJJiKJXltQhIOUruzLntOzoiGM/9+gTWTkl+BQOtsz37+Rinlbu/cCiMQeIbIDb8qRTEevSIcH0o83G1xqn5KyVZ6uco7L+1h9vUPIe0 Iyfd7Eob LdT3ZsDbzMCu5IFYtDoLbSUr8JchOD3T3HQeDNpIFCJIjmp8uWy7Y0D1Ygy23TIevL4ohMle4+zKDMqYf62NvZ0ty0e/zUxe4UMp56Lx7TxXLL3KI8DRjelIvgMIdpz+3trxom+radyd7pquU6BuCia9x5ZFK8Ui2UF9WADz1Wl9o2gKgGkMEysE2+X8onyNVAfxny/LXcGKKM5aWi2JCSGtGLqCT4oxqZJUrcsti02cS1CQioiECMETEupxY1y63mmY87+c624RzwCXn90NaVEzmbLR5EYmDjcvthZ77eWAIGSmAnkTBiIqAwJhmgopSrAzDZk1IkrnlmtqiRlqa7munmRIytqSCArszXswmV5U7lZs= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 1/12/24 00:53, Uladzislau Rezki (Sony) wrote: > The vmcoreinfo_append_str() function expects "long unsigned int" > type as a second argument(0x%lx) to print a beginning of vmalloc > start address which is defined as a VMALLOC_START macro. > > For some architectures it can be considered as "int" type, for > example m68 generates a compile warning message. To fix it cast > a second argument to "unsigned long". > > Fixes: 9bdb180b2d ("mm/vmalloc: remove vmap_area_list") > Reported-by: kernel test robot > Closes: https://lore.kernel.org/oe-kbuild-all/202401120218.y469Puyf-lkp@intel.com/ > Signed-off-by: Uladzislau Rezki (Sony) > --- > kernel/crash_core.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/kernel/crash_core.c b/kernel/crash_core.c > index b60de490c1fc..49b31e59d3cc 100644 > --- a/kernel/crash_core.c > +++ b/kernel/crash_core.c > @@ -748,7 +748,7 @@ static int __init crash_save_vmcoreinfo_init(void) > VMCOREINFO_SYMBOL_ARRAY(swapper_pg_dir); > #endif > VMCOREINFO_SYMBOL(_stext); > - vmcoreinfo_append_str("NUMBER(VMALLOC_START)=0x%lx\n", VMALLOC_START); > + vmcoreinfo_append_str("NUMBER(VMALLOC_START)=0x%lx\n", (unsigned long) VMALLOC_START); > > #ifndef CONFIG_NUMA > VMCOREINFO_SYMBOL(mem_map); Agree with Christoph - the right place to have this fixed properly is in m68k platform while defining VMALLOC_START. But otherwise this fix in itself LGTM. Reviewed-by: Anshuman Khandual