From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7D598C02188 for ; Mon, 27 Jan 2025 10:51:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 09BBD28014A; Mon, 27 Jan 2025 05:51:06 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 04A7F28011F; Mon, 27 Jan 2025 05:51:05 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DDFD128014A; Mon, 27 Jan 2025 05:51:05 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 8529428011F for ; Mon, 27 Jan 2025 05:51:02 -0500 (EST) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 4B1021414D6 for ; Mon, 27 Jan 2025 10:50:35 +0000 (UTC) X-FDA: 83052913230.24.BC71827 Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by imf12.hostedemail.com (Postfix) with ESMTP id CBE5A40002 for ; Mon, 27 Jan 2025 10:50:31 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b=N6ia5PWw; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=a0jlF+BG; spf=pass (imf12.hostedemail.com: domain of lorenzo.stoakes@oracle.com designates 205.220.165.32 as permitted sender) smtp.mailfrom=lorenzo.stoakes@oracle.com; arc=pass ("microsoft.com:s=arcselector10001:i=1"); dmarc=pass (policy=reject) header.from=oracle.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1737975032; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=q0l2htC2b8SGFJwSNhnhvYV9WD/wVMGnSR8gML0z6ns=; b=unJbWjaXC/pUgxf0ZVSgwPZmZxwqFNRwswPYBZGL33TTFjr1K23y1WY/fI+BmO+Cr/nR1x OXhW7eSFrWr1qZXk3Yu7QIIuK0XiNVFYCwEAbfTk/brxRBtVfkFEmg6163AMO8EKTd8g1F 0BDbbr6MS2Lh3Uy5as0yg+mjUeiyMGc= ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1737975032; a=rsa-sha256; cv=pass; b=57cx8RaNq4M/wBrLecMbBKKy7FPJc04/D7QnQUZspFi6yB4pplnj4bG586t/f7rqUdh2bX Urdf/Md1gb3LtA1mz+N+WHWMEPK9m/Uj1KFp1v+737XUkhaf1u6bPoi9WmunEn6QUxLcWE U6k1Yijrc1QzcBeChfL6Jkz+pNSEUYg= ARC-Authentication-Results: i=2; imf12.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b=N6ia5PWw; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=a0jlF+BG; spf=pass (imf12.hostedemail.com: domain of lorenzo.stoakes@oracle.com designates 205.220.165.32 as permitted sender) smtp.mailfrom=lorenzo.stoakes@oracle.com; arc=pass ("microsoft.com:s=arcselector10001:i=1"); dmarc=pass (policy=reject) header.from=oracle.com Received: from pps.filterd (m0246617.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 50RA2Lua009630; Mon, 27 Jan 2025 10:50:28 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=cc :content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=corp-2023-11-20; bh=q0l2htC2b8SGFJwSNh nhvYV9WD/wVMGnSR8gML0z6ns=; b=N6ia5PWwptkVqHXRr+eA8J+Bl1G/kdwqfk YgPYx9SJ4g3KRD8bcVTOKzT1VuggeGuXzyky+nFLkgIsOPE45C9m5k/yFAZWaXoQ cuD3tEruGZD9ErNxZVWUiVyr0KoQEO4DXv4wqu1JPd+WN0tuAuF3PaLNlcwvVcGD C8l2h9sai04cybpBlcDiirKuz1IFcZ6LUSdD1D7zqKi3VJWxKe9rmwZb32x81+Pf 8Fp7xmO/POyvwV0BjKw8lDAf+gCbNYXaK9knq5tx8TcjcOa6gJrFqkNNIBCp2C0p m8LRNnsRZrqPEAumWDbS9GQTbtW41cV7QdN9ScxZFqVRtVfr1Jqw== Received: from iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta01.appoci.oracle.com [130.35.100.223]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 44crgt2jn7-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 27 Jan 2025 10:50:28 +0000 (GMT) Received: from pps.filterd (iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (8.18.1.2/8.18.1.2) with ESMTP id 50R930kO024000; Mon, 27 Jan 2025 10:50:27 GMT Received: from nam11-bn8-obe.outbound.protection.outlook.com (mail-bn8nam11lp2168.outbound.protection.outlook.com [104.47.58.168]) by iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 44cpd6td77-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 27 Jan 2025 10:50:26 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=jJptYtx5QHPo4IvSTGgxUYeg+TuqHVZecbFt7zbUf0bWTUPS3pBwrNkEA1l272V2z9tRxD7Y0dalMxKGr4qW2RZC0+jv6ceqZlcd+2tgcTOIhsEAZvoEx0EyKaCeBRa7PiDBrwKl5I4jDvX6h8RzlLGBHt4Z9luOGduDTUCOiubdLjqqR397XrfPRlMI8mNnZcfd1aoBcs3sdKLV5XAsmJ1Of4177O8kTe/OwjsP5pbybfUYsYSMqQIV84HmE6Fg65ALMRX1OzECovtGG/X9ICU3duC7zu9IAm359iQP9gIZFXcu/cyoj/+OnNbwpPzkIVaMxHGxR9cQyuUkJ5fVkQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=q0l2htC2b8SGFJwSNhnhvYV9WD/wVMGnSR8gML0z6ns=; b=iz0tYjQDczrh2Hu1Oo3bbH5WX59OVOA8Hgba+zCDo7ujkC5qe+FizOCivNiu4uRlxP/KklinV/SekjpB1O8oWwNgT6Apz0nvGS+Gh0td58X2WjCF3XfJlxwfixVnd9GE9O4GHk9U2JMx4IIw4bXFiyojAeRNsfTEWsEffyAN6JNdgAEzwPH35xCFnkhhL5ElEZltKPbvHhzdfLwRF+/DikXEzfNUEdUl5AnAwJGWBLibTp3wpWCHRvLPcZvQN9hwn0cXSuIQGdV7f4K5hhMnDgZiDxoDzCtpSZOYfjZ1JpA7+Iqh4+1INoCYHM3qGyqRfC7dP4pr/KhBtuJ/FzSAgQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=q0l2htC2b8SGFJwSNhnhvYV9WD/wVMGnSR8gML0z6ns=; b=a0jlF+BGz3/h5RVEHbYb+w+j71f86ateQ+gcKRDU3tUUpcpEwFJ/epJ9ByimkP/lGll29kgfyAhv+VTYGy6Mxu3H01+URvwVivfsxJIJ3LMDMsetZ31SKWjIM/R6opFT38oHHnPwlrhc8fXOKTacpTCwL5jG/JgG7HWdt/tZ6ZA= Received: from BYAPR10MB3366.namprd10.prod.outlook.com (2603:10b6:a03:14f::25) by SA1PR10MB5758.namprd10.prod.outlook.com (2603:10b6:806:235::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8377.17; Mon, 27 Jan 2025 10:50:25 +0000 Received: from BYAPR10MB3366.namprd10.prod.outlook.com ([fe80::baf2:dff1:d471:1c9]) by BYAPR10MB3366.namprd10.prod.outlook.com ([fe80::baf2:dff1:d471:1c9%6]) with mapi id 15.20.8377.021; Mon, 27 Jan 2025 10:50:25 +0000 Date: Mon, 27 Jan 2025 10:50:17 +0000 From: Lorenzo Stoakes To: Wei Yang Cc: akpm@linux-foundation.org, Liam.Howlett@oracle.com, vbabka@suse.cz, jannh@google.com, linux-mm@kvack.org Subject: Re: [PATCH 0/2] vma: fix unmapped_area() Message-ID: <2b7d4b72-5628-44d7-8e6c-2c8945b805d6@lucifer.local> References: <20250127075527.16614-1-richard.weiyang@gmail.com> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250127075527.16614-1-richard.weiyang@gmail.com> X-ClientProxiedBy: LO4P265CA0015.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:2ad::18) To BYAPR10MB3366.namprd10.prod.outlook.com (2603:10b6:a03:14f::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR10MB3366:EE_|SA1PR10MB5758:EE_ X-MS-Office365-Filtering-Correlation-Id: e32dbedb-49bb-4b7e-2b94-08dd3ec06722 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|1800799024|376014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?Jk8YjHkzAljtjR5nQMONdcsTKeeCSSzQ06noY32g+mnEegM+oar65RPjT8ss?= =?us-ascii?Q?HztRQzMk8NGTKUYs53HrtmhYKYGmgkk2V+8kE8a1+JyybBIJfj/RMV66CozM?= =?us-ascii?Q?Dq08cpH+Oc1Xl1QEBQUQFTi4ZwQyIlugEuBEnYkLJhBG/TfnH3Kh5IQflsES?= =?us-ascii?Q?0Dh02HNHwMtkAufOQzEJB+bRrXSvBHWhjOo7g0NmPKJLcVXOesex9nwkxhPr?= =?us-ascii?Q?FOo5SvNG19oWMspAj9vm9ZpAFBpwIRKlo9eEsv9Foyqr5CvyxP121eo0WHfu?= =?us-ascii?Q?AaUpbWAgwk7G6ibNUO8vzdoq7YTae0LY3BUYnxFVqD3DYTbfQYGHi42mBVyL?= =?us-ascii?Q?jgf5z7ntSpYaFshVn8qKkcjTswF8tOBdQkeB3zdiKm3oaWbiSH+bTnhEKP7V?= =?us-ascii?Q?VJJze2p0RCINsviQ0LYO3Gf+LyRHF7J9fxuyd/fwD4dqUuFdX70b5GVq52YF?= =?us-ascii?Q?0EB3hr0AhP+42Zz8IafzUpbMmFKGhndEoQdhIUaOXT6Kg/WyfZ5ZzWT9/z5R?= =?us-ascii?Q?HTOzu5q5e596W0+BsQeh7XIvf1fYpXrcgkjof5puJvTitbwxaGF2Hv0kkj26?= =?us-ascii?Q?DkXDEetkhgGdgExjnhXm+heAkqzQ8uYawDhgFhiCJoPdi/yt3zAjjqHb9sng?= =?us-ascii?Q?XrMxa2wDBla986I+Zmg/JIJshSQ+iv4xLa19kpr6l+i9BvsO/OgzupMvtQ02?= =?us-ascii?Q?xZkSg/8dqFCQeXjerCk4FQv81CBAVrsYHnTCtWfWQxkZ1zh9qnV6M9O4W74d?= =?us-ascii?Q?Dk6p60qodgTZUeKxZ2X/2PvJiWHQ4Z5eBzYI/pVxaPM18GJH6EmVKY35Qc2E?= =?us-ascii?Q?vhDX1/ZrD01Up1kW8GxLqkQWwh31ezhlvBMzYXe+JegFj86peqHW9pr+WfIa?= =?us-ascii?Q?Q2O1AKde8fDux4gkDEywPVn9HqUG0ffSpIMbH8KA9RMZEkZH8EK19lpwKQz2?= =?us-ascii?Q?LVl+BkwK5Uk5pgdY0yPL0GGgwQXUcuXjiKD50kP62f0U4keOao3f7mYTEACe?= =?us-ascii?Q?4Y/wKy29pbXSofAsv38SA2tEiZ8+5BZzFGZgH0q+CZTKr3fIhahyq3lfK1eN?= =?us-ascii?Q?MRl0Lap0uR+jMe3ZbiiN7uyljZMyIa3CRJIU2hi0r3vvssOejhVT7h4Sip5a?= =?us-ascii?Q?ZLzxBCnWZoivLhIvZj3O+tt/nCIqhdPns1PVUiLAwmXGrEXpORjaWmB+r5Px?= =?us-ascii?Q?DZ9RVsaQ4HJ3Q0P5dvh2z0hDPYyWB1cmnhARzYO5jiuaiUTO4FptVn8EJ5me?= =?us-ascii?Q?dZHML8eGL4/viBsZZoQTMxa3cEOFSK0oLf9elCAR1Sh9vRjnlSD1du4wNj+H?= =?us-ascii?Q?a93yHDXJ1+Xqe6MAxtY6YEepW1DWnpROsuveaD71GtmDo/dSki/i6inGBxsL?= =?us-ascii?Q?oumlTGAdqsc6bzsQUIx9jzoXuJeu?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR10MB3366.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(1800799024)(376014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Ji94b+Ct5yS9TwC1b5voDa2mzTvhm5EwEJOzETqozIejozoApq+HR0FazV7o?= =?us-ascii?Q?kuE/5MVuKYUftKVDrz3mhcIZBeQcLE6vGPkc9ttsNd0iQOmJdq4/MI4zWf3f?= =?us-ascii?Q?6wuOyCvxmHaYU6aHEBAsksrS7Nxm5bvnh+/IeK8juxY/F7GBz2Q636+fxIn0?= =?us-ascii?Q?ruUWFUBgDufBNSOEpk7cXI2rlyf/GItEec1M01MwO3QIAxU8nv/LWFPKpwFf?= =?us-ascii?Q?q8k11ByFf9V9113c8F8Mqs0TxZEZZzGvhQw/EUO2hxYcNu7UJ5z0ld2pzBEj?= =?us-ascii?Q?K26NFO/VGxcBJVml8cirUjZH0A8EYpuF5vgOseR8xv9aZvwl2H6Hvr5FOb2y?= =?us-ascii?Q?miBHKbj7fQ6OoPUiseFJW887s32v3pF37NJana+R7EUwSk7+Me8+G1sLzzLr?= =?us-ascii?Q?GsXqBCm+E9/fg4CNI2w+qBab0bCUr1RhY1WM9ZrlzFMeEwrFlGpEd+x9d4MQ?= =?us-ascii?Q?ssNA5UJ4Zhu6kzU8selumcM/o/hEr33MO2KkVINTnShlpDO5aZhp14qK7vok?= =?us-ascii?Q?CU8GASrYyGb93Rj08YwTbTv1WJmyw9eCJDQyuTPuPxm+0gbFNnUIrnKDpJTo?= =?us-ascii?Q?ZLuHTTBnuV2grjQePr5Yiy2v/weJz8V42QQA7uu33aoS0J87zcO52CLT5q9V?= =?us-ascii?Q?YAcxXgMnwDav9MNXA7URswEz/2EBBL7IVEd/UDpzDGvjkZm/omr5wJpIp/Sd?= =?us-ascii?Q?JXFPdO2OLRpzlsOZHyH8/RXtcQMvzALJ+Jh4PRE5LGAx7m1lBrVzKZjbG9pL?= =?us-ascii?Q?NLD/6G15e3TWCli5bY/aZ2KWPW9kszoWNARwuXMV7bwStaVe/aWDrBUc8Krd?= =?us-ascii?Q?D+NYoQopQcj0tGZv3HxtK9/ZdqkjrRO3Y8V2ga3ryvmSYOvd1GUciTNu0UbE?= =?us-ascii?Q?gcqICCvd9kqvQG7njyakAfw5a4tLGMO0rv8aHLEivmsU6iHb773mVVBEFRot?= =?us-ascii?Q?tLEaC1eP4aHskupuvzQAXp8R38sY27bLfdwwS2RVhB7/ILbajwQDt0ur06Ge?= =?us-ascii?Q?H0PbQJ4eghV65FGVRwYxdYO1Od+4yfMr2m5YzsH1ttnMBwGdbJ1h8dM6u87B?= =?us-ascii?Q?qVic50iqiJOtf/50RZ3H2QgVgbnf87oof3rfJAvEOsvBgrT7Fh82NWO4RqCS?= =?us-ascii?Q?PvbbYyau/gUdMF7NtCdk6TfnvCOGosIiQAd59/NuyMQHBwIc+8SR106ZTIbk?= =?us-ascii?Q?C3zylFNR/Oej9yjaMEeEsE3CFwjZO+69ZO0OSMgZmvihANfZZ58JL5XoPKjU?= =?us-ascii?Q?Tj+k0DKZ1f+0zT/gLZ7EpQreOYt+5LrQ0qPpeLyOi0pK3dEciYMnXS8MaH43?= =?us-ascii?Q?UVKuwjlXC4ZnVK394wZcNAGoCGEtHnM1Z89bKj3icrwiicSmzdY7CwcaiQjj?= =?us-ascii?Q?BFZiF3Q+CZxA/ylY2T8qx24g34Pc9B3HLr7j0Cd0cmlSC2xBRi8GpbwJ9TVl?= =?us-ascii?Q?YJTaITNkMeS5642Ra8/9adUeHUzUcFzVLywyQb/L0aHl8yeChdqiGANC6Vju?= =?us-ascii?Q?2ZhyyYSPPBWdFdP5t5Sh/DEo/2cOqzGn9ghXQv7AAMQCrrkfbKgGTMoe0uXO?= =?us-ascii?Q?zE6WXBoXMZ4Da3yCQ24/+pVpOe31/7iWzJUeHRstcucuFnym8rX/7oC7rK0u?= =?us-ascii?Q?cw=3D=3D?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: Ewp1V/NldhMld/T1zb3u8XDsN0IYKDpkOQOr7v12nxTiNXVDBq7ioQrDZ8HYbe2sFgQWbhX2FqPi+1j9o0fRK+6huP+6VEqH1Co/qFF92ykS8N+cfE8aDPs1hwt8eo6A9uY50gjsNip72LUftDCfPPUCDz7JnLgR6NzIGPX9nVFP6kTelepjLlBZ8azHzet2vAoAXwdWQd9JHQ7Vps8UkYx9ju6ZRV6RkPy3danwt9TF3FdtQSKRpbKrmm7UWe/iOrBE3WrCx1FkjKcZQFeeXDFWrpeqziWT1vOrRiOHGlbrcG/qcb2DGyQaOnXvU4jHgrUwWKU84Yp8P3TizerTEq1JWyO4EDVF2nxuGvK+uLNk7KmrQdeNahBKZMSFN23HK3ZJrHsAcJAbV4xXXncdFGPa+uMNl+ezXkgSf4tc19AdnwHmN2KZsZ2zAGUy8Ac25YZJULGFuSIA1WbvawIkXf3zfOKn5s5MAbyVw1tcjYwtBr6fCIQKE6W+yiUc1Hyk7LThjEqDq4q/D9eyaiPuvh2/YXexPATJOuHsuB0qr5W/XXI8g8JCgkjXJDYjmM9wSsrlk6IqfitUAprLNrxoYNUTGAr7mUhhsynbUvZzWcg= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: e32dbedb-49bb-4b7e-2b94-08dd3ec06722 X-MS-Exchange-CrossTenant-AuthSource: BYAPR10MB3366.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Jan 2025 10:50:25.0263 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: mXJ92o2oJ7FJ4l0Jyp/LHoNHXKgDaUH2I7C20SGSb8k924o2Yg1uYOozSqwye51MZUJ+nLnxKZGi4cgzecmERBPC/GR+K34HQXti3FzaRqg= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR10MB5758 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1057,Hydra:6.0.680,FMLib:17.12.68.34 definitions=2025-01-27_04,2025-01-27_01,2024-11-22_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 suspectscore=0 mlxlogscore=999 bulkscore=0 phishscore=0 mlxscore=0 spamscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2411120000 definitions=main-2501270087 X-Proofpoint-GUID: p6-S9jv7HWqRMb6NEjw-aioc-G9o4P3k X-Proofpoint-ORIG-GUID: p6-S9jv7HWqRMb6NEjw-aioc-G9o4P3k X-Rspamd-Queue-Id: CBE5A40002 X-Stat-Signature: t85pirgyechcpqx45aczqj4se94obwb3 X-Rspam-User: X-Rspamd-Server: rspam12 X-HE-Tag: 1737975031-22954 X-HE-Meta: U2FsdGVkX1/2zoC0m26UQ43Mq+SjCNB/zKRJTcFFt8SaZSzlhapuTD5C2eX1alQBbL9AtrhX9qQ7C399wZFNFqvLTwfD+3rUAbwQhSt0aH9ANtaQZ7w/iJyOrVNPJYw1VQpBVd3n4Ddt0NmHQyok5wge3VJZSBrrKAiBixlDwcGdf3pa3YCvEkNkUQsYdkFyfC3GsxYk4jjc51pC3dsMQSGlAYOKiY5Ob8+Pu002nDWbHfEqO9inpMrFiIOYzTukfmrjvWlhKdkziWZrIzcYe0t/YfZljPsS076t1HC8Pj5zPlR6O4Rem2LMfOue5WB/ATNlQ88hyNkq9TmtCosDgNnhipjxDFmEUgWDj9clJZHsDr96+GsCjSPCJIIVGrLIzSl90lBmeQLWmxhVofn1IHwrjX6Bj5A1fS71YRn70cm4TXbnQQS3xEWj/7WiICjL+Q3Xst9wP7srO2yiDHr/EjflPyA8H7KuE8Qd6C6/kowh0ujjHNeaO8g4S3NNdOdtEjkMPmoxcfJqe/ZpPE71AmOPB5QscbFJBO0pumJozGQGRPtbkshg8AzR3/g5/f0v0+qJFFSD2HG0/GrF46KZTac9sL7ZZp8glNBC8890bhkqnw3HUfzES88ray2Nkj1+QoLqVOvrTah39kq6XKiHw7lbe7X6V2lmBbIWLKYPjE4JEgAFIJrRvKcVwCx55itFAE9JlMPNgTnjmeVyvN7XOfBskqT/bKDi9LLHGA7ksGPYwH5utUQUF3HFwPkjfJs+pLu/sZjgERqCxtgNxhzqbSZzAkml6WpUeUy9W/Z8cJKTMYewTK/MJBu2ohD67DD8rZ/7eh6IsU4uO9kiZV74x2C2TiMfN0/XvUx2qk3QX9n6jQBfgfVnc790iI7WPN2rBfgPudsuJAWoPopUPKDl2Ccf2v0BYveinJ7rQ/XZ5uCJkCNrJMi3PmOv0kSUBgvBJOfIZdspPP6OBY4PD8R B6NUgwhf 61qlu1X7dTRYf54Q0dBDIuXZIHnMX2zXQ5GBhMGJ4y4jWWW49paz798f1+PFpCicCq0GMj/VMc/RWfhBTwGQJ4d7sRIKa2/gPZNnWAXVA8iW0rL+idsEz/WNc15p4WJOfcdaWXuD5yIjvVM9eQCozjBO5CW7wxCyuzRiVfSKTV1fwQvBYgfSpB9Bn0xR/LNn5xqcNp+wy7g5yU3/CmpgJYoF0kntLD5V2243ybPxtMFWOYeTTk6wFwB1jQlqzIJM8gbE9Qke44m9fl7Od/jj429z4BonfHqTMEDtw3ONWliXJe/Y8Sf3z3IBGrt9IiRRGTGOOUti+Uc4Fn0nRiWuVrbWQFrmE7y0q06gW8u2a8FXy6si7l/uBZQl9la+dbrH2ppWBvmq/LSpLrSabTzKTYOHtew00zP91h3bm7g2vFVYHucfdrvVk2aClun4B5CDrLXwceHPOlPIuQy6QiuMTGAQSa4nAI68C9OV9+tfaH96Qw19ljGuwUP5Qez+Gj+Bew1eh5v6ZQZk29UrxZqCJMHAc/U75tjLoMiwL+8rzsX8K+f10fRag81a/d1rezg6TUxIsZOINB2GOvuMa97lKE8yPOeMyQ55QjIk5DE5+gWBkxARy8GHk74otfTtjzFgua2dksCiifQ7aY2Nz9QG2QWfLMwmz27sUHPk/ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000011, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Wei, I seem to recall us having a very recent converation about holding off on patches like these for a little while to which you agreed, and then you sent this pretty much the very next day? And during the merge window? Honestly not _hugely_ impressed with that. In my view this patch should have instead started as a query to Liam about the gap calculation, this would have been far more civil and would have allowed us to determine for sure if the approach you've taken here is valid. Given your history of sending entirely trivial patches which we keep asking you not to send (mixed in with the occasional actually useful patch) it is KEY to communicate to ensure we're on the same page. If you send meaningful commits, we want to merge them. Arbitrarily sending something like this, at this point in time, when you've been asked not to - does not help achieve this aim. On Mon, Jan 27, 2025 at 07:55:25AM +0000, Wei Yang wrote: > The gap check in unmapped_area() seems not correct. > > Add test cases to verify the behavior. This is an -entirely- unacceptable cover letter. It's two lines dude. Give some details. You're actually tackling a very, very specific aspect and scenario in some of the most sensitive code in all of mm. You really, really need to be clear on what it is you're doing, why, what workload you were doing to hit this, what testing you've done, what real life things this interacts with etc. etc. It makes our lives easier as maintainers. Right now I see this as 'another trivial Wei patch', you need to provide details to prove otherwise, if that is indeed, not the case. Also your subject line here is horrible - 'fix unmapped_area()' - actually you seem to be (in your view) correcting the calculation with respect to upward-growing stacks. Correct me if I'm wrong. I mean even your patch 1/2 has a better message... It needs to be more specific to what you're doing. > > Wei Yang (2): > mm/vma: fix gap check for unmapped_area with VM_GROWSDOWN > tools: testing: add unmapped_area() tests > > mm/vma.c | 2 +- > tools/testing/vma/vma.c | 177 +++++++++++++++++++++++++++++++ > tools/testing/vma/vma_internal.h | 2 +- > 3 files changed, 179 insertions(+), 2 deletions(-) > > -- > 2.34.1 > >