From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4B8FDD6DDED for ; Fri, 15 Nov 2024 10:03:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8FDDB6B0089; Fri, 15 Nov 2024 05:03:50 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 8AC456B008A; Fri, 15 Nov 2024 05:03:50 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 725D36B008C; Fri, 15 Nov 2024 05:03:50 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 4FD636B0089 for ; Fri, 15 Nov 2024 05:03:50 -0500 (EST) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id C7C7B1C749B for ; Fri, 15 Nov 2024 10:03:49 +0000 (UTC) X-FDA: 82787892516.02.2D0B0B9 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf13.hostedemail.com (Postfix) with ESMTP id D9A602000C for ; Fri, 15 Nov 2024 10:03:00 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Gmzo1xC7; spf=pass (imf13.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1731664790; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=EZnDRZ71uyzvr2+dGgO534gfg5ta2KTMQyX5WiGwzMw=; b=zWIgPTHKJ3amXRS16KGIVYPCnmcn4Q8dOifzxTMbPAoYk/rcHNZ4uY1wFj9GLk2Fq/2hF+ PMltnP7hEkD2FLk7HVXuqZoOpmCOaSLbzBWvtt4EbIG+K73bJpO4ZUh1UOoacQ6BH7GBPu lhZFmh3KyOi329AxLMMLSEmo9bQtmvo= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Gmzo1xC7; spf=pass (imf13.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1731664790; a=rsa-sha256; cv=none; b=ad1F2ynu1fzdB0NnLpZJkRU4GLRfaK+6EQ6HsA+QNgl+MODT5QFcauqAkIv3RSeQTTtaB4 I8mi/f9TUeC1WNwEUi+r35wmK5DwT/4//XBUgX0sh43VW+WJl1wywUQZUo80jg6JvLg235 DFCNGJy0u2E7/oFctR4kary0Ddp7IV4= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1731665026; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=EZnDRZ71uyzvr2+dGgO534gfg5ta2KTMQyX5WiGwzMw=; b=Gmzo1xC7tv1K4Y2WuzUVViTqFh493FSY9I9Rrd5k62RqSVRlJzJgImoORjepu0VfD5/yMR ieMaQoh4Ucli+agFF7KkImjffm1B8uTQaXKzf5e/8x2arKXk4vwkthmoiEp+6ucBd4xH12 Urx/uhS78+E1FoyWrN75xq4Oznb+9WA= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-126-h0Yiz4eXOAWzhUsMQORRNg-1; Fri, 15 Nov 2024 05:03:45 -0500 X-MC-Unique: h0Yiz4eXOAWzhUsMQORRNg-1 X-Mimecast-MFC-AGG-ID: h0Yiz4eXOAWzhUsMQORRNg Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-382171e3c4bso1011043f8f.0 for ; Fri, 15 Nov 2024 02:03:45 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1731665024; x=1732269824; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=EZnDRZ71uyzvr2+dGgO534gfg5ta2KTMQyX5WiGwzMw=; b=jXVSSAGSKOaAqn1yc1M+7WsjpuDMBG4OVoBCQdLSKWS+jVKZrKa5AFxAWJvb29R2Gu TIU4PLWkr37OrglPGjPsNJBRGe1HPRCjFncEgXNyrcwedQTtbnGI39vc8aVeB9Jp6qFn 3vYsotARuEgDxEMh1yC7PumZQvtTj2rAuQnWiwgm0wNYEEhjIN9HCIK+ZzAz25sWxKvm tInouRmSBY7OPm6akrBSCMbJA/wKy/TXAtowDKrHr6N1bs6uXSqrhZLYSG2/K0yUoKv3 atIq/M6lB3UREbWWI6TXjFcKAB33p/mLjsaim86OO3tO3U9QBvCYhjdA/Q4uHvu8XYPE ZTbg== X-Forwarded-Encrypted: i=1; AJvYcCXRl5LGLF7OyGQdwuDiaBvHzNxBp+Cr++pUE3TyX80ZB2CYRtCvQxu0OpYV7X7BGpNkIe88s7xjYA==@kvack.org X-Gm-Message-State: AOJu0YyQQ1ZHch4+1roCHK73NUGOI0qhKJuv3RyFQdMHQBb3cP+Pk4tQ Mvwl0vkj57t1G+VSVIFR4VEpI4d25Drzd0YZVal3xUXUeEACX8GkcrFgCFmBh+W4OBu5yWdI9sd N6VBMoJaGb0uRZBc7Irw8mTBiO5JMzL4ZV61INZO5zfQtBpqF X-Received: by 2002:a05:6000:1865:b0:37d:443b:7ca4 with SMTP id ffacd0b85a97d-38214022068mr6154317f8f.14.1731665023930; Fri, 15 Nov 2024 02:03:43 -0800 (PST) X-Google-Smtp-Source: AGHT+IEcalZaTTsWSZU/E4ZgekugNGYKtIjPxdb5azK2RW63irWlZEd/lURJaTLrMsANb0/rcEU5NA== X-Received: by 2002:a05:6000:1865:b0:37d:443b:7ca4 with SMTP id ffacd0b85a97d-38214022068mr6154132f8f.14.1731665023249; Fri, 15 Nov 2024 02:03:43 -0800 (PST) Received: from ?IPV6:2003:cb:c721:8100:177e:1983:5478:64ec? (p200300cbc7218100177e1983547864ec.dip0.t-ipconnect.de. [2003:cb:c721:8100:177e:1983:5478:64ec]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-432dac21a15sm48656425e9.38.2024.11.15.02.03.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 15 Nov 2024 02:03:42 -0800 (PST) Message-ID: <2b5c2b71-d31b-406d-abc5-d9a0a67712f5@redhat.com> Date: Fri, 15 Nov 2024 11:03:40 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 01/11] fs/proc/vmcore: convert vmcore_cb_lock into vmcore_mutex To: Baoquan He Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-s390@vger.kernel.org, virtualization@lists.linux.dev, kvm@vger.kernel.org, linux-fsdevel@vger.kernel.org, kexec@lists.infradead.org, Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , "Michael S. Tsirkin" , Jason Wang , Xuan Zhuo , =?UTF-8?Q?Eugenio_P=C3=A9rez?= , Vivek Goyal , Dave Young , Thomas Huth , Cornelia Huck , Janosch Frank , Claudio Imbrenda , Eric Farman , Andrew Morton References: <20241025151134.1275575-1-david@redhat.com> <20241025151134.1275575-2-david@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: ZhfOOoSoMYbUiMaDdpkl8GWvTW2tnLas3Muldb_c-bg_1731665024 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: D9A602000C X-Stat-Signature: 7prp3bq48z5wi96yntes8qmy5yx8pk15 X-Rspam-User: X-HE-Tag: 1731664980-843534 X-HE-Meta: U2FsdGVkX19t3hYF2c2q+QTzY/JL+/6slql3mPpBEiexxPwm4vYUeeN9UJu1EpLIF3Vq3WLy/4+g6+eBRLJTAYPbSITcxhFfbzgTwxrCadbe03G+qYHgQATbMnmCeaeLz0nm4Km4sNIHFKQN+nlOMH99LDXaLd6PxUGYraNOda8UROxM4W+EMn7pDJwgAEidSDAMmH/RNTX7F4oFSnBXP59CyutwmgACckPIih2wA37lNBSJZIX0INbU3rTvqJCh1SwNvRu1w+dXTHvDBhPnSGifcYTcSVVvEkJ6H7IxumGeuCMM5yDgJDjzwce8OvFqxamTrvlUwWGS+clMAhHg61vZyXtgUgt3UxXXiucZheVXk2uv+UFk9eg2U0ZOjkVH9lh4FUfjje/h1mBr13g1mS7iT+iBGKakk0bdIs7xICKzVI54HaUkTtZ1coNysR5GXJB+o7Mlm0vmb6v7+zJmrIQ+e8Ha4r0vvBPYCq1uahxglQDUEgXQW/9zChcu9u+uWlm+zV8erTTM2xk5QASHj0gxk52J1hDCBHJoU/rtzH20W+A+U1haNMaucjjkdA5xhbNrVzvNQbekglvvzTHak93AwBjQm09S/vAjJvDF99dPf1G77fZ06A4hX8m4493j+EeK5H8Q9plDlUBUMp9R8tTNYDirigCrIhYRXbp9MQsO8bE7yzft5knDmrAhw7FU1HsNknMPbHQKhv0INrjj2C6GdxVVjzRstZvdZh29JlbrwTUGSGN2ok0egLD62sdZovc08Y96hAV7+FTQ3hMoxaimp+QY06K+umtl4bYfXjYc0L9eFoJ3Scw4nrbJetxK/OhGZQdLDKrjobb0MoJbS4HOkpB9d0PonSLDM5DhOk7Tc+OcTBPjOvaW3JNPSmaRuT5zM/iFMQ0Vfu93KTionAlKpjUOFPVkqTUj/f22+8M1VqGEA9CT7FZZsQsbL7JhdLt4mzpYAOgxu1Csfx6 4ZPqMH5N 5r12XEQldXbZh6E/d4RMxkAhYbwpzm21O26ESYT10KmfzgSQcF4kHLYamxOwnrMnrIa+xjNytnShUjxzdH6K+KE4r6vN5tyIpDCAuLjOPFr93z/t6MZjTKEOc2pahkp00G5jjVNQNdhh1RZ6Al2nK5Xq5UC5gU4vpCRQhoGMb3TZz8PdOanBbGlHJDKtfXtOZd5ThH7yenHhWllUq9RsCts2+nm2McXU1W8lZQUCBEuq4YBYgcYnxBlMUu8Hv+idURZf/kKHjIvTLjigoKV/1K4YEC0PXnhftRIDGWZYR+rl7JGiuqsSHF2OybC7ATAHF4yQOrbsbrMXsihgDCL8+BxvL2gv+Vaqu5APhV22qaH0MeOutzoBm/B5x1mQWCJc344dOxfDIsGk6ozZzwOf6xwctcdduhWmZ+Wlpmwrh2ELBo31laoOBAkfLyC07o9ixFCvU X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 15.11.24 10:30, Baoquan He wrote: > On 10/25/24 at 05:11pm, David Hildenbrand wrote: >> We want to protect vmcore modifications from concurrent opening of >> the vmcore, and also serialize vmcore modiciations. Let's convert the > > >> spinlock into a mutex, because some of the operations we'll be >> protecting might sleep (e.g., memory allocations) and might take a bit >> longer. > > Could you elaborate this a little further. E.g the concurrent opening of > vmcore is spot before this patchset or have been seen, and in which place > the memory allocation is spot. Asking this becasue I'd like to learn and > make clear if this is a existing issue and need be back ported into our > old RHEL distros. Thanks in advance. It's a preparation for the other patches, that do what is described here: a) We can currently modify the vmcore after it was opened. This can happen if the vmcoredd is added after the vmcore was loaded. Similar things will happen with the PROC_VMCORE_DEVICE_RAM extension. b) To handle it cleanly we need to protect the modifications against concurrent opening. And the modifcations end up allocating memory and cannot easily take the spinlock. So far a spinlock was sufficient, now a mutex is required. Maybe we'd want to backport 1,2,3, but not sure if we consider this critical enough. -- Cheers, David / dhildenb